* [PATCH v3 01/14] hw/pci/pci_ids: Add PCI vendor ID for ASPEED
2025-09-18 3:13 [PATCH v3 00/14] Support PCIe RC to AST2600 and AST2700 Jamin Lin via
@ 2025-09-18 3:13 ` Jamin Lin via
2025-09-18 3:13 ` [PATCH v3 02/14] hw/pci-host/aspeed: Add AST2600 PCIe PHY model Jamin Lin via
` (13 subsequent siblings)
14 siblings, 0 replies; 29+ messages in thread
From: Jamin Lin via @ 2025-09-18 3:13 UTC (permalink / raw)
To: Paolo Bonzini, Peter Maydell, Cédric Le Goater, Steven Lee,
Troy Lee, Andrew Jeffery, Joel Stanley, Michael S. Tsirkin,
Marcel Apfelbaum, open list:ARM TCG CPUs,
open list:All patches CC here
Cc: jamin_lin, troy_lee, nabihestefan, wuhaotsh, titusr,
Cédric Le Goater
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
---
include/hw/pci/pci_ids.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/hw/pci/pci_ids.h b/include/hw/pci/pci_ids.h
index 33e2898be9..16034aaa2c 100644
--- a/include/hw/pci/pci_ids.h
+++ b/include/hw/pci/pci_ids.h
@@ -291,4 +291,6 @@
#define PCI_VENDOR_ID_NVIDIA 0x10de
+#define PCI_VENDOR_ID_ASPEED 0x1A03
+
#endif
--
2.43.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* [PATCH v3 02/14] hw/pci-host/aspeed: Add AST2600 PCIe PHY model
2025-09-18 3:13 [PATCH v3 00/14] Support PCIe RC to AST2600 and AST2700 Jamin Lin via
2025-09-18 3:13 ` [PATCH v3 01/14] hw/pci/pci_ids: Add PCI vendor ID for ASPEED Jamin Lin via
@ 2025-09-18 3:13 ` Jamin Lin via
2025-09-18 6:41 ` [SPAM] " Cédric Le Goater
2025-09-18 3:13 ` [PATCH v3 03/14] hw/pci-host/aspeed: Add AST2600 PCIe config space and host bridge Jamin Lin via
` (12 subsequent siblings)
14 siblings, 1 reply; 29+ messages in thread
From: Jamin Lin via @ 2025-09-18 3:13 UTC (permalink / raw)
To: Paolo Bonzini, Peter Maydell, Cédric Le Goater, Steven Lee,
Troy Lee, Andrew Jeffery, Joel Stanley, Michael S. Tsirkin,
Marcel Apfelbaum, open list:ARM TCG CPUs,
open list:All patches CC here
Cc: jamin_lin, troy_lee, nabihestefan, wuhaotsh, titusr
This patch introduces an initial ASPEED PCIe PHY/host controller model to
support the AST2600 SoC. It provides a simple register block with MMIO
read/write callbacks, integration into the build system, and trace events
for debugging.
Key changes:
1. PCIe PHY MMIO read/write callbacks
Implemented aspeed_pcie_phy_read() and aspeed_pcie_phy_write() to
handle 32-bit register accesses.
2. Build system and Kconfig integration
Added CONFIG_PCI_EXPRESS_ASPEED in hw/pci-host/Kconfig and meson
rules.
Updated ASPEED_SOC in hw/arm/Kconfig to imply PCI_DEVICES and select
PCI_EXPRESS_ASPEED.
3. Trace events for debug
New tracepoints aspeed_pcie_phy_read and aspeed_pcie_phy_write allow
monitoring MMIO accesses.
4. Register space and defaults (AST2600 reference)
Expose a 0x100 register space, as documented in the AST2600 datasheet.
On reset, set default values:
PEHR_ID: Vendor ID = ASPEED, Device ID = 0x1150
PEHR_CLASS_CODE = 0x06040006
PEHR_DATALINK = 0xD7040022
PEHR_LINK: bit[5] set to 1 to indicate link up.
This provides a skeleton device for the AST2600 platform. It enables
firmware to detect the PCIe link as up by default and allows future
extension.
This commit is the starting point of the series to introduce ASPEED PCIe
Root Complex (RC) support. Based on previous work from Cédric Le Goater,
the following commits in this series extend and refine the implementation:
- Add a PCIe Root Port so that devices can be attached without requiring an
extra bridge.
- Restrict the Root Port device instantiation to the AST2600 platform.
- Integrate aspeed_cfg_translate_write() to support both AST2600 and AST2700.
- Add MSI support and a preliminary RC IOMMU address space.
- Fix issues with MSI interrupt clearing.
- Extend support to the AST2700 SoC.
- Drop the AST2600 RC_L support.
- Introduce PCIe RC functional tests covering both AST2600 and AST2700.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
include/hw/pci-host/aspeed_pcie.h | 42 ++++++++
hw/pci-host/aspeed_pcie.c | 157 ++++++++++++++++++++++++++++++
hw/arm/Kconfig | 3 +
hw/pci-host/Kconfig | 4 +
hw/pci-host/meson.build | 1 +
hw/pci-host/trace-events | 4 +
6 files changed, 211 insertions(+)
create mode 100644 include/hw/pci-host/aspeed_pcie.h
create mode 100644 hw/pci-host/aspeed_pcie.c
diff --git a/include/hw/pci-host/aspeed_pcie.h b/include/hw/pci-host/aspeed_pcie.h
new file mode 100644
index 0000000000..d9fb829048
--- /dev/null
+++ b/include/hw/pci-host/aspeed_pcie.h
@@ -0,0 +1,42 @@
+/*
+ * ASPEED PCIe Host Controller
+ *
+ * Copyright (C) 2025 ASPEED Technology Inc.
+ * Copyright (c) 2022 Cédric Le Goater <clg@kaod.org>
+ *
+ * Authors:
+ * Cédric Le Goater <clg@kaod.org>
+ * Jamin Lin <jamin_lin@aspeedtech.com>
+ *
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ *
+ * Based on previous work from Cédric Le Goater.
+ * Modifications extend support for the ASPEED AST2600 and AST2700 platforms.
+ */
+
+#ifndef ASPEED_PCIE_H
+#define ASPEED_PCIE_H
+
+#include "hw/sysbus.h"
+#include "hw/pci/pci_bridge.h"
+#include "hw/pci/pcie_host.h"
+#include "qom/object.h"
+
+#define TYPE_ASPEED_PCIE_PHY "aspeed.pcie-phy"
+OBJECT_DECLARE_TYPE(AspeedPCIEPhyState, AspeedPCIEPhyClass, ASPEED_PCIE_PHY);
+
+struct AspeedPCIEPhyState {
+ SysBusDevice parent_obj;
+
+ MemoryRegion mmio;
+ uint32_t *regs;
+ uint32_t id;
+};
+
+struct AspeedPCIEPhyClass {
+ SysBusDeviceClass parent_class;
+
+ uint64_t nr_regs;
+};
+
+#endif /* ASPEED_PCIE_H */
diff --git a/hw/pci-host/aspeed_pcie.c b/hw/pci-host/aspeed_pcie.c
new file mode 100644
index 0000000000..110c963779
--- /dev/null
+++ b/hw/pci-host/aspeed_pcie.c
@@ -0,0 +1,157 @@
+/*
+ * ASPEED PCIe Host Controller
+ *
+ * Copyright (C) 2025 ASPEED Technology Inc.
+ * Copyright (c) 2022 Cédric Le Goater <clg@kaod.org>
+ *
+ * Authors:
+ * Cédric Le Goater <clg@kaod.org>
+ * Jamin Lin <jamin_lin@aspeedtech.com>
+ *
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ *
+ * Based on previous work from Cédric Le Goater.
+ * Modifications extend support for the ASPEED AST2600 and AST2700 platforms.
+ */
+
+#include "qemu/osdep.h"
+#include "qemu/log.h"
+#include "qapi/error.h"
+#include "hw/qdev-properties.h"
+#include "hw/registerfields.h"
+#include "hw/irq.h"
+#include "hw/pci/pci_host.h"
+#include "hw/pci-host/aspeed_pcie.h"
+#include "hw/pci/msi.h"
+#include "trace.h"
+
+/*
+ * PCIe PHY
+ *
+ * PCIe Host Controller (PCIEH)
+ */
+
+/* AST2600 */
+REG32(PEHR_ID, 0x00)
+ FIELD(PEHR_ID, DEV, 16, 16)
+REG32(PEHR_CLASS_CODE, 0x04)
+REG32(PEHR_DATALINK, 0x10)
+REG32(PEHR_PROTECT, 0x7C)
+ FIELD(PEHR_PROTECT, LOCK, 0, 8)
+REG32(PEHR_LINK, 0xC0)
+ FIELD(PEHR_LINK, STS, 5, 1)
+
+#define ASPEED_PCIE_PHY_UNLOCK 0xA8
+
+static uint64_t aspeed_pcie_phy_read(void *opaque, hwaddr addr,
+ unsigned int size)
+{
+ AspeedPCIEPhyState *s = ASPEED_PCIE_PHY(opaque);
+ uint32_t reg = addr >> 2;
+ uint32_t value = 0;
+
+ value = s->regs[reg];
+
+ trace_aspeed_pcie_phy_read(s->id, addr, value);
+
+ return value;
+}
+
+static void aspeed_pcie_phy_write(void *opaque, hwaddr addr, uint64_t data,
+ unsigned int size)
+{
+ AspeedPCIEPhyState *s = ASPEED_PCIE_PHY(opaque);
+ uint32_t reg = addr >> 2;
+
+ trace_aspeed_pcie_phy_write(s->id, addr, data);
+
+ switch (reg) {
+ case R_PEHR_PROTECT:
+ data &= R_PEHR_PROTECT_LOCK_MASK;
+ s->regs[reg] = !!(data == ASPEED_PCIE_PHY_UNLOCK);
+ break;
+ default:
+ s->regs[reg] = data;
+ break;
+ }
+}
+
+static const MemoryRegionOps aspeed_pcie_phy_ops = {
+ .read = aspeed_pcie_phy_read,
+ .write = aspeed_pcie_phy_write,
+ .endianness = DEVICE_LITTLE_ENDIAN,
+ .valid = {
+ .min_access_size = 1,
+ .max_access_size = 4,
+ },
+};
+
+static void aspeed_pcie_phy_reset(DeviceState *dev)
+{
+ AspeedPCIEPhyState *s = ASPEED_PCIE_PHY(dev);
+ AspeedPCIEPhyClass *apc = ASPEED_PCIE_PHY_GET_CLASS(s);
+
+ memset(s->regs, 0, apc->nr_regs << 2);
+
+ s->regs[R_PEHR_ID] =
+ (0x1150 << R_PEHR_ID_DEV_SHIFT) | PCI_VENDOR_ID_ASPEED;
+ s->regs[R_PEHR_CLASS_CODE] = 0x06040006;
+ s->regs[R_PEHR_DATALINK] = 0xD7040022;
+ s->regs[R_PEHR_LINK] = R_PEHR_LINK_STS_MASK;
+}
+
+static void aspeed_pcie_phy_realize(DeviceState *dev, Error **errp)
+{
+ AspeedPCIEPhyState *s = ASPEED_PCIE_PHY(dev);
+ AspeedPCIEPhyClass *apc = ASPEED_PCIE_PHY_GET_CLASS(s);
+ SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
+ g_autofree char *name;
+
+ s->regs = g_new(uint32_t, apc->nr_regs);
+ name = g_strdup_printf(TYPE_ASPEED_PCIE_PHY ".regs.%d", s->id);
+ memory_region_init_io(&s->mmio, OBJECT(s), &aspeed_pcie_phy_ops, s, name,
+ apc->nr_regs << 2);
+ sysbus_init_mmio(sbd, &s->mmio);
+}
+
+static void aspeed_pcie_phy_unrealize(DeviceState *dev)
+{
+ AspeedPCIEPhyState *s = ASPEED_PCIE_PHY(dev);
+
+ g_free(s->regs);
+ s->regs = NULL;
+}
+
+static const Property aspeed_pcie_phy_props[] = {
+ DEFINE_PROP_UINT32("id", AspeedPCIEPhyState, id, 0),
+};
+
+static void aspeed_pcie_phy_class_init(ObjectClass *klass, const void *data)
+{
+ DeviceClass *dc = DEVICE_CLASS(klass);
+ AspeedPCIEPhyClass *apc = ASPEED_PCIE_PHY_CLASS(klass);
+
+ dc->desc = "ASPEED PCIe Phy";
+ dc->realize = aspeed_pcie_phy_realize;
+ dc->unrealize = aspeed_pcie_phy_unrealize;
+ device_class_set_legacy_reset(dc, aspeed_pcie_phy_reset);
+ device_class_set_props(dc, aspeed_pcie_phy_props);
+
+ apc->nr_regs = 0x100 >> 2;
+}
+
+static const TypeInfo aspeed_pcie_phy_info = {
+ .name = TYPE_ASPEED_PCIE_PHY,
+ .parent = TYPE_SYS_BUS_DEVICE,
+ .instance_size = sizeof(AspeedPCIEPhyState),
+ .class_init = aspeed_pcie_phy_class_init,
+ .class_size = sizeof(AspeedPCIEPhyClass),
+};
+
+static void aspeed_pcie_register_types(void)
+{
+ type_register_static(&aspeed_pcie_phy_info);
+}
+
+type_init(aspeed_pcie_register_types);
+
diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index 3baa6c6c74..b44b85f436 100644
--- a/hw/arm/Kconfig
+++ b/hw/arm/Kconfig
@@ -541,6 +541,7 @@ config ASPEED_SOC
bool
default y
depends on TCG && ARM
+ imply PCI_DEVICES
select DS1338
select FTGMAC100
select I2C
@@ -561,6 +562,8 @@ config ASPEED_SOC
select MAX31785
select FSI_APB2OPB_ASPEED
select AT24C
+ select PCI_EXPRESS
+ select PCI_EXPRESS_ASPEED
config MPS2
bool
diff --git a/hw/pci-host/Kconfig b/hw/pci-host/Kconfig
index 9824fa188d..8cbb8304a3 100644
--- a/hw/pci-host/Kconfig
+++ b/hw/pci-host/Kconfig
@@ -46,6 +46,10 @@ config PCI_I440FX
select PCI
select PAM
+config PCI_EXPRESS_ASPEED
+ bool
+ select PCI_EXPRESS
+
config PCI_EXPRESS_Q35
bool
select PCI_EXPRESS
diff --git a/hw/pci-host/meson.build b/hw/pci-host/meson.build
index 937a0f72ac..86b754d0b0 100644
--- a/hw/pci-host/meson.build
+++ b/hw/pci-host/meson.build
@@ -2,6 +2,7 @@ pci_ss = ss.source_set()
pci_ss.add(when: 'CONFIG_PAM', if_true: files('pam.c'))
pci_ss.add(when: 'CONFIG_PCI_BONITO', if_true: files('bonito.c'))
pci_ss.add(when: 'CONFIG_GT64120', if_true: files('gt64120.c'))
+pci_ss.add(when: 'CONFIG_PCI_EXPRESS_ASPEED', if_true: files('aspeed_pcie.c'))
pci_ss.add(when: 'CONFIG_PCI_EXPRESS_DESIGNWARE', if_true: files('designware.c'))
pci_ss.add(when: 'CONFIG_PCI_EXPRESS_GENERIC_BRIDGE', if_true: files('gpex.c'))
pci_ss.add(when: ['CONFIG_PCI_EXPRESS_GENERIC_BRIDGE', 'CONFIG_ACPI'], if_true: files('gpex-acpi.c'))
diff --git a/hw/pci-host/trace-events b/hw/pci-host/trace-events
index 0a816b9aa1..3438516756 100644
--- a/hw/pci-host/trace-events
+++ b/hw/pci-host/trace-events
@@ -1,5 +1,9 @@
# See docs/devel/tracing.rst for syntax documentation.
+# aspeed_pcie.c
+aspeed_pcie_phy_read(uint32_t id, uint64_t addr, uint32_t value) "%d: addr 0x%" PRIx64 " value 0x%" PRIx32
+aspeed_pcie_phy_write(uint32_t id, uint64_t addr, uint32_t value) "%d: addr 0x%" PRIx64 " value 0x%" PRIx32
+
# bonito.c
bonito_spciconf_small_access(uint64_t addr, unsigned size) "PCI config address is smaller then 32-bit, addr: 0x%"PRIx64", size: %u"
--
2.43.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* Re: [SPAM] [PATCH v3 02/14] hw/pci-host/aspeed: Add AST2600 PCIe PHY model
2025-09-18 3:13 ` [PATCH v3 02/14] hw/pci-host/aspeed: Add AST2600 PCIe PHY model Jamin Lin via
@ 2025-09-18 6:41 ` Cédric Le Goater
2025-09-18 7:22 ` Jamin Lin
0 siblings, 1 reply; 29+ messages in thread
From: Cédric Le Goater @ 2025-09-18 6:41 UTC (permalink / raw)
To: Jamin Lin, Paolo Bonzini, Peter Maydell, Steven Lee, Troy Lee,
Andrew Jeffery, Joel Stanley, Michael S. Tsirkin,
Marcel Apfelbaum, open list:ARM TCG CPUs,
open list:All patches CC here
Cc: troy_lee, nabihestefan, wuhaotsh, titusr
On 9/18/25 05:13, Jamin Lin wrote:
> This patch introduces an initial ASPEED PCIe PHY/host controller model to
> support the AST2600 SoC. It provides a simple register block with MMIO
> read/write callbacks, integration into the build system, and trace events
> for debugging.
>
> Key changes:
>
> 1. PCIe PHY MMIO read/write callbacks
> Implemented aspeed_pcie_phy_read() and aspeed_pcie_phy_write() to
> handle 32-bit register accesses.
>
> 2. Build system and Kconfig integration
> Added CONFIG_PCI_EXPRESS_ASPEED in hw/pci-host/Kconfig and meson
> rules.
> Updated ASPEED_SOC in hw/arm/Kconfig to imply PCI_DEVICES and select
> PCI_EXPRESS_ASPEED.
>
> 3. Trace events for debug
> New tracepoints aspeed_pcie_phy_read and aspeed_pcie_phy_write allow
> monitoring MMIO accesses.
>
> 4. Register space and defaults (AST2600 reference)
> Expose a 0x100 register space, as documented in the AST2600 datasheet.
> On reset, set default values:
> PEHR_ID: Vendor ID = ASPEED, Device ID = 0x1150
> PEHR_CLASS_CODE = 0x06040006
> PEHR_DATALINK = 0xD7040022
> PEHR_LINK: bit[5] set to 1 to indicate link up.
>
> This provides a skeleton device for the AST2600 platform. It enables
> firmware to detect the PCIe link as up by default and allows future
> extension.
>
> This commit is the starting point of the series to introduce ASPEED PCIe
> Root Complex (RC) support. Based on previous work from Cédric Le Goater,
> the following commits in this series extend and refine the implementation:
>
> - Add a PCIe Root Port so that devices can be attached without requiring an
> extra bridge.
> - Restrict the Root Port device instantiation to the AST2600 platform.
> - Integrate aspeed_cfg_translate_write() to support both AST2600 and AST2700.
> - Add MSI support and a preliminary RC IOMMU address space.
> - Fix issues with MSI interrupt clearing.
> - Extend support to the AST2700 SoC.
> - Drop the AST2600 RC_L support.
> - Introduce PCIe RC functional tests covering both AST2600 and AST2700.
>
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> ---
> include/hw/pci-host/aspeed_pcie.h | 42 ++++++++
> hw/pci-host/aspeed_pcie.c | 157 ++++++++++++++++++++++++++++++
> hw/arm/Kconfig | 3 +
> hw/pci-host/Kconfig | 4 +
> hw/pci-host/meson.build | 1 +
> hw/pci-host/trace-events | 4 +
> 6 files changed, 211 insertions(+)
> create mode 100644 include/hw/pci-host/aspeed_pcie.h
> create mode 100644 hw/pci-host/aspeed_pcie.c
>
> diff --git a/include/hw/pci-host/aspeed_pcie.h b/include/hw/pci-host/aspeed_pcie.h
> new file mode 100644
> index 0000000000..d9fb829048
> --- /dev/null
> +++ b/include/hw/pci-host/aspeed_pcie.h
> @@ -0,0 +1,42 @@
> +/*
> + * ASPEED PCIe Host Controller
> + *
> + * Copyright (C) 2025 ASPEED Technology Inc.
> + * Copyright (c) 2022 Cédric Le Goater <clg@kaod.org>
> + *
> + * Authors:
> + * Cédric Le Goater <clg@kaod.org>
> + * Jamin Lin <jamin_lin@aspeedtech.com>
> + *
> + * SPDX-License-Identifier: GPL-2.0-or-later
> + *
> + * Based on previous work from Cédric Le Goater.
> + * Modifications extend support for the ASPEED AST2600 and AST2700 platforms.
> + */
> +
> +#ifndef ASPEED_PCIE_H
> +#define ASPEED_PCIE_H
> +
> +#include "hw/sysbus.h"
> +#include "hw/pci/pci_bridge.h"
> +#include "hw/pci/pcie_host.h"
> +#include "qom/object.h"
> +
> +#define TYPE_ASPEED_PCIE_PHY "aspeed.pcie-phy"
> +OBJECT_DECLARE_TYPE(AspeedPCIEPhyState, AspeedPCIEPhyClass, ASPEED_PCIE_PHY);
> +
> +struct AspeedPCIEPhyState {
> + SysBusDevice parent_obj;
> +
> + MemoryRegion mmio;
> + uint32_t *regs;
> + uint32_t id;
> +};
> +
> +struct AspeedPCIEPhyClass {
> + SysBusDeviceClass parent_class;
> +
> + uint64_t nr_regs;
> +};
> +
> +#endif /* ASPEED_PCIE_H */
> diff --git a/hw/pci-host/aspeed_pcie.c b/hw/pci-host/aspeed_pcie.c
> new file mode 100644
> index 0000000000..110c963779
> --- /dev/null
> +++ b/hw/pci-host/aspeed_pcie.c
> @@ -0,0 +1,157 @@
> +/*
> + * ASPEED PCIe Host Controller
> + *
> + * Copyright (C) 2025 ASPEED Technology Inc.
> + * Copyright (c) 2022 Cédric Le Goater <clg@kaod.org>
> + *
> + * Authors:
> + * Cédric Le Goater <clg@kaod.org>
> + * Jamin Lin <jamin_lin@aspeedtech.com>
> + *
> + * SPDX-License-Identifier: GPL-2.0-or-later
> + *
> + * Based on previous work from Cédric Le Goater.
> + * Modifications extend support for the ASPEED AST2600 and AST2700 platforms.
> + */
> +
> +#include "qemu/osdep.h"
> +#include "qemu/log.h"
> +#include "qapi/error.h"
> +#include "hw/qdev-properties.h"
> +#include "hw/registerfields.h"
> +#include "hw/irq.h"
> +#include "hw/pci/pci_host.h"
> +#include "hw/pci-host/aspeed_pcie.h"
> +#include "hw/pci/msi.h"
> +#include "trace.h"
> +
> +/*
> + * PCIe PHY
> + *
> + * PCIe Host Controller (PCIEH)
> + */
> +
> +/* AST2600 */
> +REG32(PEHR_ID, 0x00)
> + FIELD(PEHR_ID, DEV, 16, 16)
> +REG32(PEHR_CLASS_CODE, 0x04)
> +REG32(PEHR_DATALINK, 0x10)
> +REG32(PEHR_PROTECT, 0x7C)
> + FIELD(PEHR_PROTECT, LOCK, 0, 8)
> +REG32(PEHR_LINK, 0xC0)
> + FIELD(PEHR_LINK, STS, 5, 1)
> +
> +#define ASPEED_PCIE_PHY_UNLOCK 0xA8
> +
> +static uint64_t aspeed_pcie_phy_read(void *opaque, hwaddr addr,
> + unsigned int size)
> +{
> + AspeedPCIEPhyState *s = ASPEED_PCIE_PHY(opaque);
> + uint32_t reg = addr >> 2;
> + uint32_t value = 0;
> +
> + value = s->regs[reg];
> +
> + trace_aspeed_pcie_phy_read(s->id, addr, value);
> +
> + return value;
> +}
> +
> +static void aspeed_pcie_phy_write(void *opaque, hwaddr addr, uint64_t data,
> + unsigned int size)
> +{
> + AspeedPCIEPhyState *s = ASPEED_PCIE_PHY(opaque);
> + uint32_t reg = addr >> 2;
> +
> + trace_aspeed_pcie_phy_write(s->id, addr, data);
> +
> + switch (reg) {
> + case R_PEHR_PROTECT:
> + data &= R_PEHR_PROTECT_LOCK_MASK;
> + s->regs[reg] = !!(data == ASPEED_PCIE_PHY_UNLOCK);
> + break;
> + default:
> + s->regs[reg] = data;
> + break;
> + }
> +}
> +
> +static const MemoryRegionOps aspeed_pcie_phy_ops = {
> + .read = aspeed_pcie_phy_read,
> + .write = aspeed_pcie_phy_write,
> + .endianness = DEVICE_LITTLE_ENDIAN,
> + .valid = {
> + .min_access_size = 1,
> + .max_access_size = 4,
> + },
> +};
> +
> +static void aspeed_pcie_phy_reset(DeviceState *dev)
> +{
> + AspeedPCIEPhyState *s = ASPEED_PCIE_PHY(dev);
> + AspeedPCIEPhyClass *apc = ASPEED_PCIE_PHY_GET_CLASS(s);
> +
> + memset(s->regs, 0, apc->nr_regs << 2);
> +
> + s->regs[R_PEHR_ID] =
> + (0x1150 << R_PEHR_ID_DEV_SHIFT) | PCI_VENDOR_ID_ASPEED;
> + s->regs[R_PEHR_CLASS_CODE] = 0x06040006;
> + s->regs[R_PEHR_DATALINK] = 0xD7040022;
> + s->regs[R_PEHR_LINK] = R_PEHR_LINK_STS_MASK;
> +}
> +
> +static void aspeed_pcie_phy_realize(DeviceState *dev, Error **errp)
> +{
> + AspeedPCIEPhyState *s = ASPEED_PCIE_PHY(dev);
> + AspeedPCIEPhyClass *apc = ASPEED_PCIE_PHY_GET_CLASS(s);
> + SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
> + g_autofree char *name;
g_autofree variables should defined when declared. So,
g_autofree char *name = g_strdup_printf(TYPE_ASPEED_PCIE_PHY ".regs.%d", s->id);
I can do that if there are no major issues in the series.
Thanks,
C.
> +
> + s->regs = g_new(uint32_t, apc->nr_regs);
> + name = g_strdup_printf(TYPE_ASPEED_PCIE_PHY ".regs.%d", s->id);
> + memory_region_init_io(&s->mmio, OBJECT(s), &aspeed_pcie_phy_ops, s, name,
> + apc->nr_regs << 2);
> + sysbus_init_mmio(sbd, &s->mmio);
> +}
> +
> +static void aspeed_pcie_phy_unrealize(DeviceState *dev)
> +{
> + AspeedPCIEPhyState *s = ASPEED_PCIE_PHY(dev);
> +
> + g_free(s->regs);
> + s->regs = NULL;
> +}
> +
> +static const Property aspeed_pcie_phy_props[] = {
> + DEFINE_PROP_UINT32("id", AspeedPCIEPhyState, id, 0),
> +};
> +
> +static void aspeed_pcie_phy_class_init(ObjectClass *klass, const void *data)
> +{
> + DeviceClass *dc = DEVICE_CLASS(klass);
> + AspeedPCIEPhyClass *apc = ASPEED_PCIE_PHY_CLASS(klass);
> +
> + dc->desc = "ASPEED PCIe Phy";
> + dc->realize = aspeed_pcie_phy_realize;
> + dc->unrealize = aspeed_pcie_phy_unrealize;
> + device_class_set_legacy_reset(dc, aspeed_pcie_phy_reset);
> + device_class_set_props(dc, aspeed_pcie_phy_props);
> +
> + apc->nr_regs = 0x100 >> 2;
> +}
> +
> +static const TypeInfo aspeed_pcie_phy_info = {
> + .name = TYPE_ASPEED_PCIE_PHY,
> + .parent = TYPE_SYS_BUS_DEVICE,
> + .instance_size = sizeof(AspeedPCIEPhyState),
> + .class_init = aspeed_pcie_phy_class_init,
> + .class_size = sizeof(AspeedPCIEPhyClass),
> +};
> +
> +static void aspeed_pcie_register_types(void)
> +{
> + type_register_static(&aspeed_pcie_phy_info);
> +}
> +
> +type_init(aspeed_pcie_register_types);
> +
> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
> index 3baa6c6c74..b44b85f436 100644
> --- a/hw/arm/Kconfig
> +++ b/hw/arm/Kconfig
> @@ -541,6 +541,7 @@ config ASPEED_SOC
> bool
> default y
> depends on TCG && ARM
> + imply PCI_DEVICES
> select DS1338
> select FTGMAC100
> select I2C
> @@ -561,6 +562,8 @@ config ASPEED_SOC
> select MAX31785
> select FSI_APB2OPB_ASPEED
> select AT24C
> + select PCI_EXPRESS
> + select PCI_EXPRESS_ASPEED
>
> config MPS2
> bool
> diff --git a/hw/pci-host/Kconfig b/hw/pci-host/Kconfig
> index 9824fa188d..8cbb8304a3 100644
> --- a/hw/pci-host/Kconfig
> +++ b/hw/pci-host/Kconfig
> @@ -46,6 +46,10 @@ config PCI_I440FX
> select PCI
> select PAM
>
> +config PCI_EXPRESS_ASPEED
> + bool
> + select PCI_EXPRESS
> +
> config PCI_EXPRESS_Q35
> bool
> select PCI_EXPRESS
> diff --git a/hw/pci-host/meson.build b/hw/pci-host/meson.build
> index 937a0f72ac..86b754d0b0 100644
> --- a/hw/pci-host/meson.build
> +++ b/hw/pci-host/meson.build
> @@ -2,6 +2,7 @@ pci_ss = ss.source_set()
> pci_ss.add(when: 'CONFIG_PAM', if_true: files('pam.c'))
> pci_ss.add(when: 'CONFIG_PCI_BONITO', if_true: files('bonito.c'))
> pci_ss.add(when: 'CONFIG_GT64120', if_true: files('gt64120.c'))
> +pci_ss.add(when: 'CONFIG_PCI_EXPRESS_ASPEED', if_true: files('aspeed_pcie.c'))
> pci_ss.add(when: 'CONFIG_PCI_EXPRESS_DESIGNWARE', if_true: files('designware.c'))
> pci_ss.add(when: 'CONFIG_PCI_EXPRESS_GENERIC_BRIDGE', if_true: files('gpex.c'))
> pci_ss.add(when: ['CONFIG_PCI_EXPRESS_GENERIC_BRIDGE', 'CONFIG_ACPI'], if_true: files('gpex-acpi.c'))
> diff --git a/hw/pci-host/trace-events b/hw/pci-host/trace-events
> index 0a816b9aa1..3438516756 100644
> --- a/hw/pci-host/trace-events
> +++ b/hw/pci-host/trace-events
> @@ -1,5 +1,9 @@
> # See docs/devel/tracing.rst for syntax documentation.
>
> +# aspeed_pcie.c
> +aspeed_pcie_phy_read(uint32_t id, uint64_t addr, uint32_t value) "%d: addr 0x%" PRIx64 " value 0x%" PRIx32
> +aspeed_pcie_phy_write(uint32_t id, uint64_t addr, uint32_t value) "%d: addr 0x%" PRIx64 " value 0x%" PRIx32
> +
> # bonito.c
> bonito_spciconf_small_access(uint64_t addr, unsigned size) "PCI config address is smaller then 32-bit, addr: 0x%"PRIx64", size: %u"
>
^ permalink raw reply [flat|nested] 29+ messages in thread* RE: [SPAM] [PATCH v3 02/14] hw/pci-host/aspeed: Add AST2600 PCIe PHY model
2025-09-18 6:41 ` [SPAM] " Cédric Le Goater
@ 2025-09-18 7:22 ` Jamin Lin
0 siblings, 0 replies; 29+ messages in thread
From: Jamin Lin @ 2025-09-18 7:22 UTC (permalink / raw)
To: Cédric Le Goater, Paolo Bonzini, Peter Maydell, Steven Lee,
Troy Lee, Andrew Jeffery, Joel Stanley, Michael S. Tsirkin,
Marcel Apfelbaum, open list:ARM TCG CPUs,
open list:All patches CC here
Cc: Troy Lee, nabihestefan@google.com, wuhaotsh@google.com,
titusr@google.com
Hi Cédric
> Subject: Re: [SPAM] [PATCH v3 02/14] hw/pci-host/aspeed: Add AST2600 PCIe
> PHY model
>
> On 9/18/25 05:13, Jamin Lin wrote:
> > This patch introduces an initial ASPEED PCIe PHY/host controller model
> > to support the AST2600 SoC. It provides a simple register block with
> > MMIO read/write callbacks, integration into the build system, and
> > trace events for debugging.
> >
> > Key changes:
> >
> > 1. PCIe PHY MMIO read/write callbacks
> > Implemented aspeed_pcie_phy_read() and aspeed_pcie_phy_write() to
> > handle 32-bit register accesses.
> >
> > 2. Build system and Kconfig integration
> > Added CONFIG_PCI_EXPRESS_ASPEED in hw/pci-host/Kconfig and
> meson
> > rules.
> > Updated ASPEED_SOC in hw/arm/Kconfig to imply PCI_DEVICES and
> select
> > PCI_EXPRESS_ASPEED.
> >
> > 3. Trace events for debug
> > New tracepoints aspeed_pcie_phy_read and aspeed_pcie_phy_write
> allow
> > monitoring MMIO accesses.
> >
> > 4. Register space and defaults (AST2600 reference)
> > Expose a 0x100 register space, as documented in the AST2600
> datasheet.
> > On reset, set default values:
> > PEHR_ID: Vendor ID = ASPEED, Device ID = 0x1150
> > PEHR_CLASS_CODE = 0x06040006
> > PEHR_DATALINK = 0xD7040022
> > PEHR_LINK: bit[5] set to 1 to indicate link up.
> >
> > This provides a skeleton device for the AST2600 platform. It enables
> > firmware to detect the PCIe link as up by default and allows future
> > extension.
> >
> > This commit is the starting point of the series to introduce ASPEED
> > PCIe Root Complex (RC) support. Based on previous work from Cédric Le
> > Goater, the following commits in this series extend and refine the
> implementation:
> >
> > - Add a PCIe Root Port so that devices can be attached without
> > requiring an extra bridge.
> > - Restrict the Root Port device instantiation to the AST2600 platform.
> > - Integrate aspeed_cfg_translate_write() to support both AST2600 and
> AST2700.
> > - Add MSI support and a preliminary RC IOMMU address space.
> > - Fix issues with MSI interrupt clearing.
> > - Extend support to the AST2700 SoC.
> > - Drop the AST2600 RC_L support.
> > - Introduce PCIe RC functional tests covering both AST2600 and AST2700.
> >
> > Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> > ---
> > include/hw/pci-host/aspeed_pcie.h | 42 ++++++++
> > hw/pci-host/aspeed_pcie.c | 157
> ++++++++++++++++++++++++++++++
> > hw/arm/Kconfig | 3 +
> > hw/pci-host/Kconfig | 4 +
> > hw/pci-host/meson.build | 1 +
> > hw/pci-host/trace-events | 4 +
> > 6 files changed, 211 insertions(+)
> > create mode 100644 include/hw/pci-host/aspeed_pcie.h
> > create mode 100644 hw/pci-host/aspeed_pcie.c
> >
> > diff --git a/include/hw/pci-host/aspeed_pcie.h
> > b/include/hw/pci-host/aspeed_pcie.h
> > new file mode 100644
> > index 0000000000..d9fb829048
> > --- /dev/null
> > +++ b/include/hw/pci-host/aspeed_pcie.h
> > @@ -0,0 +1,42 @@
> > +/*
> > + * ASPEED PCIe Host Controller
> > + *
> > + * Copyright (C) 2025 ASPEED Technology Inc.
> > + * Copyright (c) 2022 Cédric Le Goater <clg@kaod.org>
> > + *
> > + * Authors:
> > + * Cédric Le Goater <clg@kaod.org>
> > + * Jamin Lin <jamin_lin@aspeedtech.com>
> > + *
> > + * SPDX-License-Identifier: GPL-2.0-or-later
> > + *
> > + * Based on previous work from Cédric Le Goater.
> > + * Modifications extend support for the ASPEED AST2600 and AST2700
> platforms.
> > + */
> > +
> > +#ifndef ASPEED_PCIE_H
> > +#define ASPEED_PCIE_H
> > +
> > +#include "hw/sysbus.h"
> > +#include "hw/pci/pci_bridge.h"
> > +#include "hw/pci/pcie_host.h"
> > +#include "qom/object.h"
> > +
> > +#define TYPE_ASPEED_PCIE_PHY "aspeed.pcie-phy"
> > +OBJECT_DECLARE_TYPE(AspeedPCIEPhyState, AspeedPCIEPhyClass,
> > +ASPEED_PCIE_PHY);
> > +
> > +struct AspeedPCIEPhyState {
> > + SysBusDevice parent_obj;
> > +
> > + MemoryRegion mmio;
> > + uint32_t *regs;
> > + uint32_t id;
> > +};
> > +
> > +struct AspeedPCIEPhyClass {
> > + SysBusDeviceClass parent_class;
> > +
> > + uint64_t nr_regs;
> > +};
> > +
> > +#endif /* ASPEED_PCIE_H */
> > diff --git a/hw/pci-host/aspeed_pcie.c b/hw/pci-host/aspeed_pcie.c new
> > file mode 100644 index 0000000000..110c963779
> > --- /dev/null
> > +++ b/hw/pci-host/aspeed_pcie.c
> > @@ -0,0 +1,157 @@
> > +/*
> > + * ASPEED PCIe Host Controller
> > + *
> > + * Copyright (C) 2025 ASPEED Technology Inc.
> > + * Copyright (c) 2022 Cédric Le Goater <clg@kaod.org>
> > + *
> > + * Authors:
> > + * Cédric Le Goater <clg@kaod.org>
> > + * Jamin Lin <jamin_lin@aspeedtech.com>
> > + *
> > + * SPDX-License-Identifier: GPL-2.0-or-later
> > + *
> > + * Based on previous work from Cédric Le Goater.
> > + * Modifications extend support for the ASPEED AST2600 and AST2700
> platforms.
> > + */
> > +
> > +#include "qemu/osdep.h"
> > +#include "qemu/log.h"
> > +#include "qapi/error.h"
> > +#include "hw/qdev-properties.h"
> > +#include "hw/registerfields.h"
> > +#include "hw/irq.h"
> > +#include "hw/pci/pci_host.h"
> > +#include "hw/pci-host/aspeed_pcie.h"
> > +#include "hw/pci/msi.h"
> > +#include "trace.h"
> > +
> > +/*
> > + * PCIe PHY
> > + *
> > + * PCIe Host Controller (PCIEH)
> > + */
> > +
> > +/* AST2600 */
> > +REG32(PEHR_ID, 0x00)
> > + FIELD(PEHR_ID, DEV, 16, 16)
> > +REG32(PEHR_CLASS_CODE, 0x04)
> > +REG32(PEHR_DATALINK, 0x10)
> > +REG32(PEHR_PROTECT, 0x7C)
> > + FIELD(PEHR_PROTECT, LOCK, 0, 8)
> > +REG32(PEHR_LINK, 0xC0)
> > + FIELD(PEHR_LINK, STS, 5, 1)
> > +
> > +#define ASPEED_PCIE_PHY_UNLOCK 0xA8
> > +
> > +static uint64_t aspeed_pcie_phy_read(void *opaque, hwaddr addr,
> > + unsigned int size) {
> > + AspeedPCIEPhyState *s = ASPEED_PCIE_PHY(opaque);
> > + uint32_t reg = addr >> 2;
> > + uint32_t value = 0;
> > +
> > + value = s->regs[reg];
> > +
> > + trace_aspeed_pcie_phy_read(s->id, addr, value);
> > +
> > + return value;
> > +}
> > +
> > +static void aspeed_pcie_phy_write(void *opaque, hwaddr addr, uint64_t
> data,
> > + unsigned int size) {
> > + AspeedPCIEPhyState *s = ASPEED_PCIE_PHY(opaque);
> > + uint32_t reg = addr >> 2;
> > +
> > + trace_aspeed_pcie_phy_write(s->id, addr, data);
> > +
> > + switch (reg) {
> > + case R_PEHR_PROTECT:
> > + data &= R_PEHR_PROTECT_LOCK_MASK;
> > + s->regs[reg] = !!(data == ASPEED_PCIE_PHY_UNLOCK);
> > + break;
> > + default:
> > + s->regs[reg] = data;
> > + break;
> > + }
> > +}
> > +
> > +static const MemoryRegionOps aspeed_pcie_phy_ops = {
> > + .read = aspeed_pcie_phy_read,
> > + .write = aspeed_pcie_phy_write,
> > + .endianness = DEVICE_LITTLE_ENDIAN,
> > + .valid = {
> > + .min_access_size = 1,
> > + .max_access_size = 4,
> > + },
> > +};
> > +
> > +static void aspeed_pcie_phy_reset(DeviceState *dev) {
> > + AspeedPCIEPhyState *s = ASPEED_PCIE_PHY(dev);
> > + AspeedPCIEPhyClass *apc = ASPEED_PCIE_PHY_GET_CLASS(s);
> > +
> > + memset(s->regs, 0, apc->nr_regs << 2);
> > +
> > + s->regs[R_PEHR_ID] =
> > + (0x1150 << R_PEHR_ID_DEV_SHIFT) | PCI_VENDOR_ID_ASPEED;
> > + s->regs[R_PEHR_CLASS_CODE] = 0x06040006;
> > + s->regs[R_PEHR_DATALINK] = 0xD7040022;
> > + s->regs[R_PEHR_LINK] = R_PEHR_LINK_STS_MASK; }
> > +
> > +static void aspeed_pcie_phy_realize(DeviceState *dev, Error **errp) {
> > + AspeedPCIEPhyState *s = ASPEED_PCIE_PHY(dev);
> > + AspeedPCIEPhyClass *apc = ASPEED_PCIE_PHY_GET_CLASS(s);
> > + SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
> > + g_autofree char *name;
>
> g_autofree variables should defined when declared. So,
>
> g_autofree char *name = g_strdup_printf(TYPE_ASPEED_PCIE_PHY
> ".regs.%d", s->id);
>
Thanks for your review and suggestion.
Will fix it.
Jamin
> I can do that if there are no major issues in the series.
>
>
> Thanks,
>
> C.
>
>
> > +
> > + s->regs = g_new(uint32_t, apc->nr_regs);
> > + name = g_strdup_printf(TYPE_ASPEED_PCIE_PHY ".regs.%d", s->id);
> > + memory_region_init_io(&s->mmio, OBJECT(s), &aspeed_pcie_phy_ops,
> s, name,
> > + apc->nr_regs << 2);
> > + sysbus_init_mmio(sbd, &s->mmio);
> > +}
> > +
> > +static void aspeed_pcie_phy_unrealize(DeviceState *dev) {
> > + AspeedPCIEPhyState *s = ASPEED_PCIE_PHY(dev);
> > +
> > + g_free(s->regs);
> > + s->regs = NULL;
> > +}
> > +
> > +static const Property aspeed_pcie_phy_props[] = {
> > + DEFINE_PROP_UINT32("id", AspeedPCIEPhyState, id, 0), };
> > +
> > +static void aspeed_pcie_phy_class_init(ObjectClass *klass, const void
> > +*data) {
> > + DeviceClass *dc = DEVICE_CLASS(klass);
> > + AspeedPCIEPhyClass *apc = ASPEED_PCIE_PHY_CLASS(klass);
> > +
> > + dc->desc = "ASPEED PCIe Phy";
> > + dc->realize = aspeed_pcie_phy_realize;
> > + dc->unrealize = aspeed_pcie_phy_unrealize;
> > + device_class_set_legacy_reset(dc, aspeed_pcie_phy_reset);
> > + device_class_set_props(dc, aspeed_pcie_phy_props);
> > +
> > + apc->nr_regs = 0x100 >> 2;
> > +}
> > +
> > +static const TypeInfo aspeed_pcie_phy_info = {
> > + .name = TYPE_ASPEED_PCIE_PHY,
> > + .parent = TYPE_SYS_BUS_DEVICE,
> > + .instance_size = sizeof(AspeedPCIEPhyState),
> > + .class_init = aspeed_pcie_phy_class_init,
> > + .class_size = sizeof(AspeedPCIEPhyClass), };
> > +
> > +static void aspeed_pcie_register_types(void) {
> > + type_register_static(&aspeed_pcie_phy_info);
> > +}
> > +
> > +type_init(aspeed_pcie_register_types);
> > +
> > diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index
> > 3baa6c6c74..b44b85f436 100644
> > --- a/hw/arm/Kconfig
> > +++ b/hw/arm/Kconfig
> > @@ -541,6 +541,7 @@ config ASPEED_SOC
> > bool
> > default y
> > depends on TCG && ARM
> > + imply PCI_DEVICES
> > select DS1338
> > select FTGMAC100
> > select I2C
> > @@ -561,6 +562,8 @@ config ASPEED_SOC
> > select MAX31785
> > select FSI_APB2OPB_ASPEED
> > select AT24C
> > + select PCI_EXPRESS
> > + select PCI_EXPRESS_ASPEED
> >
> > config MPS2
> > bool
> > diff --git a/hw/pci-host/Kconfig b/hw/pci-host/Kconfig index
> > 9824fa188d..8cbb8304a3 100644
> > --- a/hw/pci-host/Kconfig
> > +++ b/hw/pci-host/Kconfig
> > @@ -46,6 +46,10 @@ config PCI_I440FX
> > select PCI
> > select PAM
> >
> > +config PCI_EXPRESS_ASPEED
> > + bool
> > + select PCI_EXPRESS
> > +
> > config PCI_EXPRESS_Q35
> > bool
> > select PCI_EXPRESS
> > diff --git a/hw/pci-host/meson.build b/hw/pci-host/meson.build index
> > 937a0f72ac..86b754d0b0 100644
> > --- a/hw/pci-host/meson.build
> > +++ b/hw/pci-host/meson.build
> > @@ -2,6 +2,7 @@ pci_ss = ss.source_set()
> > pci_ss.add(when: 'CONFIG_PAM', if_true: files('pam.c'))
> > pci_ss.add(when: 'CONFIG_PCI_BONITO', if_true: files('bonito.c'))
> > pci_ss.add(when: 'CONFIG_GT64120', if_true: files('gt64120.c'))
> > +pci_ss.add(when: 'CONFIG_PCI_EXPRESS_ASPEED', if_true:
> > +files('aspeed_pcie.c'))
> > pci_ss.add(when: 'CONFIG_PCI_EXPRESS_DESIGNWARE', if_true:
> files('designware.c'))
> > pci_ss.add(when: 'CONFIG_PCI_EXPRESS_GENERIC_BRIDGE', if_true:
> files('gpex.c'))
> > pci_ss.add(when: ['CONFIG_PCI_EXPRESS_GENERIC_BRIDGE',
> > 'CONFIG_ACPI'], if_true: files('gpex-acpi.c')) diff --git
> > a/hw/pci-host/trace-events b/hw/pci-host/trace-events index
> > 0a816b9aa1..3438516756 100644
> > --- a/hw/pci-host/trace-events
> > +++ b/hw/pci-host/trace-events
> > @@ -1,5 +1,9 @@
> > # See docs/devel/tracing.rst for syntax documentation.
> >
> > +# aspeed_pcie.c
> > +aspeed_pcie_phy_read(uint32_t id, uint64_t addr, uint32_t value) "%d:
> > +addr 0x%" PRIx64 " value 0x%" PRIx32 aspeed_pcie_phy_write(uint32_t
> > +id, uint64_t addr, uint32_t value) "%d: addr 0x%" PRIx64 " value 0x%"
> > +PRIx32
> > +
> > # bonito.c
> > bonito_spciconf_small_access(uint64_t addr, unsigned size) "PCI config
> address is smaller then 32-bit, addr: 0x%"PRIx64", size: %u"
> >
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v3 03/14] hw/pci-host/aspeed: Add AST2600 PCIe config space and host bridge
2025-09-18 3:13 [PATCH v3 00/14] Support PCIe RC to AST2600 and AST2700 Jamin Lin via
2025-09-18 3:13 ` [PATCH v3 01/14] hw/pci/pci_ids: Add PCI vendor ID for ASPEED Jamin Lin via
2025-09-18 3:13 ` [PATCH v3 02/14] hw/pci-host/aspeed: Add AST2600 PCIe PHY model Jamin Lin via
@ 2025-09-18 3:13 ` Jamin Lin via
2025-09-18 7:02 ` [SPAM] " Cédric Le Goater
2025-09-18 3:13 ` [PATCH v3 04/14] hw/pci-host/aspeed: Add AST2600 PCIe Root Device support Jamin Lin via
` (11 subsequent siblings)
14 siblings, 1 reply; 29+ messages in thread
From: Jamin Lin via @ 2025-09-18 3:13 UTC (permalink / raw)
To: Paolo Bonzini, Peter Maydell, Cédric Le Goater, Steven Lee,
Troy Lee, Andrew Jeffery, Joel Stanley, Michael S. Tsirkin,
Marcel Apfelbaum, open list:ARM TCG CPUs,
open list:All patches CC here
Cc: jamin_lin, troy_lee, nabihestefan, wuhaotsh, titusr
Introduce PCIe config and host bridge model for the AST2600 platform.
This patch adds support for the H2X (AHB to PCIe Bus Bridge) controller
with a 0x100 byte register space. The register layout is shared between
two root complexes: 0x00–0x7f is common, 0x80–0xbf for RC_L, and 0xc0–0xff
for RC_H. Only RC_H is modeled in this implementation.
The RC_H bus uses bus numbers in the 0x80–0xff range instead of the
standard root bus 0x00. To allow the PCI subsystem to discover devices,
the host bridge logic remaps the root bus number back to 0x00 whenever the
configured bus number matches the "bus-nr" property.
New MMIO callbacks are added for the H2X config space:
- aspeed_pcie_cfg_read() and aspeed_pcie_cfg_write() handle register
accesses.
- aspeed_pcie_cfg_readwrite() provides configuration read/write support.
- aspeed_pcie_cfg_translate_write() handles PCIe byte-enable semantics for
write operations.
The reset handler initializes the H2X register block with default values
as defined in the AST2600 datasheet.
Additional changes:
- Implement ASPEED PCIe root complex (TYPE_ASPEED_PCIE_RC).
- Wire up interrupt propagation via aspeed_pcie_rc_set_irq().
- Add tracepoints for config read/write and INTx handling.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
include/hw/pci-host/aspeed_pcie.h | 59 +++++
hw/pci-host/aspeed_pcie.c | 418 ++++++++++++++++++++++++++++++
hw/pci-host/trace-events | 4 +
3 files changed, 481 insertions(+)
diff --git a/include/hw/pci-host/aspeed_pcie.h b/include/hw/pci-host/aspeed_pcie.h
index d9fb829048..850d579189 100644
--- a/include/hw/pci-host/aspeed_pcie.h
+++ b/include/hw/pci-host/aspeed_pcie.h
@@ -22,6 +22,65 @@
#include "hw/pci/pcie_host.h"
#include "qom/object.h"
+typedef struct AspeedPCIECfgTxDesc {
+ uint32_t desc0;
+ uint32_t desc1;
+ uint32_t desc2;
+ uint32_t desc3;
+ uint32_t wdata;
+ uint32_t rdata_reg;
+} AspeedPCIECfgTxDesc;
+
+typedef struct AspeedPCIERcRegs {
+ uint32_t int_en_reg;
+ uint32_t int_sts_reg;
+} AspeedPCIERcRegs;
+
+typedef struct AspeedPCIERegMap {
+ AspeedPCIERcRegs rc;
+} AspeedPCIERegMap;
+
+#define TYPE_ASPEED_PCIE_RC "aspeed.pcie-rc"
+OBJECT_DECLARE_SIMPLE_TYPE(AspeedPCIERcState, ASPEED_PCIE_RC);
+
+struct AspeedPCIERcState {
+ PCIExpressHost parent_obj;
+
+ MemoryRegion mmio_window;
+ MemoryRegion io_window;
+ MemoryRegion mmio;
+ MemoryRegion io;
+
+ uint32_t bus_nr;
+ char name[16];
+ qemu_irq irq;
+};
+
+/* Bridge between AHB bus and PCIe RC. */
+#define TYPE_ASPEED_PCIE_CFG "aspeed.pcie-cfg"
+OBJECT_DECLARE_TYPE(AspeedPCIECfgState, AspeedPCIECfgClass, ASPEED_PCIE_CFG);
+
+struct AspeedPCIECfgState {
+ SysBusDevice parent_obj;
+
+ MemoryRegion mmio;
+ uint32_t *regs;
+ uint32_t id;
+
+ const AspeedPCIERcRegs *rc_regs;
+ AspeedPCIERcState rc;
+};
+
+struct AspeedPCIECfgClass {
+ SysBusDeviceClass parent_class;
+
+ const AspeedPCIERegMap *reg_map;
+ const MemoryRegionOps *reg_ops;
+
+ uint64_t rc_bus_nr;
+ uint64_t nr_regs;
+};
+
#define TYPE_ASPEED_PCIE_PHY "aspeed.pcie-phy"
OBJECT_DECLARE_TYPE(AspeedPCIEPhyState, AspeedPCIEPhyClass, ASPEED_PCIE_PHY);
diff --git a/hw/pci-host/aspeed_pcie.c b/hw/pci-host/aspeed_pcie.c
index 110c963779..08d717381b 100644
--- a/hw/pci-host/aspeed_pcie.c
+++ b/hw/pci-host/aspeed_pcie.c
@@ -25,6 +25,422 @@
#include "hw/pci/msi.h"
#include "trace.h"
+/*
+ * PCIe Root Complex (RC)
+ */
+
+static void aspeed_pcie_rc_set_irq(void *opaque, int irq, int level)
+{
+ AspeedPCIERcState *rc = (AspeedPCIERcState *) opaque;
+ AspeedPCIECfgState *cfg =
+ container_of(rc, AspeedPCIECfgState, rc);
+ bool intx;
+
+ assert(irq < PCI_NUM_PINS);
+
+ if (level) {
+ cfg->regs[cfg->rc_regs->int_sts_reg] |= BIT(irq);
+ } else {
+ cfg->regs[cfg->rc_regs->int_sts_reg] &= ~BIT(irq);
+ }
+
+ intx = !!(cfg->regs[cfg->rc_regs->int_sts_reg] &
+ cfg->regs[cfg->rc_regs->int_en_reg]);
+ trace_aspeed_pcie_rc_intx_set_irq(cfg->id, irq, intx);
+ qemu_set_irq(rc->irq, intx);
+}
+
+static int aspeed_pcie_rc_map_irq(PCIDevice *pci_dev, int irq_num)
+{
+ return irq_num % PCI_NUM_PINS;
+}
+
+static void aspeed_pcie_rc_realize(DeviceState *dev, Error **errp)
+{
+ PCIExpressHost *pex = PCIE_HOST_BRIDGE(dev);
+ AspeedPCIERcState *rc = ASPEED_PCIE_RC(dev);
+ AspeedPCIECfgState *cfg =
+ container_of(rc, AspeedPCIECfgState, rc);
+ PCIHostState *pci = PCI_HOST_BRIDGE(dev);
+ SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
+ g_autofree char *name;
+
+ /* PCI configuration space */
+ pcie_host_mmcfg_init(pex, PCIE_MMCFG_SIZE_MAX);
+ sysbus_init_mmio(sbd, &pex->mmio);
+
+ /* MMIO and IO region */
+ memory_region_init(&rc->mmio, OBJECT(rc), "mmio", UINT64_MAX);
+ memory_region_init(&rc->io, OBJECT(rc), "io", 0x10000);
+
+ name = g_strdup_printf("pcie.%d.mmio_window", cfg->id);
+ memory_region_init_io(&rc->mmio_window, OBJECT(rc), &unassigned_io_ops,
+ OBJECT(rc), name, UINT64_MAX);
+ name = g_strdup_printf("pcie.%d.ioport_window", cfg->id);
+ memory_region_init_io(&rc->io_window, OBJECT(rc), &unassigned_io_ops,
+ OBJECT(rc), name, 0x10000);
+
+ memory_region_add_subregion(&rc->mmio_window, 0, &rc->mmio);
+ memory_region_add_subregion(&rc->io_window, 0, &rc->io);
+ sysbus_init_mmio(sbd, &rc->mmio_window);
+ sysbus_init_mmio(sbd, &rc->io_window);
+
+ sysbus_init_irq(sbd, &rc->irq);
+ name = g_strdup_printf("pcie.rc%d", cfg->id);
+ pci->bus = pci_register_root_bus(dev, name, aspeed_pcie_rc_set_irq,
+ aspeed_pcie_rc_map_irq, rc, &rc->mmio,
+ &rc->io, 0, 4, TYPE_PCIE_BUS);
+ pci->bus->flags |= PCI_BUS_EXTENDED_CONFIG_SPACE;
+}
+
+static const char *aspeed_pcie_rc_root_bus_path(PCIHostState *host_bridge,
+ PCIBus *rootbus)
+{
+ AspeedPCIERcState *rc = ASPEED_PCIE_RC(host_bridge);
+ AspeedPCIECfgState *cfg =
+ container_of(rc, AspeedPCIECfgState, rc);
+
+ snprintf(rc->name, sizeof(rc->name), "%04x:%02x", cfg->id, rc->bus_nr);
+
+ return rc->name;
+}
+
+static const Property aspeed_pcie_rc_props[] = {
+ DEFINE_PROP_UINT32("bus-nr", AspeedPCIERcState, bus_nr, 0),
+};
+
+static void aspeed_pcie_rc_class_init(ObjectClass *klass, const void *data)
+{
+ PCIHostBridgeClass *hc = PCI_HOST_BRIDGE_CLASS(klass);
+ DeviceClass *dc = DEVICE_CLASS(klass);
+
+ dc->desc = "ASPEED PCIe RC";
+ dc->realize = aspeed_pcie_rc_realize;
+ dc->fw_name = "pci";
+ set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
+
+ hc->root_bus_path = aspeed_pcie_rc_root_bus_path;
+ device_class_set_props(dc, aspeed_pcie_rc_props);
+
+ msi_nonbroken = true;
+}
+
+static const TypeInfo aspeed_pcie_rc_info = {
+ .name = TYPE_ASPEED_PCIE_RC,
+ .parent = TYPE_PCIE_HOST_BRIDGE,
+ .instance_size = sizeof(AspeedPCIERcState),
+ .class_init = aspeed_pcie_rc_class_init,
+};
+
+/*
+ * PCIe Config
+ *
+ * AHB to PCIe Bus Bridge (H2X)
+ *
+ * On the AST2600:
+ * NOTE: rc_l is not supported by this model.
+ * - Registers 0x00 - 0x7F are shared by both PCIe0 (rc_l) and PCIe1 (rc_h).
+ * - Registers 0x80 - 0xBF are specific to PCIe0.
+ * - Registers 0xC0 - 0xFF are specific to PCIe1.
+ */
+
+/* AST2600 */
+REG32(H2X_CTRL, 0x00)
+ FIELD(H2X_CTRL, CLEAR_RX, 4, 1)
+REG32(H2X_TX_CLEAR, 0x08)
+ FIELD(H2X_TX_CLEAR, IDLE, 0, 1)
+REG32(H2X_RDATA, 0x0C)
+REG32(H2X_TX_DESC0, 0x10)
+REG32(H2X_TX_DESC1, 0x14)
+REG32(H2X_TX_DESC2, 0x18)
+REG32(H2X_TX_DESC3, 0x1C)
+REG32(H2X_TX_DATA, 0x20)
+REG32(H2X_TX_STS, 0x24)
+ FIELD(H2X_TX_STS, IDLE, 31, 1)
+ FIELD(H2X_TX_STS, RC_L_TX_COMP, 24, 1)
+ FIELD(H2X_TX_STS, RC_H_TX_COMP, 25, 1)
+ FIELD(H2X_TX_STS, TRIG, 0, 1)
+REG32(H2X_RC_H_CTRL, 0xC0)
+REG32(H2X_RC_H_INT_EN, 0xC4)
+REG32(H2X_RC_H_INT_STS, 0xC8)
+ SHARED_FIELD(H2X_RC_INT_INTDONE, 4, 1)
+ SHARED_FIELD(H2X_RC_INT_INTX, 0, 4)
+REG32(H2X_RC_H_RDATA, 0xCC)
+
+#define TLP_FMTTYPE_CFGRD0 0x04 /* Configuration Read Type 0 */
+#define TLP_FMTTYPE_CFGWR0 0x44 /* Configuration Write Type 0 */
+#define TLP_FMTTYPE_CFGRD1 0x05 /* Configuration Read Type 1 */
+#define TLP_FMTTYPE_CFGWR1 0x45 /* Configuration Write Type 1 */
+
+#define PCIE_CFG_FMTTYPE_MASK(x) (((x) >> 24) & 0xff)
+#define PCIE_CFG_BYTE_EN(x) ((x) & 0xf)
+
+static const AspeedPCIERegMap aspeed_regmap = {
+ .rc = {
+ .int_en_reg = R_H2X_RC_H_INT_EN,
+ .int_sts_reg = R_H2X_RC_H_INT_STS,
+ },
+};
+
+static uint64_t aspeed_pcie_cfg_read(void *opaque, hwaddr addr,
+ unsigned int size)
+{
+ AspeedPCIECfgState *s = ASPEED_PCIE_CFG(opaque);
+ uint32_t reg = addr >> 2;
+ uint32_t value = 0;
+
+ value = s->regs[reg];
+
+ trace_aspeed_pcie_cfg_read(s->id, addr, value);
+
+ return value;
+}
+
+static void aspeed_pcie_cfg_translate_write(uint8_t byte_en, uint32_t *addr,
+ uint64_t *val, int *len)
+{
+ uint64_t packed_val = 0;
+ int first_bit = -1;
+ int index = 0;
+ int i;
+
+ *len = ctpop8(byte_en);
+
+ if (*len == 0 || *len > 4) {
+ qemu_log_mask(LOG_GUEST_ERROR, "%s: invalid byte enable: 0x%x\n",
+ __func__, byte_en);
+ return;
+ }
+
+ /* Special case: full 4-byte write must be 4-byte aligned */
+ if (byte_en == 0x0f) {
+ if ((*addr & 0x3) != 0) {
+ qemu_log_mask(LOG_GUEST_ERROR,
+ "%s: 4-byte write not 4-byte aligned: addr=0x%x\n",
+ __func__, *addr);
+ return;
+ }
+ *val &= 0xffffffffULL;
+ return;
+ }
+
+ for (i = 0; i < 4; i++) {
+ if (byte_en & (1 << i)) {
+ if (first_bit < 0) {
+ first_bit = i;
+ }
+ packed_val |= ((*val >> (i * 8)) & 0xff) << (index * 8);
+ index++;
+ }
+ }
+
+ *addr += first_bit;
+ *val = packed_val;
+}
+
+static void aspeed_pcie_cfg_readwrite(AspeedPCIECfgState *s,
+ const AspeedPCIECfgTxDesc *desc)
+{
+ AspeedPCIERcState *rc = &s->rc;
+ PCIHostState *pci;
+ uint32_t cfg_addr;
+ PCIDevice *pdev;
+ uint32_t offset;
+ uint8_t byte_en;
+ bool is_write;
+ uint8_t devfn;
+ uint64_t val;
+ uint8_t bus;
+ int len;
+
+ val = ~0;
+ is_write = !!(desc->desc0 & BIT(30));
+ cfg_addr = desc->desc2;
+
+ bus = (cfg_addr >> 24) & 0xff;
+ devfn = (cfg_addr >> 16) & 0xff;
+ offset = cfg_addr & 0xffc;
+
+ pci = PCI_HOST_BRIDGE(rc);
+
+ /*
+ * On the AST2600, the RC_H bus number range from 0x80 to 0xFF, with the
+ * root device and root port assigned to bus 0x80 instead of the standard
+ * 0x00. To allow the PCI subsystem to correctly discover devices on the
+ * root bus, bus 0x80 is remapped to 0x00.
+ */
+ if (bus == rc->bus_nr) {
+ bus = 0;
+ }
+
+ pdev = pci_find_device(pci->bus, bus, devfn);
+ if (!pdev) {
+ s->regs[desc->rdata_reg] = ~0;
+ goto out;
+ }
+
+ switch (PCIE_CFG_FMTTYPE_MASK(desc->desc0)) {
+ case TLP_FMTTYPE_CFGWR0:
+ case TLP_FMTTYPE_CFGWR1:
+ byte_en = PCIE_CFG_BYTE_EN(desc->desc1);
+ val = desc->wdata;
+ aspeed_pcie_cfg_translate_write(byte_en, &offset, &val, &len);
+ pci_host_config_write_common(pdev, offset, pci_config_size(pdev),
+ val, len);
+ break;
+ case TLP_FMTTYPE_CFGRD0:
+ case TLP_FMTTYPE_CFGRD1:
+ val = pci_host_config_read_common(pdev, offset,
+ pci_config_size(pdev), 4);
+ s->regs[desc->rdata_reg] = val;
+ break;
+ default:
+ qemu_log_mask(LOG_GUEST_ERROR, "%s: invalid CFG type. DESC0=0x%x\n",
+ __func__, desc->desc0);
+ }
+
+out:
+ trace_aspeed_pcie_cfg_rw(s->id, is_write ? "write" : "read", bus, devfn,
+ cfg_addr, val);
+}
+
+static void aspeed_pcie_cfg_write(void *opaque, hwaddr addr, uint64_t data,
+ unsigned int size)
+{
+ AspeedPCIECfgState *s = ASPEED_PCIE_CFG(opaque);
+ AspeedPCIECfgTxDesc desc;
+ uint32_t reg = addr >> 2;
+ uint32_t rc_reg;
+
+ trace_aspeed_pcie_cfg_write(s->id, addr, data);
+
+ switch (reg) {
+ case R_H2X_CTRL:
+ if (data & R_H2X_CTRL_CLEAR_RX_MASK) {
+ s->regs[R_H2X_RDATA] = ~0;
+ }
+ break;
+ case R_H2X_TX_CLEAR:
+ if (data & R_H2X_TX_CLEAR_IDLE_MASK) {
+ s->regs[R_H2X_TX_STS] &= ~R_H2X_TX_STS_IDLE_MASK;
+ }
+ break;
+ case R_H2X_TX_STS:
+ if (data & R_H2X_TX_STS_TRIG_MASK) {
+ desc.desc0 = s->regs[R_H2X_TX_DESC0];
+ desc.desc1 = s->regs[R_H2X_TX_DESC1];
+ desc.desc2 = s->regs[R_H2X_TX_DESC2];
+ desc.desc3 = s->regs[R_H2X_TX_DESC3];
+ desc.wdata = s->regs[R_H2X_TX_DATA];
+ desc.rdata_reg = R_H2X_RC_H_RDATA;
+ aspeed_pcie_cfg_readwrite(s, &desc);
+ rc_reg = s->rc_regs->int_sts_reg;
+ s->regs[rc_reg] |= H2X_RC_INT_INTDONE_MASK;
+ s->regs[R_H2X_TX_STS] |=
+ BIT(R_H2X_TX_STS_RC_H_TX_COMP_SHIFT);
+ s->regs[R_H2X_TX_STS] |= R_H2X_TX_STS_IDLE_MASK;
+ }
+ break;
+ /* preserve INTx status */
+ case R_H2X_RC_H_INT_STS:
+ if (data & H2X_RC_INT_INTDONE_MASK) {
+ s->regs[R_H2X_TX_STS] &= ~R_H2X_TX_STS_RC_H_TX_COMP_MASK;
+ }
+ s->regs[reg] &= ~data | H2X_RC_INT_INTX_MASK;
+ break;
+ default:
+ s->regs[reg] = data;
+ break;
+ }
+}
+
+static const MemoryRegionOps aspeed_pcie_cfg_ops = {
+ .read = aspeed_pcie_cfg_read,
+ .write = aspeed_pcie_cfg_write,
+ .endianness = DEVICE_LITTLE_ENDIAN,
+ .valid = {
+ .min_access_size = 1,
+ .max_access_size = 4,
+ },
+};
+
+static void aspeed_pcie_cfg_instance_init(Object *obj)
+{
+ AspeedPCIECfgState *s = ASPEED_PCIE_CFG(obj);
+
+ object_initialize_child(obj, "rc", &s->rc, TYPE_ASPEED_PCIE_RC);
+
+ return;
+}
+
+static void aspeed_pcie_cfg_reset(DeviceState *dev)
+{
+ AspeedPCIECfgState *s = ASPEED_PCIE_CFG(dev);
+ AspeedPCIECfgClass *apc = ASPEED_PCIE_CFG_GET_CLASS(s);
+
+ memset(s->regs, 0, apc->nr_regs << 2);
+}
+
+static void aspeed_pcie_cfg_realize(DeviceState *dev, Error **errp)
+{
+ SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
+ AspeedPCIECfgState *s = ASPEED_PCIE_CFG(dev);
+ AspeedPCIECfgClass *apc = ASPEED_PCIE_CFG_GET_CLASS(s);
+ g_autofree char *name;
+
+ s->rc_regs = &apc->reg_map->rc;
+ s->regs = g_new(uint32_t, apc->nr_regs);
+ name = g_strdup_printf(TYPE_ASPEED_PCIE_CFG ".regs.%d", s->id);
+ memory_region_init_io(&s->mmio, OBJECT(s), apc->reg_ops, s, name,
+ apc->nr_regs << 2);
+ sysbus_init_mmio(sbd, &s->mmio);
+
+ object_property_set_int(OBJECT(&s->rc), "bus-nr",
+ apc->rc_bus_nr,
+ &error_abort);
+ if (!sysbus_realize(SYS_BUS_DEVICE(&s->rc), errp)) {
+ return;
+ }
+}
+
+static void aspeed_pcie_cfg_unrealize(DeviceState *dev)
+{
+ AspeedPCIECfgState *s = ASPEED_PCIE_CFG(dev);
+
+ g_free(s->regs);
+ s->regs = NULL;
+}
+
+static const Property aspeed_pcie_cfg_props[] = {
+ DEFINE_PROP_UINT32("id", AspeedPCIECfgState, id, 0),
+};
+
+static void aspeed_pcie_cfg_class_init(ObjectClass *klass, const void *data)
+{
+ DeviceClass *dc = DEVICE_CLASS(klass);
+ AspeedPCIECfgClass *apc = ASPEED_PCIE_CFG_CLASS(klass);
+
+ dc->desc = "ASPEED PCIe Config";
+ dc->realize = aspeed_pcie_cfg_realize;
+ dc->unrealize = aspeed_pcie_cfg_unrealize;
+ device_class_set_legacy_reset(dc, aspeed_pcie_cfg_reset);
+ device_class_set_props(dc, aspeed_pcie_cfg_props);
+
+ apc->reg_ops = &aspeed_pcie_cfg_ops;
+ apc->reg_map = &aspeed_regmap;
+ apc->nr_regs = 0x100 >> 2;
+ apc->rc_bus_nr = 0x80;
+}
+
+static const TypeInfo aspeed_pcie_cfg_info = {
+ .name = TYPE_ASPEED_PCIE_CFG,
+ .parent = TYPE_SYS_BUS_DEVICE,
+ .instance_init = aspeed_pcie_cfg_instance_init,
+ .instance_size = sizeof(AspeedPCIECfgState),
+ .class_init = aspeed_pcie_cfg_class_init,
+ .class_size = sizeof(AspeedPCIECfgClass),
+};
+
/*
* PCIe PHY
*
@@ -150,6 +566,8 @@ static const TypeInfo aspeed_pcie_phy_info = {
static void aspeed_pcie_register_types(void)
{
+ type_register_static(&aspeed_pcie_rc_info);
+ type_register_static(&aspeed_pcie_cfg_info);
type_register_static(&aspeed_pcie_phy_info);
}
diff --git a/hw/pci-host/trace-events b/hw/pci-host/trace-events
index 3438516756..2584ea56e2 100644
--- a/hw/pci-host/trace-events
+++ b/hw/pci-host/trace-events
@@ -1,6 +1,10 @@
# See docs/devel/tracing.rst for syntax documentation.
# aspeed_pcie.c
+aspeed_pcie_rc_intx_set_irq(uint32_t id, int num, int level) "%d: num %d set IRQ leve %d"
+aspeed_pcie_cfg_read(uint32_t id, uint64_t addr, uint32_t value) "%d: addr 0x%" PRIx64 " value 0x%" PRIx32
+aspeed_pcie_cfg_write(uint32_t id, uint64_t addr, uint32_t value) "%d: addr 0x%" PRIx64 " value 0x%" PRIx32
+aspeed_pcie_cfg_rw(uint32_t id, const char *dir, uint8_t bus, uint8_t devfn, uint64_t addr, uint64_t data) "%d: %s bus:0x%x devfn:0x%x addr 0x%" PRIx64 " data 0x%" PRIx64
aspeed_pcie_phy_read(uint32_t id, uint64_t addr, uint32_t value) "%d: addr 0x%" PRIx64 " value 0x%" PRIx32
aspeed_pcie_phy_write(uint32_t id, uint64_t addr, uint32_t value) "%d: addr 0x%" PRIx64 " value 0x%" PRIx32
--
2.43.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* Re: [SPAM] [PATCH v3 03/14] hw/pci-host/aspeed: Add AST2600 PCIe config space and host bridge
2025-09-18 3:13 ` [PATCH v3 03/14] hw/pci-host/aspeed: Add AST2600 PCIe config space and host bridge Jamin Lin via
@ 2025-09-18 7:02 ` Cédric Le Goater
2025-09-18 7:24 ` Jamin Lin
0 siblings, 1 reply; 29+ messages in thread
From: Cédric Le Goater @ 2025-09-18 7:02 UTC (permalink / raw)
To: Jamin Lin, Paolo Bonzini, Peter Maydell, Steven Lee, Troy Lee,
Andrew Jeffery, Joel Stanley, Michael S. Tsirkin,
Marcel Apfelbaum, open list:ARM TCG CPUs,
open list:All patches CC here
Cc: troy_lee, nabihestefan, wuhaotsh, titusr
On 9/18/25 05:13, Jamin Lin wrote:
> Introduce PCIe config and host bridge model for the AST2600 platform.
>
> This patch adds support for the H2X (AHB to PCIe Bus Bridge) controller
> with a 0x100 byte register space. The register layout is shared between
> two root complexes: 0x00–0x7f is common, 0x80–0xbf for RC_L, and 0xc0–0xff
> for RC_H. Only RC_H is modeled in this implementation.
>
> The RC_H bus uses bus numbers in the 0x80–0xff range instead of the
> standard root bus 0x00. To allow the PCI subsystem to discover devices,
> the host bridge logic remaps the root bus number back to 0x00 whenever the
> configured bus number matches the "bus-nr" property.
>
> New MMIO callbacks are added for the H2X config space:
> - aspeed_pcie_cfg_read() and aspeed_pcie_cfg_write() handle register
> accesses.
> - aspeed_pcie_cfg_readwrite() provides configuration read/write support.
> - aspeed_pcie_cfg_translate_write() handles PCIe byte-enable semantics for
> write operations.
>
> The reset handler initializes the H2X register block with default values
> as defined in the AST2600 datasheet.
>
> Additional changes:
> - Implement ASPEED PCIe root complex (TYPE_ASPEED_PCIE_RC).
> - Wire up interrupt propagation via aspeed_pcie_rc_set_irq().
> - Add tracepoints for config read/write and INTx handling.
>
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> ---
> include/hw/pci-host/aspeed_pcie.h | 59 +++++
> hw/pci-host/aspeed_pcie.c | 418 ++++++++++++++++++++++++++++++
> hw/pci-host/trace-events | 4 +
> 3 files changed, 481 insertions(+)
>
> diff --git a/include/hw/pci-host/aspeed_pcie.h b/include/hw/pci-host/aspeed_pcie.h
> index d9fb829048..850d579189 100644
> --- a/include/hw/pci-host/aspeed_pcie.h
> +++ b/include/hw/pci-host/aspeed_pcie.h
> @@ -22,6 +22,65 @@
> #include "hw/pci/pcie_host.h"
> #include "qom/object.h"
>
> +typedef struct AspeedPCIECfgTxDesc {
> + uint32_t desc0;
> + uint32_t desc1;
> + uint32_t desc2;
> + uint32_t desc3;
> + uint32_t wdata;
> + uint32_t rdata_reg;
> +} AspeedPCIECfgTxDesc;
> +
> +typedef struct AspeedPCIERcRegs {
> + uint32_t int_en_reg;
> + uint32_t int_sts_reg;
> +} AspeedPCIERcRegs;
> +
> +typedef struct AspeedPCIERegMap {
> + AspeedPCIERcRegs rc;
> +} AspeedPCIERegMap;
> +
> +#define TYPE_ASPEED_PCIE_RC "aspeed.pcie-rc"
> +OBJECT_DECLARE_SIMPLE_TYPE(AspeedPCIERcState, ASPEED_PCIE_RC);
> +
> +struct AspeedPCIERcState {
> + PCIExpressHost parent_obj;
> +
> + MemoryRegion mmio_window;
> + MemoryRegion io_window;
> + MemoryRegion mmio;
> + MemoryRegion io;
> +
> + uint32_t bus_nr;
> + char name[16];
> + qemu_irq irq;> +};
> +
> +/* Bridge between AHB bus and PCIe RC. */
> +#define TYPE_ASPEED_PCIE_CFG "aspeed.pcie-cfg"
> +OBJECT_DECLARE_TYPE(AspeedPCIECfgState, AspeedPCIECfgClass, ASPEED_PCIE_CFG);
> +
> +struct AspeedPCIECfgState {
> + SysBusDevice parent_obj;
> +
> + MemoryRegion mmio;
> + uint32_t *regs;
> + uint32_t id;
> +
> + const AspeedPCIERcRegs *rc_regs;
> + AspeedPCIERcState rc;
> +};
> +
> +struct AspeedPCIECfgClass {
> + SysBusDeviceClass parent_class;
> +
> + const AspeedPCIERegMap *reg_map;
> + const MemoryRegionOps *reg_ops;
> +
> + uint64_t rc_bus_nr;
> + uint64_t nr_regs;
> +};
> +
> #define TYPE_ASPEED_PCIE_PHY "aspeed.pcie-phy"
> OBJECT_DECLARE_TYPE(AspeedPCIEPhyState, AspeedPCIEPhyClass, ASPEED_PCIE_PHY);
>
> diff --git a/hw/pci-host/aspeed_pcie.c b/hw/pci-host/aspeed_pcie.c
> index 110c963779..08d717381b 100644
> --- a/hw/pci-host/aspeed_pcie.c
> +++ b/hw/pci-host/aspeed_pcie.c
> @@ -25,6 +25,422 @@
> #include "hw/pci/msi.h"
> #include "trace.h"
>
> +/*
> + * PCIe Root Complex (RC)
> + */
> +
> +static void aspeed_pcie_rc_set_irq(void *opaque, int irq, int level)
> +{
> + AspeedPCIERcState *rc = (AspeedPCIERcState *) opaque;
> + AspeedPCIECfgState *cfg =
> + container_of(rc, AspeedPCIECfgState, rc);
> + bool intx;
> +
> + assert(irq < PCI_NUM_PINS);
> +
> + if (level) {
> + cfg->regs[cfg->rc_regs->int_sts_reg] |= BIT(irq);
> + } else {
> + cfg->regs[cfg->rc_regs->int_sts_reg] &= ~BIT(irq);
> + }
> +
> + intx = !!(cfg->regs[cfg->rc_regs->int_sts_reg] &
> + cfg->regs[cfg->rc_regs->int_en_reg]);
> + trace_aspeed_pcie_rc_intx_set_irq(cfg->id, irq, intx);
> + qemu_set_irq(rc->irq, intx);
> +}
> +
> +static int aspeed_pcie_rc_map_irq(PCIDevice *pci_dev, int irq_num)
> +{
> + return irq_num % PCI_NUM_PINS;
> +}
> +
> +static void aspeed_pcie_rc_realize(DeviceState *dev, Error **errp)
> +{
> + PCIExpressHost *pex = PCIE_HOST_BRIDGE(dev);
> + AspeedPCIERcState *rc = ASPEED_PCIE_RC(dev);
> + AspeedPCIECfgState *cfg =
> + container_of(rc, AspeedPCIECfgState, rc);
> + PCIHostState *pci = PCI_HOST_BRIDGE(dev);
> + SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
> + g_autofree char *name;
g_autofree variables should be assigned when declared.
> +
> + /* PCI configuration space */
> + pcie_host_mmcfg_init(pex, PCIE_MMCFG_SIZE_MAX);
> + sysbus_init_mmio(sbd, &pex->mmio);
> +
> + /* MMIO and IO region */
> + memory_region_init(&rc->mmio, OBJECT(rc), "mmio", UINT64_MAX);
> + memory_region_init(&rc->io, OBJECT(rc), "io", 0x10000);
> +
> + name = g_strdup_printf("pcie.%d.mmio_window", cfg->id);
> + memory_region_init_io(&rc->mmio_window, OBJECT(rc), &unassigned_io_ops,
> + OBJECT(rc), name, UINT64_MAX);
> + name = g_strdup_printf("pcie.%d.ioport_window", cfg->id);
This is going to leak memory .
> + memory_region_init_io(&rc->io_window, OBJECT(rc), &unassigned_io_ops,
> + OBJECT(rc), name, 0x10000);
> +
> + memory_region_add_subregion(&rc->mmio_window, 0, &rc->mmio);
> + memory_region_add_subregion(&rc->io_window, 0, &rc->io);
> + sysbus_init_mmio(sbd, &rc->mmio_window);
> + sysbus_init_mmio(sbd, &rc->io_window);
> +
> + sysbus_init_irq(sbd, &rc->irq);
> + name = g_strdup_printf("pcie.rc%d", cfg->id);
> + pci->bus = pci_register_root_bus(dev, name, aspeed_pcie_rc_set_irq,
> + aspeed_pcie_rc_map_irq, rc, &rc->mmio,
> + &rc->io, 0, 4, TYPE_PCIE_BUS);
> + pci->bus->flags |= PCI_BUS_EXTENDED_CONFIG_SPACE;
> +}
> +
> +static const char *aspeed_pcie_rc_root_bus_path(PCIHostState *host_bridge,
> + PCIBus *rootbus)
> +{
> + AspeedPCIERcState *rc = ASPEED_PCIE_RC(host_bridge);
> + AspeedPCIECfgState *cfg =
> + container_of(rc, AspeedPCIECfgState, rc);
> +
> + snprintf(rc->name, sizeof(rc->name), "%04x:%02x", cfg->id, rc->bus_nr);
> +
> + return rc->name;
> +}
> +
> +static const Property aspeed_pcie_rc_props[] = {
> + DEFINE_PROP_UINT32("bus-nr", AspeedPCIERcState, bus_nr, 0),
> +};
> +
> +static void aspeed_pcie_rc_class_init(ObjectClass *klass, const void *data)
> +{
> + PCIHostBridgeClass *hc = PCI_HOST_BRIDGE_CLASS(klass);
> + DeviceClass *dc = DEVICE_CLASS(klass);
> +
> + dc->desc = "ASPEED PCIe RC";
> + dc->realize = aspeed_pcie_rc_realize;
> + dc->fw_name = "pci";
> + set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
> +
> + hc->root_bus_path = aspeed_pcie_rc_root_bus_path;
> + device_class_set_props(dc, aspeed_pcie_rc_props);
> +
> + msi_nonbroken = true;
> +}
> +
> +static const TypeInfo aspeed_pcie_rc_info = {
> + .name = TYPE_ASPEED_PCIE_RC,
> + .parent = TYPE_PCIE_HOST_BRIDGE,
> + .instance_size = sizeof(AspeedPCIERcState),
> + .class_init = aspeed_pcie_rc_class_init,
> +};
> +
> +/*
> + * PCIe Config
> + *
> + * AHB to PCIe Bus Bridge (H2X)
> + *
> + * On the AST2600:
> + * NOTE: rc_l is not supported by this model.
> + * - Registers 0x00 - 0x7F are shared by both PCIe0 (rc_l) and PCIe1 (rc_h).
> + * - Registers 0x80 - 0xBF are specific to PCIe0.
> + * - Registers 0xC0 - 0xFF are specific to PCIe1.
> + */
> +
> +/* AST2600 */
> +REG32(H2X_CTRL, 0x00)
> + FIELD(H2X_CTRL, CLEAR_RX, 4, 1)
> +REG32(H2X_TX_CLEAR, 0x08)
> + FIELD(H2X_TX_CLEAR, IDLE, 0, 1)
> +REG32(H2X_RDATA, 0x0C)
> +REG32(H2X_TX_DESC0, 0x10)
> +REG32(H2X_TX_DESC1, 0x14)
> +REG32(H2X_TX_DESC2, 0x18)
> +REG32(H2X_TX_DESC3, 0x1C)
> +REG32(H2X_TX_DATA, 0x20)
> +REG32(H2X_TX_STS, 0x24)
> + FIELD(H2X_TX_STS, IDLE, 31, 1)
> + FIELD(H2X_TX_STS, RC_L_TX_COMP, 24, 1)
> + FIELD(H2X_TX_STS, RC_H_TX_COMP, 25, 1)
> + FIELD(H2X_TX_STS, TRIG, 0, 1)
> +REG32(H2X_RC_H_CTRL, 0xC0)
> +REG32(H2X_RC_H_INT_EN, 0xC4)
> +REG32(H2X_RC_H_INT_STS, 0xC8)
> + SHARED_FIELD(H2X_RC_INT_INTDONE, 4, 1)
> + SHARED_FIELD(H2X_RC_INT_INTX, 0, 4)
> +REG32(H2X_RC_H_RDATA, 0xCC)
> +
> +#define TLP_FMTTYPE_CFGRD0 0x04 /* Configuration Read Type 0 */
> +#define TLP_FMTTYPE_CFGWR0 0x44 /* Configuration Write Type 0 */
> +#define TLP_FMTTYPE_CFGRD1 0x05 /* Configuration Read Type 1 */
> +#define TLP_FMTTYPE_CFGWR1 0x45 /* Configuration Write Type 1 */
> +
> +#define PCIE_CFG_FMTTYPE_MASK(x) (((x) >> 24) & 0xff)
> +#define PCIE_CFG_BYTE_EN(x) ((x) & 0xf)
> +
> +static const AspeedPCIERegMap aspeed_regmap = {
> + .rc = {
> + .int_en_reg = R_H2X_RC_H_INT_EN,
> + .int_sts_reg = R_H2X_RC_H_INT_STS,
> + },
> +};
> +
> +static uint64_t aspeed_pcie_cfg_read(void *opaque, hwaddr addr,
> + unsigned int size)
> +{
> + AspeedPCIECfgState *s = ASPEED_PCIE_CFG(opaque);
> + uint32_t reg = addr >> 2;
> + uint32_t value = 0;
> +
> + value = s->regs[reg];
> +
> + trace_aspeed_pcie_cfg_read(s->id, addr, value);
> +
> + return value;
> +}
> +
> +static void aspeed_pcie_cfg_translate_write(uint8_t byte_en, uint32_t *addr,
> + uint64_t *val, int *len)
> +{
> + uint64_t packed_val = 0;
> + int first_bit = -1;
> + int index = 0;
> + int i;
> +
> + *len = ctpop8(byte_en);
> +
> + if (*len == 0 || *len > 4) {
> + qemu_log_mask(LOG_GUEST_ERROR, "%s: invalid byte enable: 0x%x\n",
> + __func__, byte_en);
> + return;
> + }
> +
> + /* Special case: full 4-byte write must be 4-byte aligned */
> + if (byte_en == 0x0f) {
> + if ((*addr & 0x3) != 0) {
> + qemu_log_mask(LOG_GUEST_ERROR,
> + "%s: 4-byte write not 4-byte aligned: addr=0x%x\n",
> + __func__, *addr);
> + return;
> + }
> + *val &= 0xffffffffULL;
> + return;
> + }
> +
> + for (i = 0; i < 4; i++) {
> + if (byte_en & (1 << i)) {
> + if (first_bit < 0) {
> + first_bit = i;
> + }
> + packed_val |= ((*val >> (i * 8)) & 0xff) << (index * 8);
> + index++;
> + }
> + }
> +
> + *addr += first_bit;
> + *val = packed_val;
> +}
> +
> +static void aspeed_pcie_cfg_readwrite(AspeedPCIECfgState *s,
> + const AspeedPCIECfgTxDesc *desc)
> +{
> + AspeedPCIERcState *rc = &s->rc;
> + PCIHostState *pci;
> + uint32_t cfg_addr;
> + PCIDevice *pdev;
> + uint32_t offset;
> + uint8_t byte_en;
> + bool is_write;
> + uint8_t devfn;
> + uint64_t val;
> + uint8_t bus;
> + int len;
> +
> + val = ~0;
> + is_write = !!(desc->desc0 & BIT(30));
> + cfg_addr = desc->desc2;
> +
> + bus = (cfg_addr >> 24) & 0xff;
> + devfn = (cfg_addr >> 16) & 0xff;
> + offset = cfg_addr & 0xffc;
> +
> + pci = PCI_HOST_BRIDGE(rc);
> +
> + /*
> + * On the AST2600, the RC_H bus number range from 0x80 to 0xFF, with the
> + * root device and root port assigned to bus 0x80 instead of the standard
> + * 0x00. To allow the PCI subsystem to correctly discover devices on the
> + * root bus, bus 0x80 is remapped to 0x00.
> + */
> + if (bus == rc->bus_nr) {
> + bus = 0;
> + }
> +
> + pdev = pci_find_device(pci->bus, bus, devfn);
> + if (!pdev) {
> + s->regs[desc->rdata_reg] = ~0;
> + goto out;
> + }
> +
> + switch (PCIE_CFG_FMTTYPE_MASK(desc->desc0)) {
> + case TLP_FMTTYPE_CFGWR0:
> + case TLP_FMTTYPE_CFGWR1:
> + byte_en = PCIE_CFG_BYTE_EN(desc->desc1);
> + val = desc->wdata;
> + aspeed_pcie_cfg_translate_write(byte_en, &offset, &val, &len);
> + pci_host_config_write_common(pdev, offset, pci_config_size(pdev),
> + val, len);
> + break;
> + case TLP_FMTTYPE_CFGRD0:
> + case TLP_FMTTYPE_CFGRD1:
> + val = pci_host_config_read_common(pdev, offset,
> + pci_config_size(pdev), 4);
> + s->regs[desc->rdata_reg] = val;
> + break;
> + default:
> + qemu_log_mask(LOG_GUEST_ERROR, "%s: invalid CFG type. DESC0=0x%x\n",
> + __func__, desc->desc0);
> + }
> +
> +out:
> + trace_aspeed_pcie_cfg_rw(s->id, is_write ? "write" : "read", bus, devfn,
> + cfg_addr, val);
> +}
> +
> +static void aspeed_pcie_cfg_write(void *opaque, hwaddr addr, uint64_t data,
> + unsigned int size)
> +{
> + AspeedPCIECfgState *s = ASPEED_PCIE_CFG(opaque);
> + AspeedPCIECfgTxDesc desc;
> + uint32_t reg = addr >> 2;
> + uint32_t rc_reg;
> +
> + trace_aspeed_pcie_cfg_write(s->id, addr, data);
> +
> + switch (reg) {
> + case R_H2X_CTRL:
> + if (data & R_H2X_CTRL_CLEAR_RX_MASK) {
> + s->regs[R_H2X_RDATA] = ~0;
> + }
> + break;
> + case R_H2X_TX_CLEAR:
> + if (data & R_H2X_TX_CLEAR_IDLE_MASK) {
> + s->regs[R_H2X_TX_STS] &= ~R_H2X_TX_STS_IDLE_MASK;
> + }
> + break;
> + case R_H2X_TX_STS:
> + if (data & R_H2X_TX_STS_TRIG_MASK) {
> + desc.desc0 = s->regs[R_H2X_TX_DESC0];
> + desc.desc1 = s->regs[R_H2X_TX_DESC1];
> + desc.desc2 = s->regs[R_H2X_TX_DESC2];
> + desc.desc3 = s->regs[R_H2X_TX_DESC3];
> + desc.wdata = s->regs[R_H2X_TX_DATA];
> + desc.rdata_reg = R_H2X_RC_H_RDATA;
> + aspeed_pcie_cfg_readwrite(s, &desc);
> + rc_reg = s->rc_regs->int_sts_reg;
> + s->regs[rc_reg] |= H2X_RC_INT_INTDONE_MASK;
> + s->regs[R_H2X_TX_STS] |=
> + BIT(R_H2X_TX_STS_RC_H_TX_COMP_SHIFT);
> + s->regs[R_H2X_TX_STS] |= R_H2X_TX_STS_IDLE_MASK;
> + }
> + break;
> + /* preserve INTx status */
> + case R_H2X_RC_H_INT_STS:
> + if (data & H2X_RC_INT_INTDONE_MASK) {
> + s->regs[R_H2X_TX_STS] &= ~R_H2X_TX_STS_RC_H_TX_COMP_MASK;
> + }
> + s->regs[reg] &= ~data | H2X_RC_INT_INTX_MASK;
> + break;
> + default:
> + s->regs[reg] = data;
> + break;
> + }
> +}
> +
> +static const MemoryRegionOps aspeed_pcie_cfg_ops = {
> + .read = aspeed_pcie_cfg_read,
> + .write = aspeed_pcie_cfg_write,
> + .endianness = DEVICE_LITTLE_ENDIAN,
> + .valid = {
> + .min_access_size = 1,
> + .max_access_size = 4,
> + },
> +};
> +
> +static void aspeed_pcie_cfg_instance_init(Object *obj)
> +{
> + AspeedPCIECfgState *s = ASPEED_PCIE_CFG(obj);
> +
> + object_initialize_child(obj, "rc", &s->rc, TYPE_ASPEED_PCIE_RC);
> +
> + return;
> +}
> +
> +static void aspeed_pcie_cfg_reset(DeviceState *dev)
> +{
> + AspeedPCIECfgState *s = ASPEED_PCIE_CFG(dev);
> + AspeedPCIECfgClass *apc = ASPEED_PCIE_CFG_GET_CLASS(s);
> +
> + memset(s->regs, 0, apc->nr_regs << 2);
> +}
> +
> +static void aspeed_pcie_cfg_realize(DeviceState *dev, Error **errp)
> +{
> + SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
> + AspeedPCIECfgState *s = ASPEED_PCIE_CFG(dev);
> + AspeedPCIECfgClass *apc = ASPEED_PCIE_CFG_GET_CLASS(s);
> + g_autofree char *name;
name should be assigned.
Thanks,
C.
> +
> + s->rc_regs = &apc->reg_map->rc;
> + s->regs = g_new(uint32_t, apc->nr_regs);
> + name = g_strdup_printf(TYPE_ASPEED_PCIE_CFG ".regs.%d", s->id);
> + memory_region_init_io(&s->mmio, OBJECT(s), apc->reg_ops, s, name,
> + apc->nr_regs << 2);
> + sysbus_init_mmio(sbd, &s->mmio);
> +
> + object_property_set_int(OBJECT(&s->rc), "bus-nr",
> + apc->rc_bus_nr,
> + &error_abort);
> + if (!sysbus_realize(SYS_BUS_DEVICE(&s->rc), errp)) {
> + return;
> + }
> +}
> +
> +static void aspeed_pcie_cfg_unrealize(DeviceState *dev)
> +{
> + AspeedPCIECfgState *s = ASPEED_PCIE_CFG(dev);
> +
> + g_free(s->regs);
> + s->regs = NULL;
> +}
> +
> +static const Property aspeed_pcie_cfg_props[] = {
> + DEFINE_PROP_UINT32("id", AspeedPCIECfgState, id, 0),
> +};
> +
> +static void aspeed_pcie_cfg_class_init(ObjectClass *klass, const void *data)
> +{
> + DeviceClass *dc = DEVICE_CLASS(klass);
> + AspeedPCIECfgClass *apc = ASPEED_PCIE_CFG_CLASS(klass);
> +
> + dc->desc = "ASPEED PCIe Config";
> + dc->realize = aspeed_pcie_cfg_realize;
> + dc->unrealize = aspeed_pcie_cfg_unrealize;
> + device_class_set_legacy_reset(dc, aspeed_pcie_cfg_reset);
> + device_class_set_props(dc, aspeed_pcie_cfg_props);
> +
> + apc->reg_ops = &aspeed_pcie_cfg_ops;
> + apc->reg_map = &aspeed_regmap;
> + apc->nr_regs = 0x100 >> 2;
> + apc->rc_bus_nr = 0x80;
> +}
> +
> +static const TypeInfo aspeed_pcie_cfg_info = {
> + .name = TYPE_ASPEED_PCIE_CFG,
> + .parent = TYPE_SYS_BUS_DEVICE,
> + .instance_init = aspeed_pcie_cfg_instance_init,
> + .instance_size = sizeof(AspeedPCIECfgState),
> + .class_init = aspeed_pcie_cfg_class_init,
> + .class_size = sizeof(AspeedPCIECfgClass),
> +};
> +
> /*
> * PCIe PHY
> *
> @@ -150,6 +566,8 @@ static const TypeInfo aspeed_pcie_phy_info = {
>
> static void aspeed_pcie_register_types(void)
> {
> + type_register_static(&aspeed_pcie_rc_info);
> + type_register_static(&aspeed_pcie_cfg_info);
> type_register_static(&aspeed_pcie_phy_info);
> }
>
> diff --git a/hw/pci-host/trace-events b/hw/pci-host/trace-events
> index 3438516756..2584ea56e2 100644
> --- a/hw/pci-host/trace-events
> +++ b/hw/pci-host/trace-events
> @@ -1,6 +1,10 @@
> # See docs/devel/tracing.rst for syntax documentation.
>
> # aspeed_pcie.c
> +aspeed_pcie_rc_intx_set_irq(uint32_t id, int num, int level) "%d: num %d set IRQ leve %d"
> +aspeed_pcie_cfg_read(uint32_t id, uint64_t addr, uint32_t value) "%d: addr 0x%" PRIx64 " value 0x%" PRIx32
> +aspeed_pcie_cfg_write(uint32_t id, uint64_t addr, uint32_t value) "%d: addr 0x%" PRIx64 " value 0x%" PRIx32
> +aspeed_pcie_cfg_rw(uint32_t id, const char *dir, uint8_t bus, uint8_t devfn, uint64_t addr, uint64_t data) "%d: %s bus:0x%x devfn:0x%x addr 0x%" PRIx64 " data 0x%" PRIx64
> aspeed_pcie_phy_read(uint32_t id, uint64_t addr, uint32_t value) "%d: addr 0x%" PRIx64 " value 0x%" PRIx32
> aspeed_pcie_phy_write(uint32_t id, uint64_t addr, uint32_t value) "%d: addr 0x%" PRIx64 " value 0x%" PRIx32
>
^ permalink raw reply [flat|nested] 29+ messages in thread* RE: [SPAM] [PATCH v3 03/14] hw/pci-host/aspeed: Add AST2600 PCIe config space and host bridge
2025-09-18 7:02 ` [SPAM] " Cédric Le Goater
@ 2025-09-18 7:24 ` Jamin Lin
0 siblings, 0 replies; 29+ messages in thread
From: Jamin Lin @ 2025-09-18 7:24 UTC (permalink / raw)
To: Cédric Le Goater, Paolo Bonzini, Peter Maydell, Steven Lee,
Troy Lee, Andrew Jeffery, Joel Stanley, Michael S. Tsirkin,
Marcel Apfelbaum, open list:ARM TCG CPUs,
open list:All patches CC here
Cc: Troy Lee, nabihestefan@google.com, wuhaotsh@google.com,
titusr@google.com
Hi Cédric
> Subject: Re: [SPAM] [PATCH v3 03/14] hw/pci-host/aspeed: Add AST2600 PCIe
> config space and host bridge
>
> On 9/18/25 05:13, Jamin Lin wrote:
> > Introduce PCIe config and host bridge model for the AST2600 platform.
> >
> > This patch adds support for the H2X (AHB to PCIe Bus Bridge)
> > controller with a 0x100 byte register space. The register layout is
> > shared between two root complexes: 0x00–0x7f is common, 0x80–0xbf for
> > RC_L, and 0xc0–0xff for RC_H. Only RC_H is modeled in this
> implementation.
> >
> > The RC_H bus uses bus numbers in the 0x80–0xff range instead of the
> > standard root bus 0x00. To allow the PCI subsystem to discover
> > devices, the host bridge logic remaps the root bus number back to 0x00
> > whenever the configured bus number matches the "bus-nr" property.
> >
> > New MMIO callbacks are added for the H2X config space:
> > - aspeed_pcie_cfg_read() and aspeed_pcie_cfg_write() handle register
> > accesses.
> > - aspeed_pcie_cfg_readwrite() provides configuration read/write support.
> > - aspeed_pcie_cfg_translate_write() handles PCIe byte-enable semantics for
> > write operations.
> >
> > The reset handler initializes the H2X register block with default
> > values as defined in the AST2600 datasheet.
> >
> > Additional changes:
> > - Implement ASPEED PCIe root complex (TYPE_ASPEED_PCIE_RC).
> > - Wire up interrupt propagation via aspeed_pcie_rc_set_irq().
> > - Add tracepoints for config read/write and INTx handling.
> >
> > Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> > ---
> > include/hw/pci-host/aspeed_pcie.h | 59 +++++
> > hw/pci-host/aspeed_pcie.c | 418
> ++++++++++++++++++++++++++++++
> > hw/pci-host/trace-events | 4 +
> > 3 files changed, 481 insertions(+)
> >
> > diff --git a/include/hw/pci-host/aspeed_pcie.h
> > b/include/hw/pci-host/aspeed_pcie.h
> > index d9fb829048..850d579189 100644
> > --- a/include/hw/pci-host/aspeed_pcie.h
> > +++ b/include/hw/pci-host/aspeed_pcie.h
> > @@ -22,6 +22,65 @@
> > #include "hw/pci/pcie_host.h"
> > #include "qom/object.h"
> >
> > +typedef struct AspeedPCIECfgTxDesc {
> > + uint32_t desc0;
> > + uint32_t desc1;
> > + uint32_t desc2;
> > + uint32_t desc3;
> > + uint32_t wdata;
> > + uint32_t rdata_reg;
> > +} AspeedPCIECfgTxDesc;
> > +
> > +typedef struct AspeedPCIERcRegs {
> > + uint32_t int_en_reg;
> > + uint32_t int_sts_reg;
> > +} AspeedPCIERcRegs;
> > +
> > +typedef struct AspeedPCIERegMap {
> > + AspeedPCIERcRegs rc;
> > +} AspeedPCIERegMap;
> > +
> > +#define TYPE_ASPEED_PCIE_RC "aspeed.pcie-rc"
> > +OBJECT_DECLARE_SIMPLE_TYPE(AspeedPCIERcState, ASPEED_PCIE_RC);
> > +
> > +struct AspeedPCIERcState {
> > + PCIExpressHost parent_obj;
> > +
> > + MemoryRegion mmio_window;
> > + MemoryRegion io_window;
> > + MemoryRegion mmio;
> > + MemoryRegion io;
> > +
> > + uint32_t bus_nr;
> > + char name[16];
> > + qemu_irq irq;> +};
> > +
> > +/* Bridge between AHB bus and PCIe RC. */ #define
> > +TYPE_ASPEED_PCIE_CFG "aspeed.pcie-cfg"
> > +OBJECT_DECLARE_TYPE(AspeedPCIECfgState, AspeedPCIECfgClass,
> > +ASPEED_PCIE_CFG);
> > +
> > +struct AspeedPCIECfgState {
> > + SysBusDevice parent_obj;
> > +
> > + MemoryRegion mmio;
> > + uint32_t *regs;
> > + uint32_t id;
> > +
> > + const AspeedPCIERcRegs *rc_regs;
> > + AspeedPCIERcState rc;
> > +};
> > +
> > +struct AspeedPCIECfgClass {
> > + SysBusDeviceClass parent_class;
> > +
> > + const AspeedPCIERegMap *reg_map;
> > + const MemoryRegionOps *reg_ops;
> > +
> > + uint64_t rc_bus_nr;
> > + uint64_t nr_regs;
> > +};
> > +
> > #define TYPE_ASPEED_PCIE_PHY "aspeed.pcie-phy"
> > OBJECT_DECLARE_TYPE(AspeedPCIEPhyState, AspeedPCIEPhyClass,
> > ASPEED_PCIE_PHY);
> >
> > diff --git a/hw/pci-host/aspeed_pcie.c b/hw/pci-host/aspeed_pcie.c
> > index 110c963779..08d717381b 100644
> > --- a/hw/pci-host/aspeed_pcie.c
> > +++ b/hw/pci-host/aspeed_pcie.c
> > @@ -25,6 +25,422 @@
> > #include "hw/pci/msi.h"
> > #include "trace.h"
> >
> > +/*
> > + * PCIe Root Complex (RC)
> > + */
> > +
> > +static void aspeed_pcie_rc_set_irq(void *opaque, int irq, int level)
> > +{
> > + AspeedPCIERcState *rc = (AspeedPCIERcState *) opaque;
> > + AspeedPCIECfgState *cfg =
> > + container_of(rc, AspeedPCIECfgState, rc);
> > + bool intx;
> > +
> > + assert(irq < PCI_NUM_PINS);
> > +
> > + if (level) {
> > + cfg->regs[cfg->rc_regs->int_sts_reg] |= BIT(irq);
> > + } else {
> > + cfg->regs[cfg->rc_regs->int_sts_reg] &= ~BIT(irq);
> > + }
> > +
> > + intx = !!(cfg->regs[cfg->rc_regs->int_sts_reg] &
> > + cfg->regs[cfg->rc_regs->int_en_reg]);
> > + trace_aspeed_pcie_rc_intx_set_irq(cfg->id, irq, intx);
> > + qemu_set_irq(rc->irq, intx);
> > +}
> > +
> > +static int aspeed_pcie_rc_map_irq(PCIDevice *pci_dev, int irq_num) {
> > + return irq_num % PCI_NUM_PINS;
> > +}
> > +
> > +static void aspeed_pcie_rc_realize(DeviceState *dev, Error **errp) {
> > + PCIExpressHost *pex = PCIE_HOST_BRIDGE(dev);
> > + AspeedPCIERcState *rc = ASPEED_PCIE_RC(dev);
> > + AspeedPCIECfgState *cfg =
> > + container_of(rc, AspeedPCIECfgState, rc);
> > + PCIHostState *pci = PCI_HOST_BRIDGE(dev);
> > + SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
> > + g_autofree char *name;
>
> g_autofree variables should be assigned when declared.
>
Thanks for your review and suggestion.
Will fix it.
> > +
> > + /* PCI configuration space */
> > + pcie_host_mmcfg_init(pex, PCIE_MMCFG_SIZE_MAX);
> > + sysbus_init_mmio(sbd, &pex->mmio);
> > +
> > + /* MMIO and IO region */
> > + memory_region_init(&rc->mmio, OBJECT(rc), "mmio", UINT64_MAX);
> > + memory_region_init(&rc->io, OBJECT(rc), "io", 0x10000);
> > +
> > + name = g_strdup_printf("pcie.%d.mmio_window", cfg->id);
> > + memory_region_init_io(&rc->mmio_window, OBJECT(rc),
> &unassigned_io_ops,
> > + OBJECT(rc), name, UINT64_MAX);
> > + name = g_strdup_printf("pcie.%d.ioport_window", cfg->id);
>
> This is going to leak memory .
Will fix it.
>
> > + memory_region_init_io(&rc->io_window, OBJECT(rc),
> &unassigned_io_ops,
> > + OBJECT(rc), name, 0x10000);
> > +
> > + memory_region_add_subregion(&rc->mmio_window, 0, &rc->mmio);
> > + memory_region_add_subregion(&rc->io_window, 0, &rc->io);
> > + sysbus_init_mmio(sbd, &rc->mmio_window);
> > + sysbus_init_mmio(sbd, &rc->io_window);
> > +
> > + sysbus_init_irq(sbd, &rc->irq);
> > + name = g_strdup_printf("pcie.rc%d", cfg->id);
> > + pci->bus = pci_register_root_bus(dev, name, aspeed_pcie_rc_set_irq,
> > + aspeed_pcie_rc_map_irq, rc,
> &rc->mmio,
> > + &rc->io, 0, 4,
> TYPE_PCIE_BUS);
> > + pci->bus->flags |= PCI_BUS_EXTENDED_CONFIG_SPACE; }
> > +
> > +static const char *aspeed_pcie_rc_root_bus_path(PCIHostState
> *host_bridge,
> > + PCIBus *rootbus)
> {
> > + AspeedPCIERcState *rc = ASPEED_PCIE_RC(host_bridge);
> > + AspeedPCIECfgState *cfg =
> > + container_of(rc, AspeedPCIECfgState, rc);
> > +
> > + snprintf(rc->name, sizeof(rc->name), "%04x:%02x", cfg->id,
> > + rc->bus_nr);
> > +
> > + return rc->name;
> > +}
> > +
> > +static const Property aspeed_pcie_rc_props[] = {
> > + DEFINE_PROP_UINT32("bus-nr", AspeedPCIERcState, bus_nr, 0), };
> > +
> > +static void aspeed_pcie_rc_class_init(ObjectClass *klass, const void
> > +*data) {
> > + PCIHostBridgeClass *hc = PCI_HOST_BRIDGE_CLASS(klass);
> > + DeviceClass *dc = DEVICE_CLASS(klass);
> > +
> > + dc->desc = "ASPEED PCIe RC";
> > + dc->realize = aspeed_pcie_rc_realize;
> > + dc->fw_name = "pci";
> > + set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
> > +
> > + hc->root_bus_path = aspeed_pcie_rc_root_bus_path;
> > + device_class_set_props(dc, aspeed_pcie_rc_props);
> > +
> > + msi_nonbroken = true;
> > +}
> > +
> > +static const TypeInfo aspeed_pcie_rc_info = {
> > + .name = TYPE_ASPEED_PCIE_RC,
> > + .parent = TYPE_PCIE_HOST_BRIDGE,
> > + .instance_size = sizeof(AspeedPCIERcState),
> > + .class_init = aspeed_pcie_rc_class_init, };
> > +
> > +/*
> > + * PCIe Config
> > + *
> > + * AHB to PCIe Bus Bridge (H2X)
> > + *
> > + * On the AST2600:
> > + * NOTE: rc_l is not supported by this model.
> > + * - Registers 0x00 - 0x7F are shared by both PCIe0 (rc_l) and PCIe1 (rc_h).
> > + * - Registers 0x80 - 0xBF are specific to PCIe0.
> > + * - Registers 0xC0 - 0xFF are specific to PCIe1.
> > + */
> > +
> > +/* AST2600 */
> > +REG32(H2X_CTRL, 0x00)
> > + FIELD(H2X_CTRL, CLEAR_RX, 4, 1)
> > +REG32(H2X_TX_CLEAR, 0x08)
> > + FIELD(H2X_TX_CLEAR, IDLE, 0, 1)
> > +REG32(H2X_RDATA, 0x0C)
> > +REG32(H2X_TX_DESC0, 0x10)
> > +REG32(H2X_TX_DESC1, 0x14)
> > +REG32(H2X_TX_DESC2, 0x18)
> > +REG32(H2X_TX_DESC3, 0x1C)
> > +REG32(H2X_TX_DATA, 0x20)
> > +REG32(H2X_TX_STS, 0x24)
> > + FIELD(H2X_TX_STS, IDLE, 31, 1)
> > + FIELD(H2X_TX_STS, RC_L_TX_COMP, 24, 1)
> > + FIELD(H2X_TX_STS, RC_H_TX_COMP, 25, 1)
> > + FIELD(H2X_TX_STS, TRIG, 0, 1)
> > +REG32(H2X_RC_H_CTRL, 0xC0)
> > +REG32(H2X_RC_H_INT_EN, 0xC4)
> > +REG32(H2X_RC_H_INT_STS, 0xC8)
> > + SHARED_FIELD(H2X_RC_INT_INTDONE, 4, 1)
> > + SHARED_FIELD(H2X_RC_INT_INTX, 0, 4)
> > +REG32(H2X_RC_H_RDATA, 0xCC)
> > +
> > +#define TLP_FMTTYPE_CFGRD0 0x04 /* Configuration Read Type 0 */
> > +#define TLP_FMTTYPE_CFGWR0 0x44 /* Configuration Write Type 0 */
> > +#define TLP_FMTTYPE_CFGRD1 0x05 /* Configuration Read Type 1 */
> > +#define TLP_FMTTYPE_CFGWR1 0x45 /* Configuration Write Type 1 */
> > +
> > +#define PCIE_CFG_FMTTYPE_MASK(x) (((x) >> 24) & 0xff) #define
> > +PCIE_CFG_BYTE_EN(x) ((x) & 0xf)
> > +
> > +static const AspeedPCIERegMap aspeed_regmap = {
> > + .rc = {
> > + .int_en_reg = R_H2X_RC_H_INT_EN,
> > + .int_sts_reg = R_H2X_RC_H_INT_STS,
> > + },
> > +};
> > +
> > +static uint64_t aspeed_pcie_cfg_read(void *opaque, hwaddr addr,
> > + unsigned int size) {
> > + AspeedPCIECfgState *s = ASPEED_PCIE_CFG(opaque);
> > + uint32_t reg = addr >> 2;
> > + uint32_t value = 0;
> > +
> > + value = s->regs[reg];
> > +
> > + trace_aspeed_pcie_cfg_read(s->id, addr, value);
> > +
> > + return value;
> > +}
> > +
> > +static void aspeed_pcie_cfg_translate_write(uint8_t byte_en, uint32_t
> *addr,
> > + uint64_t *val, int
> *len)
> > +{
> > + uint64_t packed_val = 0;
> > + int first_bit = -1;
> > + int index = 0;
> > + int i;
> > +
> > + *len = ctpop8(byte_en);
> > +
> > + if (*len == 0 || *len > 4) {
> > + qemu_log_mask(LOG_GUEST_ERROR, "%s: invalid byte enable:
> 0x%x\n",
> > + __func__, byte_en);
> > + return;
> > + }
> > +
> > + /* Special case: full 4-byte write must be 4-byte aligned */
> > + if (byte_en == 0x0f) {
> > + if ((*addr & 0x3) != 0) {
> > + qemu_log_mask(LOG_GUEST_ERROR,
> > + "%s: 4-byte write not 4-byte aligned:
> addr=0x%x\n",
> > + __func__, *addr);
> > + return;
> > + }
> > + *val &= 0xffffffffULL;
> > + return;
> > + }
> > +
> > + for (i = 0; i < 4; i++) {
> > + if (byte_en & (1 << i)) {
> > + if (first_bit < 0) {
> > + first_bit = i;
> > + }
> > + packed_val |= ((*val >> (i * 8)) & 0xff) << (index * 8);
> > + index++;
> > + }
> > + }
> > +
> > + *addr += first_bit;
> > + *val = packed_val;
> > +}
> > +
> > +static void aspeed_pcie_cfg_readwrite(AspeedPCIECfgState *s,
> > + const AspeedPCIECfgTxDesc
> > +*desc) {
> > + AspeedPCIERcState *rc = &s->rc;
> > + PCIHostState *pci;
> > + uint32_t cfg_addr;
> > + PCIDevice *pdev;
> > + uint32_t offset;
> > + uint8_t byte_en;
> > + bool is_write;
> > + uint8_t devfn;
> > + uint64_t val;
> > + uint8_t bus;
> > + int len;
> > +
> > + val = ~0;
> > + is_write = !!(desc->desc0 & BIT(30));
> > + cfg_addr = desc->desc2;
> > +
> > + bus = (cfg_addr >> 24) & 0xff;
> > + devfn = (cfg_addr >> 16) & 0xff;
> > + offset = cfg_addr & 0xffc;
> > +
> > + pci = PCI_HOST_BRIDGE(rc);
> > +
> > + /*
> > + * On the AST2600, the RC_H bus number range from 0x80 to 0xFF,
> with the
> > + * root device and root port assigned to bus 0x80 instead of the
> standard
> > + * 0x00. To allow the PCI subsystem to correctly discover devices on
> the
> > + * root bus, bus 0x80 is remapped to 0x00.
> > + */
> > + if (bus == rc->bus_nr) {
> > + bus = 0;
> > + }
> > +
> > + pdev = pci_find_device(pci->bus, bus, devfn);
> > + if (!pdev) {
> > + s->regs[desc->rdata_reg] = ~0;
> > + goto out;
> > + }
> > +
> > + switch (PCIE_CFG_FMTTYPE_MASK(desc->desc0)) {
> > + case TLP_FMTTYPE_CFGWR0:
> > + case TLP_FMTTYPE_CFGWR1:
> > + byte_en = PCIE_CFG_BYTE_EN(desc->desc1);
> > + val = desc->wdata;
> > + aspeed_pcie_cfg_translate_write(byte_en, &offset, &val, &len);
> > + pci_host_config_write_common(pdev, offset,
> pci_config_size(pdev),
> > + val, len);
> > + break;
> > + case TLP_FMTTYPE_CFGRD0:
> > + case TLP_FMTTYPE_CFGRD1:
> > + val = pci_host_config_read_common(pdev, offset,
> > + pci_config_size(pdev),
> 4);
> > + s->regs[desc->rdata_reg] = val;
> > + break;
> > + default:
> > + qemu_log_mask(LOG_GUEST_ERROR, "%s: invalid CFG type.
> DESC0=0x%x\n",
> > + __func__, desc->desc0);
> > + }
> > +
> > +out:
> > + trace_aspeed_pcie_cfg_rw(s->id, is_write ? "write" : "read", bus,
> devfn,
> > + cfg_addr, val); }
> > +
> > +static void aspeed_pcie_cfg_write(void *opaque, hwaddr addr, uint64_t
> data,
> > + unsigned int size) {
> > + AspeedPCIECfgState *s = ASPEED_PCIE_CFG(opaque);
> > + AspeedPCIECfgTxDesc desc;
> > + uint32_t reg = addr >> 2;
> > + uint32_t rc_reg;
> > +
> > + trace_aspeed_pcie_cfg_write(s->id, addr, data);
> > +
> > + switch (reg) {
> > + case R_H2X_CTRL:
> > + if (data & R_H2X_CTRL_CLEAR_RX_MASK) {
> > + s->regs[R_H2X_RDATA] = ~0;
> > + }
> > + break;
> > + case R_H2X_TX_CLEAR:
> > + if (data & R_H2X_TX_CLEAR_IDLE_MASK) {
> > + s->regs[R_H2X_TX_STS] &= ~R_H2X_TX_STS_IDLE_MASK;
> > + }
> > + break;
> > + case R_H2X_TX_STS:
> > + if (data & R_H2X_TX_STS_TRIG_MASK) {
> > + desc.desc0 = s->regs[R_H2X_TX_DESC0];
> > + desc.desc1 = s->regs[R_H2X_TX_DESC1];
> > + desc.desc2 = s->regs[R_H2X_TX_DESC2];
> > + desc.desc3 = s->regs[R_H2X_TX_DESC3];
> > + desc.wdata = s->regs[R_H2X_TX_DATA];
> > + desc.rdata_reg = R_H2X_RC_H_RDATA;
> > + aspeed_pcie_cfg_readwrite(s, &desc);
> > + rc_reg = s->rc_regs->int_sts_reg;
> > + s->regs[rc_reg] |= H2X_RC_INT_INTDONE_MASK;
> > + s->regs[R_H2X_TX_STS] |=
> > + BIT(R_H2X_TX_STS_RC_H_TX_COMP_SHIFT);
> > + s->regs[R_H2X_TX_STS] |= R_H2X_TX_STS_IDLE_MASK;
> > + }
> > + break;
> > + /* preserve INTx status */
> > + case R_H2X_RC_H_INT_STS:
> > + if (data & H2X_RC_INT_INTDONE_MASK) {
> > + s->regs[R_H2X_TX_STS] &=
> ~R_H2X_TX_STS_RC_H_TX_COMP_MASK;
> > + }
> > + s->regs[reg] &= ~data | H2X_RC_INT_INTX_MASK;
> > + break;
> > + default:
> > + s->regs[reg] = data;
> > + break;
> > + }
> > +}
> > +
> > +static const MemoryRegionOps aspeed_pcie_cfg_ops = {
> > + .read = aspeed_pcie_cfg_read,
> > + .write = aspeed_pcie_cfg_write,
> > + .endianness = DEVICE_LITTLE_ENDIAN,
> > + .valid = {
> > + .min_access_size = 1,
> > + .max_access_size = 4,
> > + },
> > +};
> > +
> > +static void aspeed_pcie_cfg_instance_init(Object *obj) {
> > + AspeedPCIECfgState *s = ASPEED_PCIE_CFG(obj);
> > +
> > + object_initialize_child(obj, "rc", &s->rc, TYPE_ASPEED_PCIE_RC);
> > +
> > + return;
> > +}
> > +
> > +static void aspeed_pcie_cfg_reset(DeviceState *dev) {
> > + AspeedPCIECfgState *s = ASPEED_PCIE_CFG(dev);
> > + AspeedPCIECfgClass *apc = ASPEED_PCIE_CFG_GET_CLASS(s);
> > +
> > + memset(s->regs, 0, apc->nr_regs << 2); }
> > +
> > +static void aspeed_pcie_cfg_realize(DeviceState *dev, Error **errp) {
> > + SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
> > + AspeedPCIECfgState *s = ASPEED_PCIE_CFG(dev);
> > + AspeedPCIECfgClass *apc = ASPEED_PCIE_CFG_GET_CLASS(s);
> > + g_autofree char *name;
>
> name should be assigned.
Will fix it.
>
>
> Thanks,
>
> C.
>
>
>
> > +
> > + s->rc_regs = &apc->reg_map->rc;
> > + s->regs = g_new(uint32_t, apc->nr_regs);
> > + name = g_strdup_printf(TYPE_ASPEED_PCIE_CFG ".regs.%d", s->id);
> > + memory_region_init_io(&s->mmio, OBJECT(s), apc->reg_ops, s, name,
> > + apc->nr_regs << 2);
> > + sysbus_init_mmio(sbd, &s->mmio);
> > +
> > + object_property_set_int(OBJECT(&s->rc), "bus-nr",
> > + apc->rc_bus_nr,
> > + &error_abort);
> > + if (!sysbus_realize(SYS_BUS_DEVICE(&s->rc), errp)) {
> > + return;
> > + }
> > +}
> > +
> > +static void aspeed_pcie_cfg_unrealize(DeviceState *dev) {
> > + AspeedPCIECfgState *s = ASPEED_PCIE_CFG(dev);
> > +
> > + g_free(s->regs);
> > + s->regs = NULL;
> > +}
> > +
> > +static const Property aspeed_pcie_cfg_props[] = {
> > + DEFINE_PROP_UINT32("id", AspeedPCIECfgState, id, 0), };
> > +
> > +static void aspeed_pcie_cfg_class_init(ObjectClass *klass, const void
> > +*data) {
> > + DeviceClass *dc = DEVICE_CLASS(klass);
> > + AspeedPCIECfgClass *apc = ASPEED_PCIE_CFG_CLASS(klass);
> > +
> > + dc->desc = "ASPEED PCIe Config";
> > + dc->realize = aspeed_pcie_cfg_realize;
> > + dc->unrealize = aspeed_pcie_cfg_unrealize;
> > + device_class_set_legacy_reset(dc, aspeed_pcie_cfg_reset);
> > + device_class_set_props(dc, aspeed_pcie_cfg_props);
> > +
> > + apc->reg_ops = &aspeed_pcie_cfg_ops;
> > + apc->reg_map = &aspeed_regmap;
> > + apc->nr_regs = 0x100 >> 2;
> > + apc->rc_bus_nr = 0x80;
> > +}
> > +
> > +static const TypeInfo aspeed_pcie_cfg_info = {
> > + .name = TYPE_ASPEED_PCIE_CFG,
> > + .parent = TYPE_SYS_BUS_DEVICE,
> > + .instance_init = aspeed_pcie_cfg_instance_init,
> > + .instance_size = sizeof(AspeedPCIECfgState),
> > + .class_init = aspeed_pcie_cfg_class_init,
> > + .class_size = sizeof(AspeedPCIECfgClass), };
> > +
> > /*
> > * PCIe PHY
> > *
> > @@ -150,6 +566,8 @@ static const TypeInfo aspeed_pcie_phy_info = {
> >
> > static void aspeed_pcie_register_types(void)
> > {
> > + type_register_static(&aspeed_pcie_rc_info);
> > + type_register_static(&aspeed_pcie_cfg_info);
> > type_register_static(&aspeed_pcie_phy_info);
> > }
> >
> > diff --git a/hw/pci-host/trace-events b/hw/pci-host/trace-events index
> > 3438516756..2584ea56e2 100644
> > --- a/hw/pci-host/trace-events
> > +++ b/hw/pci-host/trace-events
> > @@ -1,6 +1,10 @@
> > # See docs/devel/tracing.rst for syntax documentation.
> >
> > # aspeed_pcie.c
> > +aspeed_pcie_rc_intx_set_irq(uint32_t id, int num, int level) "%d: num %d
> set IRQ leve %d"
> > +aspeed_pcie_cfg_read(uint32_t id, uint64_t addr, uint32_t value) "%d:
> > +addr 0x%" PRIx64 " value 0x%" PRIx32 aspeed_pcie_cfg_write(uint32_t
> > +id, uint64_t addr, uint32_t value) "%d: addr 0x%" PRIx64 " value 0x%"
> > +PRIx32 aspeed_pcie_cfg_rw(uint32_t id, const char *dir, uint8_t bus,
> > +uint8_t devfn, uint64_t addr, uint64_t data) "%d: %s bus:0x%x
> > +devfn:0x%x addr 0x%" PRIx64 " data 0x%" PRIx64
> > aspeed_pcie_phy_read(uint32_t id, uint64_t addr, uint32_t value) "%d:
> addr 0x%" PRIx64 " value 0x%" PRIx32
> > aspeed_pcie_phy_write(uint32_t id, uint64_t addr, uint32_t value)
> > "%d: addr 0x%" PRIx64 " value 0x%" PRIx32
> >
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v3 04/14] hw/pci-host/aspeed: Add AST2600 PCIe Root Device support
2025-09-18 3:13 [PATCH v3 00/14] Support PCIe RC to AST2600 and AST2700 Jamin Lin via
` (2 preceding siblings ...)
2025-09-18 3:13 ` [PATCH v3 03/14] hw/pci-host/aspeed: Add AST2600 PCIe config space and host bridge Jamin Lin via
@ 2025-09-18 3:13 ` Jamin Lin via
2025-09-18 3:13 ` [PATCH v3 05/14] hw/pci-host/aspeed: Add AST2600 PCIe Root Port and make address configurable Jamin Lin via
` (10 subsequent siblings)
14 siblings, 0 replies; 29+ messages in thread
From: Jamin Lin via @ 2025-09-18 3:13 UTC (permalink / raw)
To: Paolo Bonzini, Peter Maydell, Cédric Le Goater, Steven Lee,
Troy Lee, Andrew Jeffery, Joel Stanley, Michael S. Tsirkin,
Marcel Apfelbaum, open list:ARM TCG CPUs,
open list:All patches CC here
Cc: jamin_lin, troy_lee, nabihestefan, wuhaotsh, titusr
Introduce a PCIe Root Device for AST2600 platform.
The AST2600 root complex exposes a PCIe root device at bus 80, devfn 0.
This root device is implemented as a child of the PCIe RC and modeled
as a host bridge PCI function (class_id = PCI_CLASS_BRIDGE_HOST).
Key changes:
- Add a new device type "aspeed.pcie-root-device".
- Instantiate the root device as part of AspeedPCIERcState.
- Initialize it during RC realize() and attach it to the root bus.
- Mark the root device as non-user-creatable.
- Add RC boolean property "has-rd" to control whether the Root Device is
created (platforms can enable/disable it as needed).
Note: Only AST2600 implements this PCIe root device. AST2700 does not
provide one.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
include/hw/pci-host/aspeed_pcie.h | 11 ++++++
hw/pci-host/aspeed_pcie.c | 56 +++++++++++++++++++++++++++++++
2 files changed, 67 insertions(+)
diff --git a/include/hw/pci-host/aspeed_pcie.h b/include/hw/pci-host/aspeed_pcie.h
index 850d579189..fe30ac02ae 100644
--- a/include/hw/pci-host/aspeed_pcie.h
+++ b/include/hw/pci-host/aspeed_pcie.h
@@ -40,6 +40,13 @@ typedef struct AspeedPCIERegMap {
AspeedPCIERcRegs rc;
} AspeedPCIERegMap;
+#define TYPE_ASPEED_PCIE_ROOT_DEVICE "aspeed.pcie-root-device"
+OBJECT_DECLARE_SIMPLE_TYPE(AspeedPCIERootDeviceState, ASPEED_PCIE_ROOT_DEVICE);
+
+struct AspeedPCIERootDeviceState {
+ PCIBridge parent_obj;
+};
+
#define TYPE_ASPEED_PCIE_RC "aspeed.pcie-rc"
OBJECT_DECLARE_SIMPLE_TYPE(AspeedPCIERcState, ASPEED_PCIE_RC);
@@ -53,7 +60,10 @@ struct AspeedPCIERcState {
uint32_t bus_nr;
char name[16];
+ bool has_rd;
qemu_irq irq;
+
+ AspeedPCIERootDeviceState root_device;
};
/* Bridge between AHB bus and PCIe RC. */
@@ -79,6 +89,7 @@ struct AspeedPCIECfgClass {
uint64_t rc_bus_nr;
uint64_t nr_regs;
+ bool rc_has_rd;
};
#define TYPE_ASPEED_PCIE_PHY "aspeed.pcie-phy"
diff --git a/hw/pci-host/aspeed_pcie.c b/hw/pci-host/aspeed_pcie.c
index 08d717381b..aa546cb0e7 100644
--- a/hw/pci-host/aspeed_pcie.c
+++ b/hw/pci-host/aspeed_pcie.c
@@ -25,6 +25,44 @@
#include "hw/pci/msi.h"
#include "trace.h"
+/*
+ * PCIe Root Device
+ * This device exists only on AST2600.
+ */
+
+static void aspeed_pcie_root_device_class_init(ObjectClass *klass,
+ const void *data)
+{
+ PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
+ DeviceClass *dc = DEVICE_CLASS(klass);
+
+ set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
+ dc->desc = "ASPEED PCIe Root Device";
+ k->vendor_id = PCI_VENDOR_ID_ASPEED;
+ k->device_id = 0x2600;
+ k->class_id = PCI_CLASS_BRIDGE_HOST;
+ k->subsystem_vendor_id = k->vendor_id;
+ k->subsystem_id = k->device_id;
+ k->revision = 0;
+
+ /*
+ * PCI-facing part of the host bridge,
+ * not usable without the host-facing part
+ */
+ dc->user_creatable = false;
+}
+
+static const TypeInfo aspeed_pcie_root_device_info = {
+ .name = TYPE_ASPEED_PCIE_ROOT_DEVICE,
+ .parent = TYPE_PCI_DEVICE,
+ .instance_size = sizeof(AspeedPCIERootDeviceState),
+ .class_init = aspeed_pcie_root_device_class_init,
+ .interfaces = (const InterfaceInfo[]) {
+ { INTERFACE_CONVENTIONAL_PCI_DEVICE },
+ { },
+ },
+};
+
/*
* PCIe Root Complex (RC)
*/
@@ -91,6 +129,18 @@ static void aspeed_pcie_rc_realize(DeviceState *dev, Error **errp)
aspeed_pcie_rc_map_irq, rc, &rc->mmio,
&rc->io, 0, 4, TYPE_PCIE_BUS);
pci->bus->flags |= PCI_BUS_EXTENDED_CONFIG_SPACE;
+
+ /* setup root device */
+ if (rc->has_rd) {
+ object_initialize_child(OBJECT(rc), "root_device", &rc->root_device,
+ TYPE_ASPEED_PCIE_ROOT_DEVICE);
+ qdev_prop_set_int32(DEVICE(&rc->root_device), "addr",
+ PCI_DEVFN(0, 0));
+ qdev_prop_set_bit(DEVICE(&rc->root_device), "multifunction", false);
+ if (!qdev_realize(DEVICE(&rc->root_device), BUS(pci->bus), errp)) {
+ return;
+ }
+ }
}
static const char *aspeed_pcie_rc_root_bus_path(PCIHostState *host_bridge,
@@ -107,6 +157,7 @@ static const char *aspeed_pcie_rc_root_bus_path(PCIHostState *host_bridge,
static const Property aspeed_pcie_rc_props[] = {
DEFINE_PROP_UINT32("bus-nr", AspeedPCIERcState, bus_nr, 0),
+ DEFINE_PROP_BOOL("has-rd", AspeedPCIERcState, has_rd, 0),
};
static void aspeed_pcie_rc_class_init(ObjectClass *klass, const void *data)
@@ -398,6 +449,9 @@ static void aspeed_pcie_cfg_realize(DeviceState *dev, Error **errp)
object_property_set_int(OBJECT(&s->rc), "bus-nr",
apc->rc_bus_nr,
&error_abort);
+ object_property_set_bool(OBJECT(&s->rc), "has-rd",
+ apc->rc_has_rd,
+ &error_abort);
if (!sysbus_realize(SYS_BUS_DEVICE(&s->rc), errp)) {
return;
}
@@ -430,6 +484,7 @@ static void aspeed_pcie_cfg_class_init(ObjectClass *klass, const void *data)
apc->reg_map = &aspeed_regmap;
apc->nr_regs = 0x100 >> 2;
apc->rc_bus_nr = 0x80;
+ apc->rc_has_rd = true;
}
static const TypeInfo aspeed_pcie_cfg_info = {
@@ -567,6 +622,7 @@ static const TypeInfo aspeed_pcie_phy_info = {
static void aspeed_pcie_register_types(void)
{
type_register_static(&aspeed_pcie_rc_info);
+ type_register_static(&aspeed_pcie_root_device_info);
type_register_static(&aspeed_pcie_cfg_info);
type_register_static(&aspeed_pcie_phy_info);
}
--
2.43.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* [PATCH v3 05/14] hw/pci-host/aspeed: Add AST2600 PCIe Root Port and make address configurable
2025-09-18 3:13 [PATCH v3 00/14] Support PCIe RC to AST2600 and AST2700 Jamin Lin via
` (3 preceding siblings ...)
2025-09-18 3:13 ` [PATCH v3 04/14] hw/pci-host/aspeed: Add AST2600 PCIe Root Device support Jamin Lin via
@ 2025-09-18 3:13 ` Jamin Lin via
2025-09-18 3:13 ` [PATCH v3 06/14] hw/pci-host/aspeed: Add MSI support and per-RC IOMMU address space Jamin Lin via
` (9 subsequent siblings)
14 siblings, 0 replies; 29+ messages in thread
From: Jamin Lin via @ 2025-09-18 3:13 UTC (permalink / raw)
To: Paolo Bonzini, Peter Maydell, Cédric Le Goater, Steven Lee,
Troy Lee, Andrew Jeffery, Joel Stanley, Michael S. Tsirkin,
Marcel Apfelbaum, open list:ARM TCG CPUs,
open list:All patches CC here
Cc: jamin_lin, troy_lee, nabihestefan, wuhaotsh, titusr
Introduce an ASPEED PCIe Root Port and wire it under the RC. The root port
is modeled as TYPE_ASPEED_PCIE_ROOT_PORT (subclass of TYPE_PCIE_ROOT_PORT).
Key changes:
- Add TYPE_ASPEED_PCIE_ROOT_PORT (PCIESlot-based) with vendor/device IDs
and AER capability offset.
- Extend AspeedPCIERcState to embed a root_port instance and a
configurable rp_addr.
- Add "rp-addr" property to the RC to place the root port at a specific
devfn on the root bus.
- Set the root port's "chassis" property to ensure a unique chassis per RC.
- Extend AspeedPCIECfgClass with rc_rp_addr defaulting to PCI_DEVFN(8,0).
Rationale:
- AST2600 places the root port at 80:08.0 (bus 0x80, dev 8, fn 0).
- AST2700 must place the root port at 00:00.0, and it supports three RCs.
Each root port must therefore be uniquely identifiable; uses the
PCIe "chassis" ID for that.
- Providing a configurable "rp-addr" lets platforms select the correct
devfn per SoC family, while the "chassis" property ensures uniqueness
across multiple RC instances on AST2700.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
include/hw/pci-host/aspeed_pcie.h | 11 +++++++
hw/pci-host/aspeed_pcie.c | 50 +++++++++++++++++++++++++++++++
2 files changed, 61 insertions(+)
diff --git a/include/hw/pci-host/aspeed_pcie.h b/include/hw/pci-host/aspeed_pcie.h
index fe30ac02ae..5346c15c81 100644
--- a/include/hw/pci-host/aspeed_pcie.h
+++ b/include/hw/pci-host/aspeed_pcie.h
@@ -20,6 +20,7 @@
#include "hw/sysbus.h"
#include "hw/pci/pci_bridge.h"
#include "hw/pci/pcie_host.h"
+#include "hw/pci/pcie_port.h"
#include "qom/object.h"
typedef struct AspeedPCIECfgTxDesc {
@@ -40,6 +41,13 @@ typedef struct AspeedPCIERegMap {
AspeedPCIERcRegs rc;
} AspeedPCIERegMap;
+#define TYPE_ASPEED_PCIE_ROOT_PORT "aspeed.pcie-root-port"
+OBJECT_DECLARE_SIMPLE_TYPE(AspeedPCIERootPortState, ASPEED_PCIE_ROOT_PORT)
+
+typedef struct AspeedPCIERootPortState {
+ PCIESlot parent_obj;
+} AspeedPCIERootPortState;
+
#define TYPE_ASPEED_PCIE_ROOT_DEVICE "aspeed.pcie-root-device"
OBJECT_DECLARE_SIMPLE_TYPE(AspeedPCIERootDeviceState, ASPEED_PCIE_ROOT_DEVICE);
@@ -58,12 +66,14 @@ struct AspeedPCIERcState {
MemoryRegion mmio;
MemoryRegion io;
+ uint32_t rp_addr;
uint32_t bus_nr;
char name[16];
bool has_rd;
qemu_irq irq;
AspeedPCIERootDeviceState root_device;
+ AspeedPCIERootPortState root_port;
};
/* Bridge between AHB bus and PCIe RC. */
@@ -87,6 +97,7 @@ struct AspeedPCIECfgClass {
const AspeedPCIERegMap *reg_map;
const MemoryRegionOps *reg_ops;
+ uint32_t rc_rp_addr;
uint64_t rc_bus_nr;
uint64_t nr_regs;
bool rc_has_rd;
diff --git a/hw/pci-host/aspeed_pcie.c b/hw/pci-host/aspeed_pcie.c
index aa546cb0e7..b7a0dca273 100644
--- a/hw/pci-host/aspeed_pcie.c
+++ b/hw/pci-host/aspeed_pcie.c
@@ -21,6 +21,7 @@
#include "hw/registerfields.h"
#include "hw/irq.h"
#include "hw/pci/pci_host.h"
+#include "hw/pci/pcie_port.h"
#include "hw/pci-host/aspeed_pcie.h"
#include "hw/pci/msi.h"
#include "trace.h"
@@ -63,6 +64,32 @@ static const TypeInfo aspeed_pcie_root_device_info = {
},
};
+/*
+ * PCIe Root Port
+ */
+
+static void aspeed_pcie_root_port_class_init(ObjectClass *klass,
+ const void *data)
+{
+ PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
+ DeviceClass *dc = DEVICE_CLASS(klass);
+ PCIERootPortClass *rpc = PCIE_ROOT_PORT_CLASS(klass);
+
+ dc->desc = "ASPEED PCIe Root Port";
+ k->vendor_id = PCI_VENDOR_ID_ASPEED;
+ k->device_id = 0x1150;
+ dc->user_creatable = true;
+
+ rpc->aer_offset = 0x100;
+}
+
+static const TypeInfo aspeed_pcie_root_port_info = {
+ .name = TYPE_ASPEED_PCIE_ROOT_PORT,
+ .parent = TYPE_PCIE_ROOT_PORT,
+ .instance_size = sizeof(AspeedPCIERootPortState),
+ .class_init = aspeed_pcie_root_port_class_init,
+};
+
/*
* PCIe Root Complex (RC)
*/
@@ -141,6 +168,13 @@ static void aspeed_pcie_rc_realize(DeviceState *dev, Error **errp)
return;
}
}
+
+ /* setup root port */
+ qdev_prop_set_int32(DEVICE(&rc->root_port), "addr", rc->rp_addr);
+ qdev_prop_set_uint16(DEVICE(&rc->root_port), "chassis", cfg->id);
+ if (!qdev_realize(DEVICE(&rc->root_port), BUS(pci->bus), errp)) {
+ return;
+ }
}
static const char *aspeed_pcie_rc_root_bus_path(PCIHostState *host_bridge,
@@ -155,9 +189,19 @@ static const char *aspeed_pcie_rc_root_bus_path(PCIHostState *host_bridge,
return rc->name;
}
+static void aspeed_pcie_rc_instance_init(Object *obj)
+{
+ AspeedPCIERcState *rc = ASPEED_PCIE_RC(obj);
+ AspeedPCIERootPortState *root_port = &rc->root_port;
+
+ object_initialize_child(obj, "root_port", root_port,
+ TYPE_ASPEED_PCIE_ROOT_PORT);
+}
+
static const Property aspeed_pcie_rc_props[] = {
DEFINE_PROP_UINT32("bus-nr", AspeedPCIERcState, bus_nr, 0),
DEFINE_PROP_BOOL("has-rd", AspeedPCIERcState, has_rd, 0),
+ DEFINE_PROP_UINT32("rp-addr", AspeedPCIERcState, rp_addr, 0),
};
static void aspeed_pcie_rc_class_init(ObjectClass *klass, const void *data)
@@ -180,6 +224,7 @@ static const TypeInfo aspeed_pcie_rc_info = {
.name = TYPE_ASPEED_PCIE_RC,
.parent = TYPE_PCIE_HOST_BRIDGE,
.instance_size = sizeof(AspeedPCIERcState),
+ .instance_init = aspeed_pcie_rc_instance_init,
.class_init = aspeed_pcie_rc_class_init,
};
@@ -452,6 +497,9 @@ static void aspeed_pcie_cfg_realize(DeviceState *dev, Error **errp)
object_property_set_bool(OBJECT(&s->rc), "has-rd",
apc->rc_has_rd,
&error_abort);
+ object_property_set_int(OBJECT(&s->rc), "rp-addr",
+ apc->rc_rp_addr,
+ &error_abort);
if (!sysbus_realize(SYS_BUS_DEVICE(&s->rc), errp)) {
return;
}
@@ -485,6 +533,7 @@ static void aspeed_pcie_cfg_class_init(ObjectClass *klass, const void *data)
apc->nr_regs = 0x100 >> 2;
apc->rc_bus_nr = 0x80;
apc->rc_has_rd = true;
+ apc->rc_rp_addr = PCI_DEVFN(8, 0);
}
static const TypeInfo aspeed_pcie_cfg_info = {
@@ -623,6 +672,7 @@ static void aspeed_pcie_register_types(void)
{
type_register_static(&aspeed_pcie_rc_info);
type_register_static(&aspeed_pcie_root_device_info);
+ type_register_static(&aspeed_pcie_root_port_info);
type_register_static(&aspeed_pcie_cfg_info);
type_register_static(&aspeed_pcie_phy_info);
}
--
2.43.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* [PATCH v3 06/14] hw/pci-host/aspeed: Add MSI support and per-RC IOMMU address space
2025-09-18 3:13 [PATCH v3 00/14] Support PCIe RC to AST2600 and AST2700 Jamin Lin via
` (4 preceding siblings ...)
2025-09-18 3:13 ` [PATCH v3 05/14] hw/pci-host/aspeed: Add AST2600 PCIe Root Port and make address configurable Jamin Lin via
@ 2025-09-18 3:13 ` Jamin Lin via
2025-09-18 3:13 ` [PATCH v3 07/14] hw/arm/aspeed: Wire up PCIe devices in SoC model Jamin Lin via
` (8 subsequent siblings)
14 siblings, 0 replies; 29+ messages in thread
From: Jamin Lin via @ 2025-09-18 3:13 UTC (permalink / raw)
To: Paolo Bonzini, Peter Maydell, Cédric Le Goater, Steven Lee,
Troy Lee, Andrew Jeffery, Joel Stanley, Michael S. Tsirkin,
Marcel Apfelbaum, open list:ARM TCG CPUs,
open list:All patches CC here
Cc: jamin_lin, troy_lee, nabihestefan, wuhaotsh, titusr
Add MSI support to the ASPEED PCIe RC/Config model and introduce a per-RC
"IOMMU root" address space to correctly route MSI writes.
On AST2700 all RCs use the same MSI address, and the MSI target is PCI
system memory (not normal DRAM). If the MSI window were mapped into real
system RAM, an endpoint's write could be observed by other RCs and
spuriously trigger their interrupts. To avoid this, each RC now owns an
isolated IOMMU root AddressSpace that contains a small MSI window and a
DRAM alias region for normal DMA.
The MSI window captures writes and asserts the RC IRQ. MSI status bits
are tracked in new H2X RC_H registers (R_H2X_RC_H_MSI_EN{0,1} and
R_H2X_RC_H_MSI_STS{0,1}). Clearing all status bits drops the IRQ. The
default MSI address is set to 0x1e77005c and can be overridden via the
msi-addr property.
This keeps MSI traffic contained within each RC while preserving normal
DMA to system DRAM. It enables correct MSI/MSI-X interrupt delivery when
multiple RCs use the same MSI target address.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
include/hw/pci-host/aspeed_pcie.h | 10 +++
hw/pci-host/aspeed_pcie.c | 129 ++++++++++++++++++++++++++++++
hw/pci-host/trace-events | 3 +
3 files changed, 142 insertions(+)
diff --git a/include/hw/pci-host/aspeed_pcie.h b/include/hw/pci-host/aspeed_pcie.h
index 5346c15c81..5e60cba07b 100644
--- a/include/hw/pci-host/aspeed_pcie.h
+++ b/include/hw/pci-host/aspeed_pcie.h
@@ -35,6 +35,8 @@ typedef struct AspeedPCIECfgTxDesc {
typedef struct AspeedPCIERcRegs {
uint32_t int_en_reg;
uint32_t int_sts_reg;
+ uint32_t msi_sts0_reg;
+ uint32_t msi_sts1_reg;
} AspeedPCIERcRegs;
typedef struct AspeedPCIERegMap {
@@ -61,11 +63,18 @@ OBJECT_DECLARE_SIMPLE_TYPE(AspeedPCIERcState, ASPEED_PCIE_RC);
struct AspeedPCIERcState {
PCIExpressHost parent_obj;
+ MemoryRegion iommu_root;
+ AddressSpace iommu_as;
+ MemoryRegion dram_alias;
+ MemoryRegion *dram_mr;
MemoryRegion mmio_window;
+ MemoryRegion msi_window;
MemoryRegion io_window;
MemoryRegion mmio;
MemoryRegion io;
+ uint64_t dram_base;
+ uint32_t msi_addr;
uint32_t rp_addr;
uint32_t bus_nr;
char name[16];
@@ -97,6 +106,7 @@ struct AspeedPCIECfgClass {
const AspeedPCIERegMap *reg_map;
const MemoryRegionOps *reg_ops;
+ uint32_t rc_msi_addr;
uint32_t rc_rp_addr;
uint64_t rc_bus_nr;
uint64_t nr_regs;
diff --git a/hw/pci-host/aspeed_pcie.c b/hw/pci-host/aspeed_pcie.c
index b7a0dca273..bff01ac85a 100644
--- a/hw/pci-host/aspeed_pcie.c
+++ b/hw/pci-host/aspeed_pcie.c
@@ -94,6 +94,8 @@ static const TypeInfo aspeed_pcie_root_port_info = {
* PCIe Root Complex (RC)
*/
+#define ASPEED_PCIE_CFG_RC_MAX_MSI 64
+
static void aspeed_pcie_rc_set_irq(void *opaque, int irq, int level)
{
AspeedPCIERcState *rc = (AspeedPCIERcState *) opaque;
@@ -120,6 +122,58 @@ static int aspeed_pcie_rc_map_irq(PCIDevice *pci_dev, int irq_num)
return irq_num % PCI_NUM_PINS;
}
+static void aspeed_pcie_rc_msi_notify(AspeedPCIERcState *rc, uint64_t data)
+{
+ AspeedPCIECfgState *cfg =
+ container_of(rc, AspeedPCIECfgState, rc);
+ uint32_t reg;
+
+ /* Written data is the HW IRQ number */
+ assert(data < ASPEED_PCIE_CFG_RC_MAX_MSI);
+
+ reg = (data < 32) ?
+ cfg->rc_regs->msi_sts0_reg : cfg->rc_regs->msi_sts1_reg;
+ cfg->regs[reg] |= BIT(data % 32);
+
+ trace_aspeed_pcie_rc_msi_set_irq(cfg->id, data, 1);
+ qemu_set_irq(rc->irq, 1);
+}
+
+static void aspeed_pcie_rc_msi_write(void *opaque, hwaddr addr, uint64_t data,
+ unsigned int size)
+{
+ AspeedPCIERcState *rc = ASPEED_PCIE_RC(opaque);
+ AspeedPCIECfgState *cfg =
+ container_of(rc, AspeedPCIECfgState, rc);
+
+ trace_aspeed_pcie_rc_msi_notify(cfg->id, addr + rc->msi_addr, data);
+ aspeed_pcie_rc_msi_notify(rc, data);
+}
+
+static const MemoryRegionOps aspeed_pcie_rc_msi_ops = {
+ .write = aspeed_pcie_rc_msi_write,
+ .read = NULL,
+ .endianness = DEVICE_LITTLE_ENDIAN,
+ .valid = {
+ .min_access_size = 4,
+ .max_access_size = 4,
+ },
+ .impl = {
+ .min_access_size = 4,
+ .max_access_size = 4,
+ },
+};
+
+static AddressSpace *aspeed_pcie_rc_get_as(PCIBus *bus, void *opaque, int devfn)
+{
+ AspeedPCIERcState *rc = ASPEED_PCIE_RC(opaque);
+ return &rc->iommu_as;
+}
+
+static const PCIIOMMUOps aspeed_pcie_rc_iommu_ops = {
+ .get_address_space = aspeed_pcie_rc_get_as,
+};
+
static void aspeed_pcie_rc_realize(DeviceState *dev, Error **errp)
{
PCIExpressHost *pex = PCIE_HOST_BRIDGE(dev);
@@ -157,6 +211,42 @@ static void aspeed_pcie_rc_realize(DeviceState *dev, Error **errp)
&rc->io, 0, 4, TYPE_PCIE_BUS);
pci->bus->flags |= PCI_BUS_EXTENDED_CONFIG_SPACE;
+ /*
+ * PCIe memory view setup
+ *
+ * Background:
+ * - On AST2700, all Root Complexes use the same MSI address. This MSI
+ * address is not normal system RAM - it is a PCI system memory address.
+ * If we map the MSI/MSI-X window into real system memory, a write from
+ * one EP can be seen by all RCs and wrongly trigger interrupts on them.
+ *
+ * Design:
+ * - MSI/MSI-X here is just a placeholder address so RC and EP can talk.
+ * We make a separate MMIO space (iommu_root) for the MSI window so the
+ * writes stay local to each RC.
+ *
+ * DMA:
+ * - EPs still need access to real system memory for DMA. We add a DRAM
+ * alias in the PCI space so DMA works as expected.
+ */
+ name = g_strdup_printf("pcie.%d.iommu_root", cfg->id);
+ memory_region_init(&rc->iommu_root, OBJECT(rc), name, UINT64_MAX);
+ address_space_init(&rc->iommu_as, &rc->iommu_root, name);
+ /* setup MSI */
+ memory_region_init_io(&rc->msi_window, OBJECT(rc),
+ &aspeed_pcie_rc_msi_ops, rc,
+ "msi_window", 4);
+ memory_region_add_subregion(&rc->iommu_root, rc->msi_addr,
+ &rc->msi_window);
+ /* setup DRAM for DMA */
+ assert(rc->dram_mr != NULL);
+ name = g_strdup_printf("pcie.%d.dram_alias", cfg->id);
+ memory_region_init_alias(&rc->dram_alias, OBJECT(rc), name, rc->dram_mr,
+ 0, memory_region_size(rc->dram_mr));
+ memory_region_add_subregion(&rc->iommu_root, rc->dram_base,
+ &rc->dram_alias);
+ pci_setup_iommu(pci->bus, &aspeed_pcie_rc_iommu_ops, rc);
+
/* setup root device */
if (rc->has_rd) {
object_initialize_child(OBJECT(rc), "root_device", &rc->root_device,
@@ -202,6 +292,10 @@ static const Property aspeed_pcie_rc_props[] = {
DEFINE_PROP_UINT32("bus-nr", AspeedPCIERcState, bus_nr, 0),
DEFINE_PROP_BOOL("has-rd", AspeedPCIERcState, has_rd, 0),
DEFINE_PROP_UINT32("rp-addr", AspeedPCIERcState, rp_addr, 0),
+ DEFINE_PROP_UINT32("msi-addr", AspeedPCIERcState, msi_addr, 0),
+ DEFINE_PROP_UINT64("dram-base", AspeedPCIERcState, dram_base, 0),
+ DEFINE_PROP_LINK("dram", AspeedPCIERcState, dram_mr, TYPE_MEMORY_REGION,
+ MemoryRegion *),
};
static void aspeed_pcie_rc_class_init(ObjectClass *klass, const void *data)
@@ -262,6 +356,10 @@ REG32(H2X_RC_H_INT_STS, 0xC8)
SHARED_FIELD(H2X_RC_INT_INTDONE, 4, 1)
SHARED_FIELD(H2X_RC_INT_INTX, 0, 4)
REG32(H2X_RC_H_RDATA, 0xCC)
+REG32(H2X_RC_H_MSI_EN0, 0xE0)
+REG32(H2X_RC_H_MSI_EN1, 0xE4)
+REG32(H2X_RC_H_MSI_STS0, 0xE8)
+REG32(H2X_RC_H_MSI_STS1, 0xEC)
#define TLP_FMTTYPE_CFGRD0 0x04 /* Configuration Read Type 0 */
#define TLP_FMTTYPE_CFGWR0 0x44 /* Configuration Write Type 0 */
@@ -275,6 +373,8 @@ static const AspeedPCIERegMap aspeed_regmap = {
.rc = {
.int_en_reg = R_H2X_RC_H_INT_EN,
.int_sts_reg = R_H2X_RC_H_INT_STS,
+ .msi_sts0_reg = R_H2X_RC_H_MSI_STS0,
+ .msi_sts1_reg = R_H2X_RC_H_MSI_STS1,
},
};
@@ -444,6 +544,29 @@ static void aspeed_pcie_cfg_write(void *opaque, hwaddr addr, uint64_t data,
}
s->regs[reg] &= ~data | H2X_RC_INT_INTX_MASK;
break;
+ /*
+ * These status registers are used for notify sources ISR are executed.
+ * If one source ISR is executed, it will clear one bit.
+ * If it clear all bits, it means to initialize this register status
+ * rather than sources ISR are executed.
+ */
+ case R_H2X_RC_H_MSI_STS0:
+ case R_H2X_RC_H_MSI_STS1:
+ if (data == 0) {
+ return ;
+ }
+
+ s->regs[reg] &= ~data;
+ if (data == 0xffffffff) {
+ return;
+ }
+
+ if (!s->regs[R_H2X_RC_H_MSI_STS0] &&
+ !s->regs[R_H2X_RC_H_MSI_STS1]) {
+ trace_aspeed_pcie_rc_msi_clear_irq(s->id, 0);
+ qemu_set_irq(s->rc.irq, 0);
+ }
+ break;
default:
s->regs[reg] = data;
break;
@@ -465,6 +588,8 @@ static void aspeed_pcie_cfg_instance_init(Object *obj)
AspeedPCIECfgState *s = ASPEED_PCIE_CFG(obj);
object_initialize_child(obj, "rc", &s->rc, TYPE_ASPEED_PCIE_RC);
+ object_property_add_alias(obj, "dram", OBJECT(&s->rc), "dram");
+ object_property_add_alias(obj, "dram-base", OBJECT(&s->rc), "dram-base");
return;
}
@@ -500,6 +625,9 @@ static void aspeed_pcie_cfg_realize(DeviceState *dev, Error **errp)
object_property_set_int(OBJECT(&s->rc), "rp-addr",
apc->rc_rp_addr,
&error_abort);
+ object_property_set_int(OBJECT(&s->rc), "msi-addr",
+ apc->rc_msi_addr,
+ &error_abort);
if (!sysbus_realize(SYS_BUS_DEVICE(&s->rc), errp)) {
return;
}
@@ -531,6 +659,7 @@ static void aspeed_pcie_cfg_class_init(ObjectClass *klass, const void *data)
apc->reg_ops = &aspeed_pcie_cfg_ops;
apc->reg_map = &aspeed_regmap;
apc->nr_regs = 0x100 >> 2;
+ apc->rc_msi_addr = 0x1e77005C;
apc->rc_bus_nr = 0x80;
apc->rc_has_rd = true;
apc->rc_rp_addr = PCI_DEVFN(8, 0);
diff --git a/hw/pci-host/trace-events b/hw/pci-host/trace-events
index 2584ea56e2..a6fd88c2c4 100644
--- a/hw/pci-host/trace-events
+++ b/hw/pci-host/trace-events
@@ -2,6 +2,9 @@
# aspeed_pcie.c
aspeed_pcie_rc_intx_set_irq(uint32_t id, int num, int level) "%d: num %d set IRQ leve %d"
+aspeed_pcie_rc_msi_notify(uint32_t id, uint64_t addr, uint64_t data) "%d: 0x%" PRIx64 " data 0x%" PRIx64
+aspeed_pcie_rc_msi_set_irq(uint32_t id, uint64_t unm, int level) "%d: num 0x%" PRIx64 " set IRQ level %d"
+aspeed_pcie_rc_msi_clear_irq(uint32_t id, int level) "%d: clear IRQ level %d"
aspeed_pcie_cfg_read(uint32_t id, uint64_t addr, uint32_t value) "%d: addr 0x%" PRIx64 " value 0x%" PRIx32
aspeed_pcie_cfg_write(uint32_t id, uint64_t addr, uint32_t value) "%d: addr 0x%" PRIx64 " value 0x%" PRIx32
aspeed_pcie_cfg_rw(uint32_t id, const char *dir, uint8_t bus, uint8_t devfn, uint64_t addr, uint64_t data) "%d: %s bus:0x%x devfn:0x%x addr 0x%" PRIx64 " data 0x%" PRIx64
--
2.43.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* [PATCH v3 07/14] hw/arm/aspeed: Wire up PCIe devices in SoC model
2025-09-18 3:13 [PATCH v3 00/14] Support PCIe RC to AST2600 and AST2700 Jamin Lin via
` (5 preceding siblings ...)
2025-09-18 3:13 ` [PATCH v3 06/14] hw/pci-host/aspeed: Add MSI support and per-RC IOMMU address space Jamin Lin via
@ 2025-09-18 3:13 ` Jamin Lin via
2025-09-18 3:13 ` [PATCH v3 08/14] hw/arm/aspeed_ast2600: Add PCIe RC support (RC_H only) Jamin Lin via
` (7 subsequent siblings)
14 siblings, 0 replies; 29+ messages in thread
From: Jamin Lin via @ 2025-09-18 3:13 UTC (permalink / raw)
To: Paolo Bonzini, Peter Maydell, Cédric Le Goater, Steven Lee,
Troy Lee, Andrew Jeffery, Joel Stanley, Michael S. Tsirkin,
Marcel Apfelbaum, open list:ARM TCG CPUs,
open list:All patches CC here
Cc: jamin_lin, troy_lee, nabihestefan, wuhaotsh, titusr,
Cédric Le Goater
Add PCIe controller and PHY instances to the Aspeed SoC state and device
enum. This prepares the SoC model to host PCIe Root Complexes and their
associated PHYs.
Although the AST2600 supports only a single Root Complex, the AST2700
provides three Root Complexes. For this reason, the model defines arrays
of three PCIe config/PHY objects and enumerates three PCIe device IDs so
that both SoCs can be represented consistently.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
---
include/hw/arm/aspeed_soc.h | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/include/hw/arm/aspeed_soc.h b/include/hw/arm/aspeed_soc.h
index 217ef0eafd..79fe353f83 100644
--- a/include/hw/arm/aspeed_soc.h
+++ b/include/hw/arm/aspeed_soc.h
@@ -37,6 +37,7 @@
#include "qom/object.h"
#include "hw/misc/aspeed_lpc.h"
#include "hw/misc/unimp.h"
+#include "hw/pci-host/aspeed_pcie.h"
#include "hw/misc/aspeed_peci.h"
#include "hw/fsi/aspeed_apb2opb.h"
#include "hw/char/serial-mm.h"
@@ -49,6 +50,7 @@
#define ASPEED_MACS_NUM 4
#define ASPEED_UARTS_NUM 13
#define ASPEED_JTAG_NUM 2
+#define ASPEED_PCIE_NUM 3
struct AspeedSoCState {
DeviceState parent;
@@ -87,6 +89,8 @@ struct AspeedSoCState {
AspeedSDHCIState sdhci;
AspeedSDHCIState emmc;
AspeedLPCState lpc;
+ AspeedPCIECfgState pcie[ASPEED_PCIE_NUM];
+ AspeedPCIEPhyState pcie_phy[ASPEED_PCIE_NUM];
AspeedPECIState peci;
SerialMM uart[ASPEED_UARTS_NUM];
Clock *sysclk;
@@ -254,6 +258,15 @@ enum {
ASPEED_DEV_LPC,
ASPEED_DEV_IBT,
ASPEED_DEV_I2C,
+ ASPEED_DEV_PCIE0,
+ ASPEED_DEV_PCIE1,
+ ASPEED_DEV_PCIE2,
+ ASPEED_DEV_PCIE_PHY0,
+ ASPEED_DEV_PCIE_PHY1,
+ ASPEED_DEV_PCIE_PHY2,
+ ASPEED_DEV_PCIE_MMIO0,
+ ASPEED_DEV_PCIE_MMIO1,
+ ASPEED_DEV_PCIE_MMIO2,
ASPEED_DEV_PECI,
ASPEED_DEV_ETH1,
ASPEED_DEV_ETH2,
--
2.43.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* [PATCH v3 08/14] hw/arm/aspeed_ast2600: Add PCIe RC support (RC_H only)
2025-09-18 3:13 [PATCH v3 00/14] Support PCIe RC to AST2600 and AST2700 Jamin Lin via
` (6 preceding siblings ...)
2025-09-18 3:13 ` [PATCH v3 07/14] hw/arm/aspeed: Wire up PCIe devices in SoC model Jamin Lin via
@ 2025-09-18 3:13 ` Jamin Lin via
2025-09-18 7:34 ` [SPAM] " Cédric Le Goater
2025-09-18 3:13 ` [PATCH v3 09/14] hw/pci-host/aspeed: Add AST2700 PCIe PHY Jamin Lin via
` (6 subsequent siblings)
14 siblings, 1 reply; 29+ messages in thread
From: Jamin Lin via @ 2025-09-18 3:13 UTC (permalink / raw)
To: Paolo Bonzini, Peter Maydell, Cédric Le Goater, Steven Lee,
Troy Lee, Andrew Jeffery, Joel Stanley, Michael S. Tsirkin,
Marcel Apfelbaum, open list:ARM TCG CPUs,
open list:All patches CC here
Cc: jamin_lin, troy_lee, nabihestefan, wuhaotsh, titusr
Wire up the PCIe Root Complex in the AST2600 SoC model.
According to the AST2600 firmware driver, only the RC_H controller is
supported. RC_H uses PCIe PHY1 at 0x1e6ed200 and the PCIe config (H2X)
register block at 0x1e770000. The RC_H MMIO window is mapped at
0x70000000–0x80000000. RC_L is not modeled. The RC_H interrupt is
wired to IRQ 168. Only RC_H is realized and connected to the SoC
interrupt controller.
The SoC integration initializes PCIe PHY1, instantiates a single RC
instance, wires its MMIO regions, and connects its interrupt. An alias
region is added to map the RC MMIO space into the guest physical address
space.
This provides enough functionality for firmware and guest drivers to
discover and use the AST2600 RC_H Root Complex while leaving RC_L
unimplemented.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
hw/arm/aspeed_ast2600.c | 79 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 79 insertions(+)
diff --git a/hw/arm/aspeed_ast2600.c b/hw/arm/aspeed_ast2600.c
index d12707f0ab..0779e3b8e2 100644
--- a/hw/arm/aspeed_ast2600.c
+++ b/hw/arm/aspeed_ast2600.c
@@ -48,11 +48,13 @@ static const hwaddr aspeed_soc_ast2600_memmap[] = {
[ASPEED_DEV_XDMA] = 0x1E6E7000,
[ASPEED_DEV_ADC] = 0x1E6E9000,
[ASPEED_DEV_DP] = 0x1E6EB000,
+ [ASPEED_DEV_PCIE_PHY1] = 0x1E6ED200,
[ASPEED_DEV_SBC] = 0x1E6F2000,
[ASPEED_DEV_EMMC_BC] = 0x1E6f5000,
[ASPEED_DEV_VIDEO] = 0x1E700000,
[ASPEED_DEV_SDHCI] = 0x1E740000,
[ASPEED_DEV_EMMC] = 0x1E750000,
+ [ASPEED_DEV_PCIE0] = 0x1E770000,
[ASPEED_DEV_GPIO] = 0x1E780000,
[ASPEED_DEV_GPIO_1_8V] = 0x1E780800,
[ASPEED_DEV_RTC] = 0x1E781000,
@@ -79,6 +81,7 @@ static const hwaddr aspeed_soc_ast2600_memmap[] = {
[ASPEED_DEV_FSI1] = 0x1E79B000,
[ASPEED_DEV_FSI2] = 0x1E79B100,
[ASPEED_DEV_I3C] = 0x1E7A0000,
+ [ASPEED_DEV_PCIE_MMIO1] = 0x70000000,
[ASPEED_DEV_SDRAM] = 0x80000000,
};
@@ -127,6 +130,7 @@ static const int aspeed_soc_ast2600_irqmap[] = {
[ASPEED_DEV_LPC] = 35,
[ASPEED_DEV_IBT] = 143,
[ASPEED_DEV_I2C] = 110, /* 110 -> 125 */
+ [ASPEED_DEV_PCIE0] = 168,
[ASPEED_DEV_PECI] = 38,
[ASPEED_DEV_ETH1] = 2,
[ASPEED_DEV_ETH2] = 3,
@@ -191,6 +195,10 @@ static void aspeed_soc_ast2600_init(Object *obj)
snprintf(typename, sizeof(typename), "aspeed.i2c-%s", socname);
object_initialize_child(obj, "i2c", &s->i2c, typename);
+ object_initialize_child(obj, "pcie-cfg", &s->pcie[0], TYPE_ASPEED_PCIE_CFG);
+ object_initialize_child(obj, "pcie-phy[*]", &s->pcie_phy[0],
+ TYPE_ASPEED_PCIE_PHY);
+
object_initialize_child(obj, "peci", &s->peci, TYPE_ASPEED_PECI);
snprintf(typename, sizeof(typename), "aspeed.fmc-%s", socname);
@@ -285,6 +293,72 @@ static uint64_t aspeed_calc_affinity(int cpu)
return (0xf << ARM_AFF1_SHIFT) | cpu;
}
+/*
+ * PCIe Root Complex (RC)
+ *
+ * H2X register space (single block 0x00-0xFF):
+ * 0x00-0x7F : shared by RC_L (PCIe0) and RC_H (PCIe1)
+ * 0x80-0xBF : RC_L only
+ * 0xC0-0xFF : RC_H only
+ *
+ * Model scope / limitations:
+ * - Firmware supports RC_H only; this QEMU model does not support RC_L.
+ * - RC_H uses PHY1 and the MMIO window [0x70000000, 0x80000000]
+ * (aka MMIO1).
+ *
+ * Indexing convention (this model):
+ * - Expose a single logical instance at index 0.
+ * - pcie[0] -> hardware RC_H (PCIe1)
+ * - phy[0] -> hardware PHY1
+ * - mmio.0 -> guest address range MMIO1: 0x70000000-0x80000000
+ * - RC_L / PCIe0 is not created and mapped.
+ */
+static bool aspeed_soc_ast2600_pcie_realize(DeviceState *dev, Error **errp)
+{
+ Aspeed2600SoCState *a = ASPEED2600_SOC(dev);
+ AspeedSoCState *s = ASPEED_SOC(dev);
+ AspeedSoCClass *sc = ASPEED_SOC_GET_CLASS(s);
+ g_autofree char *name = NULL;
+ MemoryRegion *mmio_alias;
+ MemoryRegion *mmio_mr;
+ qemu_irq irq;
+
+ if (!sysbus_realize(SYS_BUS_DEVICE(&s->pcie_phy[0]), errp)) {
+ return false;
+ }
+ aspeed_mmio_map(s, SYS_BUS_DEVICE(&s->pcie_phy[0]), 0,
+ sc->memmap[ASPEED_DEV_PCIE_PHY1]);
+
+ object_property_set_int(OBJECT(&s->pcie[0]), "dram-base",
+ sc->memmap[ASPEED_DEV_SDRAM],
+ &error_abort);
+ object_property_set_link(OBJECT(&s->pcie[0]), "dram", OBJECT(s->dram_mr),
+ &error_abort);
+ if (!sysbus_realize(SYS_BUS_DEVICE(&s->pcie[0]), errp)) {
+ return false;
+ }
+ aspeed_mmio_map(s, SYS_BUS_DEVICE(&s->pcie[0]), 0,
+ sc->memmap[ASPEED_DEV_PCIE0]);
+
+ irq = qdev_get_gpio_in(DEVICE(&a->a7mpcore),
+ sc->irqmap[ASPEED_DEV_PCIE0]);
+ sysbus_connect_irq(SYS_BUS_DEVICE(&s->pcie[0].rc), 0, irq);
+
+ name = g_strdup_printf("aspeed.pcie-mmio.0");
+
+ mmio_alias = g_new0(MemoryRegion, 1);
+ mmio_mr = sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->pcie[0].rc), 1);
+
+ memory_region_init_alias(mmio_alias, OBJECT(&s->pcie[0].rc), name,
+ mmio_mr, sc->memmap[ASPEED_DEV_PCIE_MMIO1],
+ 0x10000000);
+ memory_region_add_subregion(s->memory,
+ sc->memmap[ASPEED_DEV_PCIE_MMIO1],
+ mmio_alias);
+
+ return true;
+}
+
static void aspeed_soc_ast2600_realize(DeviceState *dev, Error **errp)
{
int i;
@@ -438,6 +512,11 @@ static void aspeed_soc_ast2600_realize(DeviceState *dev, Error **errp)
sysbus_connect_irq(SYS_BUS_DEVICE(&s->peci), 0,
aspeed_soc_get_irq(s, ASPEED_DEV_PECI));
+ /* PCIe Root Complex (RC) */
+ if (!aspeed_soc_ast2600_pcie_realize(dev, errp)) {
+ return;
+ }
+
/* FMC, The number of CS is set at the board level */
object_property_set_link(OBJECT(&s->fmc), "dram", OBJECT(s->dram_mr),
&error_abort);
--
2.43.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* Re: [SPAM] [PATCH v3 08/14] hw/arm/aspeed_ast2600: Add PCIe RC support (RC_H only)
2025-09-18 3:13 ` [PATCH v3 08/14] hw/arm/aspeed_ast2600: Add PCIe RC support (RC_H only) Jamin Lin via
@ 2025-09-18 7:34 ` Cédric Le Goater
2025-09-18 9:47 ` Jamin Lin
0 siblings, 1 reply; 29+ messages in thread
From: Cédric Le Goater @ 2025-09-18 7:34 UTC (permalink / raw)
To: Jamin Lin, Paolo Bonzini, Peter Maydell, Steven Lee, Troy Lee,
Andrew Jeffery, Joel Stanley, Michael S. Tsirkin,
Marcel Apfelbaum, open list:ARM TCG CPUs,
open list:All patches CC here
Cc: troy_lee, nabihestefan, wuhaotsh, titusr
On 9/18/25 05:13, Jamin Lin wrote:
> Wire up the PCIe Root Complex in the AST2600 SoC model.
>
> According to the AST2600 firmware driver, only the RC_H controller is
> supported. RC_H uses PCIe PHY1 at 0x1e6ed200 and the PCIe config (H2X)
> register block at 0x1e770000. The RC_H MMIO window is mapped at
> 0x70000000–0x80000000. RC_L is not modeled. The RC_H interrupt is
> wired to IRQ 168. Only RC_H is realized and connected to the SoC
> interrupt controller.
>
> The SoC integration initializes PCIe PHY1, instantiates a single RC
> instance, wires its MMIO regions, and connects its interrupt. An alias
> region is added to map the RC MMIO space into the guest physical address
> space.
>
> This provides enough functionality for firmware and guest drivers to
> discover and use the AST2600 RC_H Root Complex while leaving RC_L
> unimplemented.
>
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> ---
> hw/arm/aspeed_ast2600.c | 79 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 79 insertions(+)
>
> diff --git a/hw/arm/aspeed_ast2600.c b/hw/arm/aspeed_ast2600.c
> index d12707f0ab..0779e3b8e2 100644
> --- a/hw/arm/aspeed_ast2600.c
> +++ b/hw/arm/aspeed_ast2600.c
> @@ -48,11 +48,13 @@ static const hwaddr aspeed_soc_ast2600_memmap[] = {
> [ASPEED_DEV_XDMA] = 0x1E6E7000,
> [ASPEED_DEV_ADC] = 0x1E6E9000,
> [ASPEED_DEV_DP] = 0x1E6EB000,
> + [ASPEED_DEV_PCIE_PHY1] = 0x1E6ED200,
> [ASPEED_DEV_SBC] = 0x1E6F2000,
> [ASPEED_DEV_EMMC_BC] = 0x1E6f5000,
> [ASPEED_DEV_VIDEO] = 0x1E700000,
> [ASPEED_DEV_SDHCI] = 0x1E740000,
> [ASPEED_DEV_EMMC] = 0x1E750000,
> + [ASPEED_DEV_PCIE0] = 0x1E770000,
> [ASPEED_DEV_GPIO] = 0x1E780000,
> [ASPEED_DEV_GPIO_1_8V] = 0x1E780800,
> [ASPEED_DEV_RTC] = 0x1E781000,
> @@ -79,6 +81,7 @@ static const hwaddr aspeed_soc_ast2600_memmap[] = {
> [ASPEED_DEV_FSI1] = 0x1E79B000,
> [ASPEED_DEV_FSI2] = 0x1E79B100,
> [ASPEED_DEV_I3C] = 0x1E7A0000,
> + [ASPEED_DEV_PCIE_MMIO1] = 0x70000000,
> [ASPEED_DEV_SDRAM] = 0x80000000,
> };
>
> @@ -127,6 +130,7 @@ static const int aspeed_soc_ast2600_irqmap[] = {
> [ASPEED_DEV_LPC] = 35,
> [ASPEED_DEV_IBT] = 143,
> [ASPEED_DEV_I2C] = 110, /* 110 -> 125 */
> + [ASPEED_DEV_PCIE0] = 168,
> [ASPEED_DEV_PECI] = 38,
> [ASPEED_DEV_ETH1] = 2,
> [ASPEED_DEV_ETH2] = 3,
> @@ -191,6 +195,10 @@ static void aspeed_soc_ast2600_init(Object *obj)
> snprintf(typename, sizeof(typename), "aspeed.i2c-%s", socname);
> object_initialize_child(obj, "i2c", &s->i2c, typename);
>
> + object_initialize_child(obj, "pcie-cfg", &s->pcie[0], TYPE_ASPEED_PCIE_CFG);
> + object_initialize_child(obj, "pcie-phy[*]", &s->pcie_phy[0],
> + TYPE_ASPEED_PCIE_PHY);
> +
> object_initialize_child(obj, "peci", &s->peci, TYPE_ASPEED_PECI);
>
> snprintf(typename, sizeof(typename), "aspeed.fmc-%s", socname);
> @@ -285,6 +293,72 @@ static uint64_t aspeed_calc_affinity(int cpu)
> return (0xf << ARM_AFF1_SHIFT) | cpu;
> }
>
> +/*
> + * PCIe Root Complex (RC)
> + *
> + * H2X register space (single block 0x00-0xFF):
> + * 0x00-0x7F : shared by RC_L (PCIe0) and RC_H (PCIe1)
> + * 0x80-0xBF : RC_L only
> + * 0xC0-0xFF : RC_H only
> + *
> + * Model scope / limitations:
> + * - Firmware supports RC_H only; this QEMU model does not support RC_L.
> + * - RC_H uses PHY1 and the MMIO window [0x70000000, 0x80000000]
> + * (aka MMIO1).
> + *
> + * Indexing convention (this model):
> + * - Expose a single logical instance at index 0.
> + * - pcie[0] -> hardware RC_H (PCIe1)
> + * - phy[0] -> hardware PHY1
> + * - mmio.0 -> guest address range MMIO1: 0x70000000-0x80000000
> + * - RC_L / PCIe0 is not created and mapped.
> + */
> +static bool aspeed_soc_ast2600_pcie_realize(DeviceState *dev, Error **errp)
> +{
> + Aspeed2600SoCState *a = ASPEED2600_SOC(dev);
> + AspeedSoCState *s = ASPEED_SOC(dev);
> + AspeedSoCClass *sc = ASPEED_SOC_GET_CLASS(s);
> + g_autofree char *name = NULL;
> + MemoryRegion *mmio_alias;
> + MemoryRegion *mmio_mr;
> + qemu_irq irq;
> +
> + if (!sysbus_realize(SYS_BUS_DEVICE(&s->pcie_phy[0]), errp)) {
> + return false;
> + }
> + aspeed_mmio_map(s, SYS_BUS_DEVICE(&s->pcie_phy[0]), 0,
> + sc->memmap[ASPEED_DEV_PCIE_PHY1]);
> +
> + object_property_set_int(OBJECT(&s->pcie[0]), "dram-base",
> + sc->memmap[ASPEED_DEV_SDRAM],
> + &error_abort);
> + object_property_set_link(OBJECT(&s->pcie[0]), "dram", OBJECT(s->dram_mr),
> + &error_abort);
> + if (!sysbus_realize(SYS_BUS_DEVICE(&s->pcie[0]), errp)) {
> + return false;
> + }
> + aspeed_mmio_map(s, SYS_BUS_DEVICE(&s->pcie[0]), 0,
> + sc->memmap[ASPEED_DEV_PCIE0]);
> +
> + irq = qdev_get_gpio_in(DEVICE(&a->a7mpcore),
> + sc->irqmap[ASPEED_DEV_PCIE0]);
> + sysbus_connect_irq(SYS_BUS_DEVICE(&s->pcie[0].rc), 0, irq);
> +
> + name = g_strdup_printf("aspeed.pcie-mmio.0");
Please drop the name variable.
> +
> + mmio_alias = g_new0(MemoryRegion, 1);
Why not add the alias to AspeedSoCState and avoid the allocation ?
Thanks,
C.
> + mmio_mr = sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->pcie[0].rc), 1);
> +
> + memory_region_init_alias(mmio_alias, OBJECT(&s->pcie[0].rc), name,
> + mmio_mr, sc->memmap[ASPEED_DEV_PCIE_MMIO1],
> + 0x10000000);
> + memory_region_add_subregion(s->memory,
> + sc->memmap[ASPEED_DEV_PCIE_MMIO1],
> + mmio_alias);
> +
> + return true;
> +}
> +
> static void aspeed_soc_ast2600_realize(DeviceState *dev, Error **errp)
> {
> int i;
> @@ -438,6 +512,11 @@ static void aspeed_soc_ast2600_realize(DeviceState *dev, Error **errp)
> sysbus_connect_irq(SYS_BUS_DEVICE(&s->peci), 0,
> aspeed_soc_get_irq(s, ASPEED_DEV_PECI));
>
> + /* PCIe Root Complex (RC) */
> + if (!aspeed_soc_ast2600_pcie_realize(dev, errp)) {
> + return;
> + }
> +
> /* FMC, The number of CS is set at the board level */
> object_property_set_link(OBJECT(&s->fmc), "dram", OBJECT(s->dram_mr),
> &error_abort);
^ permalink raw reply [flat|nested] 29+ messages in thread* RE: [SPAM] [PATCH v3 08/14] hw/arm/aspeed_ast2600: Add PCIe RC support (RC_H only)
2025-09-18 7:34 ` [SPAM] " Cédric Le Goater
@ 2025-09-18 9:47 ` Jamin Lin
0 siblings, 0 replies; 29+ messages in thread
From: Jamin Lin @ 2025-09-18 9:47 UTC (permalink / raw)
To: Cédric Le Goater, Paolo Bonzini, Peter Maydell, Steven Lee,
Troy Lee, Andrew Jeffery, Joel Stanley, Michael S. Tsirkin,
Marcel Apfelbaum, open list:ARM TCG CPUs,
open list:All patches CC here
Cc: Troy Lee, nabihestefan@google.com, wuhaotsh@google.com,
titusr@google.com
Hi Cédric
> Subject: Re: [SPAM] [PATCH v3 08/14] hw/arm/aspeed_ast2600: Add PCIe RC
> support (RC_H only)
>
> On 9/18/25 05:13, Jamin Lin wrote:
> > Wire up the PCIe Root Complex in the AST2600 SoC model.
> >
> > According to the AST2600 firmware driver, only the RC_H controller is
> > supported. RC_H uses PCIe PHY1 at 0x1e6ed200 and the PCIe config (H2X)
> > register block at 0x1e770000. The RC_H MMIO window is mapped at
> > 0x70000000–0x80000000. RC_L is not modeled. The RC_H interrupt is
> > wired to IRQ 168. Only RC_H is realized and connected to the SoC
> > interrupt controller.
> >
> > The SoC integration initializes PCIe PHY1, instantiates a single RC
> > instance, wires its MMIO regions, and connects its interrupt. An alias
> > region is added to map the RC MMIO space into the guest physical
> > address space.
> >
> > This provides enough functionality for firmware and guest drivers to
> > discover and use the AST2600 RC_H Root Complex while leaving RC_L
> > unimplemented.
> >
> > Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> > ---
> > hw/arm/aspeed_ast2600.c | 79
> +++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 79 insertions(+)
> >
> > diff --git a/hw/arm/aspeed_ast2600.c b/hw/arm/aspeed_ast2600.c index
> > d12707f0ab..0779e3b8e2 100644
> > --- a/hw/arm/aspeed_ast2600.c
> > +++ b/hw/arm/aspeed_ast2600.c
> > @@ -48,11 +48,13 @@ static const hwaddr aspeed_soc_ast2600_memmap[]
> = {
> > [ASPEED_DEV_XDMA] = 0x1E6E7000,
> > [ASPEED_DEV_ADC] = 0x1E6E9000,
> > [ASPEED_DEV_DP] = 0x1E6EB000,
> > + [ASPEED_DEV_PCIE_PHY1] = 0x1E6ED200,
> > [ASPEED_DEV_SBC] = 0x1E6F2000,
> > [ASPEED_DEV_EMMC_BC] = 0x1E6f5000,
> > [ASPEED_DEV_VIDEO] = 0x1E700000,
> > [ASPEED_DEV_SDHCI] = 0x1E740000,
> > [ASPEED_DEV_EMMC] = 0x1E750000,
> > + [ASPEED_DEV_PCIE0] = 0x1E770000,
> > [ASPEED_DEV_GPIO] = 0x1E780000,
> > [ASPEED_DEV_GPIO_1_8V] = 0x1E780800,
> > [ASPEED_DEV_RTC] = 0x1E781000,
> > @@ -79,6 +81,7 @@ static const hwaddr aspeed_soc_ast2600_memmap[] =
> {
> > [ASPEED_DEV_FSI1] = 0x1E79B000,
> > [ASPEED_DEV_FSI2] = 0x1E79B100,
> > [ASPEED_DEV_I3C] = 0x1E7A0000,
> > + [ASPEED_DEV_PCIE_MMIO1] = 0x70000000,
> > [ASPEED_DEV_SDRAM] = 0x80000000,
> > };
> >
> > @@ -127,6 +130,7 @@ static const int aspeed_soc_ast2600_irqmap[] = {
> > [ASPEED_DEV_LPC] = 35,
> > [ASPEED_DEV_IBT] = 143,
> > [ASPEED_DEV_I2C] = 110, /* 110 -> 125 */
> > + [ASPEED_DEV_PCIE0] = 168,
> > [ASPEED_DEV_PECI] = 38,
> > [ASPEED_DEV_ETH1] = 2,
> > [ASPEED_DEV_ETH2] = 3,
> > @@ -191,6 +195,10 @@ static void aspeed_soc_ast2600_init(Object *obj)
> > snprintf(typename, sizeof(typename), "aspeed.i2c-%s", socname);
> > object_initialize_child(obj, "i2c", &s->i2c, typename);
> >
> > + object_initialize_child(obj, "pcie-cfg", &s->pcie[0],
> TYPE_ASPEED_PCIE_CFG);
> > + object_initialize_child(obj, "pcie-phy[*]", &s->pcie_phy[0],
> > + TYPE_ASPEED_PCIE_PHY);
> > +
> > object_initialize_child(obj, "peci", &s->peci,
> > TYPE_ASPEED_PECI);
> >
> > snprintf(typename, sizeof(typename), "aspeed.fmc-%s", socname);
> > @@ -285,6 +293,72 @@ static uint64_t aspeed_calc_affinity(int cpu)
> > return (0xf << ARM_AFF1_SHIFT) | cpu;
> > }
> >
> > +/*
> > + * PCIe Root Complex (RC)
> > + *
> > + * H2X register space (single block 0x00-0xFF):
> > + * 0x00-0x7F : shared by RC_L (PCIe0) and RC_H (PCIe1)
> > + * 0x80-0xBF : RC_L only
> > + * 0xC0-0xFF : RC_H only
> > + *
> > + * Model scope / limitations:
> > + * - Firmware supports RC_H only; this QEMU model does not support
> RC_L.
> > + * - RC_H uses PHY1 and the MMIO window [0x70000000, 0x80000000]
> > + * (aka MMIO1).
> > + *
> > + * Indexing convention (this model):
> > + * - Expose a single logical instance at index 0.
> > + * - pcie[0] -> hardware RC_H (PCIe1)
> > + * - phy[0] -> hardware PHY1
> > + * - mmio.0 -> guest address range MMIO1: 0x70000000-0x80000000
> > + * - RC_L / PCIe0 is not created and mapped.
> > + */
> > +static bool aspeed_soc_ast2600_pcie_realize(DeviceState *dev, Error
> > +**errp) {
> > + Aspeed2600SoCState *a = ASPEED2600_SOC(dev);
> > + AspeedSoCState *s = ASPEED_SOC(dev);
> > + AspeedSoCClass *sc = ASPEED_SOC_GET_CLASS(s);
> > + g_autofree char *name = NULL;
> > + MemoryRegion *mmio_alias;
> > + MemoryRegion *mmio_mr;
> > + qemu_irq irq;
> > +
> > + if (!sysbus_realize(SYS_BUS_DEVICE(&s->pcie_phy[0]), errp)) {
> > + return false;
> > + }
> > + aspeed_mmio_map(s, SYS_BUS_DEVICE(&s->pcie_phy[0]), 0,
> > + sc->memmap[ASPEED_DEV_PCIE_PHY1]);
> > +
> > + object_property_set_int(OBJECT(&s->pcie[0]), "dram-base",
> > + sc->memmap[ASPEED_DEV_SDRAM],
> > + &error_abort);
> > + object_property_set_link(OBJECT(&s->pcie[0]), "dram",
> OBJECT(s->dram_mr),
> > + &error_abort);
> > + if (!sysbus_realize(SYS_BUS_DEVICE(&s->pcie[0]), errp)) {
> > + return false;
> > + }
> > + aspeed_mmio_map(s, SYS_BUS_DEVICE(&s->pcie[0]), 0,
> > + sc->memmap[ASPEED_DEV_PCIE0]);
> > +
> > + irq = qdev_get_gpio_in(DEVICE(&a->a7mpcore),
> > + sc->irqmap[ASPEED_DEV_PCIE0]);
> > + sysbus_connect_irq(SYS_BUS_DEVICE(&s->pcie[0].rc), 0, irq);
> > +
> > + name = g_strdup_printf("aspeed.pcie-mmio.0");
>
> Please drop the name variable.
>
Thanks for the your review and suggestion.
Will do.
> > +
> > + mmio_alias = g_new0(MemoryRegion, 1);
>
> Why not add the alias to AspeedSoCState and avoid the allocation ?
Will do.
Jamin
>
>
> Thanks,
>
> C.
>
>
>
> > + mmio_mr =
> sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->pcie[0].rc),
> > + 1);
> > +
> > + memory_region_init_alias(mmio_alias, OBJECT(&s->pcie[0].rc), name,
> > + mmio_mr,
> sc->memmap[ASPEED_DEV_PCIE_MMIO1],
> > + 0x10000000);
> > + memory_region_add_subregion(s->memory,
> > +
> sc->memmap[ASPEED_DEV_PCIE_MMIO1],
> > + mmio_alias);
> > +
> > + return true;
> > +}
> > +
> > static void aspeed_soc_ast2600_realize(DeviceState *dev, Error **errp)
> > {
> > int i;
> > @@ -438,6 +512,11 @@ static void
> aspeed_soc_ast2600_realize(DeviceState *dev, Error **errp)
> > sysbus_connect_irq(SYS_BUS_DEVICE(&s->peci), 0,
> > aspeed_soc_get_irq(s, ASPEED_DEV_PECI));
> >
> > + /* PCIe Root Complex (RC) */
> > + if (!aspeed_soc_ast2600_pcie_realize(dev, errp)) {
> > + return;
> > + }
> > +
> > /* FMC, The number of CS is set at the board level */
> > object_property_set_link(OBJECT(&s->fmc), "dram",
> OBJECT(s->dram_mr),
> > &error_abort);
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v3 09/14] hw/pci-host/aspeed: Add AST2700 PCIe PHY
2025-09-18 3:13 [PATCH v3 00/14] Support PCIe RC to AST2600 and AST2700 Jamin Lin via
` (7 preceding siblings ...)
2025-09-18 3:13 ` [PATCH v3 08/14] hw/arm/aspeed_ast2600: Add PCIe RC support (RC_H only) Jamin Lin via
@ 2025-09-18 3:13 ` Jamin Lin via
2025-09-18 3:13 ` [PATCH v3 10/14] hw/pci-host/aspeed: Add AST2700 PCIe config with dedicated H2X blocks Jamin Lin via
` (5 subsequent siblings)
14 siblings, 0 replies; 29+ messages in thread
From: Jamin Lin via @ 2025-09-18 3:13 UTC (permalink / raw)
To: Paolo Bonzini, Peter Maydell, Cédric Le Goater, Steven Lee,
Troy Lee, Andrew Jeffery, Joel Stanley, Michael S. Tsirkin,
Marcel Apfelbaum, open list:ARM TCG CPUs,
open list:All patches CC here
Cc: jamin_lin, troy_lee, nabihestefan, wuhaotsh, titusr
Introduce a PCIe Host Controller PHY model for AST2700. This adds an
AST2700 specific PHY type (TYPE_ASPEED_2700_PCIE_PHY) with a 0x800 byte
register space and link-status bits compatible with the firmware’s
expectations.
AST2700 provides three PCIe RCs; PCIe0 and PCIe1 are GEN4, PCIe2 is
GEN2. The PHY exposes:
PEHR_2700_LINK_GEN2 at 0x344, bit 18 indicates GEN2 link up
PEHR_2700_LINK_GEN4 at 0x358, bit 8 indicates GEN4 link up
In real hardware these GEN2/GEN4 link bits are mutually exclusive.
QEMU does not model GEN2 vs GEN4 signaling differences, so the reset
handler sets both bits to 1. This keeps the model simple and lets
firmware see the link as up; firmware will read the appropriate
register per RC port to infer the intended mode.
The header gains TYPE_ASPEED_2700_PCIE_PHY; the new class derives from
TYPE_ASPEED_PCIE_PHY, sets nr_regs to 0x800 >> 2, and installs an
AST2700 reset routine that programs the class code (0x06040011) and the
GEN2/GEN4 status bits.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
include/hw/pci-host/aspeed_pcie.h | 1 +
hw/pci-host/aspeed_pcie.c | 39 +++++++++++++++++++++++++++++++
2 files changed, 40 insertions(+)
diff --git a/include/hw/pci-host/aspeed_pcie.h b/include/hw/pci-host/aspeed_pcie.h
index 5e60cba07b..5806505f30 100644
--- a/include/hw/pci-host/aspeed_pcie.h
+++ b/include/hw/pci-host/aspeed_pcie.h
@@ -114,6 +114,7 @@ struct AspeedPCIECfgClass {
};
#define TYPE_ASPEED_PCIE_PHY "aspeed.pcie-phy"
+#define TYPE_ASPEED_2700_PCIE_PHY TYPE_ASPEED_PCIE_PHY "-ast2700"
OBJECT_DECLARE_TYPE(AspeedPCIEPhyState, AspeedPCIEPhyClass, ASPEED_PCIE_PHY);
struct AspeedPCIEPhyState {
diff --git a/hw/pci-host/aspeed_pcie.c b/hw/pci-host/aspeed_pcie.c
index bff01ac85a..266fe6e7b0 100644
--- a/hw/pci-host/aspeed_pcie.c
+++ b/hw/pci-host/aspeed_pcie.c
@@ -690,6 +690,12 @@ REG32(PEHR_PROTECT, 0x7C)
REG32(PEHR_LINK, 0xC0)
FIELD(PEHR_LINK, STS, 5, 1)
+/* AST2700 */
+REG32(PEHR_2700_LINK_GEN2, 0x344)
+ FIELD(PEHR_2700_LINK_GEN2, STS, 18, 1)
+REG32(PEHR_2700_LINK_GEN4, 0x358)
+ FIELD(PEHR_2700_LINK_GEN4, STS, 8, 1)
+
#define ASPEED_PCIE_PHY_UNLOCK 0xA8
static uint64_t aspeed_pcie_phy_read(void *opaque, hwaddr addr,
@@ -797,6 +803,38 @@ static const TypeInfo aspeed_pcie_phy_info = {
.class_size = sizeof(AspeedPCIEPhyClass),
};
+static void aspeed_2700_pcie_phy_reset(DeviceState *dev)
+{
+ AspeedPCIEPhyState *s = ASPEED_PCIE_PHY(dev);
+ AspeedPCIEPhyClass *apc = ASPEED_PCIE_PHY_GET_CLASS(s);
+
+ memset(s->regs, 0, apc->nr_regs << 2);
+
+ s->regs[R_PEHR_ID] =
+ (0x1150 << R_PEHR_ID_DEV_SHIFT) | PCI_VENDOR_ID_ASPEED;
+ s->regs[R_PEHR_CLASS_CODE] = 0x06040011;
+ s->regs[R_PEHR_2700_LINK_GEN2] = R_PEHR_2700_LINK_GEN2_STS_MASK;
+ s->regs[R_PEHR_2700_LINK_GEN4] = R_PEHR_2700_LINK_GEN4_STS_MASK;
+}
+
+static void aspeed_2700_pcie_phy_class_init(ObjectClass *klass,
+ const void *data)
+{
+ DeviceClass *dc = DEVICE_CLASS(klass);
+ AspeedPCIEPhyClass *apc = ASPEED_PCIE_PHY_CLASS(klass);
+
+ dc->desc = "ASPEED AST2700 PCIe Phy";
+ device_class_set_legacy_reset(dc, aspeed_2700_pcie_phy_reset);
+
+ apc->nr_regs = 0x800 >> 2;
+}
+
+static const TypeInfo aspeed_2700_pcie_phy_info = {
+ .name = TYPE_ASPEED_2700_PCIE_PHY,
+ .parent = TYPE_ASPEED_PCIE_PHY,
+ .class_init = aspeed_2700_pcie_phy_class_init,
+};
+
static void aspeed_pcie_register_types(void)
{
type_register_static(&aspeed_pcie_rc_info);
@@ -804,6 +842,7 @@ static void aspeed_pcie_register_types(void)
type_register_static(&aspeed_pcie_root_port_info);
type_register_static(&aspeed_pcie_cfg_info);
type_register_static(&aspeed_pcie_phy_info);
+ type_register_static(&aspeed_2700_pcie_phy_info);
}
type_init(aspeed_pcie_register_types);
--
2.43.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* [PATCH v3 10/14] hw/pci-host/aspeed: Add AST2700 PCIe config with dedicated H2X blocks
2025-09-18 3:13 [PATCH v3 00/14] Support PCIe RC to AST2600 and AST2700 Jamin Lin via
` (8 preceding siblings ...)
2025-09-18 3:13 ` [PATCH v3 09/14] hw/pci-host/aspeed: Add AST2700 PCIe PHY Jamin Lin via
@ 2025-09-18 3:13 ` Jamin Lin via
2025-09-18 3:13 ` [PATCH v3 11/14] hw/pci-host/aspeed: Disable Root Device and place Root Port at 00:00.0 to AST2700 Jamin Lin via
` (4 subsequent siblings)
14 siblings, 0 replies; 29+ messages in thread
From: Jamin Lin via @ 2025-09-18 3:13 UTC (permalink / raw)
To: Paolo Bonzini, Peter Maydell, Cédric Le Goater, Steven Lee,
Troy Lee, Andrew Jeffery, Joel Stanley, Michael S. Tsirkin,
Marcel Apfelbaum, open list:ARM TCG CPUs,
open list:All patches CC here
Cc: jamin_lin, troy_lee, nabihestefan, wuhaotsh, titusr
Introduce PCIe config (H2X) support for the AST2700 SoC.
Unlike the AST2600, the AST2700 provides three independent Root Complexes,
each with its own H2X (AHB to PCIe bridge) register block of size 0x100.
All RCs use the same MSI address (0x000000F0). The H2X block includes
two different access paths:
1. CFGI (internal bridge): used to access the host bridge itself, always
with BDF=0. The AST2700 controller simplifies the design by exposing
only one register (H2X_CFGI_TLP) with fields for ADDR[15:0], BEN[19:16],
and WR[20]. This is not a full TLP descriptor as in the external case.
For QEMU readability and code reuse, the model converts H2X_CFGI_TLP
into a standard TLP TX descriptor with BDF forced to 0 and then calls
the existing helpers aspeed_pcie_cfg_readwrite() and
aspeed_pcie_cfg_translate_write().
2. CFGE (external EP access): used to access external endpoints. The
AST2700 design provides H2X_CFGE_TLP1 and a small FIFO at H2X_CFGE_TLPN.
For reads, TX DESC0 is stored in TLP1 and DESC1/DESC2 in TLPN FIFO
slots. For writes, TX DESC0 is stored in TLP1, DESC1/DESC2 in TLPN
FIFO[0..1], and TX write data in TLPN FIFO[2].
The implementation extends AspeedPCIECfgState with a small FIFO and index,
wires up new register definitions for AST2700, and adds a specific ops
table and class (TYPE_ASPEED_2700_PCIE_CFG). The reset handler clears the
FIFO state. Interrupt and MSI status registers are also supported.
This provides enough modeling for firmware and drivers to use any of the
three PCIe RCs on AST2700 with their own dedicated H2X config window,
while reusing existing TLP decode helpers in QEMU.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
include/hw/pci-host/aspeed_pcie.h | 3 +
hw/pci-host/aspeed_pcie.c | 158 ++++++++++++++++++++++++++++++
2 files changed, 161 insertions(+)
diff --git a/include/hw/pci-host/aspeed_pcie.h b/include/hw/pci-host/aspeed_pcie.h
index 5806505f30..be53ea96b9 100644
--- a/include/hw/pci-host/aspeed_pcie.h
+++ b/include/hw/pci-host/aspeed_pcie.h
@@ -87,6 +87,7 @@ struct AspeedPCIERcState {
/* Bridge between AHB bus and PCIe RC. */
#define TYPE_ASPEED_PCIE_CFG "aspeed.pcie-cfg"
+#define TYPE_ASPEED_2700_PCIE_CFG TYPE_ASPEED_PCIE_CFG "-ast2700"
OBJECT_DECLARE_TYPE(AspeedPCIECfgState, AspeedPCIECfgClass, ASPEED_PCIE_CFG);
struct AspeedPCIECfgState {
@@ -98,6 +99,8 @@ struct AspeedPCIECfgState {
const AspeedPCIERcRegs *rc_regs;
AspeedPCIERcState rc;
+ uint32_t tlpn_fifo[3];
+ uint32_t tlpn_idx;
};
struct AspeedPCIECfgClass {
diff --git a/hw/pci-host/aspeed_pcie.c b/hw/pci-host/aspeed_pcie.c
index 266fe6e7b0..b7ae47f9b2 100644
--- a/hw/pci-host/aspeed_pcie.c
+++ b/hw/pci-host/aspeed_pcie.c
@@ -332,6 +332,11 @@ static const TypeInfo aspeed_pcie_rc_info = {
* - Registers 0x00 - 0x7F are shared by both PCIe0 (rc_l) and PCIe1 (rc_h).
* - Registers 0x80 - 0xBF are specific to PCIe0.
* - Registers 0xC0 - 0xFF are specific to PCIe1.
+ *
+ * On the AST2700:
+ * - The register range 0x00 - 0xFF is assigned to a single PCIe configuration.
+ * - There are three PCIe Root Complexes (RCs), each with its own dedicated H2X
+ * register set of size 0x100 (covering offsets 0x00 to 0xFF).
*/
/* AST2600 */
@@ -361,6 +366,31 @@ REG32(H2X_RC_H_MSI_EN1, 0xE4)
REG32(H2X_RC_H_MSI_STS0, 0xE8)
REG32(H2X_RC_H_MSI_STS1, 0xEC)
+/* AST2700 */
+REG32(H2X_CFGE_INT_STS, 0x08)
+ FIELD(H2X_CFGE_INT_STS, TX_IDEL, 0, 1)
+ FIELD(H2X_CFGE_INT_STS, RX_BUSY, 1, 1)
+REG32(H2X_CFGI_TLP, 0x20)
+ FIELD(H2X_CFGI_TLP, ADDR, 0, 16)
+ FIELD(H2X_CFGI_TLP, BEN, 16, 4)
+ FIELD(H2X_CFGI_TLP, WR, 20, 1)
+REG32(H2X_CFGI_WDATA, 0x24)
+REG32(H2X_CFGI_CTRL, 0x28)
+ FIELD(H2X_CFGI_CTRL, FIRE, 0, 1)
+REG32(H2X_CFGI_RDATA, 0x2C)
+REG32(H2X_CFGE_TLP1, 0x30)
+REG32(H2X_CFGE_TLPN, 0x34)
+REG32(H2X_CFGE_CTRL, 0x38)
+ FIELD(H2X_CFGE_CTRL, FIRE, 0, 1)
+REG32(H2X_CFGE_RDATA, 0x3C)
+REG32(H2X_INT_EN, 0x40)
+REG32(H2X_INT_STS, 0x48)
+ FIELD(H2X_INT_STS, INTX, 0, 4)
+REG32(H2X_MSI_EN0, 0x50)
+REG32(H2X_MSI_EN1, 0x54)
+REG32(H2X_MSI_STS0, 0x58)
+REG32(H2X_MSI_STS1, 0x5C)
+
#define TLP_FMTTYPE_CFGRD0 0x04 /* Configuration Read Type 0 */
#define TLP_FMTTYPE_CFGWR0 0x44 /* Configuration Write Type 0 */
#define TLP_FMTTYPE_CFGRD1 0x05 /* Configuration Read Type 1 */
@@ -378,6 +408,15 @@ static const AspeedPCIERegMap aspeed_regmap = {
},
};
+static const AspeedPCIERegMap aspeed_2700_regmap = {
+ .rc = {
+ .int_en_reg = R_H2X_INT_EN,
+ .int_sts_reg = R_H2X_INT_STS,
+ .msi_sts0_reg = R_H2X_MSI_STS0,
+ .msi_sts1_reg = R_H2X_MSI_STS1,
+ },
+};
+
static uint64_t aspeed_pcie_cfg_read(void *opaque, hwaddr addr,
unsigned int size)
{
@@ -600,6 +639,8 @@ static void aspeed_pcie_cfg_reset(DeviceState *dev)
AspeedPCIECfgClass *apc = ASPEED_PCIE_CFG_GET_CLASS(s);
memset(s->regs, 0, apc->nr_regs << 2);
+ memset(s->tlpn_fifo, 0, sizeof(s->tlpn_fifo));
+ s->tlpn_idx = 0;
}
static void aspeed_pcie_cfg_realize(DeviceState *dev, Error **errp)
@@ -674,6 +715,122 @@ static const TypeInfo aspeed_pcie_cfg_info = {
.class_size = sizeof(AspeedPCIECfgClass),
};
+static void aspeed_2700_pcie_cfg_write(void *opaque, hwaddr addr,
+ uint64_t data, unsigned int size)
+{
+ AspeedPCIECfgState *s = ASPEED_PCIE_CFG(opaque);
+ AspeedPCIECfgTxDesc desc;
+ uint32_t reg = addr >> 2;
+
+ trace_aspeed_pcie_cfg_write(s->id, addr, data);
+
+ switch (reg) {
+ case R_H2X_CFGE_INT_STS:
+ if (data & R_H2X_CFGE_INT_STS_TX_IDEL_MASK) {
+ s->regs[R_H2X_CFGE_INT_STS] &= ~R_H2X_CFGE_INT_STS_TX_IDEL_MASK;
+ }
+
+ if (data & R_H2X_CFGE_INT_STS_RX_BUSY_MASK) {
+ s->regs[R_H2X_CFGE_INT_STS] &= ~R_H2X_CFGE_INT_STS_RX_BUSY_MASK;
+ }
+ break;
+ case R_H2X_CFGI_CTRL:
+ if (data & R_H2X_CFGI_CTRL_FIRE_MASK) {
+ /*
+ * Internal access to bridge
+ * Type and BDF are 0
+ */
+ desc.desc0 = 0x04000001 |
+ (ARRAY_FIELD_EX32(s->regs, H2X_CFGI_TLP, WR) << 30);
+ desc.desc1 = 0x00401000 |
+ ARRAY_FIELD_EX32(s->regs, H2X_CFGI_TLP, BEN);
+ desc.desc2 = 0x00000000 |
+ ARRAY_FIELD_EX32(s->regs, H2X_CFGI_TLP, ADDR);
+ desc.wdata = s->regs[R_H2X_CFGI_WDATA];
+ desc.rdata_reg = R_H2X_CFGI_RDATA;
+ aspeed_pcie_cfg_readwrite(s, &desc);
+ }
+ break;
+ case R_H2X_CFGE_TLPN:
+ s->tlpn_fifo[s->tlpn_idx] = data;
+ s->tlpn_idx = (s->tlpn_idx + 1) % ARRAY_SIZE(s->tlpn_fifo);
+ break;
+ case R_H2X_CFGE_CTRL:
+ if (data & R_H2X_CFGE_CTRL_FIRE_MASK) {
+ desc.desc0 = s->regs[R_H2X_CFGE_TLP1];
+ desc.desc1 = s->tlpn_fifo[0];
+ desc.desc2 = s->tlpn_fifo[1];
+ desc.wdata = s->tlpn_fifo[2];
+ desc.rdata_reg = R_H2X_CFGE_RDATA;
+ aspeed_pcie_cfg_readwrite(s, &desc);
+ s->regs[R_H2X_CFGE_INT_STS] |= R_H2X_CFGE_INT_STS_TX_IDEL_MASK;
+ s->regs[R_H2X_CFGE_INT_STS] |= R_H2X_CFGE_INT_STS_RX_BUSY_MASK;
+ s->tlpn_idx = 0;
+ }
+ break;
+
+ case R_H2X_INT_STS:
+ s->regs[reg] &= ~data | R_H2X_INT_STS_INTX_MASK;
+ break;
+ /*
+ * These status registers are used for notify sources ISR are executed.
+ * If one source ISR is executed, it will clear one bit.
+ * If it clear all bits, it means to initialize this register status
+ * rather than sources ISR are executed.
+ */
+ case R_H2X_MSI_STS0:
+ case R_H2X_MSI_STS1:
+ if (data == 0) {
+ return ;
+ }
+
+ s->regs[reg] &= ~data;
+ if (data == 0xffffffff) {
+ return;
+ }
+
+ if (!s->regs[R_H2X_MSI_STS0] &&
+ !s->regs[R_H2X_MSI_STS1]) {
+ trace_aspeed_pcie_rc_msi_clear_irq(s->id, 0);
+ qemu_set_irq(s->rc.irq, 0);
+ }
+ break;
+ default:
+ s->regs[reg] = data;
+ break;
+ }
+}
+
+static const MemoryRegionOps aspeed_2700_pcie_cfg_ops = {
+ .read = aspeed_pcie_cfg_read,
+ .write = aspeed_2700_pcie_cfg_write,
+ .endianness = DEVICE_LITTLE_ENDIAN,
+ .valid = {
+ .min_access_size = 1,
+ .max_access_size = 4,
+ },
+};
+
+static void aspeed_2700_pcie_cfg_class_init(ObjectClass *klass,
+ const void *data)
+{
+ DeviceClass *dc = DEVICE_CLASS(klass);
+ AspeedPCIECfgClass *apc = ASPEED_PCIE_CFG_CLASS(klass);
+
+ dc->desc = "ASPEED 2700 PCIe Config";
+ apc->reg_ops = &aspeed_2700_pcie_cfg_ops;
+ apc->reg_map = &aspeed_2700_regmap;
+ apc->nr_regs = 0x100 >> 2;
+ apc->rc_msi_addr = 0x000000F0;
+ apc->rc_bus_nr = 0;
+}
+
+static const TypeInfo aspeed_2700_pcie_cfg_info = {
+ .name = TYPE_ASPEED_2700_PCIE_CFG,
+ .parent = TYPE_ASPEED_PCIE_CFG,
+ .class_init = aspeed_2700_pcie_cfg_class_init,
+};
+
/*
* PCIe PHY
*
@@ -841,6 +998,7 @@ static void aspeed_pcie_register_types(void)
type_register_static(&aspeed_pcie_root_device_info);
type_register_static(&aspeed_pcie_root_port_info);
type_register_static(&aspeed_pcie_cfg_info);
+ type_register_static(&aspeed_2700_pcie_cfg_info);
type_register_static(&aspeed_pcie_phy_info);
type_register_static(&aspeed_2700_pcie_phy_info);
}
--
2.43.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* [PATCH v3 11/14] hw/pci-host/aspeed: Disable Root Device and place Root Port at 00:00.0 to AST2700
2025-09-18 3:13 [PATCH v3 00/14] Support PCIe RC to AST2600 and AST2700 Jamin Lin via
` (9 preceding siblings ...)
2025-09-18 3:13 ` [PATCH v3 10/14] hw/pci-host/aspeed: Add AST2700 PCIe config with dedicated H2X blocks Jamin Lin via
@ 2025-09-18 3:13 ` Jamin Lin via
2025-09-18 3:13 ` [PATCH v3 12/14] hw/arm/aspeed_ast27x0: Introduce 3 PCIe RCs for AST2700 Jamin Lin via
` (3 subsequent siblings)
14 siblings, 0 replies; 29+ messages in thread
From: Jamin Lin via @ 2025-09-18 3:13 UTC (permalink / raw)
To: Paolo Bonzini, Peter Maydell, Cédric Le Goater, Steven Lee,
Troy Lee, Andrew Jeffery, Joel Stanley, Michael S. Tsirkin,
Marcel Apfelbaum, open list:ARM TCG CPUs,
open list:All patches CC here
Cc: jamin_lin, troy_lee, nabihestefan, wuhaotsh, titusr
AST2700 does not implement a PCIe Root Device; each RC exposes a single
PCIe Root Port at devfn 0:0.0.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
hw/pci-host/aspeed_pcie.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/pci-host/aspeed_pcie.c b/hw/pci-host/aspeed_pcie.c
index b7ae47f9b2..53ea544d59 100644
--- a/hw/pci-host/aspeed_pcie.c
+++ b/hw/pci-host/aspeed_pcie.c
@@ -823,6 +823,8 @@ static void aspeed_2700_pcie_cfg_class_init(ObjectClass *klass,
apc->nr_regs = 0x100 >> 2;
apc->rc_msi_addr = 0x000000F0;
apc->rc_bus_nr = 0;
+ apc->rc_has_rd = false;
+ apc->rc_rp_addr = PCI_DEVFN(0, 0);
}
static const TypeInfo aspeed_2700_pcie_cfg_info = {
--
2.43.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* [PATCH v3 12/14] hw/arm/aspeed_ast27x0: Introduce 3 PCIe RCs for AST2700
2025-09-18 3:13 [PATCH v3 00/14] Support PCIe RC to AST2600 and AST2700 Jamin Lin via
` (10 preceding siblings ...)
2025-09-18 3:13 ` [PATCH v3 11/14] hw/pci-host/aspeed: Disable Root Device and place Root Port at 00:00.0 to AST2700 Jamin Lin via
@ 2025-09-18 3:13 ` Jamin Lin via
2025-09-18 3:13 ` [PATCH v3 13/14] tests/functional/arm/test_aspeed_ast2600: Add PCIe and network test Jamin Lin via
` (2 subsequent siblings)
14 siblings, 0 replies; 29+ messages in thread
From: Jamin Lin via @ 2025-09-18 3:13 UTC (permalink / raw)
To: Paolo Bonzini, Peter Maydell, Cédric Le Goater, Steven Lee,
Troy Lee, Andrew Jeffery, Joel Stanley, Michael S. Tsirkin,
Marcel Apfelbaum, open list:ARM TCG CPUs,
open list:All patches CC here
Cc: jamin_lin, troy_lee, nabihestefan, wuhaotsh, titusr
Add PCIe Root Complex support to the AST2700 SoC model.
The AST2700 A1 silicon revision provides three PCIe Root Complexes:
PCIe0 with its PHY at 0x12C15000, config (H2X) block at 0x120E0000,
MMIO window at 0x60000000, and GIC IRQ 56.
PCIe1 with its PHY at 0x12C15800, config (H2X) block at 0x120F0000,
MMIO window at 0x80000000, and GIC IRQ 57.
PCIe2 with its PHY at 0x14C1C000, config (H2X) block at 0x140D0000,
MMIO window at 0xA0000000, and IRQ routed through INTC4 bit 31
mapped to GIC IRQ 196.
Each RC instantiates a PHY device, a PCIe config (H2X) bridge, and an MMIO
alias region. The per-RC MMIO alias size is 0x20000000. The AST2700 A0
silicon revision does not support PCIe Root Complexes, so pcie_num is set
to 0 in that variant.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
include/hw/arm/aspeed_soc.h | 1 +
hw/arm/aspeed_ast27x0.c | 76 +++++++++++++++++++++++++++++++++++++
2 files changed, 77 insertions(+)
diff --git a/include/hw/arm/aspeed_soc.h b/include/hw/arm/aspeed_soc.h
index 79fe353f83..070e2b49c5 100644
--- a/include/hw/arm/aspeed_soc.h
+++ b/include/hw/arm/aspeed_soc.h
@@ -185,6 +185,7 @@ struct AspeedSoCClass {
uint32_t silicon_rev;
uint64_t sram_size;
uint64_t secsram_size;
+ int pcie_num;
int spis_num;
int ehcis_num;
int wdts_num;
diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c
index 6aa3841b69..5da7bea8b3 100644
--- a/hw/arm/aspeed_ast27x0.c
+++ b/hw/arm/aspeed_ast27x0.c
@@ -38,6 +38,8 @@ static const hwaddr aspeed_soc_ast2700_memmap[] = {
[ASPEED_DEV_EHCI2] = 0x12063000,
[ASPEED_DEV_HACE] = 0x12070000,
[ASPEED_DEV_EMMC] = 0x12090000,
+ [ASPEED_DEV_PCIE0] = 0x120E0000,
+ [ASPEED_DEV_PCIE1] = 0x120F0000,
[ASPEED_DEV_INTC] = 0x12100000,
[ASPEED_GIC_DIST] = 0x12200000,
[ASPEED_GIC_REDIST] = 0x12280000,
@@ -45,6 +47,8 @@ static const hwaddr aspeed_soc_ast2700_memmap[] = {
[ASPEED_DEV_SCU] = 0x12C02000,
[ASPEED_DEV_RTC] = 0x12C0F000,
[ASPEED_DEV_TIMER1] = 0x12C10000,
+ [ASPEED_DEV_PCIE_PHY0] = 0x12C15000,
+ [ASPEED_DEV_PCIE_PHY1] = 0x12C15800,
[ASPEED_DEV_SLI] = 0x12C17000,
[ASPEED_DEV_UART4] = 0x12C1A000,
[ASPEED_DEV_IOMEM1] = 0x14000000,
@@ -59,6 +63,7 @@ static const hwaddr aspeed_soc_ast2700_memmap[] = {
[ASPEED_DEV_ETH2] = 0x14060000,
[ASPEED_DEV_ETH3] = 0x14070000,
[ASPEED_DEV_SDHCI] = 0x14080000,
+ [ASPEED_DEV_PCIE2] = 0x140D0000,
[ASPEED_DEV_EHCI3] = 0x14121000,
[ASPEED_DEV_EHCI4] = 0x14123000,
[ASPEED_DEV_ADC] = 0x14C00000,
@@ -66,6 +71,7 @@ static const hwaddr aspeed_soc_ast2700_memmap[] = {
[ASPEED_DEV_GPIO] = 0x14C0B000,
[ASPEED_DEV_I2C] = 0x14C0F000,
[ASPEED_DEV_INTCIO] = 0x14C18000,
+ [ASPEED_DEV_PCIE_PHY2] = 0x14C1C000,
[ASPEED_DEV_SLIIO] = 0x14C1E000,
[ASPEED_DEV_VUART] = 0x14C30000,
[ASPEED_DEV_UART0] = 0x14C33000,
@@ -81,6 +87,9 @@ static const hwaddr aspeed_soc_ast2700_memmap[] = {
[ASPEED_DEV_UART11] = 0x14C33A00,
[ASPEED_DEV_UART12] = 0x14C33B00,
[ASPEED_DEV_WDT] = 0x14C37000,
+ [ASPEED_DEV_PCIE_MMIO0] = 0x60000000,
+ [ASPEED_DEV_PCIE_MMIO1] = 0x80000000,
+ [ASPEED_DEV_PCIE_MMIO2] = 0xA0000000,
[ASPEED_DEV_SPI_BOOT] = 0x100000000,
[ASPEED_DEV_LTPI] = 0x300000000,
[ASPEED_DEV_SDRAM] = 0x400000000,
@@ -156,6 +165,8 @@ static const int aspeed_soc_ast2700a1_irqmap[] = {
[ASPEED_DEV_DP] = 28,
[ASPEED_DEV_EHCI1] = 33,
[ASPEED_DEV_EHCI2] = 37,
+ [ASPEED_DEV_PCIE0] = 56,
+ [ASPEED_DEV_PCIE1] = 57,
[ASPEED_DEV_LPC] = 192,
[ASPEED_DEV_IBT] = 192,
[ASPEED_DEV_KCS] = 192,
@@ -166,6 +177,7 @@ static const int aspeed_soc_ast2700a1_irqmap[] = {
[ASPEED_DEV_WDT] = 195,
[ASPEED_DEV_PWM] = 195,
[ASPEED_DEV_I3C] = 195,
+ [ASPEED_DEV_PCIE2] = 196,
[ASPEED_DEV_UART0] = 196,
[ASPEED_DEV_UART1] = 196,
[ASPEED_DEV_UART2] = 196,
@@ -233,6 +245,7 @@ static const int ast2700_gic132_gic196_intcmap[] = {
[ASPEED_DEV_UART12] = 18,
[ASPEED_DEV_EHCI3] = 28,
[ASPEED_DEV_EHCI4] = 29,
+ [ASPEED_DEV_PCIE2] = 31,
};
/* GICINT 133 */
@@ -519,6 +532,17 @@ static void aspeed_soc_ast2700_init(Object *obj)
snprintf(typename, sizeof(typename), "aspeed.hace-%s", socname);
object_initialize_child(obj, "hace", &s->hace, typename);
+
+ for (i = 0; i < sc->pcie_num; i++) {
+ snprintf(typename, sizeof(typename), "aspeed.pcie-phy-%s", socname);
+ object_initialize_child(obj, "pcie-phy[*]", &s->pcie_phy[i], typename);
+ object_property_set_int(OBJECT(&s->pcie_phy[i]), "id", i, &error_abort);
+
+ snprintf(typename, sizeof(typename), "aspeed.pcie-cfg-%s", socname);
+ object_initialize_child(obj, "pcie-cfg[*]", &s->pcie[i], typename);
+ object_property_set_int(OBJECT(&s->pcie[i]), "id", i, &error_abort);
+ }
+
object_initialize_child(obj, "dpmcu", &s->dpmcu,
TYPE_UNIMPLEMENTED_DEVICE);
object_initialize_child(obj, "ltpi", &s->ltpi,
@@ -610,6 +634,51 @@ static bool aspeed_soc_ast2700_gic_realize(DeviceState *dev, Error **errp)
return true;
}
+static bool aspeed_soc_ast2700_pcie_realize(DeviceState *dev, Error **errp)
+{
+ AspeedSoCState *s = ASPEED_SOC(dev);
+ AspeedSoCClass *sc = ASPEED_SOC_GET_CLASS(s);
+ g_autofree char *name = NULL;
+ MemoryRegion *mmio_alias;
+ MemoryRegion *mmio_mr;
+ qemu_irq irq;
+ int i;
+
+ for (i = 0; i < sc->pcie_num; i++) {
+ if (!sysbus_realize(SYS_BUS_DEVICE(&s->pcie_phy[i]), errp)) {
+ return false;
+ }
+ aspeed_mmio_map(s, SYS_BUS_DEVICE(&s->pcie_phy[i]), 0,
+ sc->memmap[ASPEED_DEV_PCIE_PHY0 + i]);
+
+ object_property_set_int(OBJECT(&s->pcie[i]), "dram-base",
+ sc->memmap[ASPEED_DEV_SDRAM],
+ &error_abort);
+ object_property_set_link(OBJECT(&s->pcie[i]), "dram",
+ OBJECT(s->dram_mr), &error_abort);
+ if (!sysbus_realize(SYS_BUS_DEVICE(&s->pcie[i]), errp)) {
+ return false;
+ }
+ aspeed_mmio_map(s, SYS_BUS_DEVICE(&s->pcie[i]), 0,
+ sc->memmap[ASPEED_DEV_PCIE0 + i]);
+ irq = aspeed_soc_get_irq(s, ASPEED_DEV_PCIE0 + i);
+ sysbus_connect_irq(SYS_BUS_DEVICE(&s->pcie[i].rc), 0, irq);
+
+ name = g_strdup_printf("aspeed.pcie-mmio.%d", i);
+ mmio_alias = g_new0(MemoryRegion, 1);
+ mmio_mr = sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->pcie[i].rc), 1);
+
+ memory_region_init_alias(mmio_alias, OBJECT(&s->pcie[i].rc), name,
+ mmio_mr, sc->memmap[ASPEED_DEV_PCIE_MMIO0 + i],
+ 0x20000000);
+ memory_region_add_subregion(s->memory,
+ sc->memmap[ASPEED_DEV_PCIE_MMIO0 + i],
+ mmio_alias);
+ }
+
+ return true;
+}
+
static void aspeed_soc_ast2700_realize(DeviceState *dev, Error **errp)
{
int i;
@@ -936,6 +1005,11 @@ static void aspeed_soc_ast2700_realize(DeviceState *dev, Error **errp)
sysbus_connect_irq(SYS_BUS_DEVICE(&s->hace), 0,
aspeed_soc_get_irq(s, ASPEED_DEV_HACE));
+ /* PCIe Root Complex (RC) */
+ if (!aspeed_soc_ast2700_pcie_realize(dev, errp)) {
+ return;
+ }
+
aspeed_mmio_map_unimplemented(s, SYS_BUS_DEVICE(&s->dpmcu),
"aspeed.dpmcu",
sc->memmap[ASPEED_DEV_DPMCU],
@@ -974,6 +1048,7 @@ static void aspeed_soc_ast2700a0_class_init(ObjectClass *oc, const void *data)
sc->valid_cpu_types = valid_cpu_types;
sc->silicon_rev = AST2700_A0_SILICON_REV;
sc->sram_size = 0x20000;
+ sc->pcie_num = 0;
sc->spis_num = 3;
sc->ehcis_num = 2;
sc->wdts_num = 8;
@@ -1002,6 +1077,7 @@ static void aspeed_soc_ast2700a1_class_init(ObjectClass *oc, const void *data)
sc->valid_cpu_types = valid_cpu_types;
sc->silicon_rev = AST2700_A1_SILICON_REV;
sc->sram_size = 0x20000;
+ sc->pcie_num = 3;
sc->spis_num = 3;
sc->ehcis_num = 4;
sc->wdts_num = 8;
--
2.43.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* [PATCH v3 13/14] tests/functional/arm/test_aspeed_ast2600: Add PCIe and network test
2025-09-18 3:13 [PATCH v3 00/14] Support PCIe RC to AST2600 and AST2700 Jamin Lin via
` (11 preceding siblings ...)
2025-09-18 3:13 ` [PATCH v3 12/14] hw/arm/aspeed_ast27x0: Introduce 3 PCIe RCs for AST2700 Jamin Lin via
@ 2025-09-18 3:13 ` Jamin Lin via
2025-09-18 7:55 ` [SPAM] " Cédric Le Goater
2025-09-18 3:13 ` [PATCH v3 14/14] tests/functional/aarch64/aspeed_ast2700: Add PCIe and network tests Jamin Lin via
2025-09-18 8:02 ` [SPAM] [PATCH v3 00/14] Support PCIe RC to AST2600 and AST2700 Cédric Le Goater
14 siblings, 1 reply; 29+ messages in thread
From: Jamin Lin via @ 2025-09-18 3:13 UTC (permalink / raw)
To: Paolo Bonzini, Peter Maydell, Cédric Le Goater, Steven Lee,
Troy Lee, Andrew Jeffery, Joel Stanley, Michael S. Tsirkin,
Marcel Apfelbaum, open list:ARM TCG CPUs,
open list:All patches CC here
Cc: jamin_lin, troy_lee, nabihestefan, wuhaotsh, titusr
Extend the AST2600 functional tests with PCIe and network checks.
This patch introduces a new helper "do_ast2600_pcie_test()" that runs "lspci"
on the emulated system and verifies the presence of the expected PCIe devices:
- 80:00.0 Host bridge: ASPEED Technology, Inc. Device 2600
- 80:08.0 PCI bridge: ASPEED Technology, Inc. AST1150 PCI-to-PCI Bridge
- 81:00.0 Ethernet controller: Intel Corporation 82574L Gigabit Network Connection
To exercise the PCIe network device, the test adds:
-device e1000e,netdev=net1,bus=pcie.0
-netdev user,id=net1
and assigns an IP address to the interface, verifying it with `ip addr`.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
tests/functional/arm/test_aspeed_ast2600.py | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/tests/functional/arm/test_aspeed_ast2600.py b/tests/functional/arm/test_aspeed_ast2600.py
index 87e3595584..a7d9b894fc 100755
--- a/tests/functional/arm/test_aspeed_ast2600.py
+++ b/tests/functional/arm/test_aspeed_ast2600.py
@@ -101,6 +101,23 @@ def test_arm_ast2600_evb_buildroot_tpm(self):
'https://github.com/AspeedTech-BMC/openbmc/releases/download/v09.07/ast2600-default-obmc.tar.gz',
'cb6c08595bcbba1672ce716b068ba4e48eda1ed9abe78a07b30392ba2278feba')
+ def do_ast2600_pcie_test(self):
+ exec_command_and_wait_for_pattern(self,
+ 'lspci -s 80:00.0',
+ '80:00.0 Host bridge: '
+ 'ASPEED Technology, Inc. Device 2600')
+ exec_command_and_wait_for_pattern(self,
+ 'lspci -s 80:08.0',
+ '80:08.0 PCI bridge: '
+ 'ASPEED Technology, Inc. AST1150 PCI-to-PCI Bridge')
+ exec_command_and_wait_for_pattern(self,
+ 'lspci -s 81:00.0',
+ '81:00.0 Ethernet controller: '
+ 'Intel Corporation 82574L Gigabit Network Connection')
+ exec_command_and_wait_for_pattern(self,
+ 'ip addr add 192.168.1.100/24 dev eth4 && ip addr',
+ 'inet 192.168.1.100/24 scope global eth4')
+
def test_arm_ast2600_evb_sdk(self):
self.set_machine('ast2600-evb')
@@ -110,6 +127,8 @@ def test_arm_ast2600_evb_sdk(self):
'tmp105,bus=aspeed.i2c.bus.5,address=0x4d,id=tmp-test')
self.vm.add_args('-device',
'ds1338,bus=aspeed.i2c.bus.5,address=0x32')
+ self.vm.add_args('-device', 'e1000e,netdev=net1,bus=pcie.0')
+ self.vm.add_args('-netdev', 'user,id=net1')
self.do_test_arm_aspeed_sdk_start(
self.scratch_file("ast2600-default", "image-bmc"))
@@ -135,6 +154,7 @@ def test_arm_ast2600_evb_sdk(self):
year = time.strftime("%Y")
exec_command_and_wait_for_pattern(self,
'/sbin/hwclock -f /dev/rtc1', year)
+ self.do_ast2600_pcie_test()
def test_arm_ast2600_otp_blockdev_device(self):
self.vm.set_machine("ast2600-evb")
--
2.43.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* Re: [SPAM] [PATCH v3 13/14] tests/functional/arm/test_aspeed_ast2600: Add PCIe and network test
2025-09-18 3:13 ` [PATCH v3 13/14] tests/functional/arm/test_aspeed_ast2600: Add PCIe and network test Jamin Lin via
@ 2025-09-18 7:55 ` Cédric Le Goater
2025-09-18 8:42 ` Jamin Lin
0 siblings, 1 reply; 29+ messages in thread
From: Cédric Le Goater @ 2025-09-18 7:55 UTC (permalink / raw)
To: Jamin Lin, Paolo Bonzini, Peter Maydell, Steven Lee, Troy Lee,
Andrew Jeffery, Joel Stanley, Michael S. Tsirkin,
Marcel Apfelbaum, open list:ARM TCG CPUs,
open list:All patches CC here
Cc: troy_lee, nabihestefan, wuhaotsh, titusr, Thomas Huth
+ Thomas
On 9/18/25 05:13, Jamin Lin wrote:
> Extend the AST2600 functional tests with PCIe and network checks.
>
> This patch introduces a new helper "do_ast2600_pcie_test()" that runs "lspci"
> on the emulated system and verifies the presence of the expected PCIe devices:
>
> - 80:00.0 Host bridge: ASPEED Technology, Inc. Device 2600
> - 80:08.0 PCI bridge: ASPEED Technology, Inc. AST1150 PCI-to-PCI Bridge
> - 81:00.0 Ethernet controller: Intel Corporation 82574L Gigabit Network Connection
>
> To exercise the PCIe network device, the test adds:
>
> -device e1000e,netdev=net1,bus=pcie.0
> -netdev user,id=net1
>
> and assigns an IP address to the interface, verifying it with `ip addr`.
>
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> ---
> tests/functional/arm/test_aspeed_ast2600.py | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/tests/functional/arm/test_aspeed_ast2600.py b/tests/functional/arm/test_aspeed_ast2600.py
> index 87e3595584..a7d9b894fc 100755
> --- a/tests/functional/arm/test_aspeed_ast2600.py
> +++ b/tests/functional/arm/test_aspeed_ast2600.py
> @@ -101,6 +101,23 @@ def test_arm_ast2600_evb_buildroot_tpm(self):
> 'https://github.com/AspeedTech-BMC/openbmc/releases/download/v09.07/ast2600-default-obmc.tar.gz',
> 'cb6c08595bcbba1672ce716b068ba4e48eda1ed9abe78a07b30392ba2278feba')
>
> + def do_ast2600_pcie_test(self):
> + exec_command_and_wait_for_pattern(self,
> + 'lspci -s 80:00.0',
> + '80:00.0 Host bridge: '
> + 'ASPEED Technology, Inc. Device 2600')
> + exec_command_and_wait_for_pattern(self,
> + 'lspci -s 80:08.0',
> + '80:08.0 PCI bridge: '
> + 'ASPEED Technology, Inc. AST1150 PCI-to-PCI Bridge')
> + exec_command_and_wait_for_pattern(self,
> + 'lspci -s 81:00.0',
> + '81:00.0 Ethernet controller: '
> + 'Intel Corporation 82574L Gigabit Network Connection')
> + exec_command_and_wait_for_pattern(self,
> + 'ip addr add 192.168.1.100/24 dev eth4 && ip addr',
> + 'inet 192.168.1.100/24 scope global eth4')
I think checking that the user netdev returned 'inet 10.0.2.15/24'
should be enough. It would mean that DHCP has worked and that MSI
were triggered. No need to assign a new IP address IMO.
> +
> def test_arm_ast2600_evb_sdk(self):
> self.set_machine('ast2600-evb')
>
> @@ -110,6 +127,8 @@ def test_arm_ast2600_evb_sdk(self):
> 'tmp105,bus=aspeed.i2c.bus.5,address=0x4d,id=tmp-test')
> self.vm.add_args('-device',
> 'ds1338,bus=aspeed.i2c.bus.5,address=0x32')
> + self.vm.add_args('-device', 'e1000e,netdev=net1,bus=pcie.0')
> + self.vm.add_args('-netdev', 'user,id=net1')
you need to add
self.require_netdev('user')
Thanks,
C.
> self.do_test_arm_aspeed_sdk_start(
> self.scratch_file("ast2600-default", "image-bmc"))
>
> @@ -135,6 +154,7 @@ def test_arm_ast2600_evb_sdk(self):
> year = time.strftime("%Y")
> exec_command_and_wait_for_pattern(self,
> '/sbin/hwclock -f /dev/rtc1', year)
> + self.do_ast2600_pcie_test()
>
> def test_arm_ast2600_otp_blockdev_device(self):
> self.vm.set_machine("ast2600-evb")
^ permalink raw reply [flat|nested] 29+ messages in thread* RE: [SPAM] [PATCH v3 13/14] tests/functional/arm/test_aspeed_ast2600: Add PCIe and network test
2025-09-18 7:55 ` [SPAM] " Cédric Le Goater
@ 2025-09-18 8:42 ` Jamin Lin
0 siblings, 0 replies; 29+ messages in thread
From: Jamin Lin @ 2025-09-18 8:42 UTC (permalink / raw)
To: Cédric Le Goater, Paolo Bonzini, Peter Maydell, Steven Lee,
Troy Lee, Andrew Jeffery, Joel Stanley, Michael S. Tsirkin,
Marcel Apfelbaum, open list:ARM TCG CPUs,
open list:All patches CC here
Cc: Troy Lee, nabihestefan@google.com, wuhaotsh@google.com,
titusr@google.com, Thomas Huth
Hi Cédric
> tests/functional/arm/test_aspeed_ast2600: Add PCIe and network test
>
> + Thomas
>
> On 9/18/25 05:13, Jamin Lin wrote:
> > Extend the AST2600 functional tests with PCIe and network checks.
> >
> > This patch introduces a new helper "do_ast2600_pcie_test()" that runs "lspci"
> > on the emulated system and verifies the presence of the expected PCIe
> devices:
> >
> > - 80:00.0 Host bridge: ASPEED Technology, Inc. Device 2600
> > - 80:08.0 PCI bridge: ASPEED Technology, Inc. AST1150 PCI-to-PCI
> > Bridge
> > - 81:00.0 Ethernet controller: Intel Corporation 82574L Gigabit
> > Network Connection
> >
> > To exercise the PCIe network device, the test adds:
> >
> > -device e1000e,netdev=net1,bus=pcie.0
> > -netdev user,id=net1
> >
> > and assigns an IP address to the interface, verifying it with `ip addr`.
> >
> > Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> > ---
> > tests/functional/arm/test_aspeed_ast2600.py | 20
> ++++++++++++++++++++
> > 1 file changed, 20 insertions(+)
> >
> > diff --git a/tests/functional/arm/test_aspeed_ast2600.py
> > b/tests/functional/arm/test_aspeed_ast2600.py
> > index 87e3595584..a7d9b894fc 100755
> > --- a/tests/functional/arm/test_aspeed_ast2600.py
> > +++ b/tests/functional/arm/test_aspeed_ast2600.py
> > @@ -101,6 +101,23 @@ def test_arm_ast2600_evb_buildroot_tpm(self):
> >
> 'https://github.com/AspeedTech-BMC/openbmc/releases/download/v09.07/ast
> 2600-default-obmc.tar.gz',
> >
> >
> 'cb6c08595bcbba1672ce716b068ba4e48eda1ed9abe78a07b30392ba2278feba'
> )
> >
> > + def do_ast2600_pcie_test(self):
> > + exec_command_and_wait_for_pattern(self,
> > + 'lspci -s 80:00.0',
> > + '80:00.0 Host bridge: '
> > + 'ASPEED Technology, Inc. Device 2600')
> > + exec_command_and_wait_for_pattern(self,
> > + 'lspci -s 80:08.0',
> > + '80:08.0 PCI bridge: '
> > + 'ASPEED Technology, Inc. AST1150 PCI-to-PCI Bridge')
> > + exec_command_and_wait_for_pattern(self,
> > + 'lspci -s 81:00.0',
> > + '81:00.0 Ethernet controller: '
> > + 'Intel Corporation 82574L Gigabit Network Connection')
> > + exec_command_and_wait_for_pattern(self,
> > + 'ip addr add 192.168.1.100/24 dev eth4 && ip addr',
> > + 'inet 192.168.1.100/24 scope global eth4')
>
> I think checking that the user netdev returned 'inet 10.0.2.15/24'
> should be enough. It would mean that DHCP has worked and that MSI were
> triggered. No need to assign a new IP address IMO.
>
Thanks for your review and suggestion.
Will fix it.
> > +
> > def test_arm_ast2600_evb_sdk(self):
> > self.set_machine('ast2600-evb')
> >
> > @@ -110,6 +127,8 @@ def test_arm_ast2600_evb_sdk(self):
> > 'tmp105,bus=aspeed.i2c.bus.5,address=0x4d,id=tmp-test')
> > self.vm.add_args('-device',
> > 'ds1338,bus=aspeed.i2c.bus.5,address=0x32')
> > + self.vm.add_args('-device', 'e1000e,netdev=net1,bus=pcie.0')
> > + self.vm.add_args('-netdev', 'user,id=net1')
>
> you need to add
>
> self.require_netdev('user')
>
Will add.
Jamin
>
>
> Thanks,
>
> C.
>
>
>
> > self.do_test_arm_aspeed_sdk_start(
> > self.scratch_file("ast2600-default", "image-bmc"))
> >
> > @@ -135,6 +154,7 @@ def test_arm_ast2600_evb_sdk(self):
> > year = time.strftime("%Y")
> > exec_command_and_wait_for_pattern(self,
> > '/sbin/hwclock -f /dev/rtc1', year)
> > + self.do_ast2600_pcie_test()
> >
> > def test_arm_ast2600_otp_blockdev_device(self):
> > self.vm.set_machine("ast2600-evb")
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v3 14/14] tests/functional/aarch64/aspeed_ast2700: Add PCIe and network tests
2025-09-18 3:13 [PATCH v3 00/14] Support PCIe RC to AST2600 and AST2700 Jamin Lin via
` (12 preceding siblings ...)
2025-09-18 3:13 ` [PATCH v3 13/14] tests/functional/arm/test_aspeed_ast2600: Add PCIe and network test Jamin Lin via
@ 2025-09-18 3:13 ` Jamin Lin via
2025-09-18 8:02 ` [SPAM] [PATCH v3 00/14] Support PCIe RC to AST2600 and AST2700 Cédric Le Goater
14 siblings, 0 replies; 29+ messages in thread
From: Jamin Lin via @ 2025-09-18 3:13 UTC (permalink / raw)
To: Paolo Bonzini, Peter Maydell, Cédric Le Goater, Steven Lee,
Troy Lee, Andrew Jeffery, Joel Stanley, Michael S. Tsirkin,
Marcel Apfelbaum, open list:ARM TCG CPUs,
open list:All patches CC here
Cc: jamin_lin, troy_lee, nabihestefan, wuhaotsh, titusr
Extend the AST2700 and AST2700fc functional tests with PCIe and network
checks.
This patch introduces a helper "do_ast2700_pcie_test()" that runs "lspci"
on the emulated system and verifies the expected PCIe devices:
- 0002:00:00.0 PCI bridge: ASPEED Technology, Inc. AST1150 PCI-to-PCI Bridge
- 0002:01:00.0 Ethernet controller: Intel Corporation 82574L Gigabit Network Connection
Additional changes:
- Add `-device e1000e,netdev=net1,bus=pcie.2 -netdev user,id=net1` to the
AST2700 and AST2700fc test machines.
- In the AST2700 vbootrom test, assign an IP address to the e1000e
interface and verify it using `ip addr`.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
.../functional/aarch64/test_aspeed_ast2700.py | 19 +++++++++++++++++++
.../aarch64/test_aspeed_ast2700fc.py | 13 +++++++++++++
2 files changed, 32 insertions(+)
diff --git a/tests/functional/aarch64/test_aspeed_ast2700.py b/tests/functional/aarch64/test_aspeed_ast2700.py
index a3db267294..70b2f6485d 100755
--- a/tests/functional/aarch64/test_aspeed_ast2700.py
+++ b/tests/functional/aarch64/test_aspeed_ast2700.py
@@ -69,6 +69,16 @@ def do_ast2700_i2c_test(self):
exec_command_and_wait_for_pattern(self,
'cat /sys/bus/i2c/devices/1-004d/hwmon/hwmon*/temp1_input', '18000')
+ def do_ast2700_pcie_test(self):
+ exec_command_and_wait_for_pattern(self,
+ 'lspci -s 0002:00:00.0',
+ '0002:00:00.0 PCI bridge: '
+ 'ASPEED Technology, Inc. AST1150 PCI-to-PCI Bridge')
+ exec_command_and_wait_for_pattern(self,
+ 'lspci -s 0002:01:00.0',
+ '0002:01:00.0 Ethernet controller: '
+ 'Intel Corporation 82574L Gigabit Network Connection')
+
def start_ast2700_test(self, name):
num_cpu = 4
uboot_size = os.path.getsize(self.scratch_file(name,
@@ -127,18 +137,27 @@ def test_aarch64_ast2700a1_evb_sdk_v09_06(self):
self.set_machine('ast2700a1-evb')
self.archive_extract(self.ASSET_SDK_V906_AST2700A1)
+ self.vm.add_args('-device', 'e1000e,netdev=net1,bus=pcie.2')
+ self.vm.add_args('-netdev', 'user,id=net1')
self.start_ast2700_test('ast2700-default')
self.verify_openbmc_boot_and_login('ast2700-default')
self.do_ast2700_i2c_test()
+ self.do_ast2700_pcie_test()
def test_aarch64_ast2700a1_evb_sdk_vbootrom_v09_07(self):
self.set_machine('ast2700a1-evb')
self.archive_extract(self.ASSET_SDK_V907_AST2700A1_VBOOROM)
+ self.vm.add_args('-device', 'e1000e,netdev=net1,bus=pcie.2')
+ self.vm.add_args('-netdev', 'user,id=net1')
self.start_ast2700_test_vbootrom('ast2700-default')
self.verify_vbootrom_firmware_flow()
self.verify_openbmc_boot_and_login('ast2700-default')
self.do_ast2700_i2c_test()
+ self.do_ast2700_pcie_test()
+ exec_command_and_wait_for_pattern(self,
+ 'ip addr add 192.168.1.100/24 dev eth2 && ip addr',
+ 'inet 192.168.1.100/24 scope global eth2')
if __name__ == '__main__':
QemuSystemTest.main()
diff --git a/tests/functional/aarch64/test_aspeed_ast2700fc.py b/tests/functional/aarch64/test_aspeed_ast2700fc.py
index b85370e182..28b66614d9 100755
--- a/tests/functional/aarch64/test_aspeed_ast2700fc.py
+++ b/tests/functional/aarch64/test_aspeed_ast2700fc.py
@@ -20,6 +20,8 @@ def do_test_aarch64_aspeed_sdk_start(self, image):
self.vm.set_console()
self.vm.add_args('-device',
'tmp105,bus=aspeed.i2c.bus.1,address=0x4d,id=tmp-test')
+ self.vm.add_args('-device', 'e1000e,netdev=net1,bus=pcie.2')
+ self.vm.add_args('-netdev', 'user,id=net1')
self.vm.add_args('-drive', 'file=' + image + ',if=mtd,format=raw',
'-net', 'nic', '-net', 'user', '-snapshot')
@@ -49,6 +51,16 @@ def do_ast2700_i2c_test(self):
exec_command_and_wait_for_pattern(self,
'cat /sys/bus/i2c/devices/1-004d/hwmon/hwmon*/temp1_input', '18000')
+ def do_ast2700_pcie_test(self):
+ exec_command_and_wait_for_pattern(self,
+ 'lspci -s 0002:00:00.0',
+ '0002:00:00.0 PCI bridge: '
+ 'ASPEED Technology, Inc. AST1150 PCI-to-PCI Bridge')
+ exec_command_and_wait_for_pattern(self,
+ 'lspci -s 0002:01:00.0',
+ '0002:01:00.0 Ethernet controller: '
+ 'Intel Corporation 82574L Gigabit Network Connection')
+
def do_ast2700fc_ssp_test(self):
self.vm.shutdown()
self.vm.set_console(console_index=1)
@@ -128,6 +140,7 @@ def test_aarch64_ast2700fc_sdk_v09_06(self):
self.start_ast2700fc_test('ast2700-default')
self.verify_openbmc_boot_and_login('ast2700-default')
self.do_ast2700_i2c_test()
+ self.do_ast2700_pcie_test()
self.do_ast2700fc_ssp_test()
self.do_ast2700fc_tsp_test()
--
2.43.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* Re: [SPAM] [PATCH v3 00/14] Support PCIe RC to AST2600 and AST2700
2025-09-18 3:13 [PATCH v3 00/14] Support PCIe RC to AST2600 and AST2700 Jamin Lin via
` (13 preceding siblings ...)
2025-09-18 3:13 ` [PATCH v3 14/14] tests/functional/aarch64/aspeed_ast2700: Add PCIe and network tests Jamin Lin via
@ 2025-09-18 8:02 ` Cédric Le Goater
2025-09-18 9:08 ` Jamin Lin
14 siblings, 1 reply; 29+ messages in thread
From: Cédric Le Goater @ 2025-09-18 8:02 UTC (permalink / raw)
To: Jamin Lin, Paolo Bonzini, Peter Maydell, Steven Lee, Troy Lee,
Andrew Jeffery, Joel Stanley, Michael S. Tsirkin,
Marcel Apfelbaum, open list:ARM TCG CPUs,
open list:All patches CC here
Cc: troy_lee, nabihestefan, wuhaotsh, titusr
Hell Jamin,
On 9/18/25 05:13, Jamin Lin wrote:
> v1:
> 1. Add PCIe PHY, CFG, and MMIO window support for AST2600.
> Note: Only supports RC_H.
> 2. Add PCIe PHY, CFG, and MMIO window support for AST2700.
> Note: Supports 3 RCs.
>
> v2:
> 1. Introduce a new root port device.
> 2. For AST2600 RC_H, add the root device at 80:00.0 and a root port at 80.08.0
> to match the real hardware topology, allowing users to attach PCIe devices
> at the root port.
> 3. For AST2700, add a root port at 00.00.0 for each PCIe root complex to match
> the real hardware topology, allowing users to attach PCIe devices at the
> root port.
>
> v3:
> 1. Fix review issues.
> 2. update functional test for the e1000e network card.
> 3. update license header
> 4. Adding "Based on previous work from Cedric Le Goater, with Jamin's summary
> implementation.
v3 looks good. I only had a few comments on memory allocation
(g_autofree and MMIO alias regions) and on functional tests.
v4 should be the last.
>
> Dependencies
>
> QEMU version:
> https://github.com/qemu/qemu/commit/f0007b7f03e2d7fc33e71c3a582f2364c51a226b
>
> This patch series depends on the following patch series:
> 1. hw/arm/aspeed Move ast2700-evb alias to ast2700a1-evb
> https://patchwork.kernel.org/project/qemu-devel/patch/20250902062550.3797040-1-jamin_lin@aspeedtech.com/
> 2. tests/functional/arm: Update test images for ASPEED chips
> https://patchwork.kernel.org/project/qemu-devel/cover/20250904100556.1729604-1-kane_chen@aspeedtech.com/
> 3. tests/functional/arm: Add OTP functional test
> https://patchwork.kernel.org/project/qemu-devel/cover/20250917035917.4141723-1-kane_chen@aspeedtech.com/
There changes are in aspeed-next. You could use it as a reference
in the cover letter.
Thanks,
C.
^ permalink raw reply [flat|nested] 29+ messages in thread* RE: [SPAM] [PATCH v3 00/14] Support PCIe RC to AST2600 and AST2700
2025-09-18 8:02 ` [SPAM] [PATCH v3 00/14] Support PCIe RC to AST2600 and AST2700 Cédric Le Goater
@ 2025-09-18 9:08 ` Jamin Lin
2025-09-18 9:30 ` Cédric Le Goater
0 siblings, 1 reply; 29+ messages in thread
From: Jamin Lin @ 2025-09-18 9:08 UTC (permalink / raw)
To: Cédric Le Goater, Paolo Bonzini, Peter Maydell, Steven Lee,
Troy Lee, Andrew Jeffery, Joel Stanley, Michael S. Tsirkin,
Marcel Apfelbaum, open list:ARM TCG CPUs,
open list:All patches CC here
Cc: Troy Lee, nabihestefan@google.com, wuhaotsh@google.com,
titusr@google.com
Hi Cédric
> Subject: Re: [SPAM] [PATCH v3 00/14] Support PCIe RC to AST2600 and
> AST2700
>
> Hell Jamin,
>
> On 9/18/25 05:13, Jamin Lin wrote:
> > v1:
> > 1. Add PCIe PHY, CFG, and MMIO window support for AST2600.
> > Note: Only supports RC_H.
> > 2. Add PCIe PHY, CFG, and MMIO window support for AST2700.
> > Note: Supports 3 RCs.
> >
> > v2:
> > 1. Introduce a new root port device.
> > 2. For AST2600 RC_H, add the root device at 80:00.0 and a root port at
> 80.08.0
> > to match the real hardware topology, allowing users to attach PCIe
> devices
> > at the root port.
> > 3. For AST2700, add a root port at 00.00.0 for each PCIe root complex to
> match
> > the real hardware topology, allowing users to attach PCIe devices at
> the
> > root port.
> >
> > v3:
> > 1. Fix review issues.
> > 2. update functional test for the e1000e network card.
> > 3. update license header
> > 4. Adding "Based on previous work from Cedric Le Goater, with Jamin's
> summary
> > implementation.
>
> v3 looks good. I only had a few comments on memory allocation (g_autofree
> and MMIO alias regions) and on functional tests.
>
> v4 should be the last.
>
Thanks for your review and kindly support.
Will resend v4 very soon.
>
> >
> > Dependencies
> >
> > QEMU version:
> >
> https://github.com/qemu/qemu/commit/f0007b7f03e2d7fc33e71c3a582f2364
> c5
> > 1a226b
> >
> > This patch series depends on the following patch series:
> > 1. hw/arm/aspeed Move ast2700-evb alias to ast2700a1-evb
> > https://patchwork.kernel.org/project/qemu-devel/patch/20250902062550.3
> > 797040-1-jamin_lin@aspeedtech.com/
> > 2. tests/functional/arm: Update test images for ASPEED chips
> > https://patchwork.kernel.org/project/qemu-devel/cover/20250904100556.1
> > 729604-1-kane_chen@aspeedtech.com/
> > 3. tests/functional/arm: Add OTP functional test
> > https://patchwork.kernel.org/project/qemu-devel/cover/20250917035917.4
> > 141723-1-kane_chen@aspeedtech.com/
>
>
> There changes are in aspeed-next. You could use it as a reference in the cover
> letter.
>
Will update it in v4 cover letter.
Jamin
>
> Thanks,
>
> C.
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [SPAM] [PATCH v3 00/14] Support PCIe RC to AST2600 and AST2700
2025-09-18 9:08 ` Jamin Lin
@ 2025-09-18 9:30 ` Cédric Le Goater
2025-09-19 3:48 ` Jamin Lin
0 siblings, 1 reply; 29+ messages in thread
From: Cédric Le Goater @ 2025-09-18 9:30 UTC (permalink / raw)
To: Jamin Lin, Paolo Bonzini, Peter Maydell, Steven Lee, Troy Lee,
Andrew Jeffery, Joel Stanley, Michael S. Tsirkin,
Marcel Apfelbaum, open list:ARM TCG CPUs,
open list:All patches CC here
Cc: Troy Lee, nabihestefan@google.com, wuhaotsh@google.com,
titusr@google.com
On 9/18/25 11:08, Jamin Lin wrote:
> Hi Cédric
>
>> Subject: Re: [SPAM] [PATCH v3 00/14] Support PCIe RC to AST2600 and
>> AST2700
>>
>> Hell Jamin,
>>
>> On 9/18/25 05:13, Jamin Lin wrote:
>>> v1:
>>> 1. Add PCIe PHY, CFG, and MMIO window support for AST2600.
>>> Note: Only supports RC_H.
>>> 2. Add PCIe PHY, CFG, and MMIO window support for AST2700.
>>> Note: Supports 3 RCs.
>>>
>>> v2:
>>> 1. Introduce a new root port device.
>>> 2. For AST2600 RC_H, add the root device at 80:00.0 and a root port at
>> 80.08.0
>>> to match the real hardware topology, allowing users to attach PCIe
>> devices
>>> at the root port.
>>> 3. For AST2700, add a root port at 00.00.0 for each PCIe root complex to
>> match
>>> the real hardware topology, allowing users to attach PCIe devices at
>> the
>>> root port.
>>>
>>> v3:
>>> 1. Fix review issues.
>>> 2. update functional test for the e1000e network card.
>>> 3. update license header
>>> 4. Adding "Based on previous work from Cedric Le Goater, with Jamin's
>> summary
>>> implementation.
>>
>> v3 looks good. I only had a few comments on memory allocation (g_autofree
>> and MMIO alias regions) and on functional tests.
>>
>> v4 should be the last.
>>
>
> Thanks for your review and kindly support.
> Will resend v4 very soon.
One last thing, the list of PCI capabilities reported on real HW
is a little different. See below. When you have time, it would
be good to adjust the model if possible. It can come later.
Thanks,
C.
root@ast2600-default:~# lspci -vvv
80:00.0 Host bridge: ASPEED Technology, Inc. Device 2600
Subsystem: ASPEED Technology, Inc. Device 2600
Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
Latency: 0
80:08.0 PCI bridge: ASPEED Technology, Inc. AST1150 PCI-to-PCI Bridge (rev 06) (prog-if 00 [Normal decode])
Subsystem: ASPEED Technology, Inc. AST1150 PCI-to-PCI Bridge
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr+ Stepping- SERR+ FastB2B- DisINTx+
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
Latency: 0, Cache Line Size: 64 bytes
Interrupt: pin A routed to IRQ 82
Bus: primary=80, secondary=81, subordinate=81, sec-latency=0
I/O behind bridge: 1000-1fff [size=4K] [16-bit]
Memory behind bridge: 70000000-700fffff [size=1M] [32-bit]
Prefetchable memory behind bridge: 00000000fff00000-00000000000fffff [disabled] [64-bit]
Secondary status: 66MHz+ FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort+ <SERR- <PERR-
BridgeCtl: Parity+ SERR+ NoISA- VGA- VGA16- MAbort- >Reset- FastB2B-
PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn-
Capabilities: [50] MSI: Enable+ Count=1/1 Maskable- 64bit+
Address: 000000001e77005c Data: 0000
Capabilities: [78] Power Management version 3
Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=375mA PME(D0+,D1+,D2+,D3hot+,D3cold+)
Status: D0 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME-
Capabilities: [80] Express (v2) Root Port (Slot-), IntMsgNum 0
DevCap: MaxPayload 512 bytes, PhantFunc 0
ExtTag+ RBE+ TEE-IO-
DevCtl: CorrErr- NonFatalErr- FatalErr- UnsupReq-
RlxdOrd+ ExtTag+ PhantFunc- AuxPwr- NoSnoop+
MaxPayload 128 bytes, MaxReadReq 512 bytes
DevSta: CorrErr- NonFatalErr- FatalErr- UnsupReq- AuxPwr+ TransPend-
LnkCap: Port #0, Speed 5GT/s, Width x1, ASPM L0s L1, Exit Latency L0s <1us, L1 <64us
ClockPM- Surprise- LLActRep- BwNot+ ASPMOptComp+
LnkCtl: ASPM Disabled; RCB 64 bytes, LnkDisable- CommClk-
ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
LnkSta: Speed 2.5GT/s, Width x1
TrErr- Train- SlotClk+ DLActive- BWMgmt- ABWMgmt-
RootCap: CRSVisible-
RootCtl: ErrCorrectable- ErrNon-Fatal- ErrFatal- PMEIntEna+ CRSVisible-
RootSta: PME ReqID 0000, PMEStatus- PMEPending-
DevCap2: Completion Timeout: Range ABCD, TimeoutDis+ NROPrPrP- LTR-
10BitTagComp- 10BitTagReq- OBFF Not Supported, ExtFmt- EETLPPrefix-
EmergencyPowerReduction Not Supported, EmergencyPowerReductionInit-
FRS- LN System CLS Not Supported, TPHComp- ExtTPHComp- ARIFwd-
AtomicOpsCap: Routing- 32bit- 64bit- 128bitCAS-
DevCtl2: Completion Timeout: 50us to 50ms, TimeoutDis- ARIFwd-
AtomicOpsCtl: ReqEn- EgressBlck-
IDOReq- IDOCompl- LTR- EmergencyPowerReductionReq-
10BitTagReq- OBFF Disabled, EETLPPrefixBlk-
LnkCtl2: Target Link Speed: 5GT/s, EnterCompliance- SpeedDis-
Transmit Margin: Normal Operating Range, EnterModifiedCompliance- ComplianceSOS-
Compliance Preset/De-emphasis: -6dB de-emphasis, 0dB preshoot
LnkSta2: Current De-emphasis Level: -3.5dB, EqualizationComplete- EqualizationPhase1-
EqualizationPhase2- EqualizationPhase3- LinkEqualizationRequest-
Retimer- 2Retimers- CrosslinkRes: unsupported
Capabilities: [c0] Subsystem: ASPEED Technology, Inc. AST1150 PCI-to-PCI Bridge
Capabilities: [100 v1] Virtual Channel
Caps: LPEVC=0 RefClk=100ns PATEntryBits=1
Arb: Fixed- WRR32- WRR64- WRR128-
Ctrl: ArbSelect=Fixed
Status: InProgress-
VC0: Caps: PATOffset=00 MaxTimeSlots=1 RejSnoopTrans-
Arb: Fixed- WRR32- WRR64- WRR128- TWRR128- WRR256-
Ctrl: Enable+ ID=0 ArbSelect=Fixed TC/VC=ff
Status: NegoPending- InProgress-
Capabilities: [800 v1] Advanced Error Reporting
UESta: DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt- RxOF- MalfTLP-
ECRC- UnsupReq- ACSViol- UncorrIntErr- BlockedTLP- AtomicOpBlocked- TLPBlockedErr-
PoisonTLPBlocked- DMWrReqBlocked- IDECheck- MisIDETLP- PCRC_CHECK- TLPXlatBlocked-
UEMsk: DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt- RxOF- MalfTLP-
ECRC- UnsupReq- ACSViol- UncorrIntErr- BlockedTLP- AtomicOpBlocked- TLPBlockedErr-
PoisonTLPBlocked- DMWrReqBlocked- IDECheck- MisIDETLP- PCRC_CHECK- TLPXlatBlocked-
UESvrt: DLP+ SDES+ TLP- FCP+ CmpltTO- CmpltAbrt- UnxCmplt- RxOF+ MalfTLP+
ECRC- UnsupReq- ACSViol- UncorrIntErr- BlockedTLP- AtomicOpBlocked- TLPBlockedErr-
PoisonTLPBlocked- DMWrReqBlocked- IDECheck- MisIDETLP- PCRC_CHECK- TLPXlatBlocked-
CESta: RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr- CorrIntErr- HeaderOF-
CEMsk: RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr+ CorrIntErr- HeaderOF-
AERCap: First Error Pointer: 00, ECRCGenCap- ECRCGenEn- ECRCChkCap- ECRCChkEn-
MultHdrRecCap- MultHdrRecEn- TLPPfxPres- HdrLogCap-
HeaderLog: 00000000 00000000 00000000 00000000
RootCmd: CERptEn- NFERptEn- FERptEn-
RootSta: CERcvd- MultCERcvd- UERcvd- MultUERcvd-
FirstFatal- NonFatalMsg- FatalMsg- IntMsgNum 0
ErrorSrc: ERR_COR: 0000 ERR_FATAL/NONFATAL: 0000
Kernel driver in use: pcieport
^ permalink raw reply [flat|nested] 29+ messages in thread
* RE: [SPAM] [PATCH v3 00/14] Support PCIe RC to AST2600 and AST2700
2025-09-18 9:30 ` Cédric Le Goater
@ 2025-09-19 3:48 ` Jamin Lin
2025-09-19 8:27 ` Aspeed backlog (was Re: [SPAM] [PATCH v3 00/14] Support PCIe RC to AST2600 and AST2700) Cédric Le Goater
0 siblings, 1 reply; 29+ messages in thread
From: Jamin Lin @ 2025-09-19 3:48 UTC (permalink / raw)
To: Cédric Le Goater, Paolo Bonzini, Peter Maydell, Steven Lee,
Troy Lee, Andrew Jeffery, Joel Stanley, Michael S. Tsirkin,
Marcel Apfelbaum, open list:ARM TCG CPUs,
open list:All patches CC here
Cc: Troy Lee, nabihestefan@google.com, wuhaotsh@google.com,
titusr@google.com
Hi Cédric
> Subject: Re: [SPAM] [PATCH v3 00/14] Support PCIe RC to AST2600 and
> AST2700
>
> On 9/18/25 11:08, Jamin Lin wrote:
> > Hi Cédric
> >
> >> Subject: Re: [SPAM] [PATCH v3 00/14] Support PCIe RC to AST2600 and
> >> AST2700
> >>
> >> Hell Jamin,
> >>
> >> On 9/18/25 05:13, Jamin Lin wrote:
> >>> v1:
> >>> 1. Add PCIe PHY, CFG, and MMIO window support for AST2600.
> >>> Note: Only supports RC_H.
> >>> 2. Add PCIe PHY, CFG, and MMIO window support for AST2700.
> >>> Note: Supports 3 RCs.
> >>>
> >>> v2:
> >>> 1. Introduce a new root port device.
> >>> 2. For AST2600 RC_H, add the root device at 80:00.0 and a root
> >>> port at
> >> 80.08.0
> >>> to match the real hardware topology, allowing users to attach
> >>> PCIe
> >> devices
> >>> at the root port.
> >>> 3. For AST2700, add a root port at 00.00.0 for each PCIe root
> >>> complex to
> >> match
> >>> the real hardware topology, allowing users to attach PCIe
> >>> devices at
> >> the
> >>> root port.
> >>>
> >>> v3:
> >>> 1. Fix review issues.
> >>> 2. update functional test for the e1000e network card.
> >>> 3. update license header
> >>> 4. Adding "Based on previous work from Cedric Le Goater, with
> >>> Jamin's
> >> summary
> >>> implementation.
> >>
> >> v3 looks good. I only had a few comments on memory allocation
> >> (g_autofree and MMIO alias regions) and on functional tests.
> >>
> >> v4 should be the last.
> >>
> >
> > Thanks for your review and kindly support.
> > Will resend v4 very soon.
>
> One last thing, the list of PCI capabilities reported on real HW is a little
> different. See below. When you have time, it would be good to adjust the
> model if possible. It can come later.
>
Thanks for the suggestion and for reporting this issue. I’ll add it to my working queue.
Here are the tasks currently in my queue:
1. Control coprocessor reset for AST2700
https://patchwork.kernel.org/project/qemu-devel/cover/20250717034054.1903991-1-jamin_lin@aspeedtech.com/
2. Analyze issue "func-arm-aspeed_ast2500 test occasionally times out"
https://gitlab.com/qemu-project/qemu/-/issues/3117
3. Adjust PCIe capabilities
3. Support AST2700 IPC model(may require refactoring the INTC model if needed)
4. Support AST2700 A2 (planned for end of this year or Q1 next year)
5. Support AST2700 boot from BootMCU(RISC-V) instead of vbootrom, if a single binary ready.
Thanks-Jamin
>
> Thanks,
>
> C.
>
>
>
> root@ast2600-default:~# lspci -vvv
> 80:00.0 Host bridge: ASPEED Technology, Inc. Device 2600
> Subsystem: ASPEED Technology, Inc. Device 2600
> Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop-
> ParErr- Stepping- SERR- FastB2B- DisINTx-
> Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
> <TAbort- <MAbort- >SERR- <PERR- INTx-
> Latency: 0
>
> 80:08.0 PCI bridge: ASPEED Technology, Inc. AST1150 PCI-to-PCI Bridge (rev 06)
> (prog-if 00 [Normal decode])
> Subsystem: ASPEED Technology, Inc. AST1150 PCI-to-PCI Bridge
> Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop-
> ParErr+ Stepping- SERR+ FastB2B- DisINTx+
> Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
> <TAbort- <MAbort- >SERR- <PERR- INTx-
> Latency: 0, Cache Line Size: 64 bytes
> Interrupt: pin A routed to IRQ 82
> Bus: primary=80, secondary=81, subordinate=81, sec-latency=0
> I/O behind bridge: 1000-1fff [size=4K] [16-bit]
> Memory behind bridge: 70000000-700fffff [size=1M] [32-bit]
> Prefetchable memory behind bridge: 00000000fff00000-00000000000fffff
> [disabled] [64-bit]
> Secondary status: 66MHz+ FastB2B- ParErr- DEVSEL=medium >TAbort-
> <TAbort- <MAbort+ <SERR- <PERR-
> BridgeCtl: Parity+ SERR+ NoISA- VGA- VGA16- MAbort- >Reset- FastB2B-
> PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn-
> Capabilities: [50] MSI: Enable+ Count=1/1 Maskable- 64bit+
> Address: 000000001e77005c Data: 0000
> Capabilities: [78] Power Management version 3
> Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=375mA
> PME(D0+,D1+,D2+,D3hot+,D3cold+)
> Status: D0 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME-
> Capabilities: [80] Express (v2) Root Port (Slot-), IntMsgNum 0
> DevCap: MaxPayload 512 bytes, PhantFunc 0
> ExtTag+ RBE+ TEE-IO-
> DevCtl: CorrErr- NonFatalErr- FatalErr- UnsupReq-
> RlxdOrd+ ExtTag+ PhantFunc- AuxPwr- NoSnoop+
> MaxPayload 128 bytes, MaxReadReq 512 bytes
> DevSta: CorrErr- NonFatalErr- FatalErr- UnsupReq- AuxPwr+
> TransPend-
> LnkCap: Port #0, Speed 5GT/s, Width x1, ASPM L0s L1, Exit Latency
> L0s <1us, L1 <64us
> ClockPM- Surprise- LLActRep- BwNot+ ASPMOptComp+
> LnkCtl: ASPM Disabled; RCB 64 bytes, LnkDisable- CommClk-
> ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
> LnkSta: Speed 2.5GT/s, Width x1
> TrErr- Train- SlotClk+ DLActive- BWMgmt- ABWMgmt-
> RootCap: CRSVisible-
> RootCtl: ErrCorrectable- ErrNon-Fatal- ErrFatal- PMEIntEna+
> CRSVisible-
> RootSta: PME ReqID 0000, PMEStatus- PMEPending-
> DevCap2: Completion Timeout: Range ABCD, TimeoutDis+
> NROPrPrP- LTR-
> 10BitTagComp- 10BitTagReq- OBFF Not Supported, ExtFmt-
> EETLPPrefix-
> EmergencyPowerReduction Not Supported,
> EmergencyPowerReductionInit-
> FRS- LN System CLS Not Supported, TPHComp- ExtTPHComp-
> ARIFwd-
> AtomicOpsCap: Routing- 32bit- 64bit- 128bitCAS-
> DevCtl2: Completion Timeout: 50us to 50ms, TimeoutDis- ARIFwd-
> AtomicOpsCtl: ReqEn- EgressBlck-
> IDOReq- IDOCompl- LTR- EmergencyPowerReductionReq-
> 10BitTagReq- OBFF Disabled, EETLPPrefixBlk-
> LnkCtl2: Target Link Speed: 5GT/s, EnterCompliance- SpeedDis-
> Transmit Margin: Normal Operating Range,
> EnterModifiedCompliance- ComplianceSOS-
> Compliance Preset/De-emphasis: -6dB de-emphasis, 0dB
> preshoot
> LnkSta2: Current De-emphasis Level: -3.5dB, EqualizationComplete-
> EqualizationPhase1-
> EqualizationPhase2- EqualizationPhase3-
> LinkEqualizationRequest-
> Retimer- 2Retimers- CrosslinkRes: unsupported
> Capabilities: [c0] Subsystem: ASPEED Technology, Inc. AST1150 PCI-to-PCI
> Bridge
> Capabilities: [100 v1] Virtual Channel
> Caps: LPEVC=0 RefClk=100ns PATEntryBits=1
> Arb: Fixed- WRR32- WRR64- WRR128-
> Ctrl: ArbSelect=Fixed
> Status: InProgress-
> VC0: Caps: PATOffset=00 MaxTimeSlots=1 RejSnoopTrans-
> Arb: Fixed- WRR32- WRR64- WRR128- TWRR128- WRR256-
> Ctrl: Enable+ ID=0 ArbSelect=Fixed TC/VC=ff
> Status: NegoPending- InProgress-
> Capabilities: [800 v1] Advanced Error Reporting
> UESta: DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt-
> RxOF- MalfTLP-
> ECRC- UnsupReq- ACSViol- UncorrIntErr- BlockedTLP-
> AtomicOpBlocked- TLPBlockedErr-
> PoisonTLPBlocked- DMWrReqBlocked- IDECheck- MisIDETLP-
> PCRC_CHECK- TLPXlatBlocked-
> UEMsk: DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt-
> RxOF- MalfTLP-
> ECRC- UnsupReq- ACSViol- UncorrIntErr- BlockedTLP-
> AtomicOpBlocked- TLPBlockedErr-
> PoisonTLPBlocked- DMWrReqBlocked- IDECheck- MisIDETLP-
> PCRC_CHECK- TLPXlatBlocked-
> UESvrt: DLP+ SDES+ TLP- FCP+ CmpltTO- CmpltAbrt- UnxCmplt-
> RxOF+ MalfTLP+
> ECRC- UnsupReq- ACSViol- UncorrIntErr- BlockedTLP-
> AtomicOpBlocked- TLPBlockedErr-
> PoisonTLPBlocked- DMWrReqBlocked- IDECheck- MisIDETLP-
> PCRC_CHECK- TLPXlatBlocked-
> CESta: RxErr- BadTLP- BadDLLP- Rollover- Timeout-
> AdvNonFatalErr- CorrIntErr- HeaderOF-
> CEMsk: RxErr- BadTLP- BadDLLP- Rollover- Timeout-
> AdvNonFatalErr+ CorrIntErr- HeaderOF-
> AERCap: First Error Pointer: 00, ECRCGenCap- ECRCGenEn-
> ECRCChkCap- ECRCChkEn-
> MultHdrRecCap- MultHdrRecEn- TLPPfxPres- HdrLogCap-
> HeaderLog: 00000000 00000000 00000000 00000000
> RootCmd: CERptEn- NFERptEn- FERptEn-
> RootSta: CERcvd- MultCERcvd- UERcvd- MultUERcvd-
> FirstFatal- NonFatalMsg- FatalMsg- IntMsgNum 0
> ErrorSrc: ERR_COR: 0000 ERR_FATAL/NONFATAL: 0000
> Kernel driver in use: pcieport
>
>
^ permalink raw reply [flat|nested] 29+ messages in thread
* Aspeed backlog (was Re: [SPAM] [PATCH v3 00/14] Support PCIe RC to AST2600 and AST2700)
2025-09-19 3:48 ` Jamin Lin
@ 2025-09-19 8:27 ` Cédric Le Goater
2025-09-19 9:39 ` Jamin Lin
0 siblings, 1 reply; 29+ messages in thread
From: Cédric Le Goater @ 2025-09-19 8:27 UTC (permalink / raw)
To: Jamin Lin, Paolo Bonzini, Peter Maydell, Steven Lee, Troy Lee,
Andrew Jeffery, Joel Stanley, Michael S. Tsirkin,
Marcel Apfelbaum, open list:ARM TCG CPUs,
open list:All patches CC here
Cc: Troy Lee, nabihestefan@google.com, wuhaotsh@google.com,
titusr@google.com
Hello Jamin,
>> One last thing, the list of PCI capabilities reported on real HW is a little
>> different. See below. When you have time, it would be good to adjust the
>> model if possible. It can come later.
>>
>
> Thanks for the suggestion and for reporting this issue. I’ll add it to my working queue.
> Here are the tasks currently in my queue:
>
> 1. Control coprocessor reset for AST2700
> https://patchwork.kernel.org/project/qemu-devel/cover/20250717034054.1903991-1-jamin_lin@aspeedtech.com/
This needs a rework of the co processor models. This should be QEMU 10.2
material IMO.
> 2. Analyze issue "func-arm-aspeed_ast2500 test occasionally times out"
> https://gitlab.com/qemu-project/qemu/-/issues/3117
> 3. Adjust PCIe capabilities
> 3. Support AST2700 IPC model(may require refactoring the INTC model if needed)
> 4. Support AST2700 A2 (planned for end of this year or Q1 next year)
> 5. Support AST2700 boot from BootMCU(RISC-V) instead of vbootrom, if a single binary ready.
It would be great if Troy (?) could resend the models, it's good to have
since single binary is making progress.
Also, these changes may be of interest, they need review :
- usb/uhci: Add UHCI sysbus support, and enable for AST (Guenter Roeck)
https://lore.kernel.org//qemu-devel/20241112170152.217664-1-linux@roeck-us.net
Looks really good. Needs reviewers and stakeholders.
- i3c: aspeed: Add I3C support (Joe Komlodi)
https://lore.kernel.org//qemu-devel/20250613000411.1516521-1-komlodi@google.com
Looks good overall. Needs reviewers and stakeholders.
- Add Aspeed GPIO test and Support Nuvoton Serial GPIO (Coco Li)
https://lore.kernel.org//qemu-devel/20250903213809.3779860-1-lixiaoyan@google.com
Needs reviewers
- hw/arm/aspeed: AST1700 IO expander support for (Kane-Chen-AS)
https://lore.kernel.org//qemu-devel/20250917013143.1600377-1-kane_chen@aspeedtech.com
Needs rework. I will comment more when time permits
Thanks,
C.
^ permalink raw reply [flat|nested] 29+ messages in thread* RE: Aspeed backlog (was Re: [SPAM] [PATCH v3 00/14] Support PCIe RC to AST2600 and AST2700)
2025-09-19 8:27 ` Aspeed backlog (was Re: [SPAM] [PATCH v3 00/14] Support PCIe RC to AST2600 and AST2700) Cédric Le Goater
@ 2025-09-19 9:39 ` Jamin Lin
0 siblings, 0 replies; 29+ messages in thread
From: Jamin Lin @ 2025-09-19 9:39 UTC (permalink / raw)
To: Cédric Le Goater, Paolo Bonzini, Peter Maydell, Steven Lee,
Troy Lee, Andrew Jeffery, Joel Stanley, Michael S. Tsirkin,
Marcel Apfelbaum, open list:ARM TCG CPUs,
open list:All patches CC here
Cc: Troy Lee, nabihestefan@google.com, wuhaotsh@google.com,
titusr@google.com
Hi Cédric
> Subject: Aspeed backlog (was Re: [SPAM] [PATCH v3 00/14] Support PCIe RC to
> AST2600 and AST2700)
>
> Hello Jamin,
>
> >> One last thing, the list of PCI capabilities reported on real HW is a
> >> little different. See below. When you have time, it would be good to
> >> adjust the model if possible. It can come later.
> >>
> >
> > Thanks for the suggestion and for reporting this issue. I’ll add it to my
> working queue.
> > Here are the tasks currently in my queue:
> >
> > 1. Control coprocessor reset for AST2700
> > https://patchwork.kernel.org/project/qemu-devel/cover/20250717034054.1
> > 903991-1-jamin_lin@aspeedtech.com/
>
> This needs a rework of the co processor models. This should be QEMU 10.2
> material IMO.
Yes, I am reworking it, and I will discuss with you within this patch series if I have any questions during the rework.
>
> > 2. Analyze issue "func-arm-aspeed_ast2500 test occasionally times out"
> > https://gitlab.com/qemu-project/qemu/-/issues/3117
> > 3. Adjust PCIe capabilities
> > 3. Support AST2700 IPC model(may require refactoring the INTC model if
> > needed) 4. Support AST2700 A2 (planned for end of this year or Q1 next
> > year) 5. Support AST2700 boot from BootMCU(RISC-V) instead of vbootrom,
> if a single binary ready.
>
> It would be great if Troy (?) could resend the models, it's good to have since
> single binary is making progress.
>
I will organize and send out Troy’s patch for the AST2700 BootMCU.
So far, we have only tested it up to running SPL with qemu-system-riscv32.
Thanks-Jamin
>
>
> Also, these changes may be of interest, they need review :
>
> - usb/uhci: Add UHCI sysbus support, and enable for AST (Guenter Roeck)
>
> https://lore.kernel.org//qemu-devel/20241112170152.217664-1-linux@roeck-u
> s.net
>
> Looks really good. Needs reviewers and stakeholders.
>
> - i3c: aspeed: Add I3C support (Joe Komlodi)
>
> https://lore.kernel.org//qemu-devel/20250613000411.1516521-1-komlodi@go
> ogle.com
>
> Looks good overall. Needs reviewers and stakeholders.
>
> - Add Aspeed GPIO test and Support Nuvoton Serial GPIO (Coco Li)
>
> https://lore.kernel.org//qemu-devel/20250903213809.3779860-1-lixiaoyan@g
> oogle.com
>
> Needs reviewers
>
> - hw/arm/aspeed: AST1700 IO expander support for (Kane-Chen-AS)
>
> https://lore.kernel.org//qemu-devel/20250917013143.1600377-1-kane_chen@
> aspeedtech.com
>
> Needs rework. I will comment more when time permits
>
>
> Thanks,
>
> C.
^ permalink raw reply [flat|nested] 29+ messages in thread