From: Peter Crosthwaite <crosthwaitepeter@gmail.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
pbonzini@redhat.com,
Peter Crosthwaite <crosthwaite.peter@gmail.com>
Subject: [Qemu-devel] [PATCH v1 3/6] arm: cpu: static inline cpu_arm_init()
Date: Mon, 26 Oct 2015 08:27:25 -0700 [thread overview]
Message-ID: <3b45270a4854d8868dc649bd41c72cfcb3dffd7b.1445842804.git.crosthwaite.peter@gmail.com> (raw)
In-Reply-To: <cover.1445842804.git.crosthwaite.peter@gmail.com>
In-Reply-To: <cover.1445842804.git.crosthwaite.peter@gmail.com>
Move this implementation up to the header so it is visible from system
level code once the architecture is converted to arch-obj-y. Alternative
would be to create init.c in target-arm/hw but this implementation is
trivial enough for static inline.
Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
---
target-arm/cpu.h | 6 +++++-
target-arm/helper.c | 5 -----
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/target-arm/cpu.h b/target-arm/cpu.h
index 4b702df..6b6485b 100644
--- a/target-arm/cpu.h
+++ b/target-arm/cpu.h
@@ -509,7 +509,11 @@ typedef struct CPUARMState {
#include "cpu-qom.h"
-ARMCPU *cpu_arm_init(const char *cpu_model);
+static inline ARMCPU *cpu_arm_init(const char *cpu_model)
+{
+ return ARM_CPU(cpu_generic_init(TYPE_ARM_CPU, cpu_model));
+}
+
target_ulong do_arm_semihosting(CPUARMState *env);
void aarch64_sync_32_to_64(CPUARMState *env);
void aarch64_sync_64_to_32(CPUARMState *env);
diff --git a/target-arm/helper.c b/target-arm/helper.c
index e7fda37..3118267 100644
--- a/target-arm/helper.c
+++ b/target-arm/helper.c
@@ -4501,11 +4501,6 @@ void register_cp_regs_for_features(ARMCPU *cpu)
}
}
-ARMCPU *cpu_arm_init(const char *cpu_model)
-{
- return ARM_CPU(cpu_generic_init(TYPE_ARM_CPU, cpu_model));
-}
-
void arm_cpu_register_gdb_regs_for_features(ARMCPU *cpu)
{
CPUState *cs = CPU(cpu);
--
1.9.1
next prev parent reply other threads:[~2015-10-26 15:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 15:27 [Qemu-devel] [PATCH v1 0/6] Multi-Arch Phase 2 Peter Crosthwaite
2015-10-26 15:27 ` [Qemu-devel] [PATCH v1 1/6] target-*: Don't redefine cpu_exec() Peter Crosthwaite
2015-10-26 15:27 ` [Qemu-devel] [PATCH v1 2/6] target-*: cpu.h: Undefine core code symbols Peter Crosthwaite
2015-10-26 15:27 ` Peter Crosthwaite [this message]
2015-10-26 15:27 ` [Qemu-devel] [PATCH v1 4/6] target-arm: Split cp helper API to new C file Peter Crosthwaite
2015-10-26 15:27 ` [Qemu-devel] [PATCH v1 5/6] hw: arm: Explicitly include cpu.h for consumers Peter Crosthwaite
2015-10-26 15:27 ` [Qemu-devel] [PATCH v1 6/6] hw: mb: boot " Peter Crosthwaite
2015-10-26 15:34 ` [Qemu-devel] [PATCH v1 0/6] Multi-Arch Phase 2 Paolo Bonzini
2015-10-26 16:01 ` Peter Maydell
2015-10-26 16:43 ` Peter Crosthwaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b45270a4854d8868dc649bd41c72cfcb3dffd7b.1445842804.git.crosthwaite.peter@gmail.com \
--to=crosthwaitepeter@gmail.com \
--cc=crosthwaite.peter@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).