From: Laurent Vivier <laurent@vivier.eu>
To: Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org, Laurent Vivier <lvivier@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Juan Quintela <quintela@redhat.com>,
qemu-trivial@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] tests: Do not use "\n" in g_test_message() strings
Date: Wed, 6 Mar 2019 10:15:48 +0100 [thread overview]
Message-ID: <3b4ca6e3-f1dc-e99c-c0f9-866608e5da3b@vivier.eu> (raw)
In-Reply-To: <1551457277-884-1-git-send-email-thuth@redhat.com>
On 01/03/2019 17:21, Thomas Huth wrote:
> g_test_message() takes care of the newline on its own, so we
> should not use \n in the strings here.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/ivshmem-test.c | 4 ++--
> tests/m48t59-test.c | 4 ++--
> tests/migration-test.c | 4 ++--
> tests/rtc-test.c | 4 ++--
> tests/rtl8139-test.c | 6 +++---
> tests/test-aio-multithread.c | 8 ++++----
> tests/test-coroutine.c | 10 ++++------
> tests/vhost-user-test.c | 14 +++++++-------
> 8 files changed, 26 insertions(+), 28 deletions(-)
The tests/vhost-user-test.c part doesn't apply cleanly on top of master.
Could you resend?
Thanks,
Laurent
prev parent reply other threads:[~2019-03-06 9:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 16:21 [Qemu-devel] [PATCH] tests: Do not use "\n" in g_test_message() strings Thomas Huth
2019-03-04 7:18 ` Markus Armbruster
2019-03-05 17:25 ` Stefan Hajnoczi
2019-03-06 9:15 ` Laurent Vivier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b4ca6e3-f1dc-e99c-c0f9-866608e5da3b@vivier.eu \
--to=laurent@vivier.eu \
--cc=dgilbert@redhat.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).