From: Paolo Bonzini <pbonzini@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, jcody@redhat.com,
Stefan Hajnoczi <stefanha@redhat.com>,
Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.9-rc5 v3] block: Drain BH in bdrv_drained_begin
Date: Tue, 18 Apr 2017 14:36:45 +0200 [thread overview]
Message-ID: <3b51de74-0d1b-ebae-1b98-fa74d028c982@redhat.com> (raw)
In-Reply-To: <20170418103948.13965-1-famz@redhat.com>
On 18/04/2017 12:39, Fam Zheng wrote:
> + QLIST_FOREACH_SAFE(child, &bs->children, next, tmp) {
> + BlockDriverState *bs = child->bs;
> + assert(bs->refcnt > 0);
> + bdrv_ref(bs);
> + waited |= bdrv_drain_recurse(bs);
> + bdrv_unref(bs);
> }
I think this accesses global state that is not protected by the
AioContext lock?
Paolo
next prev parent reply other threads:[~2017-04-18 12:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 10:39 [Qemu-devel] [PATCH for-2.9-rc5 v3] block: Drain BH in bdrv_drained_begin Fam Zheng
2017-04-18 10:53 ` Kevin Wolf
2017-04-18 11:21 ` Jeff Cody
2017-04-18 12:36 ` Paolo Bonzini [this message]
2017-04-18 13:46 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b51de74-0d1b-ebae-1b98-fa74d028c982@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).