From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSIu2-0001RX-Pg for qemu-devel@nongnu.org; Wed, 27 Jul 2016 03:05:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSItz-0006ge-IL for qemu-devel@nongnu.org; Wed, 27 Jul 2016 03:05:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51048) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSItz-0006gU-Ac for qemu-devel@nongnu.org; Wed, 27 Jul 2016 03:05:11 -0400 References: <1467714580-17581-1-git-send-email-zhangchen.fnst@cn.fujitsu.com> From: Jason Wang Message-ID: <3b6da64b-3612-f16d-c3b0-75b50fa9a10c@redhat.com> Date: Wed, 27 Jul 2016 15:05:05 +0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC PATCH V3 0/3] filter-rewriter: introduce filter-rewriter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhang Chen , qemu devel Cc: "eddie . dong" , Li Zhijian On 2016=E5=B9=B407=E6=9C=8827=E6=97=A5 13:49, Zhang Chen wrote: > > > On 07/27/2016 10:50 AM, Jason Wang wrote: >> >> >> On 2016=E5=B9=B407=E6=9C=8827=E6=97=A5 10:32, Zhang Chen wrote: >>> Hi~ all~~ >>> >>> Anyone have some comments for this series? >> >> Will have a look at this. >> >> Btw. I wonder how this is tested, do we need a unit test for this? > > COLO-compare and filter-rewriter works normal depend on colo-frame. > So, When colo-frame be merged I will send a colo-proxy unit test > for all filter-mirror,filter-redirector,colo-compare,filter-rewriter. Sounds cool. > > >> >>> >>> We need more comments to improve COLO codes. >>> >>> >>> Thanks >>> >>> Zhang Chen >>> >>> >>> On 07/05/2016 06:29 PM, Zhang Chen wrote: >>>> Filter-rewriter is a part of COLO project. >>>> So this patch set depend on colo-compare. >> >> Interesting, I thought it can co-work with comparing, and the=20 >> communication were done through socket now. So I think technically=20 >> the filter itself could work without COLO? > > Filter-rewriter can run without COLO, but it no sense for other people. > rewriter need TX tcp packet differ with RX tcp packet... > In normal qemu we can't get the environment same with COLO. > Then I suggest to add this to the colo comparing series. > >> >>>> It will rewrite some of secondary packet to make >>>> secondary guest's connection established successfully. >>>> In this module we will rewrite tcp packet's ack to the secondary >>>> from primary,and rewrite tcp packet's seq to the primary from >>>> secondary. >>>> >>>> v3: >>>> - fix typo >>>> - add conn->syn_flag >>>> - add some comments >>>> - remove conn_list_lock >>>> - fix offset set bug >> >> I think you can remove RFC in the next version so we can try to merge=20 >> it after one or several other iterations. > > OK~~ I will remove RFC in colo-compare and filter-rewriter. > > Thanks for your review~~ > Zhang Chen > >> >> Thanks >> >>>> >>>> v2: >>>> - add more comments about packet flows >>>> - add some trace-event >>>> - add seq offset ( =3D secondary_seq - primary_seq) >>>> >>>> v1: >>>> - initial patch >>>> >>>> Zhang Chen (3): >>>> filter-rewriter: introduce filter-rewriter initialization >>>> filter-rewriter: track connection and parse packet >>>> filter-rewriter: rewrite tcp packet to keep secondary connection >>>> >>>> net/Makefile.objs | 1 + >>>> net/colo-base.c | 2 + >>>> net/colo-base.h | 7 ++ >>>> net/filter-rewriter.c | 262=20 >>>> ++++++++++++++++++++++++++++++++++++++++++++++++++ >>>> qemu-options.hx | 13 +++ >>>> trace-events | 5 + >>>> vl.c | 3 +- >>>> 7 files changed, 292 insertions(+), 1 deletion(-) >>>> create mode 100644 net/filter-rewriter.c >>>> >>> >> >> >> >> . >> >