From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Manos Pitsidianakis <el13635@mail.ntua.gr>,
qemu-devel <qemu-devel@nongnu.org>
Cc: Kevin Wolf <kwolf@redhat.com>, Alberto Garcia <berto@igalia.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-block <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/2] block: use internal filter node in backup
Date: Tue, 15 Aug 2017 10:44:15 +0300 [thread overview]
Message-ID: <3b7fc9da-ac71-8a37-ed3d-34428021e4d3@virtuozzo.com> (raw)
In-Reply-To: <20170815061921.31596-2-el13635@mail.ntua.gr>
15.08.2017 09:19, Manos Pitsidianakis wrote:
> block/backup.c currently uses before write notifiers on the targeted
> node. We can create a filter node instead to intercept write requests
> for the backup job on the BDS level, instead of the BlockBackend level.
>
Hi Manos!
Looks interesting but what is the real benefit of it? It doesn't look
like it simplifies the code.. Also, is it affect performance?
I think it worth describing in commit message.
--
Best regards,
Vladimir
next prev parent reply other threads:[~2017-08-15 7:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 6:19 [Qemu-devel] [PATCH 0/2] add internal backup job and write-threshold filter drivers Manos Pitsidianakis
2017-08-15 6:19 ` [Qemu-devel] [PATCH 1/2] block: use internal filter node in backup Manos Pitsidianakis
2017-08-15 7:44 ` Vladimir Sementsov-Ogievskiy [this message]
2017-08-15 7:52 ` Manos Pitsidianakis
2017-08-15 6:19 ` [Qemu-devel] [PATCH 2/2] block: add filter driver to block/write-threshold.c Manos Pitsidianakis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b7fc9da-ac71-8a37-ed3d-34428021e4d3@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=berto@igalia.com \
--cc=el13635@mail.ntua.gr \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).