From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhWXH-0001L4-Un for qemu-devel@nongnu.org; Tue, 15 Aug 2017 03:45:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhWXC-0005Tm-IO for qemu-devel@nongnu.org; Tue, 15 Aug 2017 03:45:12 -0400 References: <20170815061921.31596-1-el13635@mail.ntua.gr> <20170815061921.31596-2-el13635@mail.ntua.gr> From: Vladimir Sementsov-Ogievskiy Message-ID: <3b7fc9da-ac71-8a37-ed3d-34428021e4d3@virtuozzo.com> Date: Tue, 15 Aug 2017 10:44:15 +0300 MIME-Version: 1.0 In-Reply-To: <20170815061921.31596-2-el13635@mail.ntua.gr> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [Qemu-devel] [PATCH 1/2] block: use internal filter node in backup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Manos Pitsidianakis , qemu-devel Cc: Kevin Wolf , Alberto Garcia , Stefan Hajnoczi , qemu-block 15.08.2017 09:19, Manos Pitsidianakis wrote: > block/backup.c currently uses before write notifiers on the targeted > node. We can create a filter node instead to intercept write requests > for the backup job on the BDS level, instead of the BlockBackend level. > Hi Manos! Looks interesting but what is the real benefit of it? It doesn't look like it simplifies the code.. Also, is it affect performance? I think it worth describing in commit message. -- Best regards, Vladimir