From: Richard Henderson <richard.henderson@linaro.org>
To: Taylor Simpson <tsimpson@quicinc.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "philmd@linaro.org" <philmd@linaro.org>,
"ale@rev.ng" <ale@rev.ng>, "anjo@rev.ng" <anjo@rev.ng>,
Brian Cain <bcain@quicinc.com>,
"Matheus Bernardino (QUIC)" <quic_mathbern@quicinc.com>
Subject: Re: [PATCH 08/21] Hexagon (target/hexagon) Clean up pred_written usage
Date: Thu, 27 Apr 2023 08:37:58 +0100 [thread overview]
Message-ID: <3b87ac4d-89b5-b508-9a8b-f1ffde6942a7@linaro.org> (raw)
In-Reply-To: <SN4PR0201MB8808836FFB4552CC5BB90215DE659@SN4PR0201MB8808.namprd02.prod.outlook.com>
On 4/26/23 22:27, Taylor Simpson wrote:
>>> We remove the last use of check_for_attrib. However, new uses will be
>>> introduced later in this series, so we change it to "static inline".
>>
>> This is insufficient -- clang will warn about unused inline functions within the
>> main C file (as opposed to #included).
>>
>> Use __attribute__((unused)) instead, and remove it when it gains new
>> unconditional uses.
>
> Is it OK to use the attribute itself or is G_GNUC_UNUSED preferred?
I've been using the attribute itself in my patches, e.g.
https://lore.kernel.org/qemu-devel/20230424054105.1579315-1-richard.henderson@linaro.org/T/#mb07f0d1393f7f0a252f459dca6a91a2162581281
But either is fine with me.
r~
prev parent reply other threads:[~2023-04-27 7:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 0:42 [PATCH 08/21] Hexagon (target/hexagon) Clean up pred_written usage Taylor Simpson
2023-04-26 21:23 ` Richard Henderson
2023-04-26 21:27 ` Taylor Simpson
2023-04-27 7:37 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b87ac4d-89b5-b508-9a8b-f1ffde6942a7@linaro.org \
--to=richard.henderson@linaro.org \
--cc=ale@rev.ng \
--cc=anjo@rev.ng \
--cc=bcain@quicinc.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_mathbern@quicinc.com \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).