Re: [Qemu-devel] [PULL 00/79] Misc QEMU patches for 2018-09-30

Re: [Qemu-devel] [PULL 00/79] Misc QEMU patches for 2018-09-30

[Alex Bennée]

Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> On 9/30/18 4:58 PM, Peter Maydell wrote:
>> On 30 September 2018 at 15:54, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>>> Paolo, thanks for queuing all of this, however I note some UTF-8 issues.
>>>
>>> Alex got lucky:
>>>
>>>  Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
<snip>
>>>  Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>>  Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
<snip>
>     Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
<snip>
>
> Reviewed-by: Andreas Färber <afaerber@suse.de>
> Reviewed-by: Andreas F=E4rber <afaerber@suse.de>
> Reviewed-by: Andreas F=C3=A4rber <afaerber@suse.de>
> ...
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
> Signed-off-by: Herv? Poussineau <hpoussin@reactos.org>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>

We should form a club ;-)

--
Alex Bennée

Re: [Qemu-devel] [PULL 00/79] Misc QEMU patches for 2018-09-30

[Paolo Bonzini]

On 30/09/2018 16:54, Philippe Mathieu-Daudé wrote:
> Hi Paolo, Peter.
> 
> On 9/30/18 10:11 AM, Paolo Bonzini wrote:
>> The following changes since commit 042938f46e1c477419d1931381fdadffaa49d45e:
>>
>>   Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20180926a' into staging (2018-09-28 17:07:23 +0100)
>>
>> are available in the git repository at:
>>
>>
>>   git://github.com/bonzini/qemu.git tags/for-upstream
>>
>> for you to fetch changes up to 54b570779677ff8620a79ed81ddf0906b1d23f4e:
>>
>>   hw/scsi/mptendian: Avoid taking address of fields in packed structs (2018-09-30 10:08:28 +0200)
>>
>> ----------------------------------------------------------------
>> * configure fix for environment variables (Daniel)
>> * fix memory leaks (Alex)
>> * x86_64 MTTCG (Emilio)
>> * introduce atomic64 (Emilio)
>> * Fix for virtio hang (Fam, myself)
>> * SH serial port fix (Geert)
>> * Deprecate rotation_rate for scsi-block (Fam)
>> * Extend memory-backend-file availability to all POSIX hosts (Hikaru)
>> * Memory API cleanups and fixes (Igor, Li Qiang, Peter, Philippe)
>> * MSI/IOMMU fix (Jan)
>> * Socket reconnection fixes (Marc-André)
>> * icount fixes (Emilio, myself)
>> * QSP fixes for Coverity (myself)
>> * Some record/replay improovements (Pavel)
>> * Packed struct fixes (Peter)
>> * Windows dump fixes and elf2dmp (Viktor)
>> * kbmclock fix (Yongji)
> 
> Paolo, thanks for queuing all of this, however I note some UTF-8 issues.
> 
> Alex got lucky:
> 
>  Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> 
> But Marc-André and myself have:
> 
>  Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>  Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

I'll fix it.  In the meanwhile, I'll note that we're also improving
Patchew so that it is much better at applying patches via three-way
merge (basically the adding of *-by tags moves from "patchew apply" to
the web stuff) and that should make these UTF-8 issues a thing of the past.

Paolo

Re: [Qemu-devel] [PULL 00/79] Misc QEMU patches for 2018-09-30

[Philippe Mathieu-Daudé]

On 10/1/18 10:11 AM, Paolo Bonzini wrote:
> On 30/09/2018 16:54, Philippe Mathieu-Daudé wrote:
>> Hi Paolo, Peter.
>>
>> On 9/30/18 10:11 AM, Paolo Bonzini wrote:
>>> The following changes since commit 042938f46e1c477419d1931381fdadffaa49d45e:
>>>
>>>   Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20180926a' into staging (2018-09-28 17:07:23 +0100)
>>>
>>> are available in the git repository at:
>>>
>>>
>>>   git://github.com/bonzini/qemu.git tags/for-upstream
>>>
>>> for you to fetch changes up to 54b570779677ff8620a79ed81ddf0906b1d23f4e:
>>>
>>>   hw/scsi/mptendian: Avoid taking address of fields in packed structs (2018-09-30 10:08:28 +0200)
>>>
>>> ----------------------------------------------------------------
>>> * configure fix for environment variables (Daniel)
>>> * fix memory leaks (Alex)
>>> * x86_64 MTTCG (Emilio)
>>> * introduce atomic64 (Emilio)
>>> * Fix for virtio hang (Fam, myself)
>>> * SH serial port fix (Geert)
>>> * Deprecate rotation_rate for scsi-block (Fam)
>>> * Extend memory-backend-file availability to all POSIX hosts (Hikaru)
>>> * Memory API cleanups and fixes (Igor, Li Qiang, Peter, Philippe)
>>> * MSI/IOMMU fix (Jan)
>>> * Socket reconnection fixes (Marc-André)
>>> * icount fixes (Emilio, myself)
>>> * QSP fixes for Coverity (myself)
>>> * Some record/replay improovements (Pavel)
>>> * Packed struct fixes (Peter)
>>> * Windows dump fixes and elf2dmp (Viktor)
>>> * kbmclock fix (Yongji)
>>
>> Paolo, thanks for queuing all of this, however I note some UTF-8 issues.
>>
>> Alex got lucky:
>>
>>  Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>
>> But Marc-André and myself have:
>>
>>  Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>  Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> I'll fix it.  In the meanwhile, I'll note that we're also improving
> Patchew so that it is much better at applying patches via three-way
> merge (basically the adding of *-by tags moves from "patchew apply" to
> the web stuff) and that should make these UTF-8 issues a thing of the past.

I noticed my patches are missing Cédric's R-b tags, is it a patchew
restriction?

Regards,

Phil.

Re: [Qemu-devel] [PULL 00/79] Misc QEMU patches for 2018-09-30

[Paolo Bonzini]

On 01/10/2018 10:25, Philippe Mathieu-Daudé wrote:
>> I'll fix it.  In the meanwhile, I'll note that we're also improving
>> Patchew so that it is much better at applying patches via three-way
>> merge (basically the adding of *-by tags moves from "patchew apply" to
>> the web stuff) and that should make these UTF-8 issues a thing of the past.
> I noticed my patches are missing Cédric's R-b tags, is it a patchew
> restriction?

No, it's just that sometimes I apply patches before I get the R-b (maybe
I'm not connected to the VPN and haven't downloaded all the messages).

Basically:

- if I apply with Patchew, all tags are correct but I can only do that
if there are no conflicts

- if I apply by hand, there may be missing tags and (because
Thunderbird's "view source" stupidly defaults to Latin-1) incorrect UTF-8.

Paolo

Re: [Qemu-devel] [PULL 75/79] memory: Remove old_mmio accessors

[Philippe Mathieu-Daudé]

On 30/09/2018 10:13, Paolo Bonzini wrote:
> From: Peter Maydell <peter.maydell@linaro.org>
> 
> Now that all the users of old_mmio MemoryRegion accessors
> have been converted, we can remove the core code support.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> Message-Id: <20180824170422.5783-2-peter.maydell@linaro.org>
> Based-on: <20180802174042.29234-1-peter.maydell@linaro.org>

Just noticed this tag.

If patchew is collecting all tags, this one should be filtered out.

> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---