Re: [PATCH v3 01/14] arm/cpu: Add sysreg definitions in cpu-sysregs.h

[Richard Henderson <richard.henderson@linaro.org>]

On 3/11/25 09:28, Cornelia Huck wrote:
> From: Eric Auger <eric.auger@redhat.com>
> 
> This new header contains macros that define aarch64 registers.
> In a subsequent patch, this will be replaced by a more exhaustive
> version that will be generated from linux arch/arm64/tools/sysreg
> file. Those macros are sufficient to migrate the storage of those
> ID regs from named fields in isar struct to an array cell.
> 
> [CH: reworked to use different structures]
> [CH: moved accessors from the patches first using them to here,
>       dropped interaction with writable registers, which will happen
>       later]
> [CH: use DEF magic suggested by rth]
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
>   target/arm/cpu-sysregs.h     | 37 +++++++++++++++++++++++++++
>   target/arm/cpu-sysregs.h.inc | 35 ++++++++++++++++++++++++++
>   target/arm/cpu.h             | 49 ++++++++++++++++++++++++++++++++++++
>   target/arm/cpu64.c           | 22 ++++++++++++++++
>   4 files changed, 143 insertions(+)
>   create mode 100644 target/arm/cpu-sysregs.h
>   create mode 100644 target/arm/cpu-sysregs.h.inc
> 
> diff --git a/target/arm/cpu-sysregs.h b/target/arm/cpu-sysregs.h
> new file mode 100644
> index 000000000000..b95320b5b595
> --- /dev/null
> +++ b/target/arm/cpu-sysregs.h
> @@ -0,0 +1,37 @@
> +#ifndef ARM_CPU_SYSREGS_H

All new files should have a SPDX-License-Identifier tag.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~