qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Li Zhijian" <lizhijian@cn.fujitsu.com>,
	qemu-devel@nongnu.org
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	pbonzini@redhat.com, richard.henderson@linaro.org,
	dgilbert@redhat.com, quintela@redhat.com
Subject: Re: [PATCH] misc: Remove redundant new line in perror()
Date: Fri, 9 Jul 2021 11:09:12 +0200	[thread overview]
Message-ID: <3b90356c-53e3-872f-2ca6-16c31eba68a5@vivier.eu> (raw)
In-Reply-To: <adc664b6-f4c8-1804-357a-f3f0b94e8e24@redhat.com>

Le 06/07/2021 à 11:55, Philippe Mathieu-Daudé a écrit :
> Cc'ing qemu-trivial@
> 
> On 7/6/21 11:44 AM, Li Zhijian wrote:
>> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
>> ---
>>  migration/rdma.c | 2 +-
>>  softmmu/cpus.c   | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/migration/rdma.c b/migration/rdma.c
>> index 7fb9646f6ef..e99e2e16a73 100644
>> --- a/migration/rdma.c
>> +++ b/migration/rdma.c
>> @@ -1133,7 +1133,7 @@ static int qemu_rdma_reg_whole_ram_blocks(RDMAContext *rdma)
>>                      IBV_ACCESS_REMOTE_WRITE
>>                      );
>>          if (!local->block[i].mr) {
>> -            perror("Failed to register local dest ram block!\n");
>> +            perror("Failed to register local dest ram block!");
>>              break;
>>          }
>>          rdma->total_registrations++;
>> diff --git a/softmmu/cpus.c b/softmmu/cpus.c
>> index c3caaeb26ec..071085f840b 100644
>> --- a/softmmu/cpus.c
>> +++ b/softmmu/cpus.c
>> @@ -325,7 +325,7 @@ static void sigbus_reraise(void)
>>          sigaddset(&set, SIGBUS);
>>          pthread_sigmask(SIG_UNBLOCK, &set, NULL);
>>      }
>> -    perror("Failed to re-raise SIGBUS!\n");
>> +    perror("Failed to re-raise SIGBUS!");
>>      abort();
>>  }
> 
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> 
>


Applied to my trivial-patches branch.

Thanks,
Laurent




      reply	other threads:[~2021-07-09  9:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-06  9:44 [PATCH] misc: Remove redundant new line in perror() Li Zhijian
2021-07-06  9:55 ` Philippe Mathieu-Daudé
2021-07-09  9:09   ` Laurent Vivier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b90356c-53e3-872f-2ca6-16c31eba68a5@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=dgilbert@redhat.com \
    --cc=lizhijian@cn.fujitsu.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).