From: Frederic Konrad <fred.konrad@greensocs.com>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org,
mark.burton@greensocs.com, qemu-devel@nongnu.org,
alistair.francis@xilinx.com
Subject: Re: [Qemu-devel] [PATCH V2 02/10] qemu-clk: allow to add a clock to a device
Date: Tue, 7 Feb 2017 10:49:10 +0100 [thread overview]
Message-ID: <3ba3245f-6b03-affe-6fee-d80ecabd3d39@greensocs.com> (raw)
In-Reply-To: <682b8d3a-bf00-012e-a79e-434358d181bb@kaod.org>
On 02/07/2017 10:31 AM, Cédric Le Goater wrote:
> On 02/07/2017 10:22 AM, Frederic Konrad wrote:
>>> I see how these routines are used in patch 10/10. But if we were
>>> open coding device CRF_APB, I don't think we would need them at
>>> all and it would make the code a little simple IMHO.
>> What do you mean by open coding?
>
> I mean to externalize the definition of the objects in a
> header file.
>
> Then you can replace the type 'Object *' of the attribute
> holding a reference to an instance by a non pointer type.
>
> Anyhow, I think we need to replace object_new() by
> object_initialize() for QOM, and so we need to expose a
> little more the object internals.
Ok got you.
I'll take a look.
Thanks,
Fred
>
> Thanks,
>
> C.
>
>
next prev parent reply other threads:[~2017-02-07 9:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 9:47 [Qemu-devel] [PATCH V2 00/10] Clock framework API fred.konrad
2017-01-26 9:47 ` [Qemu-devel] [PATCH V2 01/10] qemu-clk: introduce qemu-clk qom object fred.konrad
2017-02-05 15:25 ` Cédric Le Goater
2017-02-07 9:20 ` Frederic Konrad
2017-01-26 9:47 ` [Qemu-devel] [PATCH V2 02/10] qemu-clk: allow to add a clock to a device fred.konrad
2017-02-06 14:20 ` Cédric Le Goater
2017-02-07 9:22 ` Frederic Konrad
2017-02-07 9:31 ` Cédric Le Goater
2017-02-07 9:49 ` Frederic Konrad [this message]
2017-01-26 9:47 ` [Qemu-devel] [PATCH V2 03/10] qemu-clk: allow to bind two clocks together fred.konrad
2017-02-06 15:58 ` Cédric Le Goater
2017-02-07 9:45 ` Frederic Konrad
2017-01-26 9:47 ` [Qemu-devel] [PATCH V2 04/10] qemu-clk: introduce an init array to help the device construction fred.konrad
2017-02-06 16:02 ` Cédric Le Goater
2017-01-26 9:47 ` [Qemu-devel] [PATCH V2 05/10] qdev-monitor: print the device's clock with info qtree fred.konrad
2017-02-06 16:10 ` Cédric Le Goater
2017-01-26 9:47 ` [Qemu-devel] [PATCH V2 06/10] docs: add qemu-clock documentation fred.konrad
2017-02-07 16:13 ` Peter Maydell
2017-02-07 17:15 ` Frederic Konrad
2017-02-07 17:18 ` Peter Maydell
2017-01-26 9:47 ` [Qemu-devel] [PATCH V2 07/10] introduce fixed-clock fred.konrad
2017-02-06 16:13 ` Cédric Le Goater
2017-01-26 9:47 ` [Qemu-devel] [PATCH V2 08/10] introduce zynqmp_crf fred.konrad
2017-01-26 9:47 ` [Qemu-devel] [PATCH V2 09/10] zynqmp: add the zynqmp_crf to the platform fred.konrad
2017-01-26 9:47 ` [Qemu-devel] [PATCH V2 10/10] zynqmp: add reference clock fred.konrad
2017-02-06 16:38 ` Cédric Le Goater
2017-02-03 15:21 ` [Qemu-devel] [PATCH V2 00/10] Clock framework API Frederic Konrad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ba3245f-6b03-affe-6fee-d80ecabd3d39@greensocs.com \
--to=fred.konrad@greensocs.com \
--cc=alistair.francis@xilinx.com \
--cc=clg@kaod.org \
--cc=edgar.iglesias@xilinx.com \
--cc=mark.burton@greensocs.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).