From: Eric Blake <eblake@redhat.com>
To: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-block@nongnu.org,
mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 1/3] block: implement bdrv_snapshot_goto for blkreplay
Date: Tue, 28 Feb 2017 20:00:19 -0600 [thread overview]
Message-ID: <3ba92606-7d69-603e-7b24-3381314463b4@redhat.com> (raw)
In-Reply-To: <20170228105527.1284.44425.stgit@PASHA-ISP>
[-- Attachment #1: Type: text/plain, Size: 848 bytes --]
On 02/28/2017 04:55 AM, Pavel Dovgalyuk wrote:
[meta-comment]
> This patch enables making snapshots with blkreplay used in
> block devices.
> This function is required to make bdrv_snapshot_goto without
> calling .bdrv_open which is not implemented.
>
> v2: updated commit message
The v2 information...
>
> Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
> ---
...fits best here. Anything after the --- is stripped by 'git am',
making it ideal for information that is useful to the reviewers but not
important to a long-term reader (a year from now, we won't care if it
was v2 or v10 that was committed, because git only stores the version
that was checked in, and not the iterations prior to it).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-03-01 2:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 10:55 [Qemu-devel] [PATCH v2 0/3] block devices record/replay update Pavel Dovgalyuk
2017-02-28 10:55 ` [Qemu-devel] [PATCH v2 1/3] block: implement bdrv_snapshot_goto for blkreplay Pavel Dovgalyuk
2017-03-01 2:00 ` Eric Blake [this message]
2017-02-28 10:55 ` [Qemu-devel] [PATCH v2 2/3] blkreplay: create temporary overlay for underlaying devices Pavel Dovgalyuk
2017-02-28 10:55 ` [Qemu-devel] [PATCH v2 3/3] replay: disable default snapshot for record/replay Pavel Dovgalyuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ba92606-7d69-603e-7b24-3381314463b4@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).