qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-stable@nongnu.org, Greg Kurz <groug@kaod.org>
Subject: [PULL for-9.2 5/7] 9pfs: remove obsolete comment in v9fs_getattr()
Date: Thu, 28 Nov 2024 19:53:58 +0100	[thread overview]
Message-ID: <3bc4db44430f53387d17145bb52b330a830a03fe.1732820037.git.qemu_oss@crudebyte.com> (raw)
In-Reply-To: <cover.1732820037.git.qemu_oss@crudebyte.com>

The comment claims that we'd only support basic Tgetattr fields. This is
no longer true, so remove this comment.

Fixes: e06a765efbe3 ("hw/9pfs: Add st_gen support in getattr reply")
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Message-Id: <fb364d12045217a4c6ccd0dd6368103ddb80698b.1732465720.git.qemu_oss@crudebyte.com>
---
 hw/9pfs/9p.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
index 9a291d1b51..851e36b9a1 100644
--- a/hw/9pfs/9p.c
+++ b/hw/9pfs/9p.c
@@ -1596,10 +1596,6 @@ static void coroutine_fn v9fs_getattr(void *opaque)
         retval = -ENOENT;
         goto out_nofid;
     }
-    /*
-     * Currently we only support BASIC fields in stat, so there is no
-     * need to look at request_mask.
-     */
     retval = v9fs_co_lstat(pdu, &fidp->path, &stbuf);
     if (retval < 0) {
         goto out;
-- 
2.30.2



  parent reply	other threads:[~2024-11-28 19:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-28 18:53 [PULL for-9.2 0/7] 9p queue 2024-11-28 Christian Schoenebeck
2024-11-28 18:53 ` [PULL for-9.2 3/7] tests/9p: fix Rreaddir response name Christian Schoenebeck
2024-11-28 18:53 ` [PULL for-9.2 7/7] tests/9p: also check 'Tgetattr' in 'use-after-unlink' test Christian Schoenebeck
2024-11-28 18:53 ` [PULL for-9.2 1/7] 9pfs: cleanup V9fsFidState Christian Schoenebeck
2024-11-28 18:53 ` [PULL for-9.2 2/7] tests/9p: add 'use-after-unlink' test Christian Schoenebeck
2024-11-28 18:53 ` [PULL for-9.2 4/7] tests/9p: add missing Rgetattr response name Christian Schoenebeck
2024-11-28 18:53 ` [PULL for-9.2 6/7] 9pfs: fix 'Tgetattr' after unlink Christian Schoenebeck
2024-11-28 18:53 ` Christian Schoenebeck [this message]
2024-11-29 15:45 ` [PULL for-9.2 0/7] 9p queue 2024-11-28 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3bc4db44430f53387d17145bb52b330a830a03fe.1732820037.git.qemu_oss@crudebyte.com \
    --to=qemu_oss@crudebyte.com \
    --cc=groug@kaod.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).