From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>,
David Hildenbrand <david@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH 1/3] s390x: move S390_ADAPTER_SUPPRESSIBLE
Date: Wed, 17 Mar 2021 12:30:19 +0100 [thread overview]
Message-ID: <3be3264f-1400-5b57-1a99-c7f92610c9be@redhat.com> (raw)
In-Reply-To: <20210317095622.2839895-2-kraxel@redhat.com>
On 3/17/21 10:56 AM, Gerd Hoffmann wrote:
> The definition S390_ADAPTER_SUPPRESSIBLE was moved to "cpu.h", per
> suggestion of Thomas Huth. From interface design perspective, IMHO, not
> a good thing as it belongs to the public interface of
> css_register_io_adapters(). We did this because CONFIG_KVM requeires
Typo "requeires" -> "requires"
> NEED_CPU_H and Thomas, and other commenters did not like the
> consequences of that.
>
> Moving the interrupt related declarations to s390_flic.h was suggested
> by Cornelia Huck.
>
> Signed-off-by: Halil Pasic <pasic@linux.ibm.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> include/hw/s390x/css.h | 7 -------
> include/hw/s390x/s390_flic.h | 3 +++
> target/s390x/cpu.h | 9 ++++++---
> 3 files changed, 9 insertions(+), 10 deletions(-)
next prev parent reply other threads:[~2021-03-17 11:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 9:56 [PATCH 0/3] s390x: modularize virtio-gpu-ccw Gerd Hoffmann
2021-03-17 9:56 ` [PATCH 1/3] s390x: move S390_ADAPTER_SUPPRESSIBLE Gerd Hoffmann
2021-03-17 11:30 ` Philippe Mathieu-Daudé [this message]
2021-03-17 9:56 ` [PATCH 2/3] s390x: add have_virtio_ccw Gerd Hoffmann
2021-03-17 9:56 ` [PATCH 3/3] s390x: modularize virtio-gpu-ccw Gerd Hoffmann
2021-03-22 13:12 ` [PATCH 0/3] " Halil Pasic
2021-03-26 8:40 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3be3264f-1400-5b57-1a99-c7f92610c9be@redhat.com \
--to=philmd@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).