Re: [PULL 00/22] Tests and misc patches

[Thomas Huth <thuth@redhat.com>]

On 10/09/2024 17.38, Peter Maydell wrote:
> On Tue, 10 Sept 2024 at 13:37, Thomas Huth <thuth@redhat.com> wrote:
>>
>> The following changes since commit 7bbadc60b58b742494555f06cd342311ddab9351:
>>
>>    Merge tag 'crypto-fixes-pull-request' of https://gitlab.com/berrange/qemu into staging (2024-09-09 15:19:32 +0100)
>>
>> are available in the Git repository at:
>>
>>    https://gitlab.com/thuth/qemu.git tags/pull-request-2024-09-10
>>
>> for you to fetch changes up to cc3e005eb22332ba277bff2e39025d0087f3795e:
>>
>>    tests/functional: Fix bad usage of has_cmd (2024-09-10 13:44:42 +0200)
>>
>> ----------------------------------------------------------------
>> * Split --enable-sanitizers to --enable-{asan, ubsan}
>> * Build MSYS2 job using multiple CPUs
>> * Fix "make distclean" wrt contrib/plugins/
>> * Convert more Avocado tests to plain standalone functional tests
>> * Fix bug that breaks "make check-functional" when tesseract is missing
>>
>> ----------------------------------------------------------------
> 
> On the 'make check-vm-openbsd' test I run:
> 
> 595/944 qemu:func-quick+func-mips64el /
> func-mips64el-mips64el_fuloong2e          ERROR            6.16s
> exit status 1
> 602/944 qemu:func-quick+func-or1k / func-or1k-or1k_sim
>             ERROR            6.91s   exit status 1
> 
> Slightly more detail further up in the log:
> 
> 
> 595/944 qemu:func-quick+func-mips64el /
> func-mips64el-mips64el_fuloong2e          ERROR            6.16s
> exit status 1
> ――――――――――――――――――――――――――――――――――――― ✀  ―――――――――――――――――――――――――――――――――――――
> stderr:
> Traceback (most recent call last):
>    File "/home/qemu/qemu-test.fsnflZ/src/tests/functional/test_mips64el_fuloong2e.py",
> line 29, in test_linux_kernel_3_16
>      deb_path = self.ASSET_KERNEL.fetch()
>    File "/home/qemu/qemu-test.fsnflZ/src/tests/functional/qemu_test/asset.py",
> line 135, in fetch
>      if not self._check(tmp_cache_file):
>    File "/home/qemu/qemu-test.fsnflZ/src/tests/functional/qemu_test/asset.py",
> line 52, in _check
>      checksum = subprocess.check_output(
>    File "/usr/local/lib/python3.10/subprocess.py", line 421, in check_output
>      return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
>    File "/usr/local/lib/python3.10/subprocess.py", line 503, in run
>      with Popen(*popenargs, **kwargs) as process:
>    File "/usr/local/lib/python3.10/subprocess.py", line 971, in __init__
>      self._execute_child(args, executable, preexec_fn, close_fds,
>    File "/usr/local/lib/python3.10/subprocess.py", line 1863, in _execute_child
>      raise child_exception_type(errno_num, err_msg, err_filename)
> FileNotFoundError: [Errno 2] No such file or directory: 'sha256sum'
> 
> 
> (test program exited with status code 1)
> 
> 
> Similarly for the or1k failure.
> 
> If you want to use sha256sum in "make check" then we should
> ensure that it's installed in these BSD VM images.

Ok ... I'm looking into using the hashlib from Python instead, that way 
we'll be independent from external binaries here.

> Also, does this mean that "make check" is now going to run
> a lot of the tests that were previously in "make check-avocado"?
> That seems like it might make our CI jobs take longer...

No, it will only some basic tests that don't download any assets. These 
should be the rather quick ones.

  Thomas