From: Laurent Vivier <lvivier@redhat.com>
To: Juan Quintela <quintela@redhat.com>, qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Eric Blake <eblake@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/4] multifd: Drop x-multifd-page-count parameter
Date: Wed, 6 Feb 2019 15:20:57 +0100 [thread overview]
Message-ID: <3beec7d3-7a57-30be-affb-c68caa713a60@redhat.com> (raw)
In-Reply-To: <20190206132331.1694-3-quintela@redhat.com>
On 06/02/2019 14:23, Juan Quintela wrote:
> Libvirt don't want to expose (and explain it). And testing looks like
> 128 is good for all use cases, so just drop it.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
> hmp.c | 7 -------
> migration/migration.c | 30 ------------------------------
> migration/migration.h | 1 -
> migration/ram.c | 13 ++++++++-----
> qapi/migration.json | 13 +------------
> 5 files changed, 9 insertions(+), 55 deletions(-)
>
...
> diff --git a/migration/migration.c b/migration/migration.c
> index f673486679..65df9b566e 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -81,7 +81,6 @@
> /* The delay time (in ms) between two COLO checkpoints */
> #define DEFAULT_MIGRATE_X_CHECKPOINT_DELAY (200 * 100)
> #define DEFAULT_MIGRATE_MULTIFD_CHANNELS 2
> -#define DEFAULT_MIGRATE_MULTIFD_PAGE_COUNT 128
Why do you update it in the previous patch to remove it in this one?
Thanks,
Laurent
next prev parent reply other threads:[~2019-02-06 14:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 13:23 [Qemu-devel] [PATCH 0/4] migration: Make multifd not experimental Juan Quintela
2019-02-06 13:23 ` [Qemu-devel] [PATCH 1/4] multifd: Change page count default to 128 Juan Quintela
2019-02-07 11:33 ` Daniel P. Berrangé
2019-02-07 12:13 ` Juan Quintela
2019-02-07 12:13 ` Juan Quintela
2019-02-07 12:41 ` Daniel P. Berrangé
2019-02-06 13:23 ` [Qemu-devel] [PATCH 2/4] multifd: Drop x-multifd-page-count parameter Juan Quintela
2019-02-06 14:20 ` Laurent Vivier [this message]
2019-02-06 17:58 ` Juan Quintela
2019-02-06 19:00 ` Laurent Vivier
2019-02-07 12:15 ` Juan Quintela
2019-02-07 12:33 ` Daniel P. Berrangé
2019-02-12 9:34 ` Juan Quintela
2019-02-12 10:29 ` Daniel P. Berrangé
2019-02-06 13:23 ` [Qemu-devel] [PATCH 3/4] multifd: Drop x- Juan Quintela
2019-02-07 11:23 ` Dr. David Alan Gilbert
2019-02-06 13:23 ` [Qemu-devel] [PATCH 4/4] tests: Add migration multifd test Juan Quintela
2019-02-06 15:49 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3beec7d3-7a57-30be-affb-c68caa713a60@redhat.com \
--to=lvivier@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).