From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E03ACC433E0 for ; Mon, 22 Feb 2021 12:10:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5026264E24 for ; Mon, 22 Feb 2021 12:10:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5026264E24 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46042 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEA2Z-00021V-5e for qemu-devel@archiver.kernel.org; Mon, 22 Feb 2021 07:10:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42658) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lE9wn-0004Lr-Ol for qemu-devel@nongnu.org; Mon, 22 Feb 2021 07:04:19 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:21612) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lE9wh-0003Ng-LU for qemu-devel@nongnu.org; Mon, 22 Feb 2021 07:04:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613995447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pTALdb+XyTM6asu2D4ffugcTsy2nyxxKm3NrHb1p4jo=; b=cVhTfDeIpAIyclPMO9dvpdIhDTwJnCHI/TPZUFv2vCXNKz7pWNWMr0KvtXTnbJqWynYlyS i2PFLaDNTEDxUbfoHmfJZX2Jb0Oy3eY76Atb/BZ2mserfu/9pRMaATPjv25bYJdzWQH4B5 KnQj67PMn/yB7k/8nFjsojeHBXYPhHQ= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-6-BZFjPLlOOO-90_fCM7GB0w-1; Mon, 22 Feb 2021 07:04:05 -0500 X-MC-Unique: BZFjPLlOOO-90_fCM7GB0w-1 Received: by mail-ed1-f71.google.com with SMTP id m16so6823672edd.21 for ; Mon, 22 Feb 2021 04:04:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pTALdb+XyTM6asu2D4ffugcTsy2nyxxKm3NrHb1p4jo=; b=m3yWcgx9XO2DBSndkuwR+gOX+t2ksIsTD5R43d9whSUMzGO11GiSpIVc9I+xr1umGv HVADkGmBH2vhn9pzwHzmTwStt6JEMhfxq6/cWBFEpLeoaKF/EScqF/3YG+SCIoYyIAe0 XlSUjBDNB7Pi0K1FHSZFcD37iO5iJ0tf0Oe3Ru9b1B4J3tXKyzayxDJzi4Nj3HGxZ0aR Vua15XmppluXqTrJ1vWb/xl1pDQ8S763TLDMwcB3lAPD/92+m1t5dSLxNYmGjrOyivot bWkaSlDeTLhhfeA3z4WKhPrlWbrpW7HimCc5fY4qty5uTJoAnxRAKDG0xSZhgVQcHxI+ 30uw== X-Gm-Message-State: AOAM5312yPqbUYqQGQU4GQ3DATcK4DdBAT6fHYWsa8/SMxllxs169UrA iS3eAWQ7NjzlYXtmudw/z37J7xdTsAdsQ1e6Spg9R4fVwXcjBjB03BVP+0Bkq4HJYakVLRp9NES IbHcXUNAgV98+7nk= X-Received: by 2002:a17:906:1d0f:: with SMTP id n15mr20721232ejh.553.1613995444661; Mon, 22 Feb 2021 04:04:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJyV7mvnHnhGNeLLYT/ZmBBKQzrgx3WrBTuMQQbixNLtGfoqvgIVvPfr2wUY75OPrjVZi04uDw== X-Received: by 2002:a17:906:1d0f:: with SMTP id n15mr20721196ejh.553.1613995444463; Mon, 22 Feb 2021 04:04:04 -0800 (PST) Received: from [192.168.1.36] (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id d3sm12124707edk.82.2021.02.22.04.04.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Feb 2021 04:04:03 -0800 (PST) Subject: Re: [PATCH v2 01/22] block: add eMMC block device type To: Sai Pavan Boddu , Markus Armbruster , Kevin Wolf , Max Reitz , Vladimir Sementsov-Ogievskiy , Eric Blake , Joel Stanley , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Vincent Palatin , "Dr. David Alan Gilbert" , Thomas Huth , Stefan Hajnoczi , Peter Maydell , Alistair Francis , "Edgar E. Iglesias" , Luc Michel , Paolo Bonzini References: <1613982039-13861-1-git-send-email-sai.pavan.boddu@xilinx.com> <1613982039-13861-2-git-send-email-sai.pavan.boddu@xilinx.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <3c229241-fdc5-a445-d96e-ca16a5c0106b@redhat.com> Date: Mon, 22 Feb 2021 13:04:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <1613982039-13861-2-git-send-email-sai.pavan.boddu@xilinx.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: saipava@xilinx.com, qemu-devel@nongnu.org, qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/22/21 9:20 AM, Sai Pavan Boddu wrote: > From: Vincent Palatin > > Add new block device type. > > Signed-off-by: Vincent Palatin > [SPB: Rebased over 5.1 version] > Signed-off-by: Sai Pavan Boddu > Signed-off-by: Joel Stanley > Signed-off-by: Cédric Le Goater > Reviewed-by: Alistair Francis > --- > include/sysemu/blockdev.h | 1 + > blockdev.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/include/sysemu/blockdev.h b/include/sysemu/blockdev.h > index 3b5fcda..eefae9f 100644 > --- a/include/sysemu/blockdev.h > +++ b/include/sysemu/blockdev.h > @@ -24,6 +24,7 @@ typedef enum { > */ > IF_NONE = 0, > IF_IDE, IF_SCSI, IF_FLOPPY, IF_PFLASH, IF_MTD, IF_SD, IF_VIRTIO, IF_XEN, > + IF_EMMC, > IF_COUNT > } BlockInterfaceType; > > diff --git a/blockdev.c b/blockdev.c > index cd438e6..390d43c 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -83,6 +83,7 @@ static const char *const if_name[IF_COUNT] = { > [IF_SD] = "sd", > [IF_VIRTIO] = "virtio", > [IF_XEN] = "xen", > + [IF_EMMC] = "emmc", > }; We don't need to introduce support for the legacy -drive magic. -device should be enough for this device, right?