Re: [Qemu-devel] SPARC kernel oops with logging

[Gabriel Southern <gabriel.southern@gmail.com>]

Thanks, this patch does seem to have fixed the problem for me.

-Gabriel

>
> I think this patch should fix the problem.
>
> Sparc disassembler wants to check previous addresses for some stuff
> and this may actually cause faults if the address is close to page
> start, because of the function used for the memory access.
>
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> ---
>  disas.c |    5 +----
>  1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/disas.c b/disas.c
> index 37f7433..6ed31e3 100644
> --- a/disas.c
> +++ b/disas.c
> @@ -33,10 +33,7 @@ target_read_memory (bfd_vma memaddr,
>                     int length,
>                     struct disassemble_info *info)
>  {
> -    int i;
> -    for(i = 0; i < length; i++) {
> -        myaddr[i] = ldub_code(memaddr + i);
> -    }
> +    cpu_memory_rw_debug(cpu_single_env, memaddr, myaddr, length, 0);
>     return 0;
>  }
>
> --
> 1.6.2.4
>