From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M1oFG-00032n-CE
	for qemu-devel@nongnu.org; Wed, 06 May 2009 17:01:38 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M1oFA-00032K-0v
	for qemu-devel@nongnu.org; Wed, 06 May 2009 17:01:36 -0400
Received: from [199.232.76.173] (port=35358 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M1oF9-00032H-S0
	for qemu-devel@nongnu.org; Wed, 06 May 2009 17:01:31 -0400
Received: from mail-ew0-f165.google.com ([209.85.219.165]:54921)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gabriel.southern@gmail.com>) id 1M1oF9-0004rQ-Ai
	for qemu-devel@nongnu.org; Wed, 06 May 2009 17:01:31 -0400
Received: by ewy9 with SMTP id 9so593200ewy.34
	for <qemu-devel@nongnu.org>; Wed, 06 May 2009 14:01:30 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <f43fc5580905061157u580ce687t7cf6e9dbd2c9d0ac@mail.gmail.com>
References: <3c2bf46d0905041456j66ab4d92m633ca366afac8f61@mail.gmail.com>
	<f43fc5580905050829w6b880e81h7e469e9e6ec39a68@mail.gmail.com>
	<3c2bf46d0905051637n519c4637u2d1e77c1049a1df3@mail.gmail.com>
	<f43fc5580905061157u580ce687t7cf6e9dbd2c9d0ac@mail.gmail.com>
Date: Wed, 6 May 2009 14:01:29 -0700
Message-ID: <3c2bf46d0905061401u19dc1fa9tf5a15a0b65ab81aa@mail.gmail.com>
Subject: Re: [Qemu-devel] SPARC kernel oops with logging
From: Gabriel Southern <gabriel.southern@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org

Thanks, this patch does seem to have fixed the problem for me.

-Gabriel

>
> I think this patch should fix the problem.
>
> Sparc disassembler wants to check previous addresses for some stuff
> and this may actually cause faults if the address is close to page
> start, because of the function used for the memory access.
>
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> ---
> =A0disas.c | =A0 =A05 +----
> =A01 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/disas.c b/disas.c
> index 37f7433..6ed31e3 100644
> --- a/disas.c
> +++ b/disas.c
> @@ -33,10 +33,7 @@ target_read_memory (bfd_vma memaddr,
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 int length,
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 struct disassemble_info *info)
> =A0{
> - =A0 =A0int i;
> - =A0 =A0for(i =3D 0; i < length; i++) {
> - =A0 =A0 =A0 =A0myaddr[i] =3D ldub_code(memaddr + i);
> - =A0 =A0}
> + =A0 =A0cpu_memory_rw_debug(cpu_single_env, memaddr, myaddr, length, 0);
> =A0 =A0 return 0;
> =A0}
>
> --
> 1.6.2.4
>