Re: [RFC PATCH] target/ppc: Remove the unusable e200 CPUs

["Cédric Le Goater" <clg@kaod.org>]

On 10/17/25 17:50, Harsh Prateek Bora wrote:
> 
> 
> On 10/17/25 20:15, Thomas Huth wrote:
>> From: Thomas Huth <thuth@redhat.com>
>>
>> There is currently no machine in QEMU (except the "none" machine)
>> that can be run with one of the e200 ppc CPUs - all machines either
>> complain about an invalid CPU type or crash QEMU immediatly.
>>
>> Looking at the history of this CPU type, it seems like it has never
>> been used in QEMU and only implemented as a placeholder (see e.g. the
>> comment about unimplemented instructions in the POWERPC_FAMILY(e200)
>> section of cpu_init.c). Being completely unused and unusable since
>> such a long time, let's just remove it now.
>>
>> Note: The init_excp_e200() is used by the e500 CPUs, too, so we
>> rename this function to init_excp_e500() instead of removing it.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>   target/ppc/cpu-models.h |   4 --
>>   target/ppc/cpu-models.c |   5 --
>>   target/ppc/cpu_init.c   | 147 +---------------------------------------
>>   3 files changed, 2 insertions(+), 154 deletions(-)
>>
>> diff --git a/target/ppc/cpu-models.h b/target/ppc/cpu-models.h
>> index c6cd27f390e..a439eb37ee4 100644
>> --- a/target/ppc/cpu-models.h
>> +++ b/target/ppc/cpu-models.h
>> @@ -120,10 +120,6 @@ enum {
>>   #define CPU_POWERPC_MPC5200_v12      CPU_POWERPC_G2LEgp1
>>   #define CPU_POWERPC_MPC5200B_v20     CPU_POWERPC_G2LEgp1
>>   #define CPU_POWERPC_MPC5200B_v21     CPU_POWERPC_G2LEgp1
>> -    /* e200 family */
>> -    /* e200 cores */
>> -    CPU_POWERPC_e200z5             = 0x81000000,
>> -    CPU_POWERPC_e200z6             = 0x81120000,
>>       /* e300 family */
>>       /* e300 cores */
>>       CPU_POWERPC_e300c1             = 0x00830010,
>> diff --git a/target/ppc/cpu-models.c b/target/ppc/cpu-models.c
>> index 89ae763c7f6..26b6debcfc9 100644
>> --- a/target/ppc/cpu-models.c
>> +++ b/target/ppc/cpu-models.c
>> @@ -244,11 +244,6 @@
>>                       CPU_POWERPC_MPC5200B_v20, POWERPC_SVR_5200B_v20, G2LE)
>>       POWERPC_DEF_SVR("mpc5200b_v21", "MPC5200B v2.1",
>>                       CPU_POWERPC_MPC5200B_v21, POWERPC_SVR_5200B_v21, G2LE)
>> -    /* e200 family                                                           */
>> -    POWERPC_DEF("e200z5",        CPU_POWERPC_e200z5,                 e200,
>> -                "PowerPC e200z5 core")
>> -    POWERPC_DEF("e200z6",        CPU_POWERPC_e200z6,                 e200,
>> -                "PowerPC e200z6 core")
> 
> While I hope removal of e200 should be fine, I am thinking if we want to
> deprecate it in this cycle and remove it in next ?

Since it was never usable (I don't remember of any tests for these
CPUs), I agree with Thomas to bypass the deprecation process.



Thanks,

C.