From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:36008)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1gpD5S-0004uR-22
	for qemu-devel@nongnu.org; Thu, 31 Jan 2019 09:13:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1gpD5Q-0005Us-AR
	for qemu-devel@nongnu.org; Thu, 31 Jan 2019 09:13:02 -0500
References: <1548866382-14488-1-git-send-email-thuth@redhat.com>
	<4e8dcc26-7e62-c79d-c354-8ade5db33f26@redhat.com>
From: Thomas Huth <thuth@redhat.com>
Message-ID: <3c30472b-bc7f-d3cc-cf1f-1e5127205984@redhat.com>
Date: Thu, 31 Jan 2019 15:12:48 +0100
MIME-Version: 1.0
In-Reply-To: <4e8dcc26-7e62-c79d-c354-8ade5db33f26@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] hw/ppc: Don't include m48t59.h
 if it is not necessary
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <philmd@redhat.com>, qemu-ppc@nongnu.org, David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org

On 2019-01-30 18:21, Philippe Mathieu-Daud=C3=A9 wrote:
> On 1/30/19 5:39 PM, Thomas Huth wrote:
>> These files don't use anything from m48t59.h, so no need to include
>> this header here.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>  hw/ppc/mac_newworld.c | 1 -
>>  hw/ppc/mac_oldworld.c | 1 -
>>  hw/ppc/ppc.c          | 2 --
>>  hw/ppc/ppc_booke.c    | 1 -
>>  4 files changed, 5 deletions(-)
>>
>> diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c
>> index bb19eab..f1c8400 100644
>> --- a/hw/ppc/mac_newworld.c
>> +++ b/hw/ppc/mac_newworld.c
>> @@ -53,7 +53,6 @@
>>  #include "hw/ppc/mac.h"
>>  #include "hw/input/adb.h"
>>  #include "hw/ppc/mac_dbdma.h"
>> -#include "hw/timer/m48t59.h"
>>  #include "hw/pci/pci.h"
>>  #include "net/net.h"
>>  #include "sysemu/sysemu.h"
>> diff --git a/hw/ppc/mac_oldworld.c b/hw/ppc/mac_oldworld.c
>> index 817f70e..98d531d 100644
>> --- a/hw/ppc/mac_oldworld.c
>> +++ b/hw/ppc/mac_oldworld.c
>> @@ -30,7 +30,6 @@
>>  #include "hw/ppc/ppc.h"
>>  #include "mac.h"
>>  #include "hw/input/adb.h"
>> -#include "hw/timer/m48t59.h"
>>  #include "sysemu/sysemu.h"
>>  #include "net/net.h"
>>  #include "hw/isa/isa.h"
>> diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c
>> index 98b409f..cffdc39 100644
>> --- a/hw/ppc/ppc.c
>> +++ b/hw/ppc/ppc.c
>> @@ -30,10 +30,8 @@
>>  #include "qemu/timer.h"
>>  #include "sysemu/sysemu.h"
>>  #include "sysemu/cpus.h"
>> -#include "hw/timer/m48t59.h"
>>  #include "qemu/log.h"
>>  #include "qemu/error-report.h"
>> -#include "hw/loader.h"
>=20
> I supposed the "hw/loader.h" change slipped in by mistake.

I should have mentioned it in the patch description, I guess. ppc.c also
compiles without this line, so it can be removed, too.

 Thomas