From: Richard Henderson <richard.henderson@linaro.org>
To: Claudio Fontana <cfontana@suse.de>, Paolo Bonzini <pbonzini@redhat.com>
Cc: Alex Bennee <alex.bennee@linaro.org>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: does make check now require TCG? Or is it a parallelism issue?
Date: Thu, 8 Oct 2020 13:05:05 -0500 [thread overview]
Message-ID: <3c527b0f-afa1-4b86-4fa5-9acca2a296bd@linaro.org> (raw)
In-Reply-To: <6fe91a5a-c136-9af3-c48a-97ccdca7a543@suse.de>
On 10/8/20 12:53 PM, Claudio Fontana wrote:
> On 10/8/20 7:44 PM, Richard Henderson wrote:
>> On 10/8/20 10:02 AM, Paolo Bonzini wrote:
>>> On 08/10/20 16:48, Claudio Fontana wrote:
>>>> on master, a build without tcg like:
>>>>
>>>> exec '../configure' '--disable-tcg' '--enable-kvm' '--enable-hax' "$@"
>>>>
>>>> make -j120 check
>>>> Generating qemu-version.h with a meson_exe.py custom command
>>>> make: *** No rule to make target 'qemu-system-aarch64', needed by 'check-block'. Stop.
>>>> make: *** Waiting for unfinished jobs....
>>>>
>>>> qemu-system-aarch64 is required for check-block now?
>>>
>>> No, it's not, it's an unnecessary dependency. This will fix it:
>>>
>>> diff --git a/tests/Makefile.include b/tests/Makefile.include
>>> index 5aca98e60c..1ca70d88ce 100644
>>> --- a/tests/Makefile.include
>>> +++ b/tests/Makefile.include
>>> @@ -140,7 +140,7 @@ QEMU_IOTESTS_HELPERS-$(CONFIG_LINUX) = tests/qemu-iotests/socket_scm_helper$(EXE
>>> check: check-block
>>> check-block: $(SRC_PATH)/tests/check-block.sh qemu-img$(EXESUF) \
>>> qemu-io$(EXESUF) qemu-nbd$(EXESUF) $(QEMU_IOTESTS_HELPERS-y) \
>>> - $(patsubst %-softmmu,qemu-system-%,$(filter %-softmmu,$(TARGET_DIRS)))
>>> + qemu-system-$(patsubst ppc64%,ppc64, $(shell uname -m))
>>
>> Why doesn't the original line work? Waiting until all of the configured
>
> The original line breaks because without TCG built-in there will be no qemu-system-aarch64 to wait for.
But aarch64 should not be in TARGET_DIRS (for x86 host) with --disable-tcg.
There must be some other problem.
I can reproduce this though, just as you say.
Ah, TARGET_DIRS isn't being pruned anymore when a target is disabled for lack
of accelerator.
Paolo, side effect of 8a19980e3f ("configure: move accelerator logic to
meson")? I guess we should move the setting of TARGET_DIRS to meson as well.
r~
next prev parent reply other threads:[~2020-10-08 18:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 14:48 does make check now require TCG? Or is it a parallelism issue? Claudio Fontana
2020-10-08 15:02 ` Paolo Bonzini
2020-10-08 15:34 ` Claudio Fontana
2020-10-08 16:25 ` Claudio Fontana
2020-10-08 16:31 ` Paolo Bonzini
2020-10-08 16:35 ` Claudio Fontana
2020-10-08 16:51 ` Claudio Fontana
2020-10-09 9:23 ` Philippe Mathieu-Daudé
2020-10-09 9:40 ` Claudio Fontana
2020-10-09 10:35 ` Pavel Dovgalyuk
2020-10-09 11:46 ` Paolo Bonzini
2020-10-08 17:44 ` Richard Henderson
2020-10-08 17:53 ` Claudio Fontana
2020-10-08 18:05 ` Richard Henderson [this message]
2020-10-08 18:24 ` Paolo Bonzini
2020-10-08 21:07 ` Claudio Fontana
2020-10-09 7:40 ` Paolo Bonzini
2020-10-09 10:28 ` Claudio Fontana
2020-10-09 11:49 ` Paolo Bonzini
2020-10-09 12:13 ` Peter Maydell
2020-10-09 13:32 ` Claudio Fontana
2020-10-09 17:10 ` Paolo Bonzini
2020-10-09 7:21 ` Thomas Huth
2020-10-09 7:37 ` Paolo Bonzini
2020-10-09 9:25 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c527b0f-afa1-4b86-4fa5-9acca2a296bd@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=cfontana@suse.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).