qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: michael@walle.cc
To: Peter Maydell <peter.maydell@linaro.org>
Cc: xiaoqiang zhao <zxq_yx_007@163.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Igor Mitsyanko <i.mitsyanko@gmail.com>,
	qemu-arm <qemu-arm@nongnu.org>,
	hirofumi@mail.parknet.co.jp
Subject: Re: [Qemu-devel] [PATCH 0/5] QOM'ify hw/display devices
Date: Wed, 04 May 2016 16:31:34 +0200	[thread overview]
Message-ID: <3c5b37394680b8b4940236d7bc313be2@walle.cc> (raw)
In-Reply-To: <CAFEAcA8ohPD0pwkZYfE8RmDjpu15vUeYNo+wn4PFo2f4ZEq3Rg@mail.gmail.com>

Am 2016-05-04 16:26, schrieb Peter Maydell:
> On 24 March 2016 at 10:29, xiaoqiang zhao <zxq_yx_007@163.com> wrote:
>> This patch set trys to QOM'ify hw/display files, see commit messages
>> for more details
>> 
>> xiaoqiang zhao (5):
>>   hw/display: QOM'ify exynos4210_fimd.c
>>   hw/display: QOM'ify jazz_led.c
>>   hw/display: QOM'ify milkymist-tmu2.c
>>   hw/display: QOM'ify milkymist-vgafb.c
>>   hw/display: QOM'ify pl110.c
> 
> Hi; I was going to review this series (apologies for taking so
> long!)
> but looking at my email archive and the patchwork server
> the patches in it seem a bit confused. I see seven patches, not five,
> with rather odd patch number indications:
>  1/5
>  2/5
>  3/6
>  4/5
>  5/6
>  5/5
>  6/6
> 
> (and 5/5 and 6/6 seem to be the same). Could you resend the
> series with the correct patches in it, please?


Oh my. I wanted to test the milkymist stuff last week, but didn't find 
time to complete it. I'll try it this week(end).

If 5/5 and 6/6 is the milkymist-vgafb.c, then I noticed the duplication, 
too.

-michael

  reply	other threads:[~2016-05-04 14:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-24 10:29 [Qemu-devel] [PATCH 0/5] QOM'ify hw/display devices xiaoqiang zhao
2016-03-24 10:29 ` [Qemu-devel] [PATCH 1/5] hw/display: QOM'ify exynos4210_fimd.c xiaoqiang zhao
2016-03-24 10:29 ` [Qemu-devel] [PATCH 2/5] hw/display: QOM'ify jazz_led.c xiaoqiang zhao
2016-03-24 10:29 ` [Qemu-devel] [PATCH 3/6] hw/display/jazz_led.c xiaoqiang zhao
2016-03-24 10:29 ` [Qemu-devel] [PATCH 4/5] hw/display: QOM'ify milkymist-vgafb.c xiaoqiang zhao
2016-03-24 10:29 ` [Qemu-devel] [PATCH 5/6] hw/display/milkymist-vgafb.c xiaoqiang zhao
2016-03-24 10:29 ` [Qemu-devel] [PATCH 5/5] hw/display: QOM'ify pl110.c xiaoqiang zhao
2016-03-24 10:29 ` [Qemu-devel] [PATCH 6/6] QOM hw/display/pl110.c xiaoqiang zhao
2016-05-04 14:26 ` [Qemu-devel] [PATCH 0/5] QOM'ify hw/display devices Peter Maydell
2016-05-04 14:31   ` michael [this message]
2016-05-05  1:51   ` xiaoqiang zhao
2016-05-05  3:12   ` xiaoqiang zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c5b37394680b8b4940236d7bc313be2@walle.cc \
    --to=michael@walle.cc \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=i.mitsyanko@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=zxq_yx_007@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).