qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Steven Sistare <steven.sistare@oracle.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, John Snow <jsnow@redhat.com>,
	Cleber Rosa <crosa@redhat.com>, Eric Blake <eblake@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	"Daniel P. Berrange" <berrange@redhat.com>,
	Eduardo Habkost <eduardo@habkost.net>,
	Fabiano Rosas <farosas@suse.de>,
	Laurent Vivier <lvivier@redhat.com>,
	devel@lists.libvirt.org
Subject: Re: [PATCH V1 0/6] fast qom tree get
Date: Mon, 28 Apr 2025 12:18:45 -0400	[thread overview]
Message-ID: <3c5e9e8d-a3c5-4179-800f-2c11d38b7b02@oracle.com> (raw)
In-Reply-To: <87selszp8o.fsf@pond.sub.org>

On 4/28/2025 4:04 AM, Markus Armbruster wrote:
> Steven Sistare <steven.sistare@oracle.com> writes:
> 
>> On 4/9/2025 3:39 AM, Markus Armbruster wrote:
>>> Hi Steve, I apologize for the slow response.
>>>
>>> Steve Sistare <steven.sistare@oracle.com> writes:
>>>
>>>> Using qom-list and qom-get to get all the nodes and property values in a
>>>> QOM tree can take multiple seconds because it requires 1000's of individual
>>>> QOM requests.  Some managers fetch the entire tree or a large subset
>>>> of it when starting a new VM, and this cost is a substantial fraction of
>>>> start up time.
>>>
>>> "Some managers"... could you name one?
>>
>> My personal experience is with Oracle's OCI, but likely others could benefit.
> 
> Elsewhere in this thread, we examined libvirt's use qom-get.  Its use of
> qom-get is also noticably slow, and your work could speed it up.
> However, most of its use is for working around QMP interface
> shortcomings around probing CPU flags.  Addressing these would help it
> even more.
> 
> This makes me wonder what questions Oracle's OCI answers with the help
> of qom-get.  Can you briefly describe them?
> 
> Even if OCI would likewise be helped more by better QMP queries, your
> fast qom tree get work might still be useful.

We already optimized our queries as a first step, but what remains is still
significant, which is why I submitted this RFE.

- Steve



  reply	other threads:[~2025-04-28 16:19 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-03 21:09 [PATCH V1 0/6] fast qom tree get Steve Sistare
2025-03-03 21:09 ` [PATCH V1 1/6] qom: qom_resolve_path Steve Sistare
2025-05-06 14:25   ` Philippe Mathieu-Daudé
2025-03-03 21:09 ` [PATCH V1 2/6] qom: qom-tree-get Steve Sistare
2025-03-03 21:09 ` [PATCH V1 3/6] python: use qom-tree-get Steve Sistare
2025-03-03 21:10 ` [PATCH V1 4/6] tests/qtest/qom-test: unit test for qom-tree-get Steve Sistare
2025-03-03 21:10 ` [PATCH V1 5/6] qom: qom-list-getv Steve Sistare
2025-03-03 21:10 ` [PATCH V1 6/6] tests/qtest/qom-test: unit test for qom-list-getv Steve Sistare
2025-04-09  7:39 ` [PATCH V1 0/6] fast qom tree get Markus Armbruster
2025-04-09  7:58   ` Peter Krempa
2025-04-11 10:11     ` Daniel P. Berrangé
2025-04-11 10:40       ` Management applications and CPU feature flags (was: [PATCH V1 0/6] fast qom tree get) Markus Armbruster
2025-04-11 10:43         ` Daniel P. Berrangé
2025-04-11 11:43           ` Management applications and CPU feature flags Markus Armbruster
2025-04-11 12:00             ` David Hildenbrand
2025-04-11 13:23             ` Jiri Denemark
2025-04-11 13:58               ` Cornelia Huck
2025-04-15 11:33                 ` Jiří Denemark
2025-04-09 12:42   ` [PATCH V1 0/6] fast qom tree get Steven Sistare
2025-04-09 13:34     ` Markus Armbruster
2025-04-09 14:06       ` Steven Sistare
2025-04-09 14:44         ` Markus Armbruster
2025-04-09 15:14           ` Steven Sistare
2025-04-10  5:57             ` Markus Armbruster
2025-04-28  8:04     ` Markus Armbruster
2025-04-28 16:18       ` Steven Sistare [this message]
2025-04-29  6:02         ` Markus Armbruster
2025-05-02 16:19           ` Steven Sistare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c5e9e8d-a3c5-4179-800f-2c11d38b7b02@oracle.com \
    --to=steven.sistare@oracle.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=crosa@redhat.com \
    --cc=devel@lists.libvirt.org \
    --cc=eblake@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=farosas@suse.de \
    --cc=jsnow@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).