From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Cole Robinson <crobinso@redhat.com>, qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [PATCH] vhost-user-gpu: Drop trailing json comma
Date: Fri, 20 Sep 2019 11:06:56 +0200 [thread overview]
Message-ID: <3c5f289e-3f9c-d243-0a67-846ba853acb7@redhat.com> (raw)
In-Reply-To: <7f5dd2ac9f3504e2699f23e69bc3d8051b729832.1568925097.git.crobinso@redhat.com>
On 9/19/19 10:33 PM, Cole Robinson wrote:
> Trailing comma is not valid json:
>
> $ cat contrib/vhost-user-gpu/50-qemu-gpu.json.in | jq
> parse error: Expected another key-value pair at line 5, column 1
Shouldn't we add this as a test?
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
> contrib/vhost-user-gpu/50-qemu-gpu.json.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/vhost-user-gpu/50-qemu-gpu.json.in b/contrib/vhost-user-gpu/50-qemu-gpu.json.in
> index 658b545864..f5edd097f8 100644
> --- a/contrib/vhost-user-gpu/50-qemu-gpu.json.in
> +++ b/contrib/vhost-user-gpu/50-qemu-gpu.json.in
> @@ -1,5 +1,5 @@
> {
> "description": "QEMU vhost-user-gpu",
> "type": "gpu",
> - "binary": "@libexecdir@/vhost-user-gpu",
> + "binary": "@libexecdir@/vhost-user-gpu"
> }
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
prev parent reply other threads:[~2019-09-20 9:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 20:33 [PATCH] vhost-user-gpu: Drop trailing json comma Cole Robinson
2019-09-20 6:17 ` Marc-André Lureau
2019-09-20 7:27 ` Li Qiang
2019-09-20 9:06 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c5f289e-3f9c-d243-0a67-846ba853acb7@redhat.com \
--to=philmd@redhat.com \
--cc=crobinso@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).