* [PATCH] vhost-user-gpu: Drop trailing json comma
@ 2019-09-19 20:33 Cole Robinson
2019-09-20 6:17 ` Marc-André Lureau
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Cole Robinson @ 2019-09-19 20:33 UTC (permalink / raw)
To: qemu-devel; +Cc: Marc-André Lureau, Gerd Hoffmann, Cole Robinson
Trailing comma is not valid json:
$ cat contrib/vhost-user-gpu/50-qemu-gpu.json.in | jq
parse error: Expected another key-value pair at line 5, column 1
Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
contrib/vhost-user-gpu/50-qemu-gpu.json.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/vhost-user-gpu/50-qemu-gpu.json.in b/contrib/vhost-user-gpu/50-qemu-gpu.json.in
index 658b545864..f5edd097f8 100644
--- a/contrib/vhost-user-gpu/50-qemu-gpu.json.in
+++ b/contrib/vhost-user-gpu/50-qemu-gpu.json.in
@@ -1,5 +1,5 @@
{
"description": "QEMU vhost-user-gpu",
"type": "gpu",
- "binary": "@libexecdir@/vhost-user-gpu",
+ "binary": "@libexecdir@/vhost-user-gpu"
}
--
2.23.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] vhost-user-gpu: Drop trailing json comma
2019-09-19 20:33 [PATCH] vhost-user-gpu: Drop trailing json comma Cole Robinson
@ 2019-09-20 6:17 ` Marc-André Lureau
2019-09-20 7:27 ` Li Qiang
2019-09-20 9:06 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Marc-André Lureau @ 2019-09-20 6:17 UTC (permalink / raw)
To: Cole Robinson; +Cc: QEMU, Gerd Hoffmann
On Fri, Sep 20, 2019 at 12:34 AM Cole Robinson <crobinso@redhat.com> wrote:
>
> Trailing comma is not valid json:
>
> $ cat contrib/vhost-user-gpu/50-qemu-gpu.json.in | jq
> parse error: Expected another key-value pair at line 5, column 1
>
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
oh json..
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> contrib/vhost-user-gpu/50-qemu-gpu.json.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/vhost-user-gpu/50-qemu-gpu.json.in b/contrib/vhost-user-gpu/50-qemu-gpu.json.in
> index 658b545864..f5edd097f8 100644
> --- a/contrib/vhost-user-gpu/50-qemu-gpu.json.in
> +++ b/contrib/vhost-user-gpu/50-qemu-gpu.json.in
> @@ -1,5 +1,5 @@
> {
> "description": "QEMU vhost-user-gpu",
> "type": "gpu",
> - "binary": "@libexecdir@/vhost-user-gpu",
> + "binary": "@libexecdir@/vhost-user-gpu"
> }
> --
> 2.23.0
>
>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] vhost-user-gpu: Drop trailing json comma
2019-09-19 20:33 [PATCH] vhost-user-gpu: Drop trailing json comma Cole Robinson
2019-09-20 6:17 ` Marc-André Lureau
@ 2019-09-20 7:27 ` Li Qiang
2019-09-20 9:06 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Li Qiang @ 2019-09-20 7:27 UTC (permalink / raw)
To: Cole Robinson; +Cc: Marc-André Lureau, Qemu Developers, Gerd Hoffmann
[-- Attachment #1: Type: text/plain, Size: 938 bytes --]
Cole Robinson <crobinso@redhat.com> 于2019年9月20日周五 上午4:34写道：
> Trailing comma is not valid json:
>
> $ cat contrib/vhost-user-gpu/50-qemu-gpu.json.in | jq
> parse error: Expected another key-value pair at line 5, column 1
>
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
> ---
> contrib/vhost-user-gpu/50-qemu-gpu.json.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/vhost-user-gpu/50-qemu-gpu.json.in
> b/contrib/vhost-user-gpu/50-qemu-gpu.json.in
> index 658b545864..f5edd097f8 100644
> --- a/contrib/vhost-user-gpu/50-qemu-gpu.json.in
> +++ b/contrib/vhost-user-gpu/50-qemu-gpu.json.in
> @@ -1,5 +1,5 @@
> {
> "description": "QEMU vhost-user-gpu",
> "type": "gpu",
> - "binary": "@libexecdir@/vhost-user-gpu",
> + "binary": "@libexecdir@/vhost-user-gpu"
> }
> --
> 2.23.0
>
>
>
[-- Attachment #2: Type: text/html, Size: 2108 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] vhost-user-gpu: Drop trailing json comma
2019-09-19 20:33 [PATCH] vhost-user-gpu: Drop trailing json comma Cole Robinson
2019-09-20 6:17 ` Marc-André Lureau
2019-09-20 7:27 ` Li Qiang
@ 2019-09-20 9:06 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-09-20 9:06 UTC (permalink / raw)
To: Cole Robinson, qemu-devel; +Cc: Marc-André Lureau, Gerd Hoffmann
On 9/19/19 10:33 PM, Cole Robinson wrote:
> Trailing comma is not valid json:
>
> $ cat contrib/vhost-user-gpu/50-qemu-gpu.json.in | jq
> parse error: Expected another key-value pair at line 5, column 1
Shouldn't we add this as a test?
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
> contrib/vhost-user-gpu/50-qemu-gpu.json.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/vhost-user-gpu/50-qemu-gpu.json.in b/contrib/vhost-user-gpu/50-qemu-gpu.json.in
> index 658b545864..f5edd097f8 100644
> --- a/contrib/vhost-user-gpu/50-qemu-gpu.json.in
> +++ b/contrib/vhost-user-gpu/50-qemu-gpu.json.in
> @@ -1,5 +1,5 @@
> {
> "description": "QEMU vhost-user-gpu",
> "type": "gpu",
> - "binary": "@libexecdir@/vhost-user-gpu",
> + "binary": "@libexecdir@/vhost-user-gpu"
> }
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-20 9:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-19 20:33 [PATCH] vhost-user-gpu: Drop trailing json comma Cole Robinson
2019-09-20 6:17 ` Marc-André Lureau
2019-09-20 7:27 ` Li Qiang
2019-09-20 9:06 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).