From: Max Reitz <mreitz@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>, John Snow <jsnow@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH 2/2] iotests: Set LC_ALL=C for sort
Date: Mon, 13 Jul 2020 09:55:36 +0200 [thread overview]
Message-ID: <3c718bfa-ae15-90b2-91d7-62222abb3372@redhat.com> (raw)
In-Reply-To: <87tuyeqvho.fsf@linaro.org>
[-- Attachment #1.1: Type: text/plain, Size: 817 bytes --]
On 11.07.20 10:57, Alex Bennée wrote:
>
> Max Reitz <mreitz@redhat.com> writes:
>
>> Otherwise the result is basically unpredictable.
>>
>> (Note that the precise environment variable to control sorting order is
>> LC_COLLATE, but LC_ALL overrides LC_COLLATE, and we do not want the
>> sorting order to be messed up if LC_ALL is set in the environment.)
>>
>> Reported-by: John Snow <jsnow@redhat.com>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>
> Queued to pr/100720-testing-and-misc-2, thanks.
>
> I've skipped patch 1/2 for now as I have an alternative fix but we can
> switch it back if you prefer?
I see you’ve sent your pull request already, so I’ll see whether I’ll
include 1/2 in some block pull request. Maybe, maybe not.
Thanks for queuing 2/2, anyway. :)
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-07-13 7:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 16:32 [PATCH 0/2] iotests: More _filter_img_create fixes Max Reitz
2020-07-10 16:32 ` [PATCH 1/2] iotests: Drop readarray from _do_filter_img_create Max Reitz
2020-07-10 16:39 ` Eric Blake
2020-07-10 21:02 ` Alex Bennée
2020-07-10 16:32 ` [PATCH 2/2] iotests: Set LC_ALL=C for sort Max Reitz
2020-07-10 16:43 ` Eric Blake
2020-07-11 8:57 ` Alex Bennée
2020-07-13 7:55 ` Max Reitz [this message]
2020-07-10 17:18 ` [PATCH 0/2] iotests: More _filter_img_create fixes John Snow
2020-07-13 6:19 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c718bfa-ae15-90b2-91d7-62222abb3372@redhat.com \
--to=mreitz@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).