From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org
Subject: Re: [PATCH v3 0/5] target/arm: Use tcg_constant_*
Date: Mon, 1 Nov 2021 13:41:10 -0400 [thread overview]
Message-ID: <3c74589f-dea1-6e56-c173-fc8e88b577bf@linaro.org> (raw)
In-Reply-To: <20211029231834.2476117-1-f4bug@amsat.org>
On 10/29/21 7:18 PM, Philippe Mathieu-Daudé wrote:
> Missing review: patches #2 & #5 (new)
>
> Introduce store_cpu_field_constant() helper to avoid using temporary
> when the value is constant (and read-only).
>
> Since v2:
> - Simplify store_cpu_field_constant(), do not modify store_cpu_field()
> - Added another use in gen_rev16()
>
> Philippe Mathieu-Daudé (5):
> target/arm: Use tcg_constant_i32() in op_smlad()
> target/arm: Introduce store_cpu_field_constant() helper
> target/arm: Use the constant variant of store_cpu_field() when
> possible
> target/arm: Use tcg_constant_i64() in do_sat_addsub_64()
> target/arm: Use tcg_constant_i32() in gen_rev16()
>
> target/arm/translate-a32.h | 3 +++
> target/arm/translate-sve.c | 17 ++++++++---------
> target/arm/translate.c | 27 ++++++++-------------------
> 3 files changed, 19 insertions(+), 28 deletions(-)
Thanks, applied to target-arm.next.
r~
prev parent reply other threads:[~2021-11-01 19:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 23:18 [PATCH v3 0/5] target/arm: Use tcg_constant_* Philippe Mathieu-Daudé
2021-10-29 23:18 ` [PATCH v3 1/5] target/arm: Use tcg_constant_i32() in op_smlad() Philippe Mathieu-Daudé
2021-10-29 23:18 ` [PATCH v3 2/5] target/arm: Introduce store_cpu_field_constant() helper Philippe Mathieu-Daudé
2021-10-30 23:45 ` Richard Henderson
2021-10-29 23:18 ` [PATCH v3 3/5] target/arm: Use the constant variant of store_cpu_field() when possible Philippe Mathieu-Daudé
2021-10-29 23:18 ` [PATCH v3 4/5] target/arm: Use tcg_constant_i64() in do_sat_addsub_64() Philippe Mathieu-Daudé
2021-10-29 23:18 ` [PATCH v3 5/5] target/arm: Use tcg_constant_i32() in gen_rev16() Philippe Mathieu-Daudé
2021-10-30 23:46 ` Richard Henderson
2021-11-01 17:41 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c74589f-dea1-6e56-c173-fc8e88b577bf@linaro.org \
--to=richard.henderson@linaro.org \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).