From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43693C433E2 for ; Thu, 10 Sep 2020 16:02:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B54D92087C for ; Thu, 10 Sep 2020 16:02:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XK2pWnCc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B54D92087C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34702 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGP1x-0007r0-FM for qemu-devel@archiver.kernel.org; Thu, 10 Sep 2020 12:02:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49258) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGP0Y-0005lz-53 for qemu-devel@nongnu.org; Thu, 10 Sep 2020 12:01:10 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:42430 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kGP0U-00050X-Hv for qemu-devel@nongnu.org; Thu, 10 Sep 2020 12:01:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599753663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mf1iChBZ5UgD/M3uVbat/D3fg0eS4kQNtkJAzBqMeME=; b=XK2pWnCcbdkOqp99dxPg919sbFgNWVa//DQ3Aapdk0r7Vt4AyeMJUBb7MBvrY37HsG9JXZ UPXKBK6kaLneUaUNRQcjIWGFFXYyH+nhMk2jPrwZzODupCuxKKrpsZMOMAKwOXisimBLXj GZJGYY9B3p4SBlp5TYlFfF1W+oaRhhE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-530-2RYp7mVjNqe8IYn2itl6bQ-1; Thu, 10 Sep 2020 12:00:55 -0400 X-MC-Unique: 2RYp7mVjNqe8IYn2itl6bQ-1 Received: by mail-wm1-f72.google.com with SMTP id w3so153664wmg.4 for ; Thu, 10 Sep 2020 09:00:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:autocrypt:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mf1iChBZ5UgD/M3uVbat/D3fg0eS4kQNtkJAzBqMeME=; b=O7CLh1vCOhkVeC1eUqKAOoutwibDQLlQc1LJmajZVFnqX4w7meyNa+2YGozY/lLO7R QinbLl/Z+Xn0of6o1AMDoYVHFiq2gXfzpKJyePx5n15oiWU54F4P73ieSOMJnhLqBjCy Jfj/A8AihNv+ng3fzqbGxsHQiurUf0FT0+BHyKeIzPPXKCuX3/e65FRTeuegTj3KXO6f tA61TasyyeAp1fkvPNopu5LULMrqyCkSwzAWPXkIMGOIK5It8SVuCmb56d5fPfFs3k48 /4GI72o11DA+qDd8VYUnA9/+VM/qJpbzLxr7BmWRdjr+Waw1Qe3ru4yTIBpz4Z2GzYly XZmw== X-Gm-Message-State: AOAM531OFYcdPFwuoa8hIeVW9bS5+SV2AToG9wXJDFW+lldNRZP51BR7 t/JyIt/83bZF5WChtvA5Npp9szeTCRxY9lmsodeRaa1UQC9lThlr0gmC4uT8iN5olyIA523xa7T ikOjwGbzB53n85E0= X-Received: by 2002:adf:eacb:: with SMTP id o11mr9484799wrn.209.1599753654158; Thu, 10 Sep 2020 09:00:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxDHzM+Veh/DnHrKPplXTDMoMTQgz1HC00Li6/MjskYac9vKDJTiIjZYxmwESWvrrPcJ1dTTQ== X-Received: by 2002:adf:eacb:: with SMTP id o11mr9484750wrn.209.1599753653799; Thu, 10 Sep 2020 09:00:53 -0700 (PDT) Received: from [192.168.1.36] (65.red-83-57-170.dynamicip.rima-tde.net. [83.57.170.65]) by smtp.gmail.com with ESMTPSA id a83sm4217918wmh.48.2020.09.10.09.00.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Sep 2020 09:00:53 -0700 (PDT) Subject: Re: [PATCH 05/10] roms/edk2: update submodule from edk2-stable201905 to edk2-stable202008 To: Laszlo Ersek , qemu devel list References: <20200908072939.30178-1-lersek@redhat.com> <20200908072939.30178-6-lersek@redhat.com> <1356c404-517c-cf5c-bc04-04237c03f572@redhat.com> <2e0b207b-d902-f56c-18d7-50998c7de991@redhat.com> <0309f104-854a-840b-8ec3-fb50960d7821@redhat.com> <96e060e8-767c-9f2c-942e-597b38473846@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: <3c7cc69e-566e-b405-f1da-c4e56c5c8e46@redhat.com> Date: Thu, 10 Sep 2020 18:00:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <96e060e8-767c-9f2c-942e-597b38473846@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=205.139.110.120; envelope-from=philmd@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/10 09:07:42 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -56 X-Spam_score: -5.7 X-Spam_bar: ----- X-Spam_report: (-5.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-3.576, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/10/20 5:44 PM, Laszlo Ersek wrote: > On 09/10/20 17:32, Philippe Mathieu-Daudé wrote: >> On 9/8/20 2:08 PM, Laszlo Ersek wrote: >>> On 09/08/20 10:22, Philippe Mathieu-Daudé wrote: >>>> Hi Laszlo, >>>> >>>> On 9/8/20 9:29 AM, Laszlo Ersek wrote: >>>>> Update the edk2 submodule from release edk2-stable201905 to >>>>> edk2-stable202008. The release notes can be read at >>>> [...] >>>>> >>>>> Cc: Philippe Mathieu-Daudé >>>>> Ref: https://bugs.launchpad.net/qemu/+bug/1852196 >>>>> Signed-off-by: Laszlo Ersek >>>>> --- >>>>> roms/edk2 | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/roms/edk2 b/roms/edk2 >>>>> index 20d2e5a125e3..06dc822d045c 160000 >>>>> --- a/roms/edk2 >>>>> +++ b/roms/edk2 >>>>> @@ -1 +1 @@ >>>>> -Subproject commit 20d2e5a125e34fc8501026613a71549b2a1a3e54 >>>>> +Subproject commit 06dc822d045c2bb42e497487935485302486e151 >>>> >>>> FYI applying this I got: >>>> >>>> Fetching submodule roms/edk2 >>>> Fetching submodule roms/edk2/CryptoPkg/Library/OpensslLib/openssl >>>> From https://github.com/openssl/openssl >>>> Could not access submodule 'krb5' >>>> Errors during submodule fetch: >>>> CryptoPkg/Library/OpensslLib/openssl >>>> Errors during submodule fetch: >>>> roms/edk2 >>>> >>>> Probably harmless, as if one care about this submodule, >>>> will run "make edk2-basetools" which runs 'git submodule >>>> update --init --force' and silently fixes the submodules. >>>> >>> >>> Did you pass the "--recursive" option to the "git submodule" perhaps? >> >> No I didn't used it. > > So what was the precise command? git-am, git-fetch, or something else?... I only used: git submodule sync git submodule update > > I'm asking because I've genuinely not seen git attempt to fetch edk2 -> > openssl -> krb, apart from "--recursive". > > (Anyway, I don't think I can do anything about the krb5 fetch...) Yeah I'm not worried about this, I was just curious. > > Thanks! > Laszlo > >> >>> >>> (Because, krb5 is a submodule of edk2's openssl submodule.) >>> >>> "--recursive" should not be used. See "ReadMe.rst" in edk2: >>> >>> """ >>> Note: When cloning submodule repos, '--recursive' option is not >>> recommended. EDK II itself will not use any code/feature from >>> submodules in above submodules. So using '--recursive' adds a >>> dependency on being able to reach servers we do not actually want >>> any code from, as well as needlessly downloading code we will not >>> use. >>> """ >>> >>> QEMU's current submodules do not require the usage of "--recursive". >>> >>> Thanks >>> Laszlo >>> >> >