From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49578) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cRiQi-0004Mq-A0 for qemu-devel@nongnu.org; Thu, 12 Jan 2017 11:40:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cRiQe-0007Vl-92 for qemu-devel@nongnu.org; Thu, 12 Jan 2017 11:40:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43976) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cRiQe-0007VI-0d for qemu-devel@nongnu.org; Thu, 12 Jan 2017 11:40:44 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1F627C0C189C for ; Thu, 12 Jan 2017 16:40:44 +0000 (UTC) References: <20170111173528.30510-1-lersek@redhat.com> <20170111173528.30510-4-lersek@redhat.com> <20170112124049.GJ3565@thinpad.lan.raisama.net> From: Laszlo Ersek Message-ID: <3c7d0bf4-08d9-c643-697d-c2597bd3780a@redhat.com> Date: Thu, 12 Jan 2017 17:40:40 +0100 MIME-Version: 1.0 In-Reply-To: <20170112124049.GJ3565@thinpad.lan.raisama.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 wave 2 3/3] hw/isa/lpc_ich9: negotiate SMI broadcast on pc-q35-2.9+ machine types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu devel list , "Michael S. Tsirkin" , Gerd Hoffmann , Igor Mammedov , Paolo Bonzini On 01/12/17 13:40, Eduardo Habkost wrote: > On Wed, Jan 11, 2017 at 06:35:28PM +0100, Laszlo Ersek wrote: >> Cc: "Michael S. Tsirkin" >> Cc: Eduardo Habkost >> Cc: Gerd Hoffmann >> Cc: Igor Mammedov >> Cc: Paolo Bonzini >> Signed-off-by: Laszlo Ersek >> --- >> >> Notes: >> v5: >> - replace the v4 patch "hw/i386/pc_q35: advertise broadcast SMI if VCPU >> hotplug is turned off" with a simple device property and compat >> setting [Igor] >> >> include/hw/i386/pc.h | 5 +++++ >> hw/isa/lpc_ich9.c | 2 ++ >> 2 files changed, 7 insertions(+) >> >> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h >> index 230e9e70c504..fb8ca7c907f6 100644 >> --- a/include/hw/i386/pc.h >> +++ b/include/hw/i386/pc.h >> @@ -376,6 +376,11 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *); >> >> #define PC_COMPAT_2_8 \ >> HW_COMPAT_2_8 \ >> + {\ >> + .driver = "ICH9-LPC",\ >> + .property = "smi_broadcast",\ >> + .value = "off",\ >> + },\ >> >> >> #define PC_COMPAT_2_7 \ >> diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c >> index ced6f803a4f2..27fae5144744 100644 >> --- a/hw/isa/lpc_ich9.c >> +++ b/hw/isa/lpc_ich9.c >> @@ -776,6 +776,8 @@ static const VMStateDescription vmstate_ich9_lpc = { >> >> static Property ich9_lpc_properties[] = { >> DEFINE_PROP_BOOL("noreboot", ICH9LPCState, pin_strap.spkr_hi, true), >> + DEFINE_PROP_BIT64("smi_broadcast", ICH9LPCState, smi_host_features, >> + ICH9_LPC_SMI_F_BROADCAST_BIT, true), > > Please use hyphens instead of underscores on QOM property names. Will do, thank you. > > Also, if this is not supposed to be configured directly by the > user, please use a "x-" prefix. Hmm, for "normal use", the user is not supposed to mess with it, correct. However, at least for testing OVMF's behavior when the negotiation is available vs. unavailable, the flag is useful on the command line too (although the same effect can be achieved with selecting pc-q35-2.8 vs. pc-q35-2.9). What does this imply?... Okay, I think I convinced myself that this should be called x-smi-broadcast. Ultimately I don't think libvirt should ever try to set this property, for example. > With that fixed: > > Reviewed-by: Eduardo Habkost > Many thanks! Laszlo