From: Eric Farman <farman@linux.ibm.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
cohuck@redhat.com, Juan Quintela <quintela@redhat.com>
Subject: Re: [PATCH] pc-bios/s390-ccw: Get rid of the the __u* types
Date: Tue, 27 Jun 2023 08:03:04 -0400 [thread overview]
Message-ID: <3c7d925e0d0f4750a678aa1d7f3270a9ba58abab.camel@linux.ibm.com> (raw)
In-Reply-To: <20230627114101.122231-1-thuth@redhat.com>
On Tue, 2023-06-27 at 13:41 +0200, Thomas Huth wrote:
> Using types starting with double underscores should be avoided since
> these
> names are marked as reserved by the C standard. The corresponding
> Linux
> kernel header file has also been changed accordingly a long time ago:
>
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/dif
> f/drivers/s390/cio/cio.h?id=cd6b4f27b9bb2a
>
> So we should get rid of the __u* in the s390-ccw bios now finally,
> too.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> Based-on: <20230510143925.4094-4-quintela@redhat.com>
>
> pc-bios/s390-ccw/cio.h | 232 ++++++++++++++++++----------------
> --
> pc-bios/s390-ccw/s390-ccw.h | 4 -
> 2 files changed, 116 insertions(+), 120 deletions(-)
Thanks for the based-on hint.
Reviewed-by: Eric Farman <farman@linux.ibm.com>
next prev parent reply other threads:[~2023-06-27 12:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 11:41 [PATCH] pc-bios/s390-ccw: Get rid of the the __u* types Thomas Huth
2023-06-27 11:58 ` Claudio Imbrenda
2023-06-27 12:03 ` Eric Farman [this message]
2023-06-27 12:03 ` Juan Quintela
2023-06-27 12:19 ` Christian Borntraeger
2023-06-28 8:32 ` Thomas Huth
2023-06-28 8:35 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c7d925e0d0f4750a678aa1d7f3270a9ba58abab.camel@linux.ibm.com \
--to=farman@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=imbrenda@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).