Re: [PATCH] .cirrus.yml: Change winsymlinks to 'native'

[Thomas Huth <thuth@redhat.com>]

On 19/07/2022 18.12, Bin Meng wrote:
> From: Bin Meng <bin.meng@windriver.com>
> 
> At present winsymlinks is set to 'nativestrict', and its behavior is:
> 
>    a) if native symlinks are enabled and <target> exists, creates
>       <destination> as a native Windows symlink;
>    b) else if native symlinks are not enabled or if <target> does
>       not exist, 'ln -s' fails.
> 
> This causes the following error message was seen during the configure:
> 
>    "ln: failed to create symbolic link
>    'x86_64-softmmu/qemu-system-x86_64.exe': No such file or directory"
> 
> Change winsymlinks to 'native' whose behavior is most similar to the
> behavior of 'ln -s' on *nix, that is:
> 
>    a) if native symlinks are enabled, and whether <target> exists
>       or not, creates <destination> as a native Windows symlink;
>    b) else if native symlinks are not enabled, and whether <target>
>       exists or not, 'ln -s' creates as a Windows shortcut file.
> 
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> ---
> 
>   .cirrus.yml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.cirrus.yml b/.cirrus.yml
> index 20843a420c..eac39024f2 100644
> --- a/.cirrus.yml
> +++ b/.cirrus.yml
> @@ -10,7 +10,7 @@ windows_msys2_task:
>       memory: 8G
>     env:
>       CIRRUS_SHELL: powershell
> -    MSYS: winsymlinks:nativestrict
> +    MSYS: winsymlinks:native
>       MSYSTEM: MINGW64
>       MSYS2_URL: https://github.com/msys2/msys2-installer/releases/download/2022-05-03/msys2-base-x86_64-20220503.sfx.exe
>       MSYS2_FINGERPRINT: 0

Acked-by: Thomas Huth <thuth@redhat.com>

Alex, if I've got that right, you're currently assembling a "testing" pull 
request - could you please pick up this patch for that, too? ... I currently 
don't have anything else pending right now, so I don't plan any new pull 
request soon.

  Thomas