From: Auger Eric <eric.auger@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
eric.auger.pro@gmail.com, qemu-devel@nongnu.org,
berrange@redhat.com, ehabkost@redhat.com, armbru@redhat.com
Subject: Re: [PATCH] qom: Allow object_property_add_child() to fail
Date: Tue, 23 Jun 2020 18:24:03 +0200 [thread overview]
Message-ID: <3c9b1afa-2df6-9c1d-0e05-1c98921ca6e9@redhat.com> (raw)
In-Reply-To: <05765f9d-7981-4d1d-6569-5eb18d8dcaf2@redhat.com>
Hi Paolo,
On 6/23/20 6:22 PM, Paolo Bonzini wrote:
> On 23/06/20 17:54, Eric Auger wrote:
>> This patch introduces two new functions, object_property_add_err() and
>> object_property_add_child_err() whose prototype features an error handle.
>> object_property_add_child_err() now gets called from user_creatable_add_type.
>> This solution was chosen instead of changing the prototype of existing
>> functions because the number of existing callers is huge.
>
> The idea is good, but I would rather name the functions
> object_property_try_add{,_child} to follow e.g. g_try_malloc.
>
> In fact, the existing function object_property_try_add can simply be
> made non-static.
Sure I will respin accordingly
Thanks
Eric
>
> Paolo
>
next prev parent reply other threads:[~2020-06-23 16:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 15:54 [PATCH] qom: Allow object_property_add_child() to fail Eric Auger
2020-06-23 16:05 ` Daniel P. Berrangé
2020-06-23 16:20 ` Paolo Bonzini
2020-06-23 16:22 ` Paolo Bonzini
2020-06-23 16:24 ` Auger Eric [this message]
2020-06-23 16:23 ` Paolo Bonzini
2020-06-24 8:22 ` Markus Armbruster
2020-06-24 8:40 ` Auger Eric
2020-06-24 8:51 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c9b1afa-2df6-9c1d-0e05-1c98921ca6e9@redhat.com \
--to=eric.auger@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).