From: Thomas Huth <thuth@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
QEMU Trivial <qemu-trivial@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] aio-posix: drop QEMU_AIO_POLL_MAX_NS env var
Date: Thu, 2 Nov 2017 07:31:13 +0100 [thread overview]
Message-ID: <3ca6376a-ae3e-1e5c-503f-239e4e62799c@redhat.com> (raw)
In-Reply-To: <20170126153837.25597-1-stefanha@redhat.com>
On 26.01.2017 16:38, Stefan Hajnoczi wrote:
> This hunk should not have been merged but I forgot to remove it. Let's
> remove it before it slips into a QEMU release.
Too late - looks like this patch has never been committed :-(
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> aio-posix.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/aio-posix.c b/aio-posix.c
> index 9453d83..9a6348b 100644
> --- a/aio-posix.c
> +++ b/aio-posix.c
> @@ -723,13 +723,6 @@ bool aio_poll(AioContext *ctx, bool blocking)
>
> void aio_context_setup(AioContext *ctx)
> {
> - /* TODO remove this in final patch submission */
> - if (getenv("QEMU_AIO_POLL_MAX_NS")) {
> - fprintf(stderr, "The QEMU_AIO_POLL_MAX_NS environment variable has "
> - "been replaced with -object iothread,poll-max-ns=NUM\n");
> - exit(1);
> - }
> -
> #ifdef CONFIG_EPOLL_CREATE1
> assert(!ctx->epollfd);
> ctx->epollfd = epoll_create1(EPOLL_CLOEXEC);
>
Could we get this at least added for QEMU 2.11 ?
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2017-11-02 6:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 15:38 [Qemu-devel] [PATCH] aio-posix: drop QEMU_AIO_POLL_MAX_NS env var Stefan Hajnoczi
2017-11-02 6:31 ` Thomas Huth [this message]
2017-11-03 15:16 ` Stefan Hajnoczi
-- strict thread matches above, loose matches on Subject: below --
2017-11-03 15:40 Stefan Hajnoczi
2017-11-06 13:04 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ca6376a-ae3e-1e5c-503f-239e4e62799c@redhat.com \
--to=thuth@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).