Re: [PATCH 01/12] stubs: add isa_create_simple

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 4/29/20 1:02 PM, Gerd Hoffmann wrote:
> Needed for -soundhw cleanup.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>   stubs/isa-bus.c     | 7 +++++++
>   stubs/Makefile.objs | 1 +
>   2 files changed, 8 insertions(+)
>   create mode 100644 stubs/isa-bus.c
> 
> diff --git a/stubs/isa-bus.c b/stubs/isa-bus.c
> new file mode 100644
> index 000000000000..cbebaed4ad04
> --- /dev/null
> +++ b/stubs/isa-bus.c
> @@ -0,0 +1,7 @@
> +#include "qemu/osdep.h"
> +#include "hw/isa/isa.h"
> +
> +ISADevice *isa_create_simple(ISABus *bus, const char *name)
> +{
> +    return NULL;

We want:

        g_assert_not_reached();

Otherwise:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> +}
> diff --git a/stubs/Makefile.objs b/stubs/Makefile.objs
> index 45be5dc0ed78..c61ff38cc801 100644
> --- a/stubs/Makefile.objs
> +++ b/stubs/Makefile.objs
> @@ -13,6 +13,7 @@ stub-obj-y += get-vm-name.o
>   stub-obj-y += iothread.o
>   stub-obj-y += iothread-lock.o
>   stub-obj-y += is-daemonized.o
> +stub-obj-y += isa-bus.o
>   stub-obj-$(CONFIG_LINUX_AIO) += linux-aio.o
>   stub-obj-$(CONFIG_LINUX_IO_URING) += io_uring.o
>   stub-obj-y += machine-init-done.o
>