From: Sourojeet Adhikari <s23adhik@csclub.uwaterloo.ca>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, philmd@linaro.org, qemu-arm@nongnu.org
Subject: [PATCH] bcm2838: Add GIC-400 timer interupt connections
Date: Sat, 15 Feb 2025 22:54:42 -0500 [thread overview]
Message-ID: <3cca4eb3-09d1-4467-81fd-27a5bfe19a3e@csclub.uwaterloo.ca> (raw)
Hello everyone,
This patch adds support for the system timer interrupts
in QEMU's BCM2838 model. It defines a new constant
called GIC400_TIMER_INT, and connects 4 timer interupts
to the GIC-400.
Previously timer interupts were not being routed to the
interupt controller, causing scheduling, and some other
stuff to have issues (me and a few friends bumped into
this, and that's why this was written lol).
Signed-off-by: Sourojeet Adhikari <s23adhik@csclub.uwaterloo.ca>
---
hw/arm/bcm2838.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/hw/arm/bcm2838.c b/hw/arm/bcm2838.c
index ddb7c5f..0a4179f 100644
--- a/hw/arm/bcm2838.c
+++ b/hw/arm/bcm2838.c
@@ -21,6 +21,8 @@
#define GIC400_TIMER_S_EL1_IRQ 13
#define GIC400_TIMER_NS_EL1_IRQ 14
#define GIC400_LEGACY_IRQ 15
+#define GIC400_TIMER_INT (96 - 32)
+
/* Number of external interrupt lines to configure the GIC with */
#define GIC_NUM_IRQS 192
@@ -176,6 +178,15 @@ static void bcm2838_realize(DeviceState *dev, Error
**errp)
qdev_get_gpio_in(gicdev, PPI(n, VIRTUAL_PMU_IRQ)));
}
+ sysbus_connect_irq(SYS_BUS_DEVICE(&ps_base->systmr), 0,
+ qdev_get_gpio_in(DEVICE(&s->gic), GIC400_TIMER_INT +
INTERRUPT_TIMER0));
+ sysbus_connect_irq(SYS_BUS_DEVICE(&ps_base->systmr), 1,
+ qdev_get_gpio_in(DEVICE(&s->gic), GIC400_TIMER_INT +
INTERRUPT_TIMER1));
+ sysbus_connect_irq(SYS_BUS_DEVICE(&ps_base->systmr), 2,
+ qdev_get_gpio_in(DEVICE(&s->gic), GIC400_TIMER_INT +
INTERRUPT_TIMER2));
+ sysbus_connect_irq(SYS_BUS_DEVICE(&ps_base->systmr), 3,
+ qdev_get_gpio_in(DEVICE(&s->gic), GIC400_TIMER_INT +
INTERRUPT_TIMER3));
+
/* Connect UART0 to the interrupt controller */
sysbus_connect_irq(SYS_BUS_DEVICE(&ps_base->uart0), 0,
qdev_get_gpio_in(gicdev, GIC_SPI_INTERRUPT_UART0));
--
2.48.1
next reply other threads:[~2025-02-16 5:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-16 3:54 Sourojeet Adhikari [this message]
2025-02-24 13:22 ` [PATCH] bcm2838: Add GIC-400 timer interupt connections Peter Maydell
2025-02-27 9:15 ` Sourojeet Adhikari
2025-02-27 15:17 ` Peter Maydell
2025-03-01 1:47 ` Sourojeet Adhikari
2025-03-01 14:09 ` Peter Maydell
2025-03-10 6:29 ` Sourojeet Adhikari
2025-03-10 10:49 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cca4eb3-09d1-4467-81fd-27a5bfe19a3e@csclub.uwaterloo.ca \
--to=s23adhik@csclub.uwaterloo.ca \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).