From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bm4YB-0002AY-Hx for qemu-devel@nongnu.org; Mon, 19 Sep 2016 15:48:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bm4J5-0006oE-Gd for qemu-devel@nongnu.org; Mon, 19 Sep 2016 15:32:48 -0400 References: <1474304097-5790-1-git-send-email-kwolf@redhat.com> <1474304097-5790-7-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <3cd054cb-5154-f19b-aba9-b4543a8a4995@redhat.com> Date: Mon, 19 Sep 2016 14:32:41 -0500 MIME-Version: 1.0 In-Reply-To: <1474304097-5790-7-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Mgn8UXh4jKo6EAHvVX5II10Ogwunf0bKd" Subject: Re: [Qemu-devel] [PATCH v2 06/10] block: Accept device model name for x-blockdev-remove-medium List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, jsnow@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Mgn8UXh4jKo6EAHvVX5II10Ogwunf0bKd From: Eric Blake To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, jsnow@redhat.com, qemu-devel@nongnu.org Message-ID: <3cd054cb-5154-f19b-aba9-b4543a8a4995@redhat.com> Subject: Re: [PATCH v2 06/10] block: Accept device model name for x-blockdev-remove-medium References: <1474304097-5790-1-git-send-email-kwolf@redhat.com> <1474304097-5790-7-git-send-email-kwolf@redhat.com> In-Reply-To: <1474304097-5790-7-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/19/2016 11:54 AM, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow qdev device names in all device related > commands. >=20 > This converts x-blockdev-remove-medium to accept a qdev device name. >=20 > As the command is experimental, we can still remove the 'device' option= > that uses the BlockBackend name. This requires some test case changes > and is left for another series. >=20 > Signed-off-by: Kevin Wolf > --- > blockdev.c | 28 ++++++++++++++++------------ > qapi/block-core.json | 7 +++++-- > qmp-commands.hx | 14 ++++++++------ > 3 files changed, 29 insertions(+), 20 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Mgn8UXh4jKo6EAHvVX5II10Ogwunf0bKd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX4D1ZAAoJEKeha0olJ0NqF2AH/3Kj4pPiD4xb1soHuf+68vet eJBBhZzg7wPfXQKT3I118/gMfRJkE/TN1IumfE5EPBjAEqVqgpfQbdYbYkdNF0TD hLUeyWIwjyLAO550pIN5apZVUH73jnWWsYu69UAyEZpB8b4BFJz03UowZOUqYDcy 1SIl7xjR9NcaaFZLY3linkXoUyyiqR74oEjO8dhB3OhNapRh3Cj1ycQbArXrlPuo lvm90gMeu43EG0AAipqfnALaHh+us4s36HT4G4LOY4+ypP7rnKLYkFJxeCsM5K3w 66dZkgYZrnbj/RjsDRP5BTs7CtDwaRZatqMHIXD+Km49sxAnA1qR6NKqabI2BY4= =3hNO -----END PGP SIGNATURE----- --Mgn8UXh4jKo6EAHvVX5II10Ogwunf0bKd--