qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Claudio Fontana <cfontana@suse.de>
Cc: qemu-devel@nongnu.org,
	Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>,
	QEMU Trivial <qemu-trivial@nongnu.org>
Subject: Re: [PATCH] stubs: update replay-tools to match replay.h types
Date: Mon, 4 Jul 2022 16:18:21 +0200	[thread overview]
Message-ID: <3cd71c14-12ea-f02c-5d02-21803d3c4b9f@redhat.com> (raw)
In-Reply-To: <20220704075832.31537-1-cfontana@suse.de>

On 04/07/2022 09.58, Claudio Fontana wrote:
> detected with GCC 13 [-Werror=enum-int-mismatch]
> 
> Solves Issue #1096.
> 
> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> Cc: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>
> ---
>   stubs/replay-tools.c | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/stubs/replay-tools.c b/stubs/replay-tools.c
> index 43296b3d4e..f2e72bb225 100644
> --- a/stubs/replay-tools.c
> +++ b/stubs/replay-tools.c
> @@ -7,13 +7,14 @@ bool replay_events_enabled(void)
>       return false;
>   }
>   
> -int64_t replay_save_clock(unsigned int kind, int64_t clock, int64_t raw_icount)
> +int64_t replay_save_clock(ReplayClockKind kind,
> +                          int64_t clock, int64_t raw_icount)
>   {
>       abort();
>       return 0;
>   }
>   
> -int64_t replay_read_clock(unsigned int kind, int64_t raw_icount)
> +int64_t replay_read_clock(ReplayClockKind kind, int64_t raw_icount)
>   {
>       abort();
>       return 0;
> @@ -48,11 +49,11 @@ void replay_mutex_unlock(void)
>   {
>   }
>   
> -void replay_register_char_driver(Chardev *chr)
> +void replay_register_char_driver(struct Chardev *chr)
>   {
>   }
>   
> -void replay_chr_be_write(Chardev *s, uint8_t *buf, int len)
> +void replay_chr_be_write(struct Chardev *s, uint8_t *buf, int len)
>   {
>       abort();
>   }

Reviewed-by: Thomas Huth <thuth@redhat.com>



  reply	other threads:[~2022-07-04 14:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-04  7:58 [PATCH] stubs: update replay-tools to match replay.h types Claudio Fontana
2022-07-04 14:18 ` Thomas Huth [this message]
2022-07-28 11:51 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3cd71c14-12ea-f02c-5d02-21803d3c4b9f@redhat.com \
    --to=thuth@redhat.com \
    --cc=cfontana@suse.de \
    --cc=pavel.dovgalyuk@ispras.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).