From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Blake <eblake@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org
Cc: stefanha@redhat.com, den@openvz.org
Subject: Re: [Qemu-devel] [PATCH v2 5/6] nbd/client: refactor TRACE of NBD_MAGIC
Date: Wed, 5 Jul 2017 17:21:55 +0200 [thread overview]
Message-ID: <3cd91c92-71d3-2c84-53d9-b6cc9da9d45c@redhat.com> (raw)
In-Reply-To: <41d055f4-1952-fbd8-7cc2-fe377b3c9d7d@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 267 bytes --]
On 29/06/2017 21:36, Eric Blake wrote:
>> + memcpy(&nbd_magic, buf, 8);
>> + nbd_magic = be64_to_cpu(nbd_magic);
> Do we really need to copy the memory around twice? Can't we just use:
> magic = ldq_be_p(buf);
> and call it good?
Yes.
Paolo
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2017-07-05 15:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 15:34 [Qemu-devel] [PATCH v2 0/6] nbd refactoring part 2 Vladimir Sementsov-Ogievskiy
2017-06-21 15:34 ` [Qemu-devel] [PATCH v2 1/6] nbd/server: nbd_negotiate: return 1 on NBD_OPT_ABORT Vladimir Sementsov-Ogievskiy
2017-06-29 18:46 ` Eric Blake
2017-07-06 16:07 ` Eric Blake
2017-06-21 15:34 ` [Qemu-devel] [PATCH v2 2/6] nbd/server: use errp instead of LOG Vladimir Sementsov-Ogievskiy
2017-06-29 19:27 ` Eric Blake
2017-07-05 12:33 ` Vladimir Sementsov-Ogievskiy
2017-07-05 15:21 ` Paolo Bonzini
2017-07-05 17:38 ` Markus Armbruster
2017-07-07 14:40 ` Eric Blake
2017-07-07 15:10 ` Vladimir Sementsov-Ogievskiy
2017-06-21 15:34 ` [Qemu-devel] [PATCH v2 3/6] nbd/server: add errp to nbd_send_reply() Vladimir Sementsov-Ogievskiy
2017-06-29 19:31 ` Eric Blake
2017-06-21 15:34 ` [Qemu-devel] [PATCH v2 4/6] nbd/common: nbd_tls_handshake: remove extra TRACE Vladimir Sementsov-Ogievskiy
2017-06-29 19:32 ` Eric Blake
2017-06-21 15:34 ` [Qemu-devel] [PATCH v2 5/6] nbd/client: refactor TRACE of NBD_MAGIC Vladimir Sementsov-Ogievskiy
2017-06-29 19:36 ` Eric Blake
2017-07-05 15:21 ` Paolo Bonzini [this message]
2017-06-21 15:34 ` [Qemu-devel] [PATCH v2 6/6] nbd: use generic trace subsystem instead of TRACE macro Vladimir Sementsov-Ogievskiy
2017-06-29 20:12 ` Eric Blake
2017-07-06 14:49 ` Eric Blake
2017-07-05 15:29 ` Paolo Bonzini
2017-07-06 8:45 ` Vladimir Sementsov-Ogievskiy
2017-07-06 8:57 ` Paolo Bonzini
2017-07-06 15:01 ` Eric Blake
2017-07-06 15:28 ` Eric Blake
2017-07-06 15:44 ` Eric Blake
2017-07-07 14:02 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cd91c92-71d3-2c84-53d9-b6cc9da9d45c@redhat.com \
--to=pbonzini@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).