From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH] memory: Remove kernel-doc comment marker
Date: Tue, 8 Sep 2020 20:17:45 +0200 [thread overview]
Message-ID: <3cecb899-a6d0-ab48-484c-34c0bfb9a942@redhat.com> (raw)
In-Reply-To: <20200908173650.3293057-1-ehabkost@redhat.com>
On 9/8/20 7:36 PM, Eduardo Habkost wrote:
> The IOMMUMemoryRegionClass struct documentation was never in the
> kernel-doc format. Stop pretending it is, by removing the "/**"
> comment marker.
>
> This fixes a documentation build error introduced when we split
> the IOMMUMemoryRegionClass typedef from the struct declaration.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> I will submit a separate patch to convert the documentation to
> kernel-doc format later. This is just a build fix that restores
> the previous behavior (IOMMUMemoryRegionClass was never included
> in the generated documentation).
> ---
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: qemu-devel@nongnu.org
> ---
> include/exec/memory.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/exec/memory.h b/include/exec/memory.h
> index dc908738c6..f1bb2a7df5 100644
> --- a/include/exec/memory.h
> +++ b/include/exec/memory.h
> @@ -211,7 +211,7 @@ enum IOMMUMemoryRegionAttr {
> IOMMU_ATTR_SPAPR_TCE_FD
> };
>
> -/**
> +/*
> * IOMMUMemoryRegionClass:
> *
> * All IOMMU implementations need to subclass TYPE_IOMMU_MEMORY_REGION
>
prev parent reply other threads:[~2020-09-08 18:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 17:36 [PATCH] memory: Remove kernel-doc comment marker Eduardo Habkost
2020-09-08 18:17 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cecb899-a6d0-ab48-484c-34c0bfb9a942@redhat.com \
--to=philmd@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).