Re: [Qemu-devel] [PATCH v3 02/12] vl: deprecate -alt-grab and -ctrl-grab

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]

On 02/02/2018 05:10 AM, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  vl.c          | 8 ++++++++
>  qemu-doc.texi | 6 ++++++
>  2 files changed, 14 insertions(+)
> 

>              case QEMU_OPTION_ctrl_grab:
> +                g_printerr("The -ctrl-grab switch is deprecated, and will be\n"
> +                           "removed in a future release.\n");
>                  ctrl_grab = 1;
>                  break;
>              case QEMU_OPTION_no_quit:
> diff --git a/qemu-doc.texi b/qemu-doc.texi
> index aa7180a3d9..5961c7a211 100644
> --- a/qemu-doc.texi
> +++ b/qemu-doc.texi
> @@ -2756,6 +2756,12 @@ support for frameless windows, and the other user interfaces never
>  implemented this in the first place.  So this will be removed together
>  with SDL 1.2 support.
>  
> +@subsection -alt-grab and -ctrl-grab (since 2.12.0)
> +
> +The ``-alt-grab'' and ``-ctrl-grab'' arguments are deprecated.  They
> +work with SDL only.  They will eventually replaced with a new way to
> +configure hotkeys which works consistently across all user interfaces.

Should the error message printed to the user document the new interface
to be used instead? But that implies that we shouldn't deprecate this
until the new interface for configuring hotkeys has been finalized...

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]