From: Paolo Bonzini <pbonzini@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org
Cc: kwolf@redhat.com, eesposit@redhat.com, qemu-devel@nongnu.org,
mreitz@redhat.com
Subject: Re: [PATCH] iotests/check: move general long options to double dash
Date: Thu, 3 Jun 2021 13:38:03 +0200 [thread overview]
Message-ID: <3d086c41-80c0-a970-367d-00e19ce55817@redhat.com> (raw)
In-Reply-To: <20210526181659.365531-1-vsementsov@virtuozzo.com>
On 26/05/21 20:16, Vladimir Sementsov-Ogievskiy wrote:
> So, the change:
>
> -makecheck -> --makecheck
> -valgrind -> --valgrind
> -nocache -> --nocache
> -misalign -> --misalign
>
> Motivation:
>
> 1. Several long options are already have double dash:
> --dry-run, --color, --groups, --exclude-groups, --start-from
>
> 2. -misalign is used to add --misalign option (two dashes) to qemu-io
>
> 3. qemu-io and qemu-nbd has --nocache option (two dashes)
Just like for QEMU, let me reiterate that this is generally not an
improvement.
Double-dash options give extra information to the user that short
(single-dash) options can be combined, while this is not the case for
iotests/check.
Paolo
next prev parent reply other threads:[~2021-06-03 11:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 18:16 [PATCH] iotests/check: move general long options to double dash Vladimir Sementsov-Ogievskiy
2021-06-03 10:21 ` Emanuele Giuseppe Esposito
2021-06-03 12:15 ` Vladimir Sementsov-Ogievskiy
2021-06-03 11:38 ` Paolo Bonzini [this message]
2021-06-03 12:19 ` Vladimir Sementsov-Ogievskiy
2021-06-04 7:19 ` Paolo Bonzini
2021-06-04 8:25 ` Vladimir Sementsov-Ogievskiy
2021-06-07 14:44 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d086c41-80c0-a970-367d-00e19ce55817@redhat.com \
--to=pbonzini@redhat.com \
--cc=eesposit@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).