From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Peter Xu" <peterx@redhat.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Bernhard Beschow" <shentey@gmail.com>,
"David Hildenbrand" <david@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
qemu-ppc@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH 2/2] exec/ioport: Factor portio_list_register() out
Date: Wed, 8 Feb 2023 09:13:43 -1000 [thread overview]
Message-ID: <3d313346-1a59-444c-fd7a-6c856f16d9fb@linaro.org> (raw)
In-Reply-To: <20230207234615.77300-3-philmd@linaro.org>
On 2/7/23 13:46, Philippe Mathieu-Daudé wrote:
> We always follow the same pattern when registering
> non-coalesced portio:
>
> - portio_list_init()
> - portio_list_add()
>
> Factor these 2 operations in a single helper named
> portio_list_register(). Since both calls become local
> to ioport.c, reduce their scope by declaring them static.
>
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
> hw/audio/adlib.c | 4 ++--
> hw/display/vga.c | 4 ++--
> hw/dma/i82374.c | 7 +++----
> hw/isa/isa-bus.c | 6 ++----
> hw/watchdog/wdt_ib700.c | 4 ++--
> include/exec/ioport.h | 10 ++++------
> softmmu/ioport.c | 21 ++++++++++++++-------
> 7 files changed, 29 insertions(+), 27 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2023-02-08 19:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 23:46 [PATCH 0/2] exec/ioport: Factor portio_list_register[flush_coalesced]() out Philippe Mathieu-Daudé
2023-02-07 23:46 ` [PATCH 1/2] exec/ioport: Factor portio_list_register_flush_coalesced() out Philippe Mathieu-Daudé
2023-02-08 19:11 ` Richard Henderson
2023-02-07 23:46 ` [PATCH 2/2] exec/ioport: Factor portio_list_register() out Philippe Mathieu-Daudé
2023-02-08 19:13 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d313346-1a59-444c-fd7a-6c856f16d9fb@linaro.org \
--to=richard.henderson@linaro.org \
--cc=david@redhat.com \
--cc=hpoussin@reactos.org \
--cc=kraxel@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=shentey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).