qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Cleber Rosa <crosa@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	Eduardo Habkost <eduardo@habkost.net>,
	Hanna Reitz <hreitz@redhat.com>
Subject: Re: [PATCH 3/4] iotests/mirror-top-perms: switch to AQMP
Date: Fri, 4 Feb 2022 11:42:07 +0300	[thread overview]
Message-ID: <3d36bcdf-edee-6d6a-ff8e-280ffe3cb005@virtuozzo.com> (raw)
In-Reply-To: <20220203022405.1336635-4-jsnow@redhat.com>

03.02.2022 05:24, John Snow wrote:
> We don't have to maintain compatibility with both QMP libraries anymore,
> so we can just remove the old exception. While we're here, take
> advantage of the extra fields present in the VMLaunchFailure exception
> that machine.py now raises.
> 
> (Note: I'm leaving the logging suppression here unchanged. I had
> suggested previously we use filters to scrub the PID out of the logging
> information so it could just be diffed as part of the iotest output, but
> that meant*always*  scrubbing PID from logger output, which defeated the
> point of even offering that information in the output to begin with.
> 
> Ultimately, I decided it's fine to just suppress the logger temporarily.)
> 
> Signed-off-by: John Snow<jsnow@redhat.com>

Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

-- 
Best regards,
Vladimir


  reply	other threads:[~2022-02-04  9:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-03  2:24 [PATCH 0/4] iotests: finalize switch to async QMP John Snow
2022-02-03  2:24 ` [PATCH 1/4] python/machine: permanently switch to AQMP John Snow
2022-02-03  2:24 ` [PATCH 2/4] scripts/bench-block-job: " John Snow
2022-02-03  2:24 ` [PATCH 3/4] iotests/mirror-top-perms: " John Snow
2022-02-04  8:42   ` Vladimir Sementsov-Ogievskiy [this message]
2022-02-03  2:24 ` [PATCH 4/4] iotests: " John Snow
2022-02-08 19:52 ` [PATCH 0/4] iotests: finalize switch to async QMP John Snow
2022-03-18 16:32   ` Hanna Reitz
2022-03-18 17:35     ` John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d36bcdf-edee-6d6a-ff8e-280ffe3cb005@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=crosa@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=hreitz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).