* [PATCH] hw/usb/hcd-xhci-nec: Remove unused XHCINecState::flags field
@ 2024-11-27 12:28 Philippe Mathieu-Daudé
2024-12-06 16:10 ` Thomas Huth
2024-12-13 14:50 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-11-27 12:28 UTC (permalink / raw)
To: qemu-devel; +Cc: Thomas Huth, Philippe Mathieu-Daudé, Nicholas Piggin
Commit b9599519a01 ("hw/usb/hcd-xhci: Remove XHCI_FLAG_SS_FIRST
flag") remove the last use of XHCINecState::flags but neglected
to remove it; do that now.
Reported-by: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/usb/hcd-xhci-nec.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/hw/usb/hcd-xhci-nec.c b/hw/usb/hcd-xhci-nec.c
index 0c063b3697d..1a191fc7372 100644
--- a/hw/usb/hcd-xhci-nec.c
+++ b/hw/usb/hcd-xhci-nec.c
@@ -30,10 +30,8 @@
OBJECT_DECLARE_SIMPLE_TYPE(XHCINecState, NEC_XHCI)
struct XHCINecState {
- /*< private >*/
XHCIPciState parent_obj;
- /*< public >*/
- uint32_t flags;
+
uint32_t intrs;
uint32_t slots;
};
@@ -51,7 +49,6 @@ static void nec_xhci_instance_init(Object *obj)
XHCIPciState *pci = XHCI_PCI(obj);
XHCINecState *nec = NEC_XHCI(obj);
- pci->xhci.flags = nec->flags;
pci->xhci.numintrs = nec->intrs;
pci->xhci.numslots = nec->slots;
}
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] hw/usb/hcd-xhci-nec: Remove unused XHCINecState::flags field
2024-11-27 12:28 [PATCH] hw/usb/hcd-xhci-nec: Remove unused XHCINecState::flags field Philippe Mathieu-Daudé
@ 2024-12-06 16:10 ` Thomas Huth
2024-12-13 14:50 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2024-12-06 16:10 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: Nicholas Piggin, QEMU Trivial
On 27/11/2024 13.28, Philippe Mathieu-Daudé wrote:
> Commit b9599519a01 ("hw/usb/hcd-xhci: Remove XHCI_FLAG_SS_FIRST
> flag") remove the last use of XHCINecState::flags but neglected
> to remove it; do that now.
>
> Reported-by: Nicholas Piggin <npiggin@gmail.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> hw/usb/hcd-xhci-nec.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/hw/usb/hcd-xhci-nec.c b/hw/usb/hcd-xhci-nec.c
> index 0c063b3697d..1a191fc7372 100644
> --- a/hw/usb/hcd-xhci-nec.c
> +++ b/hw/usb/hcd-xhci-nec.c
> @@ -30,10 +30,8 @@
> OBJECT_DECLARE_SIMPLE_TYPE(XHCINecState, NEC_XHCI)
>
> struct XHCINecState {
> - /*< private >*/
> XHCIPciState parent_obj;
> - /*< public >*/
> - uint32_t flags;
> +
> uint32_t intrs;
> uint32_t slots;
> };
> @@ -51,7 +49,6 @@ static void nec_xhci_instance_init(Object *obj)
> XHCIPciState *pci = XHCI_PCI(obj);
> XHCINecState *nec = NEC_XHCI(obj);
>
> - pci->xhci.flags = nec->flags;
> pci->xhci.numintrs = nec->intrs;
> pci->xhci.numslots = nec->slots;
> }
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] hw/usb/hcd-xhci-nec: Remove unused XHCINecState::flags field
2024-11-27 12:28 [PATCH] hw/usb/hcd-xhci-nec: Remove unused XHCINecState::flags field Philippe Mathieu-Daudé
2024-12-06 16:10 ` Thomas Huth
@ 2024-12-13 14:50 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-12-13 14:50 UTC (permalink / raw)
To: qemu-devel; +Cc: Thomas Huth, Nicholas Piggin
On 27/11/24 13:28, Philippe Mathieu-Daudé wrote:
> Commit b9599519a01 ("hw/usb/hcd-xhci: Remove XHCI_FLAG_SS_FIRST
> flag") remove the last use of XHCINecState::flags but neglected
> to remove it; do that now.
>
> Reported-by: Nicholas Piggin <npiggin@gmail.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> hw/usb/hcd-xhci-nec.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
Patch queued.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-13 14:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-27 12:28 [PATCH] hw/usb/hcd-xhci-nec: Remove unused XHCINecState::flags field Philippe Mathieu-Daudé
2024-12-06 16:10 ` Thomas Huth
2024-12-13 14:50 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).