On Aug 13, 2009, at 6:18 PM, Ryan Schmidt wrote: > On Aug 12, 2009, at 17:29, G 3 wrote: > >> On Aug 12, 2009, at 5:18 PM, Ryan Schmidt wrote: >> >>> On Aug 12, 2009, at 09:20, G 3 wrote: >>> >>>> I have made so many patches that fixed problems with the cocoa.m >>>> file. I sent them all in and not a single one of them made it into >>>> cocoa.m. I have emailed Anthony Liguori about these missing >>>> patches. He said they were already committed. They weren't. I don't >>>> know what else to do. I could send the modified cocoa.m to you if >>>> you want. >>> >>> Thank you, that would be kind. If you could send a diff for cocoa.m >>> from 0.10.6 that would be great. >> >> Sending you the entire file would be a lot easier. All you have to do >> is replace the old file with the new one. Enjoy. >> >> >> >> Note: I haven't compiled this file under 10.4. I do know it compiles >> cleanly under 10.3. I used gcc 3.3 and make 3.81. > > Attached is the diff between the version of cocoa.m in qemu 0.10.6 and > the one you sent me. The changes you propose don't seem to relate to > the code that is failing for me, and I still get the same error > message when I try to build on 10.4. > > > > I did a little research and found out why you are having problems compiling the cocoa.m file. It is a problem with this line: #if (MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_4). It is located just a few lines above this line: if ([NSView respondsToSelector:@selector(enterFullScreenMode:withOptions:)]). The greater than or equal to sign should be switched to just greater than. The method enterFullScreenMode:withOptions: is only available on Mac OS 10.5 or higher. That is why you are seeing the error with NSFullScreenModeAllScreens on 10.4. Hope this helps.