[Qemu-devel] qemu 0.10.6 on Mac OS X Tiger: NSFullScreenModeAllScreens undeclared

[Qemu-devel] qemu 0.10.6 on Mac OS X Tiger: NSFullScreenModeAllScreens undeclared

[Ryan Schmidt]

Hi. I'm with the MacPorts project (a package management system for  
Mac OS X), and we've received some reports that qemu 0.10.6 can't be  
built on Mac OS X 10.4 Tiger. This is what I get on 10.4.11 Intel:


   OBJC  cocoa.o
cocoa.m:233: warning: no previous prototype for 'cocoa_keycode_to_qemu'
cocoa.m: In function '-[QemuCocoaView toggleFullScreen:]':
cocoa.m:426: warning: 'QemuCocoaView' may not respond to '- 
exitFullScreenModeWithOptions:'
cocoa.m:426: warning: (Messages without a matching method signature
cocoa.m:426: warning: will be assumed to return 'id' and accept
cocoa.m:426: warning: '...' as arguments.)
cocoa.m:444: error: 'NSFullScreenModeAllScreens' undeclared (first  
use in this function)
cocoa.m:444: error: (Each undeclared identifier is reported only once
cocoa.m:444: error: for each function it appears in.)
cocoa.m:445: error: 'NSFullScreenModeSetting' undeclared (first use  
in this function)
cocoa.m:446: warning: 'QemuCocoaView' may not respond to '- 
enterFullScreenMode:withOptions:'
cocoa.m: In function '-[QemuCocoaAppController  
openPanelDidEnd:returnCode:contextInfo:]':
cocoa.m:786: warning: initialization discards qualifiers from pointer  
target type
make: *** [cocoa.o] Error 1


This has been reported in many places:

http://lists.gnu.org/archive/html/qemu-devel/2008-10/msg00336.html

http://lists.macosforge.org/pipermail/macports-users/2009-April/ 
014665.html

http://lists.macosforge.org/pipermail/macports-users/2009-May/ 
015353.html

http://qemu-forum.ipi.fi/viewtopic.php?f=6&t=5161&p=15200

In response to the October 2008 report of this problem on qemu-devel,  
this response included a patch:

http://lists.gnu.org/archive/html/qemu-devel/2008-10/msg00393.html

So, what is the status of this issue? Will the patch be incorporated?  
It doesn't apply cleanly anymore to the 0.10.6 sources; 3 of the 16  
hunks fail to apply, so I don't know if it actually fixes the issue.

Re:[Qemu-devel] qemu 0.10.6 on Mac OS X Tiger: NSFullScreenModeAllScreens undeclared

[G 3]

I have made so many patches that fixed problems with the cocoa.m file. 
I sent them all in and not a single one of them made it into cocoa.m. I 
have emailed Anthony Liguori about these missing patches. He said they 
were already committed. They weren't. I don't know what else to do. I 
could send the modified cocoa.m to you if you want.


On Aug 12, 2009, at 7:46 AM, qemu-devel-request@nongnu.org wrote:

> Message: 1
> Date: Wed, 12 Aug 2009 05:11:53 -0500
> From: Ryan Schmidt <qemu-2009@ryandesign.com>
> Subject: [Qemu-devel] qemu 0.10.6 on Mac OS X Tiger:
> 	NSFullScreenModeAllScreens undeclared
> To: qemu-devel@nongnu.org
> Message-ID: <6EF18DB9-22FF-4760-9CF2-699DD68C0DDC@ryandesign.com>
> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
>
> Hi. I'm with the MacPorts project (a package management system for
> Mac OS X), and we've received some reports that qemu 0.10.6 can't be
> built on Mac OS X 10.4 Tiger. This is what I get on 10.4.11 Intel:
>
>
>    OBJC  cocoa.o
> cocoa.m:233: warning: no previous prototype for 'cocoa_keycode_to_qemu'
> cocoa.m: In function '-[QemuCocoaView toggleFullScreen:]':
> cocoa.m:426: warning: 'QemuCocoaView' may not respond to '-
> exitFullScreenModeWithOptions:'
> cocoa.m:426: warning: (Messages without a matching method signature
> cocoa.m:426: warning: will be assumed to return 'id' and accept
> cocoa.m:426: warning: '...' as arguments.)
> cocoa.m:444: error: 'NSFullScreenModeAllScreens' undeclared (first
> use in this function)
> cocoa.m:444: error: (Each undeclared identifier is reported only once
> cocoa.m:444: error: for each function it appears in.)
> cocoa.m:445: error: 'NSFullScreenModeSetting' undeclared (first use
> in this function)
> cocoa.m:446: warning: 'QemuCocoaView' may not respond to '-
> enterFullScreenMode:withOptions:'
> cocoa.m: In function '-[QemuCocoaAppController
> openPanelDidEnd:returnCode:contextInfo:]':
> cocoa.m:786: warning: initialization discards qualifiers from pointer
> target type
> make: *** [cocoa.o] Error 1
>
>
> This has been reported in many places:
>
> http://lists.gnu.org/archive/html/qemu-devel/2008-10/msg00336.html
>
> http://lists.macosforge.org/pipermail/macports-users/2009-April/
> 014665.html
>
> http://lists.macosforge.org/pipermail/macports-users/2009-May/
> 015353.html
>
> http://qemu-forum.ipi.fi/viewtopic.php?f=6&t=5161&p=15200
>
> In response to the October 2008 report of this problem on qemu-devel,
> this response included a patch:
>
> http://lists.gnu.org/archive/html/qemu-devel/2008-10/msg00393.html
>
> So, what is the status of this issue? Will the patch be incorporated?
> It doesn't apply cleanly anymore to the 0.10.6 sources; 3 of the 16
> hunks fail to apply, so I don't know if it actually fixes the issue.

Re: [Qemu-devel] qemu 0.10.6 on Mac OS X Tiger: NSFullScreenModeAllScreens undeclared

[Ryan Schmidt]

On Aug 12, 2009, at 09:20, G 3 wrote:

> I have made so many patches that fixed problems with the cocoa.m  
> file. I sent them all in and not a single one of them made it into  
> cocoa.m. I have emailed Anthony Liguori about these missing  
> patches. He said they were already committed. They weren't. I don't  
> know what else to do. I could send the modified cocoa.m to you if  
> you want.

Thank you, that would be kind. If you could send a diff for cocoa.m  
from 0.10.6 that would be great.

Re: [Qemu-devel] qemu 0.10.6 on Mac OS X Tiger: NSFullScreenModeAllScreens undeclared

[Anthony Liguori]

Ryan Schmidt wrote:
> On Aug 12, 2009, at 09:20, G 3 wrote:
>
>> I have made so many patches that fixed problems with the cocoa.m 
>> file. I sent them all in and not a single one of them made it into 
>> cocoa.m. I have emailed Anthony Liguori about these missing patches. 
>> He said they were already committed. They weren't. I don't know what 
>> else to do. I could send the modified cocoa.m to you if you want.

Those cocoa patches never applied cleanly to git.

Regards,

Anthony Liguori

Re: [Qemu-devel] qemu 0.10.6 on Mac OS X Tiger: NSFullScreenModeAllScreens undeclared

[G 3]

What would I need to do in order to make them apply cleanly?

On Aug 12, 2009, at 9:21 PM, qemu-devel-request@nongnu.org wrote:

> Message: 1
> Date: Wed, 12 Aug 2009 16:45:03 -0500
> From: Anthony Liguori <anthony@codemonkey.ws>
> Subject: Re: [Qemu-devel] qemu 0.10.6 on Mac OS X Tiger:
> 	NSFullScreenModeAllScreens undeclared
> To: Ryan Schmidt <qemu-2009@ryandesign.com>
> Cc: G 3 <programmingkidx@gmail.com>, qemu-devel@nongnu.org
> Message-ID: <4A8337DF.7010506@codemonkey.ws>
> Content-Type: text/plain; charset=ISO-8859-1; format=flowed
>
> Ryan Schmidt wrote:
>> On Aug 12, 2009, at 09:20, G 3 wrote:
>>
>>> I have made so many patches that fixed problems with the cocoa.m
>>> file. I sent them all in and not a single one of them made it into
>>> cocoa.m. I have emailed Anthony Liguori about these missing patches.
>>> He said they were already committed. They weren't. I don't know what
>>> else to do. I could send the modified cocoa.m to you if you want.
>
> Those cocoa patches never applied cleanly to git.
>
> Regards,
>
> Anthony Liguori

Re: [Qemu-devel] qemu 0.10.6 on Mac OS X Tiger: NSFullScreenModeAllScreens undeclared

[Anthony Liguori]

G 3 wrote:
> What would I need to do in order to make them apply cleanly?

Submit them against the latest git.  I don't know what you've been 
submitting them against but they haven't even come close to applying 
against the latest git.

If the error is specific to stable-0.10, you should do them against 
stable-0.10 and send them with [STABLE] in the subject.

However, I can't see how they'd be specific to stable-0.10  The code's 
been touched once in the past year.

Regards,

Anthony Liguori

Re: [Qemu-devel] qemu 0.10.6 on Mac OS X Tiger: NSFullScreenModeAllScreens undeclared

[Ryan Schmidt]

[-- Attachment #1: Type: text/plain, Size: 1137 bytes --]

On Aug 12, 2009, at 17:29, G 3 wrote:

> On Aug 12, 2009, at 5:18 PM, Ryan Schmidt wrote:
>
>> On Aug 12, 2009, at 09:20, G 3 wrote:
>>
>>> I have made so many patches that fixed problems with the cocoa.m  
>>> file. I sent them all in and not a single one of them made it  
>>> into cocoa.m. I have emailed Anthony Liguori about these missing  
>>> patches. He said they were already committed. They weren't. I  
>>> don't know what else to do. I could send the modified cocoa.m to  
>>> you if you want.
>>
>> Thank you, that would be kind. If you could send a diff for  
>> cocoa.m from 0.10.6 that would be great.
>
> Sending you the entire file would be a lot easier. All you have to  
> do is replace the old file with the new one. Enjoy.
>
> <cocoa.m>
>
> Note: I haven't compiled this file under 10.4. I do know it  
> compiles cleanly under 10.3. I used gcc 3.3 and make 3.81.

Attached is the diff between the version of cocoa.m in qemu 0.10.6  
and the one you sent me. The changes you propose don't seem to relate  
to the code that is failing for me, and I still get the same error  
message when I try to build on 10.4.




[-- Attachment #2: cocoa.m.diff --]
[-- Type: application/octet-stream, Size: 1027 bytes --]

--- cocoa.m.orig	2009-07-16 19:56:22.000000000 -0500
+++ cocoa.m	2009-08-13 06:26:54.000000000 -0500
@@ -23,11 +23,17 @@
  */
 
 #import <Cocoa/Cocoa.h>
-
 #include "qemu-common.h"
 #include "console.h"
 #include "sysemu.h"
 
+#ifndef MAC_OS_X_VERSION_10_4
+#define MAC_OS_X_VERSION_10_4 1040
+#endif
+
+#ifndef __LITTLE_ENDIAN__
+#define __LITTLE_ENDIAN__ 0  /* assume PowerPC*/
+#endif
 
 //#define DEBUG
 
@@ -55,6 +61,8 @@
 } QEMUScreen;
 
 int qemu_main(int argc, char **argv); // main defined in qemu/vl.c
+int cocoa_keycode_to_qemu(int keycode);
+
 NSWindow *normalWindow;
 id cocoaView;
 static DisplayChangeListener *dcl;
@@ -783,8 +791,8 @@
     if(returnCode == NSCancelButton) {
         exit(0);
     } else if(returnCode == NSOKButton) {
-        char *bin = "qemu";
-        char *img = (char*)[ [ sheet filename ] cStringUsingEncoding:NSASCIIStringEncoding];
+        char bin[5] = "qemu";
+        char *img = (char*)[ [ sheet filename ] cString];
 
         char **argv = (char**)malloc( sizeof(char*)*3 );
 

Re: [Qemu-devel] qemu 0.10.6 on Mac OS X Tiger: NSFullScreenModeAllScreens undeclared

[G 3]

[-- Attachment #1: Type: text/plain, Size: 1819 bytes --]


On Aug 13, 2009, at 6:18 PM, Ryan Schmidt wrote:

> On Aug 12, 2009, at 17:29, G 3 wrote:
>
>> On Aug 12, 2009, at 5:18 PM, Ryan Schmidt wrote:
>>
>>> On Aug 12, 2009, at 09:20, G 3 wrote:
>>>
>>>> I have made so many patches that fixed problems with the cocoa.m 
>>>> file. I sent them all in and not a single one of them made it into 
>>>> cocoa.m. I have emailed Anthony Liguori about these missing 
>>>> patches. He said they were already committed. They weren't. I don't 
>>>> know what else to do. I could send the modified cocoa.m to you if 
>>>> you want.
>>>
>>> Thank you, that would be kind. If you could send a diff for cocoa.m 
>>> from 0.10.6 that would be great.
>>
>> Sending you the entire file would be a lot easier. All you have to do 
>> is replace the old file with the new one. Enjoy.
>>
>> <cocoa.m>
>>
>> Note: I haven't compiled this file under 10.4. I do know it compiles 
>> cleanly under 10.3. I used gcc 3.3 and make 3.81.
>
> Attached is the diff between the version of cocoa.m in qemu 0.10.6 and 
> the one you sent me. The changes you propose don't seem to relate to 
> the code that is failing for me, and I still get the same error 
> message when I try to build on 10.4.
>
>
>
> <cocoa.m.diff>


I did a little research and found out why you are having problems 
compiling the cocoa.m file. It is a problem with this line:  #if 
(MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_4). It is located 
just a few lines above this line: if ([NSView 
respondsToSelector:@selector(enterFullScreenMode:withOptions:)]).
  The greater than or equal to sign should be switched to just greater 
than. The method enterFullScreenMode:withOptions: is only available on 
Mac OS 10.5 or higher. That is why  you are seeing the error with 
NSFullScreenModeAllScreens on 10.4. Hope this helps.
  
  

[-- Attachment #2: Type: text/enriched, Size: 1907 bytes --]



On Aug 13, 2009, at 6:18 PM, Ryan Schmidt wrote:


<excerpt>On Aug 12, 2009, at 17:29, G 3 wrote:


<excerpt>On Aug 12, 2009, at 5:18 PM, Ryan Schmidt wrote:


<excerpt>On Aug 12, 2009, at 09:20, G 3 wrote:


<excerpt>I have made so many patches that fixed problems with the
cocoa.m file. I sent them all in and not a single one of them made it
into cocoa.m. I have emailed Anthony Liguori about these missing
patches. He said they were already committed. They weren't. I don't
know what else to do. I could send the modified cocoa.m to you if you
want.

</excerpt>

Thank you, that would be kind. If you could send a diff for cocoa.m
from 0.10.6 that would be great.

</excerpt>

Sending you the entire file would be a lot easier. All you have to do
is replace the old file with the new one. Enjoy.


<<cocoa.m>


Note: I haven't compiled this file under 10.4. I do know it compiles
cleanly under 10.3. I used gcc 3.3 and make 3.81.

</excerpt>

Attached is the diff between the version of cocoa.m in qemu 0.10.6 and
the one you sent me. The changes you propose don't seem to relate to
the code that is failing for me, and I still get the same error
message when I try to build on 10.4.




<<cocoa.m.diff>

</excerpt>


I did a little research and found out why you are having problems
compiling the cocoa.m file. It is a problem with this line:  #if
(MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_4). It is located
just a few lines above this line:
<fixed><color><param>7676,0F0F,5050</param>if</color> ([NSView
respondsToSelector:<color><param>7676,0F0F,5050</param>@selector</color>(enterFullScreenMode:withOptions:)]). 

</fixed> The greater than or equal to sign should be switched to just
greater than. The method enterFullScreenMode:withOptions: is only
available on Mac OS 10.5 or higher. That is why  you are seeing the
error with NSFullScreenModeAllScreens on 10.4. Hope this helps.