From: "Cédric Le Goater" <clg@kaod.org>
To: Joel Stanley <joel@jms.id.au>
Cc: Andrew Jeffery <andrew@aj.id.au>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH] hw: arm: aspeed: Enable eth0 interface for aspeed-ast2600-evb
Date: Mon, 9 Aug 2021 10:16:49 +0200 [thread overview]
Message-ID: <3d5d5b8c-9686-367b-add1-8b7d9d2aa28c@kaod.org> (raw)
In-Reply-To: <CACPK8XchtnxGyZ=wFMJU7S0V7SPUF0KoFn5BJiF7vT8bu3Qd3w@mail.gmail.com>
On 8/9/21 10:01 AM, Joel Stanley wrote:
> On Mon, 9 Aug 2021 at 07:45, Cédric Le Goater <clg@kaod.org> wrote:
>>
>> On 8/8/21 10:04 PM, Guenter Roeck wrote:
>>> Commit 7582591ae7 ("aspeed: Support AST2600A1 silicon revision") switched
>>> the silicon revision for AST2600 to revision A1. On revision A1, the first
>>> Ethernet interface is operational. Enable it.
>>
>> Indeed.
>>
>> I see that commit ba56f464f0c ("ARM: dts: aspeed: ast2600evb: Add MAC0")
>> reintroduced it a while ago. But my A0 doesn't support it. I am missing
>> something.
>>
>> Joel, why this patch didn't reach the OpenBMC kernel ?
>
> Because your a0 doesn't support it, so it would break that. That's the
> only reason.
OK then.
> For this patch,
>
> Reviewed-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
It's queued to aspeed-6.2.
Thanks
C.
prev parent reply other threads:[~2021-08-09 8:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-08 20:04 [PATCH] hw: arm: aspeed: Enable eth0 interface for aspeed-ast2600-evb Guenter Roeck
2021-08-09 7:44 ` Cédric Le Goater
2021-08-09 8:01 ` Joel Stanley
2021-08-09 8:16 ` Cédric Le Goater [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d5d5b8c-9686-367b-add1-8b7d9d2aa28c@kaod.org \
--to=clg@kaod.org \
--cc=andrew@aj.id.au \
--cc=joel@jms.id.au \
--cc=linux@roeck-us.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).