From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Shu-Chun Weng <scw@google.com>, qemu-devel@nongnu.org
Cc: Laurent Vivier <laurent@vivier.eu>,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PATCH-for-8.2? 1/2] linux-user: Define TARGET_O_LARGEFILE for aarch64
Date: Fri, 1 Dec 2023 13:38:02 +0100 [thread overview]
Message-ID: <3d64ec14-09a8-4446-9a22-2b2981b1bc06@linaro.org> (raw)
In-Reply-To: <20231201032140.2470599-2-scw@google.com>
On 1/12/23 04:21, Shu-Chun Weng wrote:
> In 050a1ba, when moving the macros from preprocessor-guarding to
> file-based definition, TARGET_O_LARGEFILE appeared to have been
> accidentally left off.
>
> This may have correctness implication, but so far I was only confused by
> strace's output.
>
Fixes: 050a1ba69a ("linux-user: move arm/aarch64/m68k fcntl definitions
to [arm|aarch64|m68k]/target_fcntl.h")
> Signed-off-by: Shu-Chun Weng <scw@google.com>
> ---
> linux-user/aarch64/target_fcntl.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/linux-user/aarch64/target_fcntl.h b/linux-user/aarch64/target_fcntl.h
> index efdf6e5f05..55ab788a7c 100644
> --- a/linux-user/aarch64/target_fcntl.h
> +++ b/linux-user/aarch64/target_fcntl.h
> @@ -11,6 +11,7 @@
> #define TARGET_O_DIRECTORY 040000 /* must be a directory */
> #define TARGET_O_NOFOLLOW 0100000 /* don't follow links */
> #define TARGET_O_DIRECT 0200000 /* direct disk access hint */
> +#define TARGET_O_LARGEFILE 0400000
>
> #include "../generic/fcntl.h"
> #endif
>
next prev parent reply other threads:[~2023-12-01 12:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 3:21 [PATCH 0/2] linux-user: openat() fixes Shu-Chun Weng
2023-12-01 3:21 ` [PATCH 1/2] linux-user: Define TARGET_O_LARGEFILE for aarch64 Shu-Chun Weng
2023-12-01 12:38 ` Philippe Mathieu-Daudé [this message]
2023-12-03 13:28 ` Laurent Vivier
2023-12-01 3:21 ` [PATCH 2/2] linux-user: Fix openat() emulation to not modify atime Shu-Chun Weng
2023-12-01 12:42 ` Philippe Mathieu-Daudé
2023-12-01 18:51 ` Shu-Chun Weng
2023-12-04 13:39 ` Philippe Mathieu-Daudé
2023-12-04 15:34 ` Stefan Hajnoczi
2023-12-01 17:09 ` Helge Deller
2023-12-04 16:58 ` Daniel P. Berrangé
2023-12-08 20:52 ` Shu-Chun Weng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d64ec14-09a8-4446-9a22-2b2981b1bc06@linaro.org \
--to=philmd@linaro.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=scw@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).